36755 2010-03-29 06:51:18 -0700 [Qt] REGRESSION: Loading of external CSS and JS files over network fails in some cases 2010-05-18 02:45:39 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC All CLOSED FIXED http://www.nokia.fi Qt P1 Normal --- 35784 1 kim.1.gronholm webkit-qt-unassigned commit-queue hausmann jesus jturcotte kling koshuin markus petri.latvala tonikitoo zecke oldest_to_newest 205417 0 kim.1.gronholm 2010-03-29 06:51:18 -0700 Some sites that have both extrenal css and js files fail to load them. Some examples: http://www.nokia.fi http://scripty2.com/demos/touch/photofun/ The regression is caused by the patch in https://bugs.webkit.org/show_bug.cgi?id=32113 Tested with Qt versions 4.6.2 and 4.7 with both Ubuntu and Windows. 205423 1 hausmann 2010-03-29 07:05:20 -0700 Kim, if the Qt::DirectionConnection broke this, do you have any idea what exactly could've caused it? 205427 2 kim.1.gronholm 2010-03-29 07:20:03 -0700 No. I didn't dig in deeper and I'm not very familiar with this part of QtWebKit. We found the patch to blame by bisecting. 205927 3 koshuin 2010-03-30 03:24:13 -0700 Tested with Qt 4.6.2 and webkit built from trunk@56711 on Symbian using Anomaly. Both URLs get stuck when loading the page and never finish. 206003 4 hausmann 2010-03-30 07:36:43 -0700 A reduction is needed. Holger suggested on IRC: "a start would be to use the mirror tool, either by mirroring as far as we get. or by using a older qt and get the complete file then we can use the power of sqlite to see the difference in requests (completed) and reducing it.. other useful hints would be: What kind of request is failing? XMLHttpRequest? sync/async one? is the load deferred? " 214425 5 hausmann 2010-04-19 18:42:28 -0700 Darn, I can't reproduce this with trunk and Qt 4.7 anymore ;( I mirrored it with Holger's tool and it loads through the builtin http server, too. Maybe it is/was a fix in Qt 4.7? 216936 6 markus 2010-04-26 01:18:05 -0700 Can someone who reproduced it before try this also with current 4.6. from git and with 4.7 from git? 217658 7 kling 2010-04-27 04:39:15 -0700 (On current Qt 4.7) Can't reproduce with WebKit trunk or WebKit from Qt 4.7 220690 8 kim.1.gronholm 2010-05-04 11:43:17 -0700 Tested with current Qt 4.6 from git (4.6.3) and current Qt 4.7 from git and both work fine! Then tested again with Qt 4.6.2 and the bug appears. We could change the version check to: #if QT_VERSION > QT_VERSION_CHECK(4, 6, 2) 220979 9 markus 2010-05-05 00:15:38 -0700 That sounds like an OK workaround to me. 221681 10 hausmann 2010-05-06 07:53:43 -0700 I bisected Qt 4.6 and indeed commit 232defa5d084386a9cdeb229cefee0a4a09bca85 in Qt fixes the problem: commit 232defa5d084386a9cdeb229cefee0a4a09bca85 Author: Markus Goetz <Markus.Goetz@nokia.com> Date: Thu Feb 11 13:21:57 2010 +0100 QNAM HTTP: Set channel to IdleState at better place The readyRead() from the expand() function called from allDone() had a new request triggered for that channel even if it is not really finished yet. Move the assignment to IdleState inside allDone to avoid this error. Reviewed-by: Andreas Kling Reviewed-by: Peter Hartmann 221683 11 55238 hausmann 2010-05-06 07:57:14 -0700 Created attachment 55238 Patch to enable direct connections only for > Qt 4.6.2 221902 12 55238 commit-queue 2010-05-06 13:01:48 -0700 Comment on attachment 55238 Patch to enable direct connections only for > Qt 4.6.2 Clearing flags on attachment: 55238 Committed r58903: <http://trac.webkit.org/changeset/58903> 221903 13 commit-queue 2010-05-06 13:01:56 -0700 All reviewed patches have been landed. Closing bug. 222216 14 hausmann 2010-05-07 00:30:00 -0700 Revision r58903 cherry-picked into qtwebkit-2.0 with commit 102de4f0e2622dd85a2eb33008473013710dd177 227209 15 jturcotte 2010-05-18 02:45:39 -0700 *** Bug 37852 has been marked as a duplicate of this bug. *** 55238 2010-05-06 07:57:14 -0700 2010-05-06 13:01:48 -0700 Patch to enable direct connections only for > Qt 4.6.2 patch.txt text/plain 1529 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2ZmYTY5Mi4uMmE5NWYzMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wNiAgU2ltb24gSGF1c21h bm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSRUdSRVNTSU9OOiBMb2FkaW5nIG9mIGV4dGVy bmFsIENTUyBhbmQgSlMgZmlsZXMgb3ZlciBuZXR3b3JrIGZhaWxzIGluIHNvbWUgY2FzZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzU1CisKKyAg ICAgICAgRW5hYmxlIHRoZSBkaXJlY3QgY29ubmVjdGlvbiBiZXR3ZWVuIFF0TmV0d29yayBhbmQg UXRXZWJLaXQgb25seSBmb3IgUXQgdmVyc2lvbnMKKyAgICAgICAgZ3JlYXRlciB0aGFuIDQuNi4y LCBkdWUgdG8gYSBidWcgaW4gUXQgdGhhdCdzIGJlZW4gZml4ZWQgYWZ0ZXIgNC42LjIuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcDoKKwog MjAxMC0wNS0wNSAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAppbmRleCAyN2I1N2I3Li5lNTJkZDFk IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhh bmRsZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5 SGFuZGxlci5jcHAKQEAgLTQxLDggKzQxLDkgQEAKIAogLy8gV2hhdCB0eXBlIG9mIGNvbm5lY3Rp b24gc2hvdWxkIGJlIHVzZWQgZm9yIHRoZSBzaWduYWxzIG9mIHRoZQogLy8gUU5ldHdvcmtSZXBs eT8gVGhpcyBkZXBlbmRzIG9uIGlmIFF0IGhhcyBhIGJ1Z2ZpeCBmb3IgdGhpcyBvciBub3QuCi0v LyBJdCBpcyBmaXhlZCBpbiBRdCA0LjYuMS4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMjExMwotI2lmIFFUX1ZFUlNJT04gPiBRVF9WRVJTSU9OX0NIRUNLKDQs IDYsIDApCisvLyBJdCBpcyBmaXhlZCBpbiBRdCA0LjYuMy4gU2VlIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjExMworLy8gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNjc1NQorI2lmIFFUX1ZFUlNJT04gPiBRVF9WRVJTSU9OX0NI RUNLKDQsIDYsIDIpCiAjZGVmaW5lIFNJR05BTF9DT05OIFF0OjpEaXJlY3RDb25uZWN0aW9uCiAj ZWxzZQogI2RlZmluZSBTSUdOQUxfQ09OTiBRdDo6UXVldWVkQ29ubmVjdGlvbgo=