36754 2010-03-29 06:46:47 -0700 [GTK] webkit_get_default_session() should make sure webkit_init() is called 2010-04-01 09:07:43 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned xan.lopez oldest_to_newest 205416 0 gustavo 2010-03-29 06:46:47 -0700 While writing an application that does not create a WebView early in its life, but that does all of the setup right away, I noticed my removal of the soup auth dialog feature was not having any effect. That is because webkit_init was not called much later, when the first WebView is created, and then adds the feature I tried to remove. I have solved this by creating, and destroying a WebView while setting up the session (ugh). 205432 1 51907 gustavo 2010-03-29 07:43:33 -0700 Created attachment 51907 proposed fix 206424 2 51907 zecke 2010-03-31 02:14:25 -0700 Comment on attachment 51907 proposed fix > +// Make sure the session is initialized properly when webkit_get_default_session() is called. > +static void test_globals_default_session() > +{ I think you want to call g_test_bug("36754"); here. Besides that the webkit_init call will call get_default_session and set_cache_model but that is fine as we have an early exit in there. 207189 3 gustavo 2010-04-01 09:07:43 -0700 Landed as r56916. 51907 2010-03-29 07:43:33 -0700 2010-03-31 02:14:25 -0700 proposed fix 0001-Make-sure-webkit_init-is-called-by-global-functions.patch text/plain 6596 gustavo RnJvbSAzODVlYTBlNjZjZTE4OTFkY2ZhM2M5NjY2ZTJlMjc5ZmM0ODNiM2NlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IE1vbiwgMjkgTWFyIDIwMTAgMTE6MDE6MjIgLTAzMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIHN1cmUgd2Via2l0X2luaXQgaXMgY2FsbGVkIGJ5IGdsb2JhbCBmdW5jdGlvbnMKCi0tLQog Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKwogR05VbWFr ZWZpbGUuYW0gICAgICAgICAgICAgICAgICAgICAgfCAgICA2ICsrKwogV2ViS2l0L2d0ay9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgfCAgIDE5ICsrKysrKysrKysKIFdlYktpdC9ndGsvdGVzdHMv dGVzdGdsb2JhbHMuYyAgICAgIHwgICA2NCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICA0ICsrCiA1IGZp bGVzIGNoYW5nZWQsIDEwNCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQogY3JlYXRlIG1v ZGUgMTAwNjQ0IFdlYktpdC9ndGsvdGVzdHMvdGVzdGdsb2JhbHMuYwoKZGlmZiAtLWdpdCBhL0No YW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwMDFkZGRiLi5iMjdlZmQxIDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMjkgIEd1 c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gd2Vi a2l0X2dldF9kZWZhdWx0X3Nlc3Npb24oKSBzaG91bGQgbWFrZSBzdXJlIHdlYmtpdF9pbml0KCkg aXMgY2FsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNjc1NAorCisgICAgICAgIE5ldyBBUEkgdGVzdC4KKworICAgICAgICAqIEdOVW1ha2VmaWxl LmFtOgorCiAyMDEwLTAzLTI2ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1n aXQgYS9HTlVtYWtlZmlsZS5hbSBiL0dOVW1ha2VmaWxlLmFtCmluZGV4IDM5OWY3YTQuLjNiZGZl NTMgMTAwNjQ0Ci0tLSBhL0dOVW1ha2VmaWxlLmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBAIC01 NjUsNiArNTY1LDcgQEAgd2Via2l0X3Rlc3RzX2xkZmxhZ3MgPSBcCiAKIFRFU1RfUFJPR1MgKz0g UHJvZ3JhbXMvdW5pdHRlc3RzL3Rlc3RodHRwYmFja2VuZCBcCiAJUHJvZ3JhbXMvdW5pdHRlc3Rz L3Rlc3Rsb2FkaW5nIFwKKwlQcm9ncmFtcy91bml0dGVzdHMvdGVzdGdsb2JhbHMgXAogCVByb2dy YW1zL3VuaXR0ZXN0cy90ZXN0bWltZWhhbmRsaW5nIFwKIAlQcm9ncmFtcy91bml0dGVzdHMvdGVz dG5ldHdvcmtyZXF1ZXN0IFwKIAlQcm9ncmFtcy91bml0dGVzdHMvdGVzdG5ldHdvcmtyZXNwb25z ZSBcCkBAIC01ODcsNiArNTg4LDExIEBAIFByb2dyYW1zX3VuaXR0ZXN0c190ZXN0aHR0cGJhY2tl bmRfQ0ZMQUdTID0gJCh3ZWJraXRfdGVzdHNfY2ZsYWdzKQogUHJvZ3JhbXNfdW5pdHRlc3RzX3Rl c3RodHRwYmFja2VuZF9MREFERCA9ICQod2Via2l0X3Rlc3RzX2xkYWRkKQogUHJvZ3JhbXNfdW5p dHRlc3RzX3Rlc3RodHRwYmFja2VuZF9MREZMQUdTID0gJCh3ZWJraXRfdGVzdHNfbGRmbGFncykK IAorUHJvZ3JhbXNfdW5pdHRlc3RzX3Rlc3RnbG9iYWxzX1NPVVJDRVMgPSBXZWJLaXQvZ3RrL3Rl c3RzL3Rlc3RnbG9iYWxzLmMKK1Byb2dyYW1zX3VuaXR0ZXN0c190ZXN0Z2xvYmFsc19DRkxBR1Mg PSAkKHdlYmtpdF90ZXN0c19jZmxhZ3MpCitQcm9ncmFtc191bml0dGVzdHNfdGVzdGdsb2JhbHNf TERBREQgPSAkKHdlYmtpdF90ZXN0c19sZGFkZCkKK1Byb2dyYW1zX3VuaXR0ZXN0c190ZXN0Z2xv YmFsc19MREZMQUdTID0gJCh3ZWJraXRfdGVzdHNfbGRmbGFncykKKwogUHJvZ3JhbXNfdW5pdHRl c3RzX3Rlc3Rsb2FkaW5nX1NPVVJDRVMgPSBXZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rsb2FkaW5nLmMK IFByb2dyYW1zX3VuaXR0ZXN0c190ZXN0bG9hZGluZ19DRkxBR1MgPSAkKHdlYmtpdF90ZXN0c19j ZmxhZ3MpCiBQcm9ncmFtc191bml0dGVzdHNfdGVzdGxvYWRpbmdfTERBREQgPSAkKHdlYmtpdF90 ZXN0c19sZGFkZCkKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKaW5kZXggNjc5MTQ2YS4uMjM2NjA0YyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAor MjAxMC0wMy0yOSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxh Ym9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXSB3ZWJraXRfZ2V0X2RlZmF1bHRfc2Vzc2lvbigpIHNob3VsZCBtYWtlIHN1cmUg d2Via2l0X2luaXQoKSBpcyBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM2NzU0CisKKyAgICAgICAgTWFrZSBzdXJlIGdsb2JhbCBmdW5jdGlv bnMgdGhhdCBkbyBub3QgcmVxdWlyZSBhIFdlYktpdFdlYlZpZXcgdG8KKyAgICAgICAgYmUgY3Jl YXRlZCBjYWxsIHdlYmtpdF9pbml0KCkgYmVmb3JlIGRvaW5nIHRoZWlyIGpvYi4gQWxzbyBhZGQg YW4KKyAgICAgICAgQVBJIHRlc3QgdG8gY2hlY2sgZm9yIHRoYXQuCisKKyAgICAgICAgKiB0ZXN0 cy90ZXN0Z2xvYmFscy5jOiBBZGRlZC4KKyAgICAgICAgKHRlc3RfZ2xvYmFsc19kZWZhdWx0X3Nl c3Npb24pOgorICAgICAgICAobWFpbik6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwOgorICAgICAgICAod2Via2l0X2dldF9kZWZhdWx0X3Nlc3Npb24pOgorICAgICAgICAod2Vi a2l0X3NldF9jYWNoZV9tb2RlbCk6CisgICAgICAgICh3ZWJraXRfZ2V0X2NhY2hlX21vZGVsKToK KwogMjAxMC0wMy0yOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAg ICAgICBCdWlsZCBmaXguIEluY2x1ZGUgV2luZG93c0tleWJvYXJkQ29kZXMuaCBpbnN0ZWFkIG9m IEtleWJvYXJkQ29kZXMuaC4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvdGVzdHMvdGVzdGdsb2Jh bHMuYyBiL1dlYktpdC9ndGsvdGVzdHMvdGVzdGdsb2JhbHMuYwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi5kNGY4Mzg4Ci0tLSAvZGV2L251bGwKKysrIGIvV2ViS2l0L2d0ay90 ZXN0cy90ZXN0Z2xvYmFscy5jCkBAIC0wLDAgKzEsNjQgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMp IDIwMTAgQ29sbGFib3JhIEx0ZC4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2Fy ZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYworICogTGljZW5zZSBhcyBw dWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgKiB2ZXJz aW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNp b24uCisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQg aXQgd2lsbCBiZSB1c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQg ZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5F U1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqIExpYnJhcnkgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQg aGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExp Y2Vuc2UKKyAqIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5M SUIuICBJZiBub3QsIHdyaXRlIHRvCisgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ bmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAorICogQm9zdG9uLCBNQSAwMjEx MC0xMzAxLCBVU0EuCisgKi8KKworI2luY2x1ZGUgPGd0ay9ndGsuaD4KKyNpbmNsdWRlIDxsaWJz b3VwL3NvdXAuaD4KKyNpbmNsdWRlIDx3ZWJraXQvd2Via2l0Lmg+CisKKyNpZiBHTElCX0NIRUNL X1ZFUlNJT04oMiwgMTYsIDApICYmIEdUS19DSEVDS19WRVJTSU9OKDIsIDE0LCAwKQorCisvLyBN YWtlIHN1cmUgdGhlIHNlc3Npb24gaXMgaW5pdGlhbGl6ZWQgcHJvcGVybHkgd2hlbiB3ZWJraXRf Z2V0X2RlZmF1bHRfc2Vzc2lvbigpIGlzIGNhbGxlZC4KK3N0YXRpYyB2b2lkIHRlc3RfZ2xvYmFs c19kZWZhdWx0X3Nlc3Npb24oKQoreworICAgIFNvdXBTZXNzaW9uKiBzZXNzaW9uID0gd2Via2l0 X2dldF9kZWZhdWx0X3Nlc3Npb24oKTsKKyAgICBzb3VwX3Nlc3Npb25fcmVtb3ZlX2ZlYXR1cmVf YnlfdHlwZShzZXNzaW9uLCBXRUJLSVRfVFlQRV9TT1VQX0FVVEhfRElBTE9HKTsKKworICAgIC8v IFRoaXMgbWFrZXMgc3VyZSBvdXIgaW5pdGlhbGl6YXRpb24gcmFuLgorICAgIGdfYXNzZXJ0KHNv dXBfc2Vzc2lvbl9nZXRfZmVhdHVyZShzZXNzaW9uLCBTT1VQX1RZUEVfQ09OVEVOVF9ERUNPREVS KSAhPSBOVUxMKTsKKworICAgIC8vIENyZWF0aW5nIGEgV2ViVmlldyBzaG91bGQgbWFrZSBzdXJl IHRoZSBzZXNzaW9uIGlzCisgICAgLy8gaW5pdGlhbGl6ZWQsIGFuZCBub3QgbWVzcyB3aXRoIG91 ciBjaGFuZ2VzLgorICAgIFdlYktpdFdlYlZpZXcqIHdlYl92aWV3ID0gV0VCS0lUX1dFQl9WSUVX KHdlYmtpdF93ZWJfdmlld19uZXcoKSk7CisgICAgZ19vYmplY3RfcmVmX3Npbmsod2ViX3ZpZXcp OworICAgIGdfb2JqZWN0X3VucmVmKHdlYl92aWV3KTsKKworICAgIC8vIFRoZXNlIG1ha2VzIHN1 cmUgb3VyIG1vZGlmaWNhdGlvbiB3YXMga2VwdC4KKyAgICBnX2Fzc2VydChzb3VwX3Nlc3Npb25f Z2V0X2ZlYXR1cmUoc2Vzc2lvbiwgU09VUF9UWVBFX0NPTlRFTlRfREVDT0RFUikgIT0gTlVMTCk7 CisgICAgZ19hc3NlcnQoc291cF9zZXNzaW9uX2dldF9mZWF0dXJlKHNlc3Npb24sIFdFQktJVF9U WVBFX1NPVVBfQVVUSF9ESUFMT0cpID09IE5VTEwpOworfQorCitpbnQgbWFpbihpbnQgYXJnYywg Y2hhcioqIGFyZ3YpCit7CisgICAgZ190aHJlYWRfaW5pdChOVUxMKTsKKyAgICBndGtfdGVzdF9p bml0KCZhcmdjLCAmYXJndiwgTlVMTCk7CisKKyAgICBnX3Rlc3RfYnVnX2Jhc2UoImh0dHBzOi8v YnVncy53ZWJraXQub3JnLyIpOworICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC9nbG9iYWxz L2RlZmF1bHRfc2Vzc2lvbiIsCisgICAgICAgICAgICAgICAgICAgIHRlc3RfZ2xvYmFsc19kZWZh dWx0X3Nlc3Npb24pOworICAgIHJldHVybiBnX3Rlc3RfcnVuKCk7Cit9CisKKyNlbHNlCitpbnQg bWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCit7CisgICAgZ19jcml0aWNhbCgiWW91IHdpbGwg bmVlZCBhdCBsZWFzdCBnbGliLTIuMTYuMCBhbmQgZ3RrLTIuMTQuMCB0byBydW4gdGhlIHVuaXQg dGVzdHMuIERvaW5nIG5vdGhpbmcgbm93LiIpOworICAgIHJldHVybiAwOworfQorCisjZW5kaWYK ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggODNmNmMwMC4uNDg5MTdhYiAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTM5NjIsNiArMzk2Miw3IEBAIHZvaWQg d2Via2l0X3dlYl92aWV3X3NldF9mdWxsX2NvbnRlbnRfem9vbShXZWJLaXRXZWJWaWV3KiB3ZWJW aWV3LCBnYm9vbGVhbiB6b29tCiAgKi8KIFNvdXBTZXNzaW9uKiB3ZWJraXRfZ2V0X2RlZmF1bHRf c2Vzc2lvbiAoKQogeworICAgIHdlYmtpdF9pbml0KCk7CiAgICAgcmV0dXJuIFJlc291cmNlSGFu ZGxlOjpkZWZhdWx0U2Vzc2lvbigpOwogfQogCkBAIC00Mzc3LDYgKzQzNzgsOCBAQCBHX0NPTlNU X1JFVFVSTiBnY2hhciogd2Via2l0X3dlYl92aWV3X2dldF9pY29uX3VyaShXZWJLaXRXZWJWaWV3 KiB3ZWJWaWV3KQogICovCiB2b2lkIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwoV2ViS2l0Q2FjaGVN b2RlbCBtb2RlbCkKIHsKKyAgICB3ZWJraXRfaW5pdCgpOworCiAgICAgaWYgKGNhY2hlTW9kZWwg PT0gbW9kZWwpCiAgICAgICAgIHJldHVybjsKIApAQCAtNDQyNSw1ICs0NDI4LDYgQEAgdm9pZCB3 ZWJraXRfc2V0X2NhY2hlX21vZGVsKFdlYktpdENhY2hlTW9kZWwgbW9kZWwpCiAgKi8KIFdlYktp dENhY2hlTW9kZWwgd2Via2l0X2dldF9jYWNoZV9tb2RlbCgpCiB7CisgICAgd2Via2l0X2luaXQo KTsKICAgICByZXR1cm4gY2FjaGVNb2RlbDsKIH0KLS0gCjEuNy4wCgo=