36751 2010-03-29 03:31:25 -0700 [Qt] Windows CE build is broken 2010-04-20 12:02:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other Other CLOSED FIXED Qt P1 Blocker --- 35784 1 hausmann hausmann commit-queue ismail jturcotte laszlo.gombos oldest_to_newest 205375 0 hausmann 2010-03-29 03:31:25 -0700 From https://bugs.webkit.org/show_bug.cgi?id=36590#c5 : pcre_compile.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_exec.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_tables.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_ucp_searchfuncs.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_xclass.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory JavaScriptCore/os-win32 is missing from the include paths. 205379 1 51896 hausmann 2010-03-29 03:39:27 -0700 Created attachment 51896 Patch 205381 2 ismail 2010-03-29 03:41:30 -0700 (In reply to comment #1) > Created an attachment (id=51896) [details] > Patch + +# DEFINES += ENABLE_SVG=0 ENABLE_XPATH=0 ENABLE_XBL=0 \ +# ENABLE_SVG_ANIMATION=0 ENABLE_SVG_USE=0 \ +# ENABLE_SVG_FOREIGN_OBJECT=0 ENABLE_SVG_AS_IMAGE=0 those seems unrelated. 206008 3 ismail 2010-03-30 07:57:47 -0700 Patch fixes the compilation error for me, thanks. 207454 4 51896 eric 2010-04-01 15:59:34 -0700 Comment on attachment 51896 Patch Can we remove the: # DEFINES += ENABLE_SVG=0 ENABLE_XPATH=0 ENABLE_XBL=0 \ 59 # ENABLE_SVG_ANIMATION=0 ENABLE_SVG_USE=0 \ 60 # ENABLE_SVG_FOREIGN_OBJECT=0 ENABLE_SVG_AS_IMAGE=0 The commented out code seems usless. 212941 5 53454 jturcotte 2010-04-15 11:15:33 -0700 Created attachment 53454 Patch v2 Upstreaming the patch currently in qt/src/3rdparty/webkit The same as the previous patch except the commented part has been removed 213471 6 hausmann 2010-04-16 16:07:41 -0700 I can't really review a patch with my own name in it, but it looks good to me ;) 213849 7 51896 eric 2010-04-18 16:27:27 -0700 Comment on attachment 51896 Patch Cleared Eric Seidel's review+ from obsolete attachment 51896 so that this bug does not appear in http://webkit.org/pending-commit. 213897 8 53454 laszlo.gombos 2010-04-18 21:13:25 -0700 Comment on attachment 53454 Patch v2 lgtm as well, r+. 213899 9 53454 commit-queue 2010-04-18 21:22:53 -0700 Comment on attachment 53454 Patch v2 Clearing flags on attachment: 53454 Committed r57802: <http://trac.webkit.org/changeset/57802> 213900 10 commit-queue 2010-04-18 21:22:58 -0700 All reviewed patches have been landed. Closing bug. 214825 11 hausmann 2010-04-20 12:02:34 -0700 Revision r57802 cherry-picked into qtwebkit-2.0 with commit 2ccb40583521dc3a8744555663359671a28aaa2a 51896 2010-03-29 03:39:27 -0700 2010-04-18 16:27:27 -0700 Patch bug-36751-20100329123925.patch text/plain 2403 hausmann ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjY2NlNGFmLi4zNDYzN2QxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDMtMjkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g V2luZG93cyBDRSBidWlsZCBpcyBicm9rZW4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3NTEKKworICAgICAgICAqIEphdmFTY3JpcHRDb3JlLnBy aTogQWRkIG9zLXdpbjMyIGFuZCBvcy13aW5jZSB0byB0aGUgaW5jbHVkZSBzZWFyY2ggcGF0aAor ICAgICAgICBmb3IgbGlianNjb3JlIGFuZCBldmVyeW9uZSB1c2luZyBpdC4KKwogMjAxMC0wMy0y OSAgVGhvbWFzIFphbmRlciAgPHQuemFuZGVyQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlLnByaSBiL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQppbmRleCBjMWNh ZWNiLi44ZDMwMWIxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5w cmkKKysrIGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCkBAIC01NCw2ICs1NCwx MyBAQCBjb250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQsbm8pIHsKIHdpbmNlKiB7CiAgICAgSU5D TFVERVBBVEggKz0gJCRRVF9TT1VSQ0VfVFJFRS9zcmMvM3JkcGFydHkvY2UtY29tcGF0CiAgICAg REVGSU5FUyArPSBXSU5DRUJBU0lDCisKKyMgICAgREVGSU5FUyArPSBFTkFCTEVfU1ZHPTAgRU5B QkxFX1hQQVRIPTAgRU5BQkxFX1hCTD0wIFwKKyMgICAgICAgICAgICAgICBFTkFCTEVfU1ZHX0FO SU1BVElPTj0wIEVOQUJMRV9TVkdfVVNFPTAgIFwKKyMgICAgICAgICAgICAgICBFTkFCTEVfU1ZH X0ZPUkVJR05fT0JKRUNUPTAgRU5BQkxFX1NWR19BU19JTUFHRT0wCisKKyAgICBJTkNMVURFUEFU SCArPSAkJFBXRC8uLi9KYXZhU2NyaXB0Q29yZS9vcy13aW5jZQorICAgIElOQ0xVREVQQVRIICs9 ICQkUFdELy4uL0phdmFTY3JpcHRDb3JlL29zLXdpbjMyCiB9CiAKIApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyYjc0NmU4Li4yZjNkN2Fk IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTAzLTI5ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNt YW5uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIFdpbmRvd3MgQ0UgYnVpbGQgaXMgYnJva2VuCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzUxCisKKyAgICAgICAgKiBXZWJD b3JlLnBybzogTW92ZWQgd2luY2UgaW5jbHVkZXMgdG8gSmF2YVNjcmlwdENvcmUucHJpCisKIDIw MTAtMDMtMjkgIFRob21hcyBaYW5kZXIgIDx0LnphbmRlckBub2tpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUu cHJvIGIvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCBiM2M1YmE3Li5iYTRlMDU1IDEwMDY0NAot LS0gYS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTk4 LDE1ICs5OCw2IEBAIHdpbjMyLW1zdmMyMDA1fHdpbjMyLW1zdmMyMDA4OnsKICAgICBRTUFLRV9D WFhGTEFHU19SRUxFQVNFIC09IC1HTAogfQogCi13aW5jZSogewotIyAgICBERUZJTkVTICs9IEVO QUJMRV9TVkc9MCBFTkFCTEVfWFBBVEg9MCBFTkFCTEVfWEJMPTAgXAotIyAgICAgICAgICAgICAg IEVOQUJMRV9TVkdfQU5JTUFUSU9OPTAgRU5BQkxFX1NWR19VU0U9MCAgXAotIyAgICAgICAgICAg ICAgIEVOQUJMRV9TVkdfRk9SRUlHTl9PQkpFQ1Q9MCBFTkFCTEVfU1ZHX0FTX0lNQUdFPTAKLQot ICAgIElOQ0xVREVQQVRIICs9ICQkUFdELy4uL0phdmFTY3JpcHRDb3JlL29zLXdpbmNlCi0gICAg SU5DTFVERVBBVEggKz0gJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvb3Mtd2luMzIKLX0KLQogIyBQ aWNrIHVwIDNyZHBhcnR5IGxpYnJhcmllcyBmcm9tIElOQ0xVREUvTElCIGp1c3QgbGlrZSB3aXRo IE1TVkMKIHdpbjMyLWcrKyB7CiAgICAgVE1QUEFUSCAgICAgICAgICAgID0gJCRxdW90ZSgkJChJ TkNMVURFKSkK 53454 2010-04-15 11:15:33 -0700 2010-04-18 21:22:53 -0700 Patch v2 wince_includes_js.patch text/plain 2144 jturcotte ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA4YTg2YzU0Li4wOTczZjA0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTAtMDMtMjkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g Rml4IEphdmFTY3JpcHRDb3JlJ3MgaW5jbHVkZSBwYXRoIGZvciBXaW5DRSBidWlsZHMKKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3NTEKKworICAg ICAgICAqIEphdmFTY3JpcHRDb3JlLnByaToKKwogMjAxMC0wNC0xMiAgSm9jZWx5biBUdXJjb3R0 ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IG5v Ym9keSwgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUucHJpIGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCmluZGV4IGM1NWM0OGIu LjJiOTQyMDYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQor KysgYi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKQEAgLTU2LDYgKzU2LDkgQEAg Y29udGFpbnMoSkFWQVNDUklQVENPUkVfSklULG5vKSB7CiB3aW5jZSogewogICAgIElOQ0xVREVQ QVRIICs9ICQkUVRfU09VUkNFX1RSRUUvc3JjLzNyZHBhcnR5L2NlLWNvbXBhdAogICAgIERFRklO RVMgKz0gV0lOQ0VCQVNJQworCisgICAgSU5DTFVERVBBVEggKz0gJCRQV0QvLi4vSmF2YVNjcmlw dENvcmUvb3Mtd2luY2UKKyAgICBJTkNMVURFUEFUSCArPSAkJFBXRC8uLi9KYXZhU2NyaXB0Q29y ZS9vcy13aW4zMgogfQogCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggYjBmOTliZC4uZWExNGQ3NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0w My0yOSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggSmF2YVNj cmlwdENvcmUncyBpbmNsdWRlIHBhdGggZm9yIFdpbkNFIGJ1aWxkcworCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjc1MQorCisgICAgICAgICogV2Vi Q29yZS5wcm86CisKIDIwMTAtMDQtMTUgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNv dHRlQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4 IGU5NDIxNjcuLjAwYTg1ZjYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIv V2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtOTksMTUgKzk5LDYgQEAgd2luMzItbXN2YzIwMDV8d2lu MzItbXN2YzIwMDg6ewogICAgIFFNQUtFX0NYWEZMQUdTX1JFTEVBU0UgLT0gLUdMCiB9CiAKLXdp bmNlKiB7Ci0jICAgIERFRklORVMgKz0gRU5BQkxFX1NWRz0wIEVOQUJMRV9YUEFUSD0wIEVOQUJM RV9YQkw9MCBcCi0jICAgICAgICAgICAgICAgRU5BQkxFX1NWR19BTklNQVRJT049MCBFTkFCTEVf U1ZHX1VTRT0wICBcCi0jICAgICAgICAgICAgICAgRU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVD0w IEVOQUJMRV9TVkdfQVNfSU1BR0U9MAotCi0gICAgSU5DTFVERVBBVEggKz0gJCRQV0QvLi4vSmF2 YVNjcmlwdENvcmUvb3Mtd2luY2UKLSAgICBJTkNMVURFUEFUSCArPSAkJFBXRC8uLi9KYXZhU2Ny aXB0Q29yZS9vcy13aW4zMgotfQotCiAjIFBpY2sgdXAgM3JkcGFydHkgbGlicmFyaWVzIGZyb20g SU5DTFVERS9MSUIganVzdCBsaWtlIHdpdGggTVNWQwogd2luMzItZysrIHsKICAgICBUTVBQQVRI ICAgICAgICAgICAgPSAkJHF1b3RlKCQkKElOQ0xVREUpKQo=