36750 2010-03-29 02:32:35 -0700 [Qt] Package build without touch support is broken 2010-04-07 06:45:24 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All CLOSED FIXED Qt P1 Blocker --- 37149 35784 1 hausmann hausmann gustavo jturcotte laszlo.gombos webkit.review.bot xan.lopez oldest_to_newest 205362 0 hausmann 2010-03-29 02:32:35 -0700 The IDL files Document.idl, Element.idl and DOMWindow.idl define touch event related properties depending on the ENABLE_TOUCH_EVENTS feature define. The conditional build is done using an #ifdef inside the idl file. That makes the generated sources depend on the setting at idl generation time, which breaks the package build where all files are pre-generated but it's possible to disable certain features. For example touch support is disabled when compiling against Qt 4.5. The idl files should use the Conditional=TOUCH_EVENTS syntax, to place the #ifdefs into the generated code. 205368 1 51894 hausmann 2010-03-29 02:42:16 -0700 Created attachment 51894 Patch 205372 2 webkit.review.bot 2010-03-29 03:15:01 -0700 Attachment 51894 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1592046 205380 3 hausmann 2010-03-29 03:40:57 -0700 (In reply to comment #2) > Attachment 51894 [details] did not build on gtk: > Build output: http://webkit-commit-queue.appspot.com/results/1592046 It looks like the Gtk EWS needs a clean rebuild. 206314 4 51894 laszlo.gombos 2010-03-30 18:27:01 -0700 Comment on attachment 51894 Patch LGTM, r+. Have not set to the cq flag yet, as it seems that this needs some extra (manual) care when landed. 207978 5 51894 eric 2010-04-02 11:50:56 -0700 Comment on attachment 51894 Patch Extra manual care means cq-. Also looks like this might cause Gtk and Mac to fail to build, which would mean r-. I'm not sure why the mac failed since it didn't produce a log. Sadly we don't yet have a way to re-queue a patch on the EWS. 209021 6 hausmann 2010-04-06 06:45:31 -0700 The error is real, the EWS worked correctly :-) I've filed 37149 to fix the bindings generator bug first before landing this. 209589 7 hausmann 2010-04-07 05:50:00 -0700 <cherry-pick-for-backport: 57204> 209605 8 hausmann 2010-04-07 06:23:46 -0700 Committed r57205: <http://trac.webkit.org/changeset/57205> 209613 9 hausmann 2010-04-07 06:45:15 -0700 Revision r57204 cherry-picked into qtwebkit-2.0 with commit f544a8b519878c81f454876d80e1cd17a2f876ebRevision r57205 cherry-picked into qtwebkit-2.0 with commit 181033d9a0e7d1a6b1fed2dfff0cbc563e9a958c 51894 2010-03-29 02:42:16 -0700 2010-04-02 11:50:56 -0700 Patch bug-36750-20100329114214.patch text/plain 4165 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDEyZmQzOS4uMWFkODBlNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMy0yOSAgU2ltb24gSGF1c21h bm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2NzUwCisKKyAgICAgICAgW1F0XSBQYWNrYWdlIGJ1aWxkIHdpdGhvdXQgdG91Y2gg c3VwcG9ydCBpcyBicm9rZW4KKworICAgICAgICBVc2UgdGhlIGNvbmRpdGlvbmFsIGF0dHJpYnV0 ZSBpbnN0ZWFkIG9mICNpZmRlZnMgaW4gdGhlIGlkbCBmaWxlIGZvciB0aGUKKyAgICAgICAgdG91 Y2ggc3BlY2lmaWMgcHJvcGVydGllcywgdG8gbWFrZSB0aGUgZ2VuZXJhdGVkIGZpbGVzIGNvbXBp bGUgd2l0aCBhbmQKKyAgICAgICAgd2l0aG91dCB0aGUgdG91Y2ggZXZlbnRzIGVuYWJsZWQuCisK KyAgICAgICAgKiBkb20vRG9jdW1lbnQuaWRsOiBVc2UgY29uZGl0aW9uYWwgaW5zdGVhZCBvZiAj aWZkZWYuCisgICAgICAgICogZG9tL0VsZW1lbnQuaWRsOiBEaXR0by4KKyAgICAgICAgKiBwYWdl L0RPTVdpbmRvdy5pZGw6IERpdHRvLgorCiAyMDEwLTAzLTI5ICBNaWtoYWlsIE5hZ2Fub3YgIDxt bmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1h bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmlkbCBiL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmlkbAppbmRleCAyNmVkN2ZkLi44OGJkNjM5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5pZGwKKysrIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsCkBAIC0zMDYsMTIg KzMwNiwxMCBAQCBtb2R1bGUgY29yZSB7CiAgICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW1dIEV2 ZW50TGlzdGVuZXIgb25yZXNldDsKICAgICAgICAgYXR0cmlidXRlIFtEb250RW51bV0gRXZlbnRM aXN0ZW5lciBvbnNlYXJjaDsKICAgICAgICAgYXR0cmlidXRlIFtEb250RW51bV0gRXZlbnRMaXN0 ZW5lciBvbnNlbGVjdHN0YXJ0OwotI2lmIGRlZmluZWQoRU5BQkxFX1RPVUNIX0VWRU5UUykgJiYg RU5BQkxFX1RPVUNIX0VWRU5UUwotICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExp c3RlbmVyIG9udG91Y2hzdGFydDsKLSAgICAgICAgYXR0cmlidXRlIFtEb250RW51bV0gRXZlbnRM aXN0ZW5lciBvbnRvdWNobW92ZTsKLSAgICAgICAgYXR0cmlidXRlIFtEb250RW51bV0gRXZlbnRM aXN0ZW5lciBvbnRvdWNoZW5kOwotICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExp c3RlbmVyIG9udG91Y2hjYW5jZWw7Ci0jZW5kaWYKKyAgICAgICAgYXR0cmlidXRlIFtEb250RW51 bSxDb25kaXRpb25hbD1UT1VDSF9FVkVOVFNdIEV2ZW50TGlzdGVuZXIgb250b3VjaHN0YXJ0Owor ICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtLENvbmRpdGlvbmFsPVRPVUNIX0VWRU5UU10gRXZl bnRMaXN0ZW5lciBvbnRvdWNobW92ZTsKKyAgICAgICAgYXR0cmlidXRlIFtEb250RW51bSxDb25k aXRpb25hbD1UT1VDSF9FVkVOVFNdIEV2ZW50TGlzdGVuZXIgb250b3VjaGVuZDsKKyAgICAgICAg YXR0cmlidXRlIFtEb250RW51bSxDb25kaXRpb25hbD1UT1VDSF9FVkVOVFNdIEV2ZW50TGlzdGVu ZXIgb250b3VjaGNhbmNlbDsKICNlbmRpZgogICAgIH07CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUv ZG9tL0VsZW1lbnQuaWRsIGIvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwKaW5kZXggZTU2NWJjMC4u MTM2ODUwMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwKKysrIGIvV2ViQ29y ZS9kb20vRWxlbWVudC5pZGwKQEAgLTE5NSwxMiArMTk1LDEwIEBAIG1vZHVsZSBjb3JlIHsKICAg ICAgICAgYXR0cmlidXRlIFtEb250RW51bV0gRXZlbnRMaXN0ZW5lciBvbnJlc2V0OwogICAgICAg ICBhdHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExpc3RlbmVyIG9uc2VhcmNoOwogICAgICAgICBh dHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExpc3RlbmVyIG9uc2VsZWN0c3RhcnQ7Ci0jaWYgZGVm aW5lZChFTkFCTEVfVE9VQ0hfRVZFTlRTKSAmJiBFTkFCTEVfVE9VQ0hfRVZFTlRTCi0gICAgICAg IGF0dHJpYnV0ZSBbRG9udEVudW1dIEV2ZW50TGlzdGVuZXIgb250b3VjaHN0YXJ0OwotICAgICAg ICBhdHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExpc3RlbmVyIG9udG91Y2htb3ZlOwotICAgICAg ICBhdHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExpc3RlbmVyIG9udG91Y2hlbmQ7Ci0gICAgICAg IGF0dHJpYnV0ZSBbRG9udEVudW1dIEV2ZW50TGlzdGVuZXIgb250b3VjaGNhbmNlbDsKLSNlbmRp ZgorICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtLENvbmRpdGlvbmFsPVRPVUNIX0VWRU5UU10g RXZlbnRMaXN0ZW5lciBvbnRvdWNoc3RhcnQ7CisgICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW0s Q29uZGl0aW9uYWw9VE9VQ0hfRVZFTlRTXSBFdmVudExpc3RlbmVyIG9udG91Y2htb3ZlOworICAg ICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtLENvbmRpdGlvbmFsPVRPVUNIX0VWRU5UU10gRXZlbnRM aXN0ZW5lciBvbnRvdWNoZW5kOworICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtLENvbmRpdGlv bmFsPVRPVUNIX0VWRU5UU10gRXZlbnRMaXN0ZW5lciBvbnRvdWNoY2FuY2VsOwogI2VuZGlmCiAg ICAgfTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9XZWJDb3Jl L3BhZ2UvRE9NV2luZG93LmlkbAppbmRleCBkNDU3YmRjLi4zMWU0ZDRmIDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAorKysgYi9XZWJDb3JlL3BhZ2UvRE9NV2luZG93Lmlk bApAQCAtMjkzLDEyICsyOTMsMTAgQEAgbW9kdWxlIHdpbmRvdyB7CiAjaWYgZGVmaW5lZChFTkFC TEVfT1JJRU5UQVRJT05fRVZFTlRTKSAmJiBFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTCiAgICAg ICAgIGF0dHJpYnV0ZSBFdmVudExpc3RlbmVyIG9ub3JpZW50YXRpb25jaGFuZ2U7CiAjZW5kaWYK LSAjaWYgZGVmaW5lZChFTkFCTEVfVE9VQ0hfRVZFTlRTKSAmJiBFTkFCTEVfVE9VQ0hfRVZFTlRT Ci0gICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW1dIEV2ZW50TGlzdGVuZXIgb250b3VjaHN0YXJ0 OwotICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExpc3RlbmVyIG9udG91Y2htb3Zl OwotICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtXSBFdmVudExpc3RlbmVyIG9udG91Y2hlbmQ7 Ci0gICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW1dIEV2ZW50TGlzdGVuZXIgb250b3VjaGNhbmNl bDsKLSAjZW5kaWYKKyAgICAgICAgYXR0cmlidXRlIFtEb250RW51bSxDb25kaXRpb25hbD1UT1VD SF9FVkVOVFNdIEV2ZW50TGlzdGVuZXIgb250b3VjaHN0YXJ0OworICAgICAgICBhdHRyaWJ1dGUg W0RvbnRFbnVtLENvbmRpdGlvbmFsPVRPVUNIX0VWRU5UU10gRXZlbnRMaXN0ZW5lciBvbnRvdWNo bW92ZTsKKyAgICAgICAgYXR0cmlidXRlIFtEb250RW51bSxDb25kaXRpb25hbD1UT1VDSF9FVkVO VFNdIEV2ZW50TGlzdGVuZXIgb250b3VjaGVuZDsKKyAgICAgICAgYXR0cmlidXRlIFtEb250RW51 bSxDb25kaXRpb25hbD1UT1VDSF9FVkVOVFNdIEV2ZW50TGlzdGVuZXIgb250b3VjaGNhbmNlbDsK IAogICAgICAgICAvLyBFdmVudFRhcmdldCBpbnRlcmZhY2UKICAgICAgICAgW0N1c3RvbV0gdm9p ZCBhZGRFdmVudExpc3RlbmVyKGluIERPTVN0cmluZyB0eXBlLApAQCAtNzEyLDkgKzcxMCw3IEBA IG1vZHVsZSB3aW5kb3cgewogI2VuZGlmCiAjZW5kaWYKIAotI2lmIGRlZmluZWQoRU5BQkxFX1RP VUNIX0VWRU5UUykgJiYgRU5BQkxFX1RPVUNIX0VWRU5UUwotICAgICAgICBhdHRyaWJ1dGUgVG91 Y2hFdmVudENvbnN0cnVjdG9yIFRvdWNoRXZlbnQ7Ci0jZW5kaWYKKyAgICAgICAgYXR0cmlidXRl IFtDb25kaXRpb25hbD1UT1VDSF9FVkVOVFNdIFRvdWNoRXZlbnRDb25zdHJ1Y3RvciBUb3VjaEV2 ZW50OwogCiAgICAgICAgIGF0dHJpYnV0ZSBET01Gb3JtRGF0YUNvbnN0cnVjdG9yIEZvcm1EYXRh OwogCg==