36749 2010-03-29 02:23:52 -0700 [Qt] Shadowbuilds of WebCore with Qt on Symbian fails. 2010-03-29 07:07:20 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC S60 3rd edition CLOSED FIXED Qt P2 Normal --- 35784 0 t.zander webkit-unassigned hausmann webkit.review.bot oldest_to_newest 205358 0 51890 t.zander 2010-03-29 02:23:52 -0700 Created attachment 51890 patch to make webkit shadow-compile on a linux box using gcce and cross compiling to arm for symbian I found that the attached change was required. 205361 1 webkit.review.bot 2010-03-29 02:28:59 -0700 Attachment 51890 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 205369 2 51895 t.zander 2010-03-29 02:43:12 -0700 Created attachment 51895 patch using git diff 205388 3 51895 hausmann 2010-03-29 04:01:19 -0700 Comment on attachment 51895 patch using git diff > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index a788d95..41629af 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,11 @@ > +2010-03-29 Thomas Zander <t.zander@nokia.com> > + > + Reviewed by NOBODY > + > + Qt qmake out-of-source builds failed > + > + * WebCore.pro: Fix for shadow builds > + > 2010-03-26 Andrey Kosyakov <caseq@chromium.org> Please explain in the ChangeLog why the build broke and add a link to this bugzilla entry. > Reviewed by Pavel Feldman. > diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro > index 15c881f..700f20c 100644 > --- a/WebCore/WebCore.pro > +++ b/WebCore/WebCore.pro > @@ -11,7 +11,7 @@ symbian: { > } else { > TARGET.UID3 = 0xE00267C2 > } > - webkitlibs.sources = QtWebKit$${QT_LIBINFIX}.dll > + webkitlibs.sources = $$QMAKE_LIBDIR_QT/QtWebKit$${QT_LIBINFIX}.dll What's $$QMAKE_LIBDIR_QT set to with sbsv2/abld builds? Doesn't the dll end up in epoc32/release/armv6/urel, too? Or does the sbs2/abld build system place the dll into both locations? Either way, this looks like the right thing to do for the plain makefile builds, but it will break when building WebKit outside of Qt, where we certainly don't place the dll in $$QMAKE_LIBDIR_QT after linking. One option would be to do it like this: webkitlibs.sources = QtWebKit$${QT_LIBINFIX}.dll CONFIG(QTDIR_build): webkitlibs.sources = $$QMAKE_LIBDIR_QT/$$webkitlibs.sources 205406 4 51900 t.zander 2010-03-29 04:59:55 -0700 Created attachment 51900 updated patch 205412 5 51902 t.zander 2010-03-29 05:43:27 -0700 Created attachment 51902 Fix for out-of-qt builds On the latest symbian SDK with an MMP based buildsystem I verified that the dll goes to the epocroot, so this should work. 205422 6 51902 hausmann 2010-03-29 07:01:48 -0700 Comment on attachment 51902 Fix for out-of-qt builds > diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro > index 15c881f..5f24664 100644 > --- a/WebCore/WebCore.pro > +++ b/WebCore/WebCore.pro > @@ -12,6 +12,7 @@ symbian: { > TARGET.UID3 = 0xE00267C2 > } > webkitlibs.sources = QtWebKit$${QT_LIBINFIX}.dll > + CONFIG(QTDIR_build)|: webkitlibs.sources = $$QMAKE_LIBDIR_QT/$$webkitlibs.sources The | doesn't belong there. I'll fix it when landing it. 205424 7 hausmann 2010-03-29 07:05:48 -0700 Committed r56719: <http://trac.webkit.org/changeset/56719> 205425 8 hausmann 2010-03-29 07:07:09 -0700 Revision r56719 cherry-picked into qtwebkit-2.0 with commit 45d1b73ab35a82b5dd8c55df5b924a60994a932a 51890 2010-03-29 02:23:52 -0700 2010-03-29 02:43:12 -0700 patch WebCore_pro-shadowBuild.diff text/plain 674 t.zander LS0tIFdlYkNvcmUvQ2hhbmdlTG9nCisrKyBXZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEx IEBACisyMDEwLTAzLTI5ICBUaG9tYXMgWmFuZGVyICA8dC56YW5kZXJAbm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWQorCisgICAgICAgIFF0IHFtYWtlIG91dC1vZi1zb3Vy Y2UgYnVpbGRzIGZhaWxlZAorCisgICAgICAgICogV2ViQ29yZS5wcm86IEZpeCBmb3Igc2hhZG93 IGJ1aWxkcworCiAyMDEwLTAzLTI2ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KLS0tIFdlYkNvcmUvV2Vi Q29yZS5wcm8KKysrIFdlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTExLDcgKzExLDcgQEAgc3ltYmlh bjogewogICAgIH0gZWxzZSB7CiAgICAgICAgIFRBUkdFVC5VSUQzID0gMHhFMDAyNjdDMgogICAg IH0KLSAgICB3ZWJraXRsaWJzLnNvdXJjZXMgPSBRdFdlYktpdCQke1FUX0xJQklORklYfS5kbGwK KyAgICB3ZWJraXRsaWJzLnNvdXJjZXMgPSAkJFFNQUtFX0xJQkRJUl9RVC9RdFdlYktpdCQke1FU X0xJQklORklYfS5kbGwKICAgICB3ZWJraXRsaWJzLnBhdGggPSAvc3lzL2JpbgogICAgIHZlbmRv cmluZm8gPSBcCiAgICAgICAgICI7IExvY2FsaXNlZCBWZW5kb3IgbmFtZSIgXAo= 51895 2010-03-29 02:43:12 -0700 2010-03-29 04:59:55 -0700 patch using git diff WebCore_pro-shadowBuild.diff text/plain 848 t.zander ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTc4OGQ5NS4uNDE2MjlhZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAxMC0wMy0yOSAgVGhvbWFzIFphbmRl ciAgPHQuemFuZGVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkKKwor ICAgICAgICBRdCBxbWFrZSBvdXQtb2Ytc291cmNlIGJ1aWxkcyBmYWlsZWQKKworICAgICAgICAq IFdlYkNvcmUucHJvOiBGaXggZm9yIHNoYWRvdyBidWlsZHMKKwogMjAxMC0wMy0yNiAgQW5kcmV5 IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBh dmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUucHJvIGIvV2ViQ29yZS9X ZWJDb3JlLnBybwppbmRleCAxNWM4ODFmLi43MDBmMjBjIDEwMDY0NAotLS0gYS9XZWJDb3JlL1dl YkNvcmUucHJvCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTExLDcgKzExLDcgQEAgc3lt YmlhbjogewogICAgIH0gZWxzZSB7CiAgICAgICAgIFRBUkdFVC5VSUQzID0gMHhFMDAyNjdDMgog ICAgIH0KLSAgICB3ZWJraXRsaWJzLnNvdXJjZXMgPSBRdFdlYktpdCQke1FUX0xJQklORklYfS5k bGwKKyAgICB3ZWJraXRsaWJzLnNvdXJjZXMgPSAkJFFNQUtFX0xJQkRJUl9RVC9RdFdlYktpdCQk e1FUX0xJQklORklYfS5kbGwKICAgICB3ZWJraXRsaWJzLnBhdGggPSAvc3lzL2JpbgogICAgIHZl bmRvcmluZm8gPSBcCiAgICAgICAgICI7IExvY2FsaXNlZCBWZW5kb3IgbmFtZSIgXAo= 51900 2010-03-29 04:59:55 -0700 2010-03-29 05:43:27 -0700 updated patch WebCore_pro-shadowBuild.diff text/plain 1031 t.zander ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTc4OGQ5NS4uNzM5YjYyZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0yOSAgVGhvbWFzIFphbmRl ciAgPHQuemFuZGVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkKKwor ICAgICAgICBEb2luZyBhICdtYWtlIHNpcycgZXhwZWN0cyB0aGUgZGxsIGluIHRoZSBsaWJkaXIs IHNvIHBsYWNlIGl0CisgICAgICAgIHRoZXJlLiAgVGhpcyBmaXhlcyBvdXQtb2Ytc291cmNlIGJ1 aWxkaW5nIHRvIGFsd2F5cyBwdXQgdGhlIGRsbAorICAgICAgICBpbiB0aGUgZXhlcGN0ZWQgZGly LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3NDkK KworICAgICAgICAqIFdlYkNvcmUucHJvOiBGaXggZm9yIHNoYWRvdyBidWlsZHMKKwogMjAxMC0w My0yNiAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUucHJv IGIvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCAxNWM4ODFmLi43MDBmMjBjIDEwMDY0NAotLS0g YS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTExLDcg KzExLDcgQEAgc3ltYmlhbjogewogICAgIH0gZWxzZSB7CiAgICAgICAgIFRBUkdFVC5VSUQzID0g MHhFMDAyNjdDMgogICAgIH0KLSAgICB3ZWJraXRsaWJzLnNvdXJjZXMgPSBRdFdlYktpdCQke1FU X0xJQklORklYfS5kbGwKKyAgICB3ZWJraXRsaWJzLnNvdXJjZXMgPSAkJFFNQUtFX0xJQkRJUl9R VC9RdFdlYktpdCQke1FUX0xJQklORklYfS5kbGwKICAgICB3ZWJraXRsaWJzLnBhdGggPSAvc3lz L2JpbgogICAgIHZlbmRvcmluZm8gPSBcCiAgICAgICAgICI7IExvY2FsaXNlZCBWZW5kb3IgbmFt ZSIgXAo= 51902 2010-03-29 05:43:27 -0700 2010-03-29 07:01:48 -0700 Fix for out-of-qt builds WebCore_pro-shadowBuild.diff text/plain 1032 t.zander ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTc4OGQ5NS4uNzM5YjYyZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0yOSAgVGhvbWFzIFphbmRl ciAgPHQuemFuZGVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkKKwor ICAgICAgICBEb2luZyBhICdtYWtlIHNpcycgZXhwZWN0cyB0aGUgZGxsIGluIHRoZSBsaWJkaXIs IHNvIHBsYWNlIGl0CisgICAgICAgIHRoZXJlLiAgVGhpcyBmaXhlcyBvdXQtb2Ytc291cmNlIGJ1 aWxkaW5nIHRvIGFsd2F5cyBwdXQgdGhlIGRsbAorICAgICAgICBpbiB0aGUgZXhlcGN0ZWQgZGly LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3NDkK KworICAgICAgICAqIFdlYkNvcmUucHJvOiBGaXggZm9yIHNoYWRvdyBidWlsZHMKKwogMjAxMC0w My0yNiAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUucHJv IGIvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCAxNWM4ODFmLi41ZjI0NjY0IDEwMDY0NAotLS0g YS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTEyLDYg KzEyLDcgQEAgc3ltYmlhbjogewogICAgICAgICBUQVJHRVQuVUlEMyA9IDB4RTAwMjY3QzIKICAg ICB9CiAgICAgd2Via2l0bGlicy5zb3VyY2VzID0gUXRXZWJLaXQkJHtRVF9MSUJJTkZJWH0uZGxs CisgICAgQ09ORklHKFFURElSX2J1aWxkKXw6IHdlYmtpdGxpYnMuc291cmNlcyA9ICQkUU1BS0Vf TElCRElSX1FULyQkd2Via2l0bGlicy5zb3VyY2VzCiAgICAgd2Via2l0bGlicy5wYXRoID0gL3N5 cy9iaW4KICAgICB2ZW5kb3JpbmZvID0gXAogICAgICAgICAiOyBMb2NhbGlzZWQgVmVuZG9yIG5h bWUiIFwK