36748 2010-03-29 02:15:08 -0700 [Qt] Webkit for symbian building fails 2010-03-29 04:16:57 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC S60 3rd edition CLOSED FIXED Qt P2 Normal --- 35784 0 t.zander webkit-unassigned hausmann webkit.review.bot oldest_to_newest 205352 0 51888 t.zander 2010-03-29 02:15:08 -0700 Created attachment 51888 patch to make webkit compile on a linux box using gcce and cross compiling to arm for symbian I found that the attached change was required. 205355 1 webkit.review.bot 2010-03-29 02:20:10 -0700 Attachment 51888 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 205359 2 51888 hausmann 2010-03-29 02:24:30 -0700 Comment on attachment 51888 patch Looks okay to me in principle, but can you explain why you're excluding these two statements? Please also add a link to the bugzilla entry in the ChangeLog? 205366 3 t.zander 2010-03-29 02:40:05 -0700 Before the only symbian build system seeing those lines were the Windows (aka MMP) based ones. Now the linux system sees them too. And those lines are not valid there so they have to be excluded specifically. Do you want me to re-submit it re-indented? 205385 4 hausmann 2010-03-29 03:48:18 -0700 (In reply to comment #3) > Before the only symbian build system seeing those lines were the Windows (aka > MMP) based ones. Now the linux system sees them too. And those lines are not > valid there so they have to be excluded specifically. > > Do you want me to re-submit it re-indented? The indentation is fine, but it would be good to have the explanation in the ChangeLog or to have a link from the ChangeLog to this bugzilla entry, so that it's possible to find out what happened when looking at the .pro file in three months :) 205387 5 51897 t.zander 2010-03-29 03:58:41 -0700 Created attachment 51897 updated patch 205396 6 51897 hausmann 2010-03-29 04:12:58 -0700 Comment on attachment 51897 updated patch Ok! For the purpose of getting this into the release soon, I'll also land it manually. 205397 7 hausmann 2010-03-29 04:14:59 -0700 Committed r56715: <http://trac.webkit.org/changeset/56715> 205398 8 hausmann 2010-03-29 04:16:47 -0700 Revision r56715 cherry-picked into qtwebkit-2.0 with commit e769d1eecfec361b8b555dbdbc10a20d40e22fd9 51888 2010-03-29 02:15:08 -0700 2010-03-29 03:58:41 -0700 patch WebCore_pro-buildOnLinux.diff text/plain 1324 t.zander LS0tIFdlYkNvcmUvQ2hhbmdlTG9nCisrKyBXZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEx IEBACisyMDEwLTAzLTI5ICBUaG9tYXMgWmFuZGVyICA8dC56YW5kZXJAbm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWQorCisgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8g YnVpbGQgdXNpbmcgYm90aCBXaW5kb3dzIGFuZCBMaW51eCBmb3IgU3ltYmlhbgorCisgICAgICAg ICogV2ViQ29yZS5wcm86IGRvbid0IGFzc3VtZSBXaW5kb3dzIGJ1aWxkc3lzdGVtIGlzIHRoZSBv bmx5IG9uZQorCiAyMDEwLTAzLTI2ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KLS0tIFdlYkNvcmUvV2Vi Q29yZS5wcm8KKysrIFdlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTMwLDEwICszMCwxMiBAQCBzeW1i aWFuOiB7CiAgICAgIyBOZWVkIHRvIGd1YXJhbnRlZSB0aGF0IHRoZXNlIGNvbWUgYmVmb3JlIHN5 c3RlbSBpbmNsdWRlcyBvZiAvZXBvYzMyL2luY2x1ZGUKICAgICBNTVBfUlVMRVMgKz0gIlVTRVJJ TkNMVURFIHJlbmRlcmluZyIKICAgICBNTVBfUlVMRVMgKz0gIlVTRVJJTkNMVURFIHBsYXRmb3Jt L3RleHQiCi0gICAgIyBSTyB0ZXh0IChjb2RlKSBzZWN0aW9uIGluIHF0d2Via2l0LmRsbCBleGNl ZWRzIGFsbG9jYXRlZCBzcGFjZSBmb3IgZ2NjZSB1ZGViIHRhcmdldC4KLSAgICAjIE1vdmUgUlct c2VjdGlvbiBiYXNlIGFkZHJlc3MgdG8gc3RhcnQgZnJvbSAweEUwMDAwMCBpbnN0ZWFkIG9mIHRo ZSB0b29sY2hhaW4gZGVmYXVsdCAweDQwMDAwMC4KLSAgICBRTUFLRV9MRkxBR1MuQVJNQ0MgKz0g LS1ydy1iYXNlIDB4RTAwMDAwCi0gICAgTU1QX1JVTEVTICs9IEFMV0FZU19CVUlMRF9BU19BUk0K KyAgICBzeW1iaWFuLWFibGR8c3ltYmlhbi1zYnN2MiB7CisgICAgICAgICMgUk8gdGV4dCAoY29k ZSkgc2VjdGlvbiBpbiBxdHdlYmtpdC5kbGwgZXhjZWVkcyBhbGxvY2F0ZWQgc3BhY2UgZm9yIGdj Y2UgdWRlYiB0YXJnZXQuCisgICAgICAgICMgTW92ZSBSVy1zZWN0aW9uIGJhc2UgYWRkcmVzcyB0 byBzdGFydCBmcm9tIDB4RTAwMDAwIGluc3RlYWQgb2YgdGhlIHRvb2xjaGFpbiBkZWZhdWx0IDB4 NDAwMDAwLgorICAgICAgICBRTUFLRV9MRkxBR1MuQVJNQ0MgKz0gLS1ydy1iYXNlIDB4RTAwMDAw CisgICAgICAgIE1NUF9SVUxFUyArPSBBTFdBWVNfQlVJTERfQVNfQVJNCisgICAgfQogICAgIENP TkZJRyhyZWxlYXNlLCBkZWJ1Z3xyZWxlYXNlKTogUU1BS0VfQ1hYRkxBR1MuQVJNQ0MgKz0gLU9U aW1lIC1PMwogfQogCg== 51897 2010-03-29 03:58:41 -0700 2010-03-29 04:12:58 -0700 updated patch WebCore_pro-buildOnLinux.diff text/plain 1622 t.zander ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTc4OGQ5NS4uNmMwNWViNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0yOSAgVGhvbWFzIFphbmRl ciAgPHQuemFuZGVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkKKwor ICAgICAgICBNYWtlIGl0IHBvc3NpYmxlIHRvIGJ1aWxkIHVzaW5nIGJvdGggV2luZG93cyBhbmQg TGludXggZm9yIFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM2NzQ4CisKKyAgICAgICAgKiBXZWJDb3JlLnBybzogZG9uJ3QgYXNzdW1lIFdp bmRvd3MgYnVpbGRzeXN0ZW0gaXMgdGhlIG9ubHkgb25lCisgICAgICAgIGFuZCBleGNsdWRlIHRo ZSB3aW5kb3dzLW9ubHkgc2V0dGVycyBmcm9tIHRoZSBsaW51eCBidWlsZHMuCisKIDIwMTAtMDMt MjYgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBi L1dlYkNvcmUvV2ViQ29yZS5wcm8KaW5kZXggMTVjODgxZi4uNDlhZDFmNSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9XZWJDb3JlLnBybworKysgYi9XZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0zMCwxMCAr MzAsMTIgQEAgc3ltYmlhbjogewogICAgICMgTmVlZCB0byBndWFyYW50ZWUgdGhhdCB0aGVzZSBj b21lIGJlZm9yZSBzeXN0ZW0gaW5jbHVkZXMgb2YgL2Vwb2MzMi9pbmNsdWRlCiAgICAgTU1QX1JV TEVTICs9ICJVU0VSSU5DTFVERSByZW5kZXJpbmciCiAgICAgTU1QX1JVTEVTICs9ICJVU0VSSU5D TFVERSBwbGF0Zm9ybS90ZXh0IgotICAgICMgUk8gdGV4dCAoY29kZSkgc2VjdGlvbiBpbiBxdHdl YmtpdC5kbGwgZXhjZWVkcyBhbGxvY2F0ZWQgc3BhY2UgZm9yIGdjY2UgdWRlYiB0YXJnZXQuCi0g ICAgIyBNb3ZlIFJXLXNlY3Rpb24gYmFzZSBhZGRyZXNzIHRvIHN0YXJ0IGZyb20gMHhFMDAwMDAg aW5zdGVhZCBvZiB0aGUgdG9vbGNoYWluIGRlZmF1bHQgMHg0MDAwMDAuCi0gICAgUU1BS0VfTEZM QUdTLkFSTUNDICs9IC0tcnctYmFzZSAweEUwMDAwMAotICAgIE1NUF9SVUxFUyArPSBBTFdBWVNf QlVJTERfQVNfQVJNCisgICAgc3ltYmlhbi1hYmxkfHN5bWJpYW4tc2JzdjIgeworICAgICAgICAj IFJPIHRleHQgKGNvZGUpIHNlY3Rpb24gaW4gcXR3ZWJraXQuZGxsIGV4Y2VlZHMgYWxsb2NhdGVk IHNwYWNlIGZvciBnY2NlIHVkZWIgdGFyZ2V0LgorICAgICAgICAjIE1vdmUgUlctc2VjdGlvbiBi YXNlIGFkZHJlc3MgdG8gc3RhcnQgZnJvbSAweEUwMDAwMCBpbnN0ZWFkIG9mIHRoZSB0b29sY2hh aW4gZGVmYXVsdCAweDQwMDAwMC4KKyAgICAgICAgUU1BS0VfTEZMQUdTLkFSTUNDICs9IC0tcnct YmFzZSAweEUwMDAwMAorICAgICAgICBNTVBfUlVMRVMgKz0gQUxXQVlTX0JVSUxEX0FTX0FSTQor ICAgIH0KICAgICBDT05GSUcocmVsZWFzZSwgZGVidWd8cmVsZWFzZSk6IFFNQUtFX0NYWEZMQUdT LkFSTUNDICs9IC1PVGltZSAtTzMKIH0KIAo=