36745 2010-03-29 01:47:46 -0700 [Qt] qmake/symbian build failure 2010-04-06 02:12:50 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC S60 3rd edition CLOSED FIXED Qt P2 Normal --- 35784 1 t.zander Stanislav.Paltis hausmann laszlo.gombos webkit.review.bot oldest_to_newest 205335 0 t.zander 2010-03-29 01:47:46 -0700 to make webkit compile on a linux box using gcce and cross compiling to arm for symbian I found that the attached change was required. 205339 1 51886 t.zander 2010-03-29 02:03:05 -0700 Created attachment 51886 fix 205346 2 webkit.review.bot 2010-03-29 02:07:12 -0700 Attachment 51886 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 205354 3 51886 hausmann 2010-03-29 02:19:45 -0700 Comment on attachment 51886 fix In Qt 4.6 the variable is called defFilePath. This patch would break support building with def files against Qt 4.6. How about simply setting both variables? :) 205356 4 hausmann 2010-03-29 02:20:18 -0700 (In reply to comment #2) > Attachment 51886 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > Total errors found: 0 in 0 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I think the reason for this is because the patch doesn't apply with -p1 but only with -p0. 205363 5 51891 t.zander 2010-03-29 02:33:39 -0700 Created attachment 51891 updated patch 205373 6 51891 hausmann 2010-03-29 03:22:13 -0700 Comment on attachment 51891 updated patch Looks good to me. I'll land it manually to add a link to bugzilla to the ChangeLog. 205383 7 hausmann 2010-03-29 03:44:49 -0700 Committed r56714: <http://trac.webkit.org/changeset/56714> 205384 8 hausmann 2010-03-29 03:45:59 -0700 Revision r56714 cherry-picked into qtwebkit-2.0 with commit 5df858f8f4da97d738f8e957eabc8398a1e5bfb4 206099 9 52063 Stanislav.Paltis 2010-03-30 12:06:19 -0700 Created attachment 52063 Proposed patch to fix a build break on Symbian QTWebkit build. This patch fixes comment character from ";" to "#" in the "symbian" section of .pro file. Was discovered while running qmake on Webcore.pro with QT 4.6.2 for Symbian. Was getting an error at line 2940: Parse Error (;; defFilePath is for Qt4.6 compatibility') Unterminated conditional block at end of file. 206100 10 webkit.review.bot 2010-03-30 12:11:52 -0700 Attachment 52063 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 File not a recognized type to check. Skipping: "WebCore/WebCore.pro" WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 206130 11 52072 Stanislav.Paltis 2010-03-30 13:01:04 -0700 Created attachment 52072 Modified previous patch to convert Tabs to spaces 206339 12 52072 laszlo.gombos 2010-03-30 19:59:02 -0700 Comment on attachment 52072 Modified previous patch to convert Tabs to spaces r+, thanks for the patch. Next time please make sure the text is properly aligned in the ChangeLog. This time I fix the ChangeLog when I commit. 206344 13 laszlo.gombos 2010-03-30 20:37:18 -0700 Landed as http://trac.webkit.org/changeset/56822. 208939 14 hausmann 2010-04-06 01:05:18 -0700 cherry-pick-for-backport: <r56822> 208947 15 hausmann 2010-04-06 02:12:20 -0700 Revision r56714 cherry-picked into qtwebkit-2.0 with commit 5df858f8f4da97d738f8e957eabc8398a1e5bfb4 208948 16 hausmann 2010-04-06 02:12:41 -0700 Revision r56822 cherry-picked into qtwebkit-2.0 with commit 4b42600cfd2bc353ecbc64efc03b7aaf6d7e0bbf 51886 2010-03-29 02:03:05 -0700 2010-03-29 02:33:39 -0700 fix WebCore_pro-defFile.diff text/plain 647 t.zander LS0tIFdlYkNvcmUvQ2hhbmdlTG9nCisrKyBXZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEx IEBACisyMDEwLTAzLTI5ICBUaG9tYXMgWmFuZGVyICA8dC56YW5kZXJAbm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWQorCisgICAgICAgIFN3aXRjaGVkIHRvIHVzaW5nIERF Rl9GSUxFLCB3aGljaCBpcyB0aGUgb2ZmaWNpYWwgdmFyaWFibGUuCisKKyAgICAgICAgKiBXZWJD b3JlLnBybzogVXNlIERFRl9GSUxFCisKIDIwMTAtMDMtMjYgIEFuZHJleSBLb3N5YWtvdiAgPGNh c2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgot LS0gV2ViQ29yZS9XZWJDb3JlLnBybworKysgV2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtMjkzMiw3 ICsyOTMyLDcgQEAgU09VUkNFUyArPSBcCiBzeW1iaWFuIHsKICAgICBzaGFyZWQgewogICAgICAg ICBjb250YWlucyhDT05GSUcsIGRlZl9maWxlcykgewotICAgICAgICAgICAgZGVmRmlsZVBhdGg9 Li4vV2ViS2l0L3F0L3N5bWJpYW4KKyAgICAgICAgICAgIERFRl9GSUxFPS4uL1dlYktpdC9xdC9z eW1iaWFuCiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBNTVBfUlVMRVMgKz0gRVhQT1JU VU5GUk9aRU4KICAgICAgICAgfQo= 51891 2010-03-29 02:33:39 -0700 2010-03-29 03:22:13 -0700 updated patch WebCore_pro-defFile.diff text/plain 864 t.zander ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTc4OGQ5NS4uM2UzYzlmOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAxMC0wMy0yOSAgVGhvbWFzIFphbmRl ciAgPHQuemFuZGVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkKKwor ICAgICAgICBTd2l0Y2hlZCB0byB1c2luZyBERUZfRklMRSwgd2hpY2ggaXMgdGhlIG9mZmljaWFs IHZhcmlhYmxlLgorCisgICAgICAgICogV2ViQ29yZS5wcm86IFVzZSBERUZfRklMRQorCiAyMDEw LTAzLTI2ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5w cm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IDE1Yzg4MWYuLjVhOTI0OWYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIvV2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtMjkz Miw2ICsyOTMyLDggQEAgU09VUkNFUyArPSBcCiBzeW1iaWFuIHsKICAgICBzaGFyZWQgewogICAg ICAgICBjb250YWlucyhDT05GSUcsIGRlZl9maWxlcykgeworICAgICAgICAgICAgREVGX0ZJTEU9 Li4vV2ViS2l0L3F0L3N5bWJpYW4KKyAgICAgICAgICAgIDsgZGVmRmlsZVBhdGggaXMgZm9yIFF0 NC42IGNvbXBhdGliaWxpdHkKICAgICAgICAgICAgIGRlZkZpbGVQYXRoPS4uL1dlYktpdC9xdC9z eW1iaWFuCiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBNTVBfUlVMRVMgKz0gRVhQT1JU VU5GUk9aRU4K 52063 2010-03-30 12:06:19 -0700 2010-03-30 13:01:04 -0700 Proposed patch to fix a build break on Symbian QTWebkit build. SymbBreakPatch.txt text/plain 1129 Stanislav.Paltis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjgwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMzAgIFN0YW5pc2xhdiBQYWx0aXMgIDxTdGFuaXNsYXYu UGFsdGlzQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIHFtYWtlL3N5bWJpYW4gYnVpbGQgZmFpbHVyZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3NDUKKworCUZpeCBidWlsZCBi cmVhayBpbiBTeW1iaWFuIGJ1aWxkIG9uIGludHJvZHVjZWQgaW4gcjU2NzE0LAorCWJ5IG1vZGlm eWluZyBjb21tZW50IGVzY2FwZSBjaGFyYWN0ZXIgZnJvbSAiOyIgdG8gIiMiLgorCisgICAgICAg ICogV2ViQ29yZS5wcm86CisKIDIwMTAtMDMtMzAgIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJDb3Jl L1dlYkNvcmUucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlzaW9u IDU2ODAwKQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpAQCAtMjk0Niw3 ICsyOTQ2LDcgQEAgc3ltYmlhbiB7CiAgICAgc2hhcmVkIHsKICAgICAgICAgY29udGFpbnMoQ09O RklHLCBkZWZfZmlsZXMpIHsKICAgICAgICAgICAgIERFRl9GSUxFPS4uL1dlYktpdC9xdC9zeW1i aWFuCi0gICAgICAgICAgICA7IGRlZkZpbGVQYXRoIGlzIGZvciBRdDQuNiBjb21wYXRpYmlsaXR5 CisgICAgICAgICAgICAjIGRlZkZpbGVQYXRoIGlzIGZvciBRdDQuNiBjb21wYXRpYmlsaXR5CiAg ICAgICAgICAgICBkZWZGaWxlUGF0aD0uLi9XZWJLaXQvcXQvc3ltYmlhbgogICAgICAgICB9IGVs c2UgewogICAgICAgICAgICAgTU1QX1JVTEVTICs9IEVYUE9SVFVORlJPWkVOCg== 52072 2010-03-30 13:01:04 -0700 2010-03-30 20:37:36 -0700 Modified previous patch to convert Tabs to spaces SymbBreakPatch.txt text/plain 1162 Stanislav.Paltis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cgKHJldmlzaW9uIDU2ODAwKQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nICh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE1IEBADQorMjAxMC0wMy0zMCAgU3RhbmlzbGF2IFBhbHRpcyAgPFN0YW5p c2xhdi5QYWx0aXNAbm9raWEuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuDQorDQorICAgICAgICBbUXRdIHFtYWtlL3N5bWJpYW4gYnVpbGQgZmFpbHVyZQ0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzQ1DQorDQor IEZpeCBidWlsZCBicmVhayBpbiBTeW1iaWFuIGJ1aWxkIG9uIGludHJvZHVjZWQgaW4gcjU2NzE0 LA0KKyBieSBtb2RpZnlpbmcgY29tbWVudCBlc2NhcGUgY2hhcmFjdGVyIGZyb20gIjsiIHRvICIj Ii4NCisNCisgICAgICAgICogV2ViQ29yZS5wcm86DQorDQogMjAxMC0wMy0zMCAgQWRhbSBMYW5n bGV5ICA8YWdsQGNocm9taXVtLm9yZz4NCiANCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExl dmluLg0KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5wcm8NCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3Jl L1dlYkNvcmUucHJvIChyZXZpc2lvbiA1NjgwMCkNCisrKyBXZWJDb3JlL1dlYkNvcmUucHJvICh3 b3JraW5nIGNvcHkpDQpAQCAtMjk0Niw3ICsyOTQ2LDcgQEAgc3ltYmlhbiB7DQogICAgIHNoYXJl ZCB7DQogICAgICAgICBjb250YWlucyhDT05GSUcsIGRlZl9maWxlcykgew0KICAgICAgICAgICAg IERFRl9GSUxFPS4uL1dlYktpdC9xdC9zeW1iaWFuDQotICAgICAgICAgICAgOyBkZWZGaWxlUGF0 aCBpcyBmb3IgUXQ0LjYgY29tcGF0aWJpbGl0eQ0KKyAgICAgICAgICAgICMgZGVmRmlsZVBhdGgg aXMgZm9yIFF0NC42IGNvbXBhdGliaWxpdHkNCiAgICAgICAgICAgICBkZWZGaWxlUGF0aD0uLi9X ZWJLaXQvcXQvc3ltYmlhbg0KICAgICAgICAgfSBlbHNlIHsNCiAgICAgICAgICAgICBNTVBfUlVM RVMgKz0gRVhQT1JUVU5GUk9aRU4NCg==