36743 2010-03-29 01:20:33 -0700 [chromium] pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin 2010-03-29 10:14:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jochen webkit-unassigned commit-queue fishd jorlow oldest_to_newest 205324 0 jochen 2010-03-29 01:20:33 -0700 [chromium] pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin 205325 1 51882 jochen 2010-03-29 01:21:41 -0700 Created attachment 51882 Patch 205329 2 51883 jochen 2010-03-29 01:26:05 -0700 Created attachment 51883 Patch 205402 3 jochen 2010-03-29 04:26:50 -0700 This bug addresses the issues raised in #36595 205404 4 51883 jorlow 2010-03-29 04:29:56 -0700 Comment on attachment 51883 Patch Actually, might as well just wait to see if Darin thinks this addresses all of his concerns. 205509 5 51883 commit-queue 2010-03-29 10:14:00 -0700 Comment on attachment 51883 Patch Clearing flags on attachment: 51883 Committed r56728: <http://trac.webkit.org/changeset/56728> 205510 6 commit-queue 2010-03-29 10:14:04 -0700 All reviewed patches have been landed. Closing bug. 51882 2010-03-29 01:21:41 -0700 2010-03-29 01:25:59 -0700 Patch bug-36743-20100329102139.patch text/plain 2480 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGUxYTc4MmYuLjQyMTJhZDEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTAzLTI5ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3Mg YSBXZWJGcmFtZSB0byBXZWJGcmFtZUNsaWVudDo6YWxsb3dEYXRhYmFzZSBpbnN0ZWFkIG9mIGEg V2ViU2VjdXJpdHlPcmlnaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM2NzQzCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWVDbGllbnQuaDoKKyAg ICAgICAgKFdlYktpdDo6V2ViRnJhbWVDbGllbnQ6OmFsbG93RGF0YWJhc2UpOgorICAgICAgICAq IHNyYy9EYXRhYmFzZU9ic2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlT2Jz ZXJ2ZXI6OmNhbkVzdGFibGlzaERhdGFiYXNlKToKKwogMjAxMC0wMy0yNCAgSmFtZXMgSGF3a2lu cyAgPGpoYXdraW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBG aXNoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50 LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKaW5kZXggNWZmYzJl My4uMDM2MDA4NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZUNs aWVudC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaApAQCAt MjY0LDcgKzI2NCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgYWxsb3dTY3JpcHQoV2Vi RnJhbWUqLCBib29sIGVuYWJsZWRQZXJTZXR0aW5ncykgeyByZXR1cm4gZW5hYmxlZFBlclNldHRp bmdzOyB9CiAKICAgICAvLyBDb250cm9scyB3aGV0aGVyIGFjY2VzcyB0byBXZWIgRGF0YWJhc2Vz IGlzIGFsbG93ZWQgZm9yIHRoaXMgZnJhbWUuCi0gICAgdmlydHVhbCBib29sIGFsbG93RGF0YWJh c2UoY29uc3QgV2ViU2VjdXJpdHlPcmlnaW4mLCBjb25zdCBXZWJTdHJpbmcmLCBjb25zdCBXZWJT dHJpbmcmLCB1bnNpZ25lZCBsb25nKSB7IHJldHVybiB0cnVlOyB9CisgICAgdmlydHVhbCBib29s IGFsbG93RGF0YWJhc2UoV2ViRnJhbWUqLCBjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdl YlN0cmluZyYgZGlzcGxheU5hbWUsIHVuc2lnbmVkIGxvbmcgZXN0aW1hdGVkU2l6ZSkgeyByZXR1 cm4gdHJ1ZTsgfQogCiAgICAgLy8gTm90aWZpZXMgdGhlIGNsaWVudCB0aGF0IHRoZSBmcmFtZSB3 b3VsZCBoYXZlIGV4ZWN1dGVkIHNjcmlwdCBpZiBzY3JpcHQgd2VyZSBlbmFibGVkLgogICAgIHZp cnR1YWwgdm9pZCBkaWROb3RBbGxvd1NjcmlwdChXZWJGcmFtZSopIHsgfQpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9EYXRhYmFzZU9ic2VydmVyLmNwcCBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvRGF0YWJhc2VPYnNlcnZlci5jcHAKaW5kZXggZTA5MzExMS4uY2E5NGViOCAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9EYXRhYmFzZU9ic2VydmVyLmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL0RhdGFiYXNlT2JzZXJ2ZXIuY3BwCkBAIC01Myw3ICs1Myw3IEBAIGJv b2wgRGF0YWJhc2VPYnNlcnZlcjo6Y2FuRXN0YWJsaXNoRGF0YWJhc2UoU2NyaXB0RXhlY3V0aW9u Q29udGV4dCogc2NyaXB0RXhlY3V0CiAgICAgaWYgKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQtPmlz RG9jdW1lbnQoKSkgewogICAgICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBzdGF0aWNfY2FzdDxE b2N1bWVudCo+KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQpOwogICAgICAgICBXZWJGcmFtZUltcGwq IHdlYkZyYW1lID0gV2ViRnJhbWVJbXBsOjpmcm9tRnJhbWUoZG9jdW1lbnQtPmZyYW1lKCkpOwot ICAgICAgICByZXR1cm4gd2ViRnJhbWUtPmNsaWVudCgpLT5hbGxvd0RhdGFiYXNlKFdlYlNlY3Vy aXR5T3JpZ2luKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQtPnNlY3VyaXR5T3JpZ2luKCkpLCBuYW1l LCBkaXNwbGF5TmFtZSwgZXN0aW1hdGVkU2l6ZSk7CisgICAgICAgIHJldHVybiB3ZWJGcmFtZS0+ Y2xpZW50KCktPmFsbG93RGF0YWJhc2Uod2ViRnJhbWUsIG5hbWUsIGRpc3BsYXlOYW1lLCBlc3Rp bWF0ZWRTaXplKTsKICAgICB9IGVsc2UgewogICAgICAgICBXb3JrZXJDb250ZXh0KiB3b3JrZXIg PSBzdGF0aWNfY2FzdDxXb3JrZXJDb250ZXh0Kj4oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCk7CiAg ICAgICAgIFdvcmtlckxvYWRlclByb3h5KiB3b3JrZXJMb2FkZXJQcm94eSA9ICZ3b3JrZXItPnRo cmVhZCgpLT53b3JrZXJMb2FkZXJQcm94eSgpOwo= 51883 2010-03-29 01:26:05 -0700 2010-03-29 10:13:59 -0700 Patch bug-36743-20100329102603.patch text/plain 2747 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGUxYTc4MmYuLjQyMTJhZDEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTAzLTI5ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3Mg YSBXZWJGcmFtZSB0byBXZWJGcmFtZUNsaWVudDo6YWxsb3dEYXRhYmFzZSBpbnN0ZWFkIG9mIGEg V2ViU2VjdXJpdHlPcmlnaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM2NzQzCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWVDbGllbnQuaDoKKyAg ICAgICAgKFdlYktpdDo6V2ViRnJhbWVDbGllbnQ6OmFsbG93RGF0YWJhc2UpOgorICAgICAgICAq IHNyYy9EYXRhYmFzZU9ic2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlT2Jz ZXJ2ZXI6OmNhbkVzdGFibGlzaERhdGFiYXNlKToKKwogMjAxMC0wMy0yNCAgSmFtZXMgSGF3a2lu cyAgPGpoYXdraW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBG aXNoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50 LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKaW5kZXggNWZmYzJl My4uMDM2MDA4NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZUNs aWVudC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaApAQCAt MjY0LDcgKzI2NCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgYWxsb3dTY3JpcHQoV2Vi RnJhbWUqLCBib29sIGVuYWJsZWRQZXJTZXR0aW5ncykgeyByZXR1cm4gZW5hYmxlZFBlclNldHRp bmdzOyB9CiAKICAgICAvLyBDb250cm9scyB3aGV0aGVyIGFjY2VzcyB0byBXZWIgRGF0YWJhc2Vz IGlzIGFsbG93ZWQgZm9yIHRoaXMgZnJhbWUuCi0gICAgdmlydHVhbCBib29sIGFsbG93RGF0YWJh c2UoY29uc3QgV2ViU2VjdXJpdHlPcmlnaW4mLCBjb25zdCBXZWJTdHJpbmcmLCBjb25zdCBXZWJT dHJpbmcmLCB1bnNpZ25lZCBsb25nKSB7IHJldHVybiB0cnVlOyB9CisgICAgdmlydHVhbCBib29s IGFsbG93RGF0YWJhc2UoV2ViRnJhbWUqLCBjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdl YlN0cmluZyYgZGlzcGxheU5hbWUsIHVuc2lnbmVkIGxvbmcgZXN0aW1hdGVkU2l6ZSkgeyByZXR1 cm4gdHJ1ZTsgfQogCiAgICAgLy8gTm90aWZpZXMgdGhlIGNsaWVudCB0aGF0IHRoZSBmcmFtZSB3 b3VsZCBoYXZlIGV4ZWN1dGVkIHNjcmlwdCBpZiBzY3JpcHQgd2VyZSBlbmFibGVkLgogICAgIHZp cnR1YWwgdm9pZCBkaWROb3RBbGxvd1NjcmlwdChXZWJGcmFtZSopIHsgfQpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9EYXRhYmFzZU9ic2VydmVyLmNwcCBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvRGF0YWJhc2VPYnNlcnZlci5jcHAKaW5kZXggZTA5MzExMS4uZTg5YmQ1ZCAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9EYXRhYmFzZU9ic2VydmVyLmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL0RhdGFiYXNlT2JzZXJ2ZXIuY3BwCkBAIC00OSwxMSArNDksMTIgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogCiBib29sIERhdGFiYXNlT2JzZXJ2ZXI6OmNhbkVzdGFibGlz aERhdGFiYXNlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQs IGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBkaXNwbGF5TmFtZSwgdW5zaWduZWQg bG9uZyBlc3RpbWF0ZWRTaXplKQogeworICAgIEFTU0VSVChzY3JpcHRFeGVjdXRpb25Db250ZXh0 LT5pc0NvbnRleHRUaHJlYWQoKSk7CiAgICAgQVNTRVJUKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQt PmlzRG9jdW1lbnQoKSB8fCBzY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc1dvcmtlckNvbnRleHQo KSk7CiAgICAgaWYgKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQtPmlzRG9jdW1lbnQoKSkgewogICAg ICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBzdGF0aWNfY2FzdDxEb2N1bWVudCo+KHNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQpOwogICAgICAgICBXZWJGcmFtZUltcGwqIHdlYkZyYW1lID0gV2ViRnJh bWVJbXBsOjpmcm9tRnJhbWUoZG9jdW1lbnQtPmZyYW1lKCkpOwotICAgICAgICByZXR1cm4gd2Vi RnJhbWUtPmNsaWVudCgpLT5hbGxvd0RhdGFiYXNlKFdlYlNlY3VyaXR5T3JpZ2luKHNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQtPnNlY3VyaXR5T3JpZ2luKCkpLCBuYW1lLCBkaXNwbGF5TmFtZSwgZXN0 aW1hdGVkU2l6ZSk7CisgICAgICAgIHJldHVybiB3ZWJGcmFtZS0+Y2xpZW50KCktPmFsbG93RGF0 YWJhc2Uod2ViRnJhbWUsIG5hbWUsIGRpc3BsYXlOYW1lLCBlc3RpbWF0ZWRTaXplKTsKICAgICB9 IGVsc2UgewogICAgICAgICBXb3JrZXJDb250ZXh0KiB3b3JrZXIgPSBzdGF0aWNfY2FzdDxXb3Jr ZXJDb250ZXh0Kj4oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCk7CiAgICAgICAgIFdvcmtlckxvYWRl clByb3h5KiB3b3JrZXJMb2FkZXJQcm94eSA9ICZ3b3JrZXItPnRocmVhZCgpLT53b3JrZXJMb2Fk ZXJQcm94eSgpOwo=