36722 2010-03-28 08:20:42 -0700 Web Inspector: resource links should navigate to resource panel enabler when resource tracking is off. 2010-03-28 10:32:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 205169 0 pfeldman 2010-03-28 08:20:42 -0700 Otherwise, nothing happens when clicking the link. 205172 1 51860 pfeldman 2010-03-28 08:22:52 -0700 Created attachment 51860 [PATCH] Proposed fix. 205175 2 51862 pfeldman 2010-03-28 08:31:40 -0700 Created attachment 51862 [PATCH] Proposed fix. 205184 3 pfeldman 2010-03-28 10:32:18 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/inspector.js Committed r56696 51860 2010-03-28 08:22:52 -0700 2010-03-28 08:24:28 -0700 [PATCH] Proposed fix. links text/plain 3409 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmQ5N2FiNy4uYTllZjk1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMiBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlc291cmNlIGxpbmtzIHNo b3VsZCBoYXZlIG5vIHVuZGVybGluZSBhbmQgYSBoZWxwZXIgdG9vbHRpcCB3aGVuIHJlc291cmNl IHRyYWNraW5nIGlzIG9mZi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzY3MjIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVzb3Vy Y2VzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZS5yZXNvdXJjZVRyYWNr aW5nV2FzRW5hYmxlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJv dG90eXBlLnJlc291cmNlVHJhY2tpbmdXYXNEaXNhYmxlZCk6CisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5jc3M6CisgICAgICAgICgucmVzb3VyY2UtdHJhY2tpbmctZGlzYWJs ZWQgLndlYmtpdC1odG1sLXJlc291cmNlLWxpbmspOgorCisyMDEwLTAzLTI4ICBQYXZlbCBGZWxk bWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRvZ2dsaW5nIHN0eWxlIHByb3Bl cnRpZXMgb24vb2ZmIGRvZXMgbm90IGFsd2F5cyB3b3JrLgogCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjcyMApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCmluZGV4IDNmZmM2ZmYuLjkyNjQ1ZDIgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcworKysg Yi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKQEAgLTQ0LDEw ICs0NCwxMCBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwgPSBmdW5jdGlvbigpCiAKICAg ICB0aGlzLl9jcmVhdGVTdGF0dXNiYXJCdXR0b25zKCk7CiAKLSAgICB0aGlzLnJlc2V0KCk7CiAg ICAgdGhpcy5maWx0ZXIodGhpcy5maWx0ZXJBbGxFbGVtZW50LCBmYWxzZSk7CiAgICAgdGhpcy5n cmFwaHNUcmVlRWxlbWVudC5jaGlsZHJlblswXS5zZWxlY3QoKTsKLSAgICB0aGlzLl9yZXNvdXJj ZVRyYWNraW5nRW5hYmxlZCA9IGZhbHNlOworCisgICAgdGhpcy5yZXNvdXJjZVRyYWNraW5nV2Fz RGlzYWJsZWQoKTsKIH0KIAogV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9 IHsKQEAgLTMxNywxMiArMzE3LDE0IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90 b3R5cGUgPSB7CiAKICAgICByZXNvdXJjZVRyYWNraW5nV2FzRW5hYmxlZDogZnVuY3Rpb24oKQog ICAgIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1haW4tcGFuZWxzIikucmVt b3ZlU3R5bGVDbGFzcygicmVzb3VyY2UtdHJhY2tpbmctZGlzYWJsZWQiKTsKICAgICAgICAgdGhp cy5fcmVzb3VyY2VUcmFja2luZ0VuYWJsZWQgPSB0cnVlOwogICAgICAgICB0aGlzLnJlc2V0KCk7 CiAgICAgfSwKIAogICAgIHJlc291cmNlVHJhY2tpbmdXYXNEaXNhYmxlZDogZnVuY3Rpb24oKQog ICAgIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1haW4tcGFuZWxzIikuYWRk U3R5bGVDbGFzcygicmVzb3VyY2UtdHJhY2tpbmctZGlzYWJsZWQiKTsKICAgICAgICAgdGhpcy5f cmVzb3VyY2VUcmFja2luZ0VuYWJsZWQgPSBmYWxzZTsKICAgICAgICAgdGhpcy5yZXNldCgpOwog ICAgIH0sCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lk ZWJhclBhbmUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanMKaW5kZXggZmZiZGZkYi4uZGMwYTEwZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwpAQCAtMjEyLDcgKzIxMiw3IEBAIFdlYklu c3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIGZvciAodmFy IG5hbWUgaW4gc3R5bGVzLnN0eWxlQXR0cmlidXRlcykgewogICAgICAgICAgICAgdmFyIGF0dHJT dHlsZSA9IHsgc3R5bGU6IG5ldyBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvbihzdHls ZXMuc3R5bGVBdHRyaWJ1dGVzW25hbWVdKSwgZWRpdGFibGU6IGZhbHNlIH07CiAgICAgICAgICAg ICBhdHRyU3R5bGUuc3VidGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoImVsZW1lbnTigJlz IOKAnCVz4oCdIGF0dHJpYnV0ZSIsIG5hbWUpOwotICAgICAgICAgICAgYXR0clN0eWxlLnNlbGVj dG9yVGV4dCA9IG5vZGUubm9kZU5hbWUgKyAiWyIgKyBuYW1lOworICAgICAgICAgICAgYXR0clN0 eWxlLnNlbGVjdG9yVGV4dCA9IG5vZGUubm9kZU5hbWUudG9Mb3dlckNhc2UoKSArICJbIiArIG5h bWU7CiAgICAgICAgICAgICBpZiAobm9kZS5nZXRBdHRyaWJ1dGUobmFtZSkpCiAgICAgICAgICAg ICAgICAgYXR0clN0eWxlLnNlbGVjdG9yVGV4dCArPSAiPSIgKyBub2RlLmdldEF0dHJpYnV0ZShu YW1lKTsKICAgICAgICAgICAgIGF0dHJTdHlsZS5zZWxlY3RvclRleHQgKz0gIl0iOwpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwppbmRleCBjZjI3YzIyLi4xNTIxOGFm IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwor KysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwpAQCAtMzk0Mywz ICszOTQzLDYgQEAgYS53b3JrZXItaXRlbTpob3ZlciB7CiAgICAgY29sb3I6IHJnYigxNSUsIDE1 JSwgMTUlKTsKIH0KIAorLnJlc291cmNlLXRyYWNraW5nLWRpc2FibGVkIC53ZWJraXQtaHRtbC1y ZXNvdXJjZS1saW5rIHsKKyAgICB0ZXh0LWRlY29yYXRpb246IG5vbmU7Cit9Cg== 51862 2010-03-28 08:31:40 -0700 2010-03-28 08:39:43 -0700 [PATCH] Proposed fix. link_enabler text/plain 2220 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmQ5N2FiNy4uNjZkNTNkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlc291cmNlIGxpbmtzIHNo b3VsZCBuYXZpZ2F0ZSB0byByZXNvdXJjZSBwYW5lbCBlbmFibGVyIHdoZW4gcmVzb3VyY2UgdHJh Y2tpbmcgaXMgb2ZmLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNjcyMgorCisgICAgICAgICogRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdz LmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLmRvY3VtZW50TW91c2VPdmVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5kb2N1bWVudENsaWNrLmZvbGxvd0xpbmspOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmRvY3Vt ZW50Q2xpY2spOgorCisyMDEwLTAzLTI4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFRvZ2dsaW5nIHN0eWxlIHByb3BlcnRpZXMgb24vb2ZmIGRvZXMgbm90 IGFsd2F5cyB3b3JrLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNjcyMApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXpl ZFN0cmluZ3MuanMgYi9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpp bmRleCA4OWFkZGI5Li5mODhmM2E0IDEwMDY0NApCaW5hcnkgZmlsZXMgYS9XZWJDb3JlL0VuZ2xp c2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBhbmQgYi9XZWJDb3JlL0VuZ2xpc2gubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qcyBkaWZmZXIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzCmluZGV4IDEzNzAyYzEuLmFlZWE1NjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtNjE5LDE1ICs2MTksNiBAQCBXZWJJbnNwZWN0b3IuZG9j dW1lbnRNb3VzZU92ZXIgPSBmdW5jdGlvbihldmVudCkKICAgICAgICAgcmV0dXJuOwogICAgIGlm IChhbmNob3IuaHJlZiAmJiBhbmNob3IuaHJlZi5pbmRleE9mKCIvZGF0YToiKSAhPSAtMSkKICAg ICAgICAgcmV0dXJuOwotICAgIGlmIChXZWJJbnNwZWN0b3IuY2FuU2hvd1NvdXJjZUxpbmUoYW5j aG9yLmhyZWYsIGFuY2hvci5saW5lTnVtYmVyLCBhbmNob3IucHJlZmVycmVkUGFuZWwpIHx8IFdl Ykluc3BlY3Rvci5Qcm9maWxlVHlwZS5VUkxSZWdFeHAuZXhlYyhhbmNob3IuaHJlZikpIHsKLSAg ICAgICAgaWYgKGV2ZW50LnRhcmdldC5vcmlnaW5hbFRpdGxlKQotICAgICAgICAgICAgZXZlbnQu dGFyZ2V0LnRpdGxlID0gZXZlbnQudGFyZ2V0Lm9yaWdpbmFsVGl0bGU7Ci0gICAgICAgIHJldHVy bjsKLSAgICB9Ci0KLSAgICBpZiAoIWV2ZW50LnRhcmdldC5vcmlnaW5hbFRpdGxlKQotICAgICAg ICBldmVudC50YXJnZXQub3JpZ2luYWxUaXRsZSA9IGV2ZW50LnRhcmdldC50aXRsZTsKLSAgICBl dmVudC50YXJnZXQudGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNhbm5vdCBvcGVuIHRo aXMgbGluay4gTWFrZSBzdXJlIHRoYXQgcmVzb3VyY2UgdHJhY2tpbmcgaXMgZW5hYmxlZCBpbiB0 aGUgUmVzb3VyY2VzIHBhbmVsLiIpOwogfQogCiBXZWJJbnNwZWN0b3IuZG9jdW1lbnRDbGljayA9 IGZ1bmN0aW9uKGV2ZW50KQpAQCAtNjY4LDYgKzY1OSw4IEBAIFdlYkluc3BlY3Rvci5kb2N1bWVu dENsaWNrID0gZnVuY3Rpb24oZXZlbnQpCiAgICAgICAgICAgICB9CiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIH0KKworICAgICAgICBXZWJJbnNwZWN0b3Iuc2hvd1Jlc291cmNlc1BhbmVs KCk7CiAgICAgfQogCiAgICAgaWYgKFdlYkluc3BlY3Rvci5mb2xsb3dMaW5rVGltZW91dCkK