36698 2010-03-27 02:55:58 -0700 There are build breaks when wml is enabled. 2010-03-30 00:08:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned abarth commit-queue eric joone.hur webkit.review.bot oldest_to_newest 204971 0 51823 gyuyoung.kim 2010-03-27 02:55:58 -0700 Created attachment 51823 Patch for a build break due to the disabled() funciton There is a build break due to the disabled() when wml is enabled. It seems that this break comes from the Bug 35056 - Disabled menu options are still submitted. WMLOptionElement class is a child class of OptionElement class as below. So, if a virtual function is added to OptionElement, WMLOptionElement class should defines that function as well. class WMLOptionElement : public WMLFormControlElement, public WMLEventHandlingElement, public OptionElement { My modification is as below, --- WebCore/wml/WMLOptionElement.h (revision 56658) +++ WebCore/wml/WMLOptionElement.h (working copy) @@ -41,6 +41,8 @@ public: virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0); virtual void parseMappedAttribute(MappedAttribute*); + virtual bool disabled() const { return false; }; + I think diabled() should be added to WMLOptionElement.h. Thank you, Gyuyoung Kim. 205264 1 51872 gyuyoung.kim 2010-03-28 17:03:07 -0700 Created attachment 51872 Patch for a build break due to the disabled() function I add a bug url to patch. Please review my patch. 205486 2 51872 darin 2010-03-29 09:28:25 -0700 Comment on attachment 51872 Patch for a build break due to the disabled() function I'm not sure that's right. Is it true that WML option elements can't be disabled? We can follow up with another patch if the WML behavior is wrong, I guess. r=me 205720 3 51872 commit-queue 2010-03-29 15:59:29 -0700 Comment on attachment 51872 Patch for a build break due to the disabled() function Rejecting patch 51872 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 2 patching file WebCore/ChangeLog patch: **** malformed patch at line 20: patching file WebCore/wml/WMLOptionElement.h Full output: http://webkit-commit-queue.appspot.com/results/1626054 205793 4 51993 gyuyoung.kim 2010-03-29 18:58:24 -0700 Created attachment 51993 Patch for a build break due to the disabled() function When wml feature is enabled, there is a build break as below, ------------------------------------------------------------------------------ DerivedSources/WMLElementFactory.cpp: In function ‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::optionConstructor(const WebCore::QualifiedName&, WebCore::Document*, bool)’: DerivedSources/WMLElementFactory.cpp:154: error: cannot allocate an object of abstract type ‘WebCore::WMLOptionElement’ ./WebCore/wml/WMLOptionElement.h:31: note: because the following virtual functions are pure within ‘WebCore::WMLOptionElement’: ./WebCore/dom/OptionElement.h:37: note: virtual bool WebCore::OptionElement::disabled() const DerivedSources/WMLElementFactory.cpp: In function ‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::selectConstructor(const WebCore::QualifiedName&, WebCore::Document*, bool)’: DerivedSources/WMLElementFactory.cpp:179: error: cannot allocate an object of abstract type ‘WebCore::WMLSelectElement’ ./WebCore/wml/WMLSelectElement.h:30: note: because the following virtual functions are pure within ‘WebCore::WMLSelectElement’: ./WebCore/dom/SelectElement.h:64: note: virtual void WebCore::SelectElement::listBoxSelectItem(int, bool, bool, bool) ------------------------------------------------------------------------------ I didn't check if the WML behavior is wrong. But, I think we need to avoid a build break for now. I will report if WML option elements can't be disabled or not again. If I am wrong, please let me know. Thank you. 205796 5 webkit.review.bot 2010-03-29 19:01:30 -0700 Attachment 51993 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/wml/WMLOptionElement.h:44: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 205848 6 51993 eric 2010-03-29 22:14:55 -0700 Comment on attachment 51993 Patch for a build break due to the disabled() function Actually, no need for hte extra ";" after the } 205851 7 52005 gyuyoung.kim 2010-03-29 22:35:18 -0700 Created attachment 52005 Patch for a build break due to the disabled() function Sorry for my frequent patches, I am not good at making a patch yet. I found one more build break because of Bug 36177 - Multiselect Popup - Listbox click simulation. (https://bugs.webkit.org/show_bug.cgi?id=36177) The patch add a virtual function to SelectElement.h as below, virtual void listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool shift, bool fireOnChangeNow = true) = 0; It seems the patch of bug didn't consider wml. I add a virtual function to WMLSelectElement.h. 205852 8 52005 eric 2010-03-29 22:40:51 -0700 Comment on attachment 52005 Patch for a build break due to the disabled() function OK. Your ChangeLog does not mention WebCore/wml/WMLSelectElement.h, but it's OK. 205855 9 gyuyoung.kim 2010-03-29 22:42:46 -0700 Thanks. When I push another patches, I will write changelog correctly. 205856 10 52005 commit-queue 2010-03-29 22:50:34 -0700 Comment on attachment 52005 Patch for a build break due to the disabled() function Rejecting patch 52005 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--build-style=both', '--quiet', '52005', '--no-update']" exit_code: 1 Last 500 characters of output: handle_errors self._run(tool, options, state) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 60, in _run step(tool, options).run(state) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 63, in run log("%s found in %s does not appear to be a valid reviewer according to committers.py." % (reviewer_text, changelog_path)) NameError: global name 'log' is not defined 205861 11 gyuyoung.kim 2010-03-29 23:00:56 -0700 My patch is wrong ? Should I make a patch again ? 205862 12 eric 2010-03-29 23:01:49 -0700 Your patch looks fine. Looks like Adam or I broke the commit-queue. I'll investigate. 205867 13 52005 eric 2010-03-29 23:14:26 -0700 Comment on attachment 52005 Patch for a build break due to the disabled() function Actually, looks like you modified the "reviewed by" line: + Reviewed by NOBODY(OOPS!). the default template is: + Reviewed by NOBODY (OOPS!). The scripts aren't smart enough to know the difference between "NOBODY(OOPS!)" and an intentionally specified reviewer. I suggest just regenerating the ChangeLog from prepare-ChangeLog, which will both fix your reviewed by line to be the default as well as add the information about WebCore/wml/WMLSelectElement.h Sorry our scripts are so troublesome. 205868 14 eric 2010-03-29 23:14:59 -0700 There was also a problem in webkit-patch's validatereviewer.py step which I've fixed. 205872 15 52007 gyuyoung.kim 2010-03-29 23:31:10 -0700 Created attachment 52007 Patch for a build break due to the disabled() function Thank you for your guide. I attach a patch again. 205877 16 52007 eric 2010-03-29 23:45:45 -0700 Comment on attachment 52007 Patch for a build break due to the disabled() function Thanks 205881 17 52007 commit-queue 2010-03-30 00:08:10 -0700 Comment on attachment 52007 Patch for a build break due to the disabled() function Clearing flags on attachment: 52007 Committed r56769: <http://trac.webkit.org/changeset/56769> 205882 18 commit-queue 2010-03-30 00:08:16 -0700 All reviewed patches have been landed. Closing bug. 51823 2010-03-27 02:55:58 -0700 2010-03-28 17:03:07 -0700 Patch for a build break due to the disabled() funciton WMLDisablePatch.txt text/plain 1352 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjY1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMjcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGVyZSBpcyBhIGJ1aWxkIGJyZWFrIGR1ZSB0byB0aGUgZGlzYWJsZWQoKSB3aGVuIHdt bCBmZWF0dXJlIGlzIAorICAgICAgICBlbmFibGVkLiBUaGlzIGJyZWFrIGNvbWVzIGZyb20gdGhl IEJ1ZyAzNTA1NiAtIERpc2FibGVkIG1lbnUgb3B0aW9ucyAKKyAgICAgICAgYXJlIHN0aWxsIHN1 Ym1pdHRlZC4oaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDU2KQor ICAgICAgICBUaGUgV01MT3B0aW9uRWxlbWVudC5oIG5lZWRzIHRvIGRlZmluZSB0aGUgZGlzYWJs ZWQoKSBhcyB3ZWxsLgorCisgICAgICAgICogd21sL1dNTE9wdGlvbkVsZW1lbnQuaDoKKyAgICAg ICAgKFdlYkNvcmU6OldNTE9wdGlvbkVsZW1lbnQ6OmRpc2FibGVkKToKKwogMjAxMC0wMy0yNiAg RGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0 aCBEYWtpbi4KSW5kZXg6IFdlYkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmgJKHJldmlzaW9uIDU2NjU4KQorKysg V2ViQ29yZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0 MSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgY2hpbGRyZW5DaGFuZ2VkKGJvb2wgY2hh bmdlZEJ5UGFyc2VyID0gZmFsc2UsIE5vZGUqIGJlZm9yZUNoYW5nZSA9IDAsIE5vZGUqIGFmdGVy Q2hhbmdlID0gMCwgaW50IGNoaWxkQ291bnREZWx0YSA9IDApOwogICAgIHZpcnR1YWwgdm9pZCBw YXJzZU1hcHBlZEF0dHJpYnV0ZShNYXBwZWRBdHRyaWJ1dGUqKTsKIAorICAgIHZpcnR1YWwgYm9v bCBkaXNhYmxlZCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9OworCiAgICAgdmlydHVhbCB2b2lk IGF0dGFjaCgpOwogICAgIHZpcnR1YWwgdm9pZCBkZXRhY2goKTsKICAgICB2aXJ0dWFsIHZvaWQg c2V0UmVuZGVyU3R5bGUoUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4pOwo= 51872 2010-03-28 17:03:07 -0700 2010-03-29 18:58:24 -0700 Patch for a build break due to the disabled() function WMLDisablePatch.txt text/plain 1407 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjY1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMjcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGVyZSBpcyBhIGJ1aWxkIGJyZWFrIGR1ZSB0byB0aGUgZGlzYWJsZWQoKSB3aGVuIHdt bCBmZWF0dXJlIGlzIAorICAgICAgICBlbmFibGVkLiBUaGlzIGJyZWFrIGNvbWVzIGZyb20gdGhl IEJ1ZyAzNTA1NiAtIERpc2FibGVkIG1lbnUgb3B0aW9ucyAKKyAgICAgICAgYXJlIHN0aWxsIHN1 Ym1pdHRlZC4oaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDU2KQor ICAgICAgICBUaGUgV01MT3B0aW9uRWxlbWVudC5oIG5lZWRzIHRvIGRlZmluZSB0aGUgZGlzYWJs ZWQoKSBhcyB3ZWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzY2OTgKKworICAgICAgICAqIHdtbC9XTUxPcHRpb25FbGVtZW50Lmg6CisgICAgICAg IChXZWJDb3JlOjpXTUxPcHRpb25FbGVtZW50OjpkaXNhYmxlZCk6CisKIDIwMTAtMDMtMjYgIERh bmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGgg RGFraW4uCkluZGV4OiBXZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCShyZXZpc2lvbiA1NjY1OCkKKysrIFdl YkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsNiArNDEs OCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGNoaWxkcmVuQ2hhbmdlZChib29sIGNoYW5n ZWRCeVBhcnNlciA9IGZhbHNlLCBOb2RlKiBiZWZvcmVDaGFuZ2UgPSAwLCBOb2RlKiBhZnRlckNo YW5nZSA9IDAsIGludCBjaGlsZENvdW50RGVsdGEgPSAwKTsKICAgICB2aXJ0dWFsIHZvaWQgcGFy c2VNYXBwZWRBdHRyaWJ1dGUoTWFwcGVkQXR0cmlidXRlKik7CiAKKyAgICB2aXJ0dWFsIGJvb2wg ZGlzYWJsZWQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfTsKKwogICAgIHZpcnR1YWwgdm9pZCBh dHRhY2goKTsKICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCk7CiAgICAgdmlydHVhbCB2b2lkIHNl dFJlbmRlclN0eWxlKFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+KTsK 51993 2010-03-29 18:58:24 -0700 2010-03-29 22:35:18 -0700 Patch for a build break due to the disabled() function WMLOptionElement-patch.txt text/plain 1408 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Njc1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBkYXJpbi4KKworICAgICAgICBUaGVy ZSBpcyBhIGJ1aWxkIGJyZWFrIGR1ZSB0byB0aGUgZGlzYWJsZWQoKSB3aGVuIHdtbCBmZWF0dXJl IGlzIAorICAgICAgICBlbmFibGVkLiBUaGlzIGJyZWFrIGNvbWVzIGZyb20gdGhlIEJ1ZyAzNTA1 NiAtIERpc2FibGVkIG1lbnUgb3B0aW9ucyAKKyAgICAgICAgYXJlIHN0aWxsIHN1Ym1pdHRlZC4o aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDU2KQorICAgICAgICBU aGUgV01MT3B0aW9uRWxlbWVudC5oIG5lZWRzIHRvIGRlZmluZSB0aGUgZGlzYWJsZWQoKSBhcyB3 ZWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2 OTgKKworICAgICAgICAqIHdtbC9XTUxPcHRpb25FbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3Jl OjpXTUxPcHRpb25FbGVtZW50OjpkaXNhYmxlZCk6CisKIDIwMTAtMDMtMjkgIFJhZmFlbCBXZWlu c3RlaW4gIDxyYWZhZWx3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpJbmRleDogV2ViQ29yZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuaAkocmV2aXNpb24gNTY3NTYpCisrKyBX ZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTQxLDYgKzQx LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBjaGlsZHJlbkNoYW5nZWQoYm9vbCBjaGFu Z2VkQnlQYXJzZXIgPSBmYWxzZSwgTm9kZSogYmVmb3JlQ2hhbmdlID0gMCwgTm9kZSogYWZ0ZXJD aGFuZ2UgPSAwLCBpbnQgY2hpbGRDb3VudERlbHRhID0gMCk7CiAgICAgdmlydHVhbCB2b2lkIHBh cnNlTWFwcGVkQXR0cmlidXRlKE1hcHBlZEF0dHJpYnV0ZSopOwogCisgICAgdmlydHVhbCBib29s IGRpc2FibGVkKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH07CisKICAgICB2aXJ0dWFsIHZvaWQg YXR0YWNoKCk7CiAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOwogICAgIHZpcnR1YWwgdm9pZCBz ZXRSZW5kZXJTdHlsZShQYXNzUmVmUHRyPFJlbmRlclN0eWxlPik7Cg== 52005 2010-03-29 22:35:18 -0700 2010-03-29 23:31:10 -0700 Patch for a build break due to the disabled() function WMLOptionElement-patch.txt text/plain 1897 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Njc1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkoT09QUyEpLgorCisgICAg ICAgIFRoZXJlIGlzIGEgYnVpbGQgYnJlYWsgZHVlIHRvIHRoZSBkaXNhYmxlZCgpIHdoZW4gd21s IGZlYXR1cmUgaXMgCisgICAgICAgIGVuYWJsZWQuIFRoaXMgYnJlYWsgY29tZXMgZnJvbSB0aGUg QnVnIDM1MDU2IC0gRGlzYWJsZWQgbWVudSBvcHRpb25zIAorICAgICAgICBhcmUgc3RpbGwgc3Vi bWl0dGVkLihodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwNTYpCisg ICAgICAgIFRoZSBXTUxPcHRpb25FbGVtZW50LmggbmVlZHMgdG8gZGVmaW5lIHRoZSBkaXNhYmxl ZCgpIGFzIHdlbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNjY5OAorCisgICAgICAgICogd21sL1dNTE9wdGlvbkVsZW1lbnQuaDoKKyAgICAgICAg KFdlYkNvcmU6OldNTE9wdGlvbkVsZW1lbnQ6OmRpc2FibGVkKToKKwogMjAxMC0wMy0yOSAgUmFm YWVsIFdlaW5zdGVpbiAgPHJhZmFlbHdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCShyZXZpc2lvbiA1Njc1 NikKKysrIFdlYkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAt NDEsNiArNDEsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGNoaWxkcmVuQ2hhbmdlZChi b29sIGNoYW5nZWRCeVBhcnNlciA9IGZhbHNlLCBOb2RlKiBiZWZvcmVDaGFuZ2UgPSAwLCBOb2Rl KiBhZnRlckNoYW5nZSA9IDAsIGludCBjaGlsZENvdW50RGVsdGEgPSAwKTsKICAgICB2aXJ0dWFs IHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1dGUoTWFwcGVkQXR0cmlidXRlKik7CiAKKyAgICB2aXJ0 dWFsIGJvb2wgZGlzYWJsZWQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorCiAgICAgdmlydHVh bCB2b2lkIGF0dGFjaCgpOwogICAgIHZpcnR1YWwgdm9pZCBkZXRhY2goKTsKICAgICB2aXJ0dWFs IHZvaWQgc2V0UmVuZGVyU3R5bGUoUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4pOwpJbmRleDogV2Vi Q29yZS93bWwvV01MU2VsZWN0RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dN TFNlbGVjdEVsZW1lbnQuaAkocmV2aXNpb24gNTY3NTYpCisrKyBXZWJDb3JlL3dtbC9XTUxTZWxl Y3RFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTg3LDYgKzg3LDcgQEAgcHVibGljOgogCiAg ICAgYm9vbCBpbml0aWFsaXplZCgpIGNvbnN0IHsgcmV0dXJuIG1faW5pdGlhbGl6ZWQ7IH0KIAor ICAgIHZpcnR1YWwgdm9pZCBsaXN0Qm94U2VsZWN0SXRlbShpbnQgbGlzdEluZGV4LCBib29sIGFs bG93TXVsdGlwbHlTZWxlY3Rpb25zLCBib29sIHNoaWZ0LCBib29sIGZpcmVPbkNoYW5nZU5vdyA9 IHRydWUpIHsgcmV0dXJuOyB9CiBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRlZElu dG9UcmVlKGJvb2wpOwogCg== 52007 2010-03-29 23:31:10 -0700 2010-03-30 00:08:10 -0700 Patch for a build break due to the disabled() function WMLOptionElement-patch.txt text/plain 2246 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Njc2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDMtMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGVyZSBpcyBhIGJ1aWxkIGJyZWFrIGR1ZSB0byB0aGUgZGlzYWJsZWQoKSB3aGVuIHdt bCBmZWF0dXJlIGlzCisgICAgICAgIGVuYWJsZWQuIFRoaXMgYnJlYWsgY29tZXMgZnJvbSB0aGUg QnVnIDM1MDU2IC0gRGlzYWJsZWQgbWVudSBvcHRpb25zCisgICAgICAgIGFyZSBzdGlsbCBzdWJt aXR0ZWQuKGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTA1NikKKyAg ICAgICAgVGhlIFdNTE9wdGlvbkVsZW1lbnQuaCBuZWVkcyB0byBkZWZpbmUgdGhlIGRpc2FibGVk KCkgYXMgd2VsbC4KKyAgICAgICAgQW5kLCB0aGVyZSBpcyBhbiBhZGRpdGlvbmFsIGJyZWFrIGR1 ZSB0byBCdWcgMzYxNzcgLSAgTXVsdGlzZWxlY3QgUG9wdXAKKyAgICAgICAgLSBMaXN0Ym94IGNs aWNrIHNpbXVsYXRpb24uIChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzYxNzcpCisgICAgICAgIHZpcnR1YWwgdm9pZCBsaXN0Qm94U2VsZWN0SXRlbSgpIHNob3VsZCBi ZSBhZGRlZCB0byBXTUxTZWxlY3RFbGVtZW50LmggYXMgd2VsbC4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2OTgKKworICAgICAgICAqIHdtbC9X TUxPcHRpb25FbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpXTUxPcHRpb25FbGVtZW50Ojpk aXNhYmxlZCk6CisgICAgICAgICogd21sL1dNTFNlbGVjdEVsZW1lbnQuaDoKKyAgICAgICAgKFdl YkNvcmU6OldNTFNlbGVjdEVsZW1lbnQ6Omxpc3RCb3hTZWxlY3RJdGVtKToKKwogMjAxMC0wMy0y OSAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIEh5YXR0LgpJbmRleDogV2ViQ29yZS93bWwvV01MT3B0aW9uRWxlbWVu dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuaAkocmV2aXNp b24gNTY3NTYpCisrKyBXZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmgJKHdvcmtpbmcgY29w eSkKQEAgLTQxLDYgKzQxLDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBjaGlsZHJlbkNo YW5nZWQoYm9vbCBjaGFuZ2VkQnlQYXJzZXIgPSBmYWxzZSwgTm9kZSogYmVmb3JlQ2hhbmdlID0g MCwgTm9kZSogYWZ0ZXJDaGFuZ2UgPSAwLCBpbnQgY2hpbGRDb3VudERlbHRhID0gMCk7CiAgICAg dmlydHVhbCB2b2lkIHBhcnNlTWFwcGVkQXR0cmlidXRlKE1hcHBlZEF0dHJpYnV0ZSopOwogCisg ICAgdmlydHVhbCBib29sIGRpc2FibGVkKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKwogICAg IHZpcnR1YWwgdm9pZCBhdHRhY2goKTsKICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCk7CiAgICAg dmlydHVhbCB2b2lkIHNldFJlbmRlclN0eWxlKFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+KTsKSW5k ZXg6IFdlYkNvcmUvd21sL1dNTFNlbGVjdEVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3dtbC9XTUxTZWxlY3RFbGVtZW50LmgJKHJldmlzaW9uIDU2NzU2KQorKysgV2ViQ29yZS93bWwv V01MU2VsZWN0RWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Nyw2ICs4Nyw3IEBAIHB1Ymxp YzoKIAogICAgIGJvb2wgaW5pdGlhbGl6ZWQoKSBjb25zdCB7IHJldHVybiBtX2luaXRpYWxpemVk OyB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgbGlzdEJveFNlbGVjdEl0ZW0oaW50IGxpc3RJbmRleCwg Ym9vbCBhbGxvd011bHRpcGx5U2VsZWN0aW9ucywgYm9vbCBzaGlmdCwgYm9vbCBmaXJlT25DaGFu Z2VOb3cgPSB0cnVlKSB7IHJldHVybjsgfQogcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgaW5z ZXJ0ZWRJbnRvVHJlZShib29sKTsKIAo=