36690 2010-03-26 18:31:36 -0700 [Qt] LayoutTests/http/tests/appcache/resource-redirect-2.html failed and skipped 2010-06-09 06:54:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux CLOSED FIXED Qt P3 Normal --- 37097 34712 35784 1 cshu krithigassree.sambamurthy commit-queue cshu hausmann laszlo.gombos ossy robert webkit.review.bot oldest_to_newest 204901 0 cshu 2010-03-26 18:31:36 -0700 The above test timed out on QtLinux. 205644 1 51960 krithigassree.sambamurthy 2010-03-29 13:34:33 -0700 Created attachment 51960 Patch helps in detetcting http redirect loops in Qt 205648 2 webkit.review.bot 2010-03-29 13:39:37 -0700 Attachment 51960 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/network/qt/QNetworkReplyHandler.cpp:252: An else should appear on the same line as the preceding } [whitespace/newline] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 205996 3 52035 krithigassree.sambamurthy 2010-03-30 07:19:05 -0700 Created attachment 52035 Re-submitting patch according to style rules 207502 4 52035 eric 2010-04-01 16:53:18 -0700 Comment on attachment 52035 Re-submitting patch according to style rules LayoutTests ChangeLog is bogus. 208049 5 52447 krithigassree.sambamurthy 2010-04-02 13:47:52 -0700 Created attachment 52447 Patch file adhereing to style rules 208653 6 52447 eric 2010-04-05 12:57:23 -0700 Comment on attachment 52447 Patch file adhereing to style rules Tab in the ChangeLog will prevent this from being committed. I'm surprised the style bot didn't catch that. This looks sane, although I'm surprised the Qt network layer doesn't do this for you. 208655 7 52447 laszlo.gombos 2010-04-05 13:03:13 -0700 Comment on attachment 52447 Patch file adhereing to style rules r- as this now has to be reworked after fix for 37097 is landed. The same bug (missing feature) cause both xhr and app cache failures. Bug 37097 is using 10 as a redirect limit, I'm ok with that instead of 16 proposed as part of this patch. Krithiga, can you rewor your patch so that it works on top of patch for bug 37097. I think your error handling code and the Skipped list update is still needed. 208671 8 cshu 2010-04-05 13:32:03 -0700 (In reply to comment #7) > (From update of attachment 52447 [details]) > r- as this now has to be reworked after fix for 37097 is landed. The same bug > (missing feature) cause both xhr and app cache failures. > > Bug 37097 is using 10 as a redirect limit, I'm ok with that instead of 16 > proposed as part of this patch. > > Krithiga, can you rewor your patch so that it works on top of patch for bug > 37097. I think your error handling code and the Skipped list update is still > needed. Thanks for finding this out for us, Laszlo. 208687 9 robert 2010-04-05 14:11:33 -0700 (In reply to comment #6) > (From update of attachment 52447 [details]) > Tab in the ChangeLog will prevent this from being committed. I'm surprised the > style bot didn't catch that. > > This looks sane, although I'm surprised the Qt network layer doesn't do this > for you. QtNetwork is pretty agnostic on this score. It passes back redirects to the client by setting an attribute in the QNetworkRequest: \value RedirectionTargetAttribute Replies only, type: QVariant::Url (no default) If present, it indicates that the server is redirecting the request to a different URL. The Network Access API does not by default follow redirections: it's up to the application to determine if the requested redirection should be allowed, according to its security policies. The returned URL might be relative. Use QUrl::resolved() to create an absolute URL out of it. So if QtWebKit wants to respect redirects it needs to sanity check them as well. 208718 10 cshu 2010-04-05 14:50:01 -0700 (In reply to comment #9) > (In reply to comment #6) > > (From update of attachment 52447 [details] [details]) > So if QtWebKit wants to respect redirects it needs to sanity check them as > well. Thanks for the clarification. This confirms the correctness of webkit approach. 209155 11 52654 krithigassree.sambamurthy 2010-04-06 11:43:19 -0700 Created attachment 52654 Patch file for appcache layout tests that can be removed from the skipped list. New patch file containing the changes to layout skipped tests and corresponding change log. 209170 12 laszlo.gombos 2010-04-06 12:20:25 -0700 ChangeLog has a small text alignment issue, otherwise looks good. Krithiga, can you fix it ? 209196 13 52659 krithigassree.sambamurthy 2010-04-06 13:11:33 -0700 Created attachment 52659 new patch file following tab rules for Change log 209201 14 52659 laszlo.gombos 2010-04-06 13:16:12 -0700 Comment on attachment 52659 new patch file following tab rules for Change log lgtm, r+. 209307 15 52659 commit-queue 2010-04-06 16:04:51 -0700 Comment on attachment 52659 new patch file following tab rules for Change log Clearing flags on attachment: 52659 Committed r57175: <http://trac.webkit.org/changeset/57175> 209308 16 commit-queue 2010-04-06 16:04:57 -0700 All reviewed patches have been landed. Closing bug. 222608 17 hausmann 2010-05-07 14:16:21 -0700 Revision r57175 cherry-picked into qtwebkit-2.0 with commit f8d7b7e06126519131d47d84f5d8cc9f0873b9fb 235765 18 ossy 2010-06-09 06:54:53 -0700 (In reply to comment #17) > Revision r57175 cherry-picked into qtwebkit-2.0 with commit f8d7b7e06126519131d47d84f5d8cc9f0873b9fb This make http/tests/appcache/fallback.html crash on the qtwebkit-2.0 bot. Have you got any idea why? I tried against Qt 4.6.0, 4.6.2 and 4.7.0, but they didn't solve this crash. 51960 2010-03-29 13:34:33 -0700 2010-03-30 07:19:05 -0700 Patch helps in detetcting http redirect loops in Qt qnetworkreplyhandler.patch text/plain 3614 krithigassree.sambamurthy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjczNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMjkgIEtyaXRoaWdhc3NyZWUgU2FtYmFtdXJ0aHkgIDxr cml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERldGVjdCByZWRpcmVjdCBsb29wcyBp biBRdCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2 NjkwCisgICAgICAgIAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1Jl cGx5SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6 UU5ldHdvcmtSZXBseUhhbmRsZXIpOgorICAgICAgICAoV2ViQ29yZTo6UU5ldHdvcmtSZXBseUhh bmRsZXI6OmZpbmlzaCk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1Jl cGx5SGFuZGxlci5oOgorCiAyMDEwLTAzLTI5ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAJ KHJldmlzaW9uIDU2NzM1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3Jr UmVwbHlIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM4LDYgKzEzOCw3IEBAIFFOZXR3 b3JrUmVwbHlIYW5kbGVyOjpRTmV0d29ya1JlcGx5SGFuZGwKICAgICAsIG1fc2hvdWxkRmluaXNo KGZhbHNlKQogICAgICwgbV9zaG91bGRTZW5kUmVzcG9uc2UoZmFsc2UpCiAgICAgLCBtX3Nob3Vs ZEZvcndhcmREYXRhKGZhbHNlKQorICAgICwgbV9yZWRpcmVjdENvdW50ZXIoMCkKIHsKICAgICBj b25zdCBSZXNvdXJjZVJlcXVlc3QgJnIgPSBtX3Jlc291cmNlSGFuZGxlLT5yZXF1ZXN0KCk7CiAK QEAgLTI0Myw5ICsyNDQsMTUgQEAgdm9pZCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6ZmluaXNoKCkK IAogICAgIFFOZXR3b3JrUmVwbHkqIG9sZFJlcGx5ID0gbV9yZXBseTsKIAotICAgIGlmIChtX3Jl ZGlyZWN0ZWQpIHsKLSAgICAgICAgcmVzZXRTdGF0ZSgpOwotICAgICAgICBzdGFydCgpOworICAg IGlmIChtX3JlZGlyZWN0ZWQpIHsgICAgICAgIAorICAgICAgICBpZiAoKyttX3JlZGlyZWN0Q291 bnRlciA+PSBNQVhfUkVESVJFQ1RTKSB7ICAgICAgICAgICAgICAgICAgICAgICAgCisgICAgICAg ICAgICBSZXNvdXJjZUVycm9yIGVycm9yKCJIVFRQIiwgUU5ldHdvcmtSZXBseTo6VW5rbm93bk5l dHdvcmtFcnJvciAsIChtX3JlcGx5LT51cmwoKSkudG9TdHJpbmcoKSwgIlRvbyBtYW55IEhUVFAg cmVkaXJlY3RzIik7CisgICAgICAgICAgICBjbGllbnQtPmRpZEZhaWwobV9yZXNvdXJjZUhhbmRs ZSwgZXJyb3IpOworICAgICAgICB9CisgICAgICAgIGVsc2UgeyAgICAgICAgCisgICAgICAgICAg ICByZXNldFN0YXRlKCk7CisgICAgICAgICAgICBzdGFydCgpOworICAgICAgICB9CiAgICAgfSBl bHNlIGlmICghbV9yZXBseS0+ZXJyb3IoKSB8fCBpZ25vcmVIdHRwRXJyb3IobV9yZXBseSwgbV9y ZXNwb25zZURhdGFTZW50KSkgewogICAgICAgICBjbGllbnQtPmRpZEZpbmlzaExvYWRpbmcobV9y ZXNvdXJjZUhhbmRsZSk7CiAgICAgfSBlbHNlIHsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCShyZXZpc2lvbiA1NjczNSkK KysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw4IEBAIGNsYXNzIFFGaWxlOwogY2xhc3MgUU5ldHdv cmtSZXBseTsKIFFUX0VORF9OQU1FU1BBQ0UKIAorI2RlZmluZSBNQVhfUkVESVJFQ1RTIDE2CisK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgUmVzb3VyY2VIYW5kbGU7CkBAIC04Miw2ICs4 NCw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3Nob3VsZEZpbmlzaDsKICAgICBib29sIG1fc2hv dWxkU2VuZFJlc3BvbnNlOwogICAgIGJvb2wgbV9zaG91bGRGb3J3YXJkRGF0YTsKKyAgICBpbnQg IG1fcmVkaXJlY3RDb3VudGVyOwogfTsKIAogLy8gU2VsZiBkZXN0cnVjdGluZyBRSU9EZXZpY2Ug Zm9yIEZvcm1EYXRhCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NjczNSkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDEwLTAzLTI5ICBLcml0 aGlnYXNzcmVlIFNhbWJhbXVydGh5ICA8a3JpdGhpZ2Fzc3JlZS5zYW1iYW11cnRoeUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVl ZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKKworICAgICAgICAqIHBs YXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMTAtMDMtMjkgIERhdmlkIExldmluICA8bGV2aW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERtaXRyeSBUaXRvdi4KSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gNTY3MzUpCisrKyBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0yMywxMCArMjMsNiBAQCBo dHRwL3Rlc3RzL3dtbAogCiAjIFNraXAgZmFpbGVkIGFwcGNhY2hlIHRlc3QgY2FzZXMKIGh0dHAv dGVzdHMvYXBwY2FjaGUvYXV0aC5odG1sCi1odHRwL3Rlc3RzL2FwcGNhY2hlL2ZhbGxiYWNrLmh0 bWwKLWh0dHAvdGVzdHMvYXBwY2FjaGUvbWFuaWZlc3QtcmVkaXJlY3QtMi5odG1sCi1odHRwL3Rl c3RzL2FwcGNhY2hlL29mZmxpbmUtYWNjZXNzLmh0bWwKLWh0dHAvdGVzdHMvYXBwY2FjaGUvcmVz b3VyY2UtcmVkaXJlY3QtMi5odG1sCiAKICMgRmFpbGluZyBVUkwgdGVzdAogaHR0cC90ZXN0cy91 cmkvZXNjYXBlZC1lbnRpdHkuaHRtbAo= 52035 2010-03-30 07:19:05 -0700 2010-04-02 13:47:52 -0700 Re-submitting patch according to style rules qnetworkreplyhandler.patch text/plain 3824 krithigassree.sambamurthy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Njc4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMzAgIEtyaXRoaWdhc3NyZWUgU2FtYmFtdXJ0aHkgIDxr cml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERldGVjdCByZWRpcmVjdCBsb29wcyBp biBRdCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2 NjkwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpRTmV0d29ya1Jl cGx5SGFuZGxlcik6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6Zmlu aXNoKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVy Lmg6CisKKwogMjAxMC0wMy0zMCAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJv c3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3Jr UmVwbHlIYW5kbGVyLmNwcAkocmV2aXNpb24gNTY3MzUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgs NiArMTM4LDcgQEAgUU5ldHdvcmtSZXBseUhhbmRsZXI6OlFOZXR3b3JrUmVwbHlIYW5kbAogICAg ICwgbV9zaG91bGRGaW5pc2goZmFsc2UpCiAgICAgLCBtX3Nob3VsZFNlbmRSZXNwb25zZShmYWxz ZSkKICAgICAsIG1fc2hvdWxkRm9yd2FyZERhdGEoZmFsc2UpCisgICAgLCBtX3JlZGlyZWN0Q291 bnRlcigwKQogewogICAgIGNvbnN0IFJlc291cmNlUmVxdWVzdCAmciA9IG1fcmVzb3VyY2VIYW5k bGUtPnJlcXVlc3QoKTsKIApAQCAtMjQzLDkgKzI0NCwxNCBAQCB2b2lkIFFOZXR3b3JrUmVwbHlI YW5kbGVyOjpmaW5pc2goKQogCiAgICAgUU5ldHdvcmtSZXBseSogb2xkUmVwbHkgPSBtX3JlcGx5 OwogCi0gICAgaWYgKG1fcmVkaXJlY3RlZCkgewotICAgICAgICByZXNldFN0YXRlKCk7Ci0gICAg ICAgIHN0YXJ0KCk7CisgICAgaWYgKG1fcmVkaXJlY3RlZCkgeyAgICAgICAgCisgICAgICAgIGlm ICgrK21fcmVkaXJlY3RDb3VudGVyID49IE1BWF9SRURJUkVDVFMpIHsgICAgICAgICAgICAgICAg ICAgICAgICAKKyAgICAgICAgICAgIFJlc291cmNlRXJyb3IgZXJyb3IoIkhUVFAiLCBRTmV0d29y a1JlcGx5OjpVbmtub3duTmV0d29ya0Vycm9yICwgKG1fcmVwbHktPnVybCgpKS50b1N0cmluZygp LCAiVG9vIG1hbnkgSFRUUCByZWRpcmVjdHMiKTsKKyAgICAgICAgICAgIGNsaWVudC0+ZGlkRmFp bChtX3Jlc291cmNlSGFuZGxlLCBlcnJvcik7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICByZXNldFN0YXRlKCk7CisgICAgICAgICAgICBzdGFydCgpOworICAgICAgICB9CiAgICAgfSBl bHNlIGlmICghbV9yZXBseS0+ZXJyb3IoKSB8fCBpZ25vcmVIdHRwRXJyb3IobV9yZXBseSwgbV9y ZXNwb25zZURhdGFTZW50KSkgewogICAgICAgICBjbGllbnQtPmRpZEZpbmlzaExvYWRpbmcobV9y ZXNvdXJjZUhhbmRsZSk7CiAgICAgfSBlbHNlIHsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCShyZXZpc2lvbiA1NjczNSkK KysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw4IEBAIGNsYXNzIFFGaWxlOwogY2xhc3MgUU5ldHdv cmtSZXBseTsKIFFUX0VORF9OQU1FU1BBQ0UKIAorI2RlZmluZSBNQVhfUkVESVJFQ1RTIDE2CisK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgUmVzb3VyY2VIYW5kbGU7CkBAIC04Miw2ICs4 NCw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3Nob3VsZEZpbmlzaDsKICAgICBib29sIG1fc2hv dWxkU2VuZFJlc3BvbnNlOwogICAgIGJvb2wgbV9zaG91bGRGb3J3YXJkRGF0YTsKKyAgICBpbnQg IG1fcmVkaXJlY3RDb3VudGVyOwogfTsKIAogLy8gU2VsZiBkZXN0cnVjdGluZyBRSU9EZXZpY2Ug Zm9yIEZvcm1EYXRhCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1Njc4NCkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEwLTAzLTMwICBLcml0 aGlnYXNzcmVlIFNhbWJhbXVydGh5ICA8a3JpdGhpZ2Fzc3JlZS5zYW1iYW11cnRoeUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVl ZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKKworICAgICAgICAqIHBs YXRmb3JtL3F0L1NraXBwZWQ6CisKKzIwMTAtMDMtMjkgIEtyaXRoaWdhc3NyZWUgU2FtYmFtdXJ0 aHkgIDxrcml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRp b24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoK KwogMjAxMC0wMy0zMCAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL3Bs YXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZAkocmV2aXNpb24gNTY3MzUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lw cGVkCSh3b3JraW5nIGNvcHkpCkBAIC0yMywxMCArMjMsNiBAQCBodHRwL3Rlc3RzL3dtbAogCiAj IFNraXAgZmFpbGVkIGFwcGNhY2hlIHRlc3QgY2FzZXMKIGh0dHAvdGVzdHMvYXBwY2FjaGUvYXV0 aC5odG1sCi1odHRwL3Rlc3RzL2FwcGNhY2hlL2ZhbGxiYWNrLmh0bWwKLWh0dHAvdGVzdHMvYXBw Y2FjaGUvbWFuaWZlc3QtcmVkaXJlY3QtMi5odG1sCi1odHRwL3Rlc3RzL2FwcGNhY2hlL29mZmxp bmUtYWNjZXNzLmh0bWwKLWh0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2UtcmVkaXJlY3QtMi5o dG1sCiAKICMgRmFpbGluZyBVUkwgdGVzdAogaHR0cC90ZXN0cy91cmkvZXNjYXBlZC1lbnRpdHku aHRtbAo= 52447 2010-04-02 13:47:52 -0700 2010-04-06 11:47:13 -0700 Patch file adhereing to style rules new.patch text/plain 3618 krithigassree.sambamurthy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzAyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMDIgIEtyaXRoaWdhc3NyZWUgU2FtYmFtdXJ0aHkgIDxr cml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFBhdGNoIHRvIGRldGVjdCByZWRpcmVj dCBsb29wcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM2NjkwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpRTmV0d29y a1JlcGx5SGFuZGxlcik6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6 ZmluaXNoKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmg6CisKIDIwMTAtMDQtMDIgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCShyZXZpc2lv biA1NzAxMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFu ZGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOCw2ICsxMzgsNyBAQCBRTmV0d29ya1JlcGx5 SGFuZGxlcjo6UU5ldHdvcmtSZXBseUhhbmRsCiAgICAgLCBtX3Nob3VsZEZpbmlzaChmYWxzZSkK ICAgICAsIG1fc2hvdWxkU2VuZFJlc3BvbnNlKGZhbHNlKQogICAgICwgbV9zaG91bGRGb3J3YXJk RGF0YShmYWxzZSkKKyAgICAsIG1fcmVkaXJlY3RDb3VudGVyKDApCiB7CiAgICAgY29uc3QgUmVz b3VyY2VSZXF1ZXN0ICZyID0gbV9yZXNvdXJjZUhhbmRsZS0+cmVxdWVzdCgpOwogCkBAIC0yNDMs OSArMjQ0LDE0IEBAIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6OmZpbmlzaCgpCiAKICAgICBR TmV0d29ya1JlcGx5KiBvbGRSZXBseSA9IG1fcmVwbHk7CiAKLSAgICBpZiAobV9yZWRpcmVjdGVk KSB7Ci0gICAgICAgIHJlc2V0U3RhdGUoKTsKLSAgICAgICAgc3RhcnQoKTsKKyAgICBpZiAobV9y ZWRpcmVjdGVkKSB7ICAgICAgICAKKyAgICAgICAgaWYgKCsrbV9yZWRpcmVjdENvdW50ZXIgPj0g TUFYX1JFRElSRUNUUykgeyAgICAgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgUmVz b3VyY2VFcnJvciBlcnJvcigiSFRUUCIsIFFOZXR3b3JrUmVwbHk6OlVua25vd25OZXR3b3JrRXJy b3IgLCAobV9yZXBseS0+dXJsKCkpLnRvU3RyaW5nKCksICJUb28gbWFueSBIVFRQIHJlZGlyZWN0 cyIpOworICAgICAgICAgICAgY2xpZW50LT5kaWRGYWlsKG1fcmVzb3VyY2VIYW5kbGUsIGVycm9y KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHJlc2V0U3RhdGUoKTsKKyAgICAgICAg ICAgIHN0YXJ0KCk7CisgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKCFtX3JlcGx5LT5lcnJvcigp IHx8IGlnbm9yZUh0dHBFcnJvcihtX3JlcGx5LCBtX3Jlc3BvbnNlRGF0YVNlbnQpKSB7CiAgICAg ICAgIGNsaWVudC0+ZGlkRmluaXNoTG9hZGluZyhtX3Jlc291cmNlSGFuZGxlKTsKICAgICB9IGVs c2UgewpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3Jr UmVwbHlIYW5kbGVyLmgJKHJldmlzaW9uIDU2NzM1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMx LDggQEAgY2xhc3MgUUZpbGU7CiBjbGFzcyBRTmV0d29ya1JlcGx5OwogUVRfRU5EX05BTUVTUEFD RQogCisjZGVmaW5lIE1BWF9SRURJUkVDVFMgMTYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBj bGFzcyBSZXNvdXJjZUhhbmRsZTsKQEAgLTgyLDYgKzg0LDcgQEAgcHJpdmF0ZToKICAgICBib29s IG1fc2hvdWxkRmluaXNoOwogICAgIGJvb2wgbV9zaG91bGRTZW5kUmVzcG9uc2U7CiAgICAgYm9v bCBtX3Nob3VsZEZvcndhcmREYXRhOworICAgIGludCAgbV9yZWRpcmVjdENvdW50ZXI7CiB9Owog CiAvLyBTZWxmIGRlc3RydWN0aW5nIFFJT0RldmljZSBmb3IgRm9ybURhdGEKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDU3MDExKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDQtMDIgIEtyaXRoaWdhc3NyZWUgU2FtYmFtdXJ0aHkgIDxr cml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKwkKKwlbUXRdIFRoaXMgcGF0Y2ggZGV0Y3RzIHF0IDMwNyByZWRp cmVjdCBsb29wcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp aT9pZD0zNjY5MAorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMC0wNC0w MiAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQu CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlzaW9uIDU2NzM1KQorKysgTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtMjMsMTAgKzIzLDYg QEAgaHR0cC90ZXN0cy93bWwKIAogIyBTa2lwIGZhaWxlZCBhcHBjYWNoZSB0ZXN0IGNhc2VzCiBo dHRwL3Rlc3RzL2FwcGNhY2hlL2F1dGguaHRtbAotaHR0cC90ZXN0cy9hcHBjYWNoZS9mYWxsYmFj ay5odG1sCi1odHRwL3Rlc3RzL2FwcGNhY2hlL21hbmlmZXN0LXJlZGlyZWN0LTIuaHRtbAotaHR0 cC90ZXN0cy9hcHBjYWNoZS9vZmZsaW5lLWFjY2Vzcy5odG1sCi1odHRwL3Rlc3RzL2FwcGNhY2hl L3Jlc291cmNlLXJlZGlyZWN0LTIuaHRtbAogCiAjIEZhaWxpbmcgVVJMIHRlc3QKIGh0dHAvdGVz dHMvdXJpL2VzY2FwZWQtZW50aXR5Lmh0bWwK 52654 2010-04-06 11:43:19 -0700 2010-04-06 13:12:14 -0700 Patch file for appcache layout tests that can be removed from the skipped list. appcache.patch text/plain 1163 krithigassree.sambamurthy SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3MDExKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDYgIEtyaXRoaWdhc3NyZWUgU2Ft YmFtdXJ0aHkgIDxrcml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwkKKwlbUXRdIFRoZXNlIHRlc3RzIGNhbiBi ZSByZW1vdmVkIGZyb20gdGhlIHNraXBwZWQgbGlzdCBzaW5jZSB0aGVzZQorICAgICAgICB3b3Jr IGFmdGVyIHRoZSByZWRpcmVjdGlvbiBsb29wIGRldGVjdGlvbiBpbXBsZW1lbnRlZCBpbiBxdCBu ZXR3b3JrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2lpP2lk PTM2NjkwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA0LTAyICBE aXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gNTY3MzUpCisrKyBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0yMywxMCArMjMsNiBAQCBo dHRwL3Rlc3RzL3dtbAogCiAjIFNraXAgZmFpbGVkIGFwcGNhY2hlIHRlc3QgY2FzZXMKIGh0dHAv dGVzdHMvYXBwY2FjaGUvYXV0aC5odG1sCi1odHRwL3Rlc3RzL2FwcGNhY2hlL2ZhbGxiYWNrLmh0 bWwKLWh0dHAvdGVzdHMvYXBwY2FjaGUvbWFuaWZlc3QtcmVkaXJlY3QtMi5odG1sCi1odHRwL3Rl c3RzL2FwcGNhY2hlL29mZmxpbmUtYWNjZXNzLmh0bWwKLWh0dHAvdGVzdHMvYXBwY2FjaGUvcmVz b3VyY2UtcmVkaXJlY3QtMi5odG1sCiAKICMgRmFpbGluZyBVUkwgdGVzdAogaHR0cC90ZXN0cy91 cmkvZXNjYXBlZC1lbnRpdHkuaHRtbAo= 52659 2010-04-06 13:11:33 -0700 2010-04-06 16:04:51 -0700 new patch file following tab rules for Change log 06_04.patch text/plain 1169 krithigassree.sambamurthy SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3MDExKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDYgIEtyaXRoaWdhc3NyZWUgU2Ft YmFtdXJ0aHkgIDxrcml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFRoZXNlIHRlc3Rz IGNhbiBiZSByZW1vdmVkIGZyb20gdGhlIHNraXBwZWQgbGlzdCBzaW5jZSB0aGVzZQorICAgICAg ICB3b3JrIGFmdGVyIHRoZSByZWRpcmVjdGlvbiBsb29wIGRldGVjdGlvbiBpbXBsZW1lbnRlZCBp biBxdCBuZXR3b3JrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2lpP2lkPTM2NjkwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA0 LTAyICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gNTY3MzUpCisrKyBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0yMywxMCArMjMs NiBAQCBodHRwL3Rlc3RzL3dtbAogCiAjIFNraXAgZmFpbGVkIGFwcGNhY2hlIHRlc3QgY2FzZXMK IGh0dHAvdGVzdHMvYXBwY2FjaGUvYXV0aC5odG1sCi1odHRwL3Rlc3RzL2FwcGNhY2hlL2ZhbGxi YWNrLmh0bWwKLWh0dHAvdGVzdHMvYXBwY2FjaGUvbWFuaWZlc3QtcmVkaXJlY3QtMi5odG1sCi1o dHRwL3Rlc3RzL2FwcGNhY2hlL29mZmxpbmUtYWNjZXNzLmh0bWwKLWh0dHAvdGVzdHMvYXBwY2Fj aGUvcmVzb3VyY2UtcmVkaXJlY3QtMi5odG1sCiAKICMgRmFpbGluZyBVUkwgdGVzdAogaHR0cC90 ZXN0cy91cmkvZXNjYXBlZC1lbnRpdHkuaHRtbAo=