<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36688</bug_id>
          
          <creation_ts>2010-03-26 18:29:11 -0700</creation_ts>
          <short_desc>[Qt] LayoutTests/http/tests/appcache/auth.html failed and skipped</short_desc>
          <delta_ts>2011-01-28 11:16:40 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>34712</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chang Shu">cshu</reporter>
          <assigned_to name="Chang Shu">cshu</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>kling</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>markus</cc>
    
    <cc>ossy</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>204899</commentid>
    <comment_count>0</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2010-03-26 18:29:11 -0700</bug_when>
    <thetext>The above test failed on Qt Linux. The test result shows time out.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>206084</commentid>
    <comment_count>1</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2010-03-30 11:22:36 -0700</bug_when>
    <thetext>I have investigated the issue and it looks to me the problem is under QNetwork layer.
The test case will send several http requests in a row. The first one to &quot;setup.php&quot; contains the login/password info and it went through. The second request to &quot;iframe.php&quot; does not contain user/password in its url and the QNetwork layer is supposed to fetch the credential from its cache. However, I didn&apos;t see the credential was saved to cache before this. I think after the successful return of the 1st request, the credential should be saved.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>213362</commentid>
    <comment_count>2</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2010-04-16 12:17:04 -0700</bug_when>
    <thetext>I reported a bug in Qt:
http://bugreports.qt.nokia.com/browse/QTBUG-9996</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>284636</commentid>
    <comment_count>3</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2010-09-24 12:53:26 -0700</bug_when>
    <thetext>the bug is fixed in Qt4.7. Once the QtWebKit buildbot starts using Qt4.7, we can close this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>303963</commentid>
    <comment_count>4</comment_count>
    <who name="Markus Goetz">markus</who>
    <bug_when>2010-11-03 03:49:56 -0700</bug_when>
    <thetext>Hey,
Can i then close the associated bug in the Qt bugtracker?
http://bugreports.qt.nokia.com/browse/QTBUG-9996
Thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325179</commentid>
    <comment_count>5</comment_count>
      <attachid>77147</attachid>
    <who name="">krithigassree.sambamurthy</who>
    <bug_when>2010-12-21 13:42:43 -0800</bug_when>
    <thetext>Created attachment 77147
Patch to unskip auth.html from Skipped.

Appcache layout test case auth.html can be removed from the Skipped list. Test case passes since switching to Qt4.7 in the buildbot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325498</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-22 08:24:21 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 77147:

http/tests/local/stylesheet-and-script-load-order-media-print.html bug 51470 (author: koivisto@iki.fi)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325499</commentid>
    <comment_count>7</comment_count>
      <attachid>77147</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-22 08:25:48 -0800</bug_when>
    <thetext>Comment on attachment 77147
Patch to unskip auth.html from Skipped.

Clearing flags on attachment: 77147

Committed r74481: &lt;http://trac.webkit.org/changeset/74481&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325500</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-22 08:25:54 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325510</commentid>
    <comment_count>9</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-12-22 08:47:08 -0800</bug_when>
    <thetext>It seems to me that running http/tests/appcache/auth.html makes the http/tests/misc/401-alternative-content.php flaky.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325558</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-22 10:35:13 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/74481 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
http/tests/local/stylesheet-and-script-load-order-media-print.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325642</commentid>
    <comment_count>11</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2010-12-22 12:47:12 -0800</bug_when>
    <thetext>The patch was reverted by http://trac.webkit.org/changeset/74486
as it causes regression. A re-work is going on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325957</commentid>
    <comment_count>12</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-23 00:40:32 -0800</bug_when>
    <thetext>What was the regression?  The stylesheet test failure?  If so, please dup bug 51470 against this one?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328636</commentid>
    <comment_count>13</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-01-03 10:42:00 -0800</bug_when>
    <thetext>*** Bug 51829 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328641</commentid>
    <comment_count>14</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-01-03 10:44:26 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; *** Bug 51829 has been marked as a duplicate of this bug. ***

After http://trac.webkit.org/changeset/74896 http/tests/misc/401-alternative-content.php fails always if I run all of the tests, but pass if I run only this test. So it must be a Qt-DRT sideeffect bug, and not flakyness as Laszlo said.

pretty diff: http://build.webkit.org/results/Qt%20Linux%20Release/r74900%20%2825916%29/http/tests/misc/401-alternative-content-pretty-diff.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341431</commentid>
    <comment_count>15</comment_count>
      <attachid>80449</attachid>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-01-28 07:27:30 -0800</bug_when>
    <thetext>Created attachment 80449
fix patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341454</commentid>
    <comment_count>16</comment_count>
      <attachid>80449</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-01-28 08:33:23 -0800</bug_when>
    <thetext>Comment on attachment 80449
fix patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80449&amp;action=review

r=me, with one adjustment:

&gt; Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:560
&gt; +    if (isHttpTest(url)) {

The helper method is a bit misleading, I think we should simply inline the check here, and also make it more specific, i.e:
if (url.scheme() == &quot;http&quot; || url.scheme() == &quot;https&quot;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341468</commentid>
    <comment_count>17</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-01-28 08:46:41 -0800</bug_when>
    <thetext>Laszlo suggested to do network cleanup for all tests, including non-http. This clean up the code. I ran part of the tests so far and no failures and no performance overhead observed. Andreas, do you prefer this change?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341476</commentid>
    <comment_count>18</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-01-28 09:06:51 -0800</bug_when>
    <thetext>(In reply to comment #17)
&gt; Laszlo suggested to do network cleanup for all tests, including non-http. This clean up the code. I ran part of the tests so far and no failures and no performance overhead observed. Andreas, do you prefer this change?

If it has no tangible performance overhead, sure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341477</commentid>
    <comment_count>19</comment_count>
      <attachid>80456</attachid>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-01-28 09:06:52 -0800</bug_when>
    <thetext>Created attachment 80456


patch based on Kling&apos;s comments.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341478</commentid>
    <comment_count>20</comment_count>
      <attachid>80457</attachid>
    <who name="Chang Shu">cshu</who>
    <bug_when>2011-01-28 09:08:24 -0800</bug_when>
    <thetext>Created attachment 80457
fix patch 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341546</commentid>
    <comment_count>21</comment_count>
      <attachid>80457</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-28 11:16:35 -0800</bug_when>
    <thetext>Comment on attachment 80457
fix patch 2

Clearing flags on attachment: 80457

Committed r76958: &lt;http://trac.webkit.org/changeset/76958&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>341547</commentid>
    <comment_count>22</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-28 11:16:40 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77147</attachid>
            <date>2010-12-21 13:42:43 -0800</date>
            <delta_ts>2011-01-28 07:27:30 -0800</delta_ts>
            <desc>Patch to unskip auth.html from Skipped.</desc>
            <filename>Patch1.patch</filename>
            <type>text/plain</type>
            <size>1128</size>
            <attacher>krithigassree.sambamurthy</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDc0NDI1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTItMjEgIEtyaXRoaWdhc3NyZWUgU2Ft
YmFtdXJ0aHkgIDxrcml0aGlnYXNzcmVlLnNhbWJhbXVydGh5QG5va2lhLmNvbT4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIExheW91dFRlc3Rz
L2h0dHAvdGVzdHMvYXBwY2FjaGUvYXV0aC5odG1sIGZhaWxlZCBhbmQgc2tpcHBlZAorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2ODgKKworICAgICAg
ICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6IFVuc2tpcCBhdXRoLmh0bWwgd2hpY2ggbm93IHBhc3Nl
cy4KKyAgICAgICAgVXNpbmcgUXQ0LjcuCisKIDIwMTAtMTItMjEgIFRvbnkgR2VudGlsY29yZSAg
PHRvbnlnQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KSW5k
ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0
VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gNzQ0MjIpCisrKyBMYXlvdXRUZXN0
cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAsOCArMTEwLDYgQEAg
aHR0cC90ZXN0cy9taXNjL2lzaW5kZXgtd2l0aC1uby1mb3JtLWJhcwogaHR0cC90ZXN0cy9taXNj
L2lzaW5kZXgtd2l0aC1uby1mb3JtLmh0bWwKIGh0dHAvdGVzdHMvbWlzYy90aW1lci12cy1sb2Fk
aW5nLmh0bWwKIAotaHR0cC90ZXN0cy9hcHBjYWNoZS9hdXRoLmh0bWwKLQogIyBPdXIgZXhwZWN0
ZWQgcmVzdWx0cyBhcmUgb3V0LW9mLWRhdGUgLSBuZWVkIHRvIGJlIHVwZGF0ZWQgZmlyc3QuCiBo
dHRwL3Rlc3RzL2xvYWRpbmcvYmFkLXNjaGVtZS1zdWJmcmFtZS5odG1sCiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80449</attachid>
            <date>2011-01-28 07:27:30 -0800</date>
            <delta_ts>2011-01-28 09:08:24 -0800</delta_ts>
            <desc>fix patch</desc>
            <filename>36688_1.patch</filename>
            <type>text/plain</type>
            <size>4378</size>
            <attacher name="Chang Shu">cshu</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc2OTQyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTcgQEAKKzIwMTEtMDEtMjggIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5jb20+CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzZXQgTmV0
d29ya0FjY2Vzc01hbmFnZXIgdG8gY2xlYW4gdXAgY3JlZGVudGlhbHMgZnJvbSBwcmV2aW91cyB0
ZXN0cy4KKyAgICAgICAgVGhpcyBjaGFuZ2UgY2F1c2VzIG5vIHBlcmZvcm1hbmNlIG92ZXJoZWFk
IGVpdGhlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTM2Njg4CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OmlzSHR0cFRlc3QpOgorICAgICAgICAoV2ViQ29yZTo6RHVt
cFJlbmRlclRyZWU6OnJlc2V0VG9Db25zaXN0ZW50U3RhdGVCZWZvcmVUZXN0aW5nKToKKyAgICAg
ICAgKFdlYkNvcmU6OkR1bXBSZW5kZXJUcmVlOjpvcGVuKToKKyAgICAgICAgKiBEdW1wUmVuZGVy
VHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0Lmg6CisKIDIwMTEtMDEtMjggIFpvbHRhbiBIb3J2YXRo
ICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu
Zy4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3Bw
CShyZXZpc2lvbiA3Njc1NSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJU
cmVlUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjAsNyArNTIwLDE0IEBAIHZvaWQgRHVtcFJl
bmRlclRyZWU6OmRyeVJ1blByaW50KFFXZWJGcmEKICNlbmRpZgogfQogCi12b2lkIER1bXBSZW5k
ZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZygpCitzdGF0aWMgYm9v
bCBpc0h0dHBUZXN0KGNvbnN0IFFVcmwmIHVybCkKK3sKKyAgICBpZiAodXJsLnNjaGVtZSgpLmNv
bnRhaW5zKCJodHRwIikpIC8vIEEgbG9vc2UgY2hlY2sgZm9yIGh0dHAgb3IgaHR0cHMKKyAgICAg
ICAgcmV0dXJuIHRydWU7CisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIER1bXBSZW5kZXJU
cmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZyhjb25zdCBRVXJsJiB1cmwp
CiB7CiAgICAgLy8gcmVzZXQgc28gdGhhdCBhbnkgY3VycmVudCBsb2FkcyBhcmUgc3RvcHBlZAog
ICAgIC8vIE5PVEU6IHRoYXQgdGhpcyBoYXMgdG8gYmUgZG9uZSBiZWZvcmUgdGhlIGxheW91dFRl
c3RDb250cm9sbGVyIGlzCkBAIC01NTAsNiArNTU3LDE0IEBAIHZvaWQgRHVtcFJlbmRlclRyZWU6
OnJlc2V0VG9Db25zaXN0ZW50U3QKICAgICBtX3BhZ2UtPm1haW5GcmFtZSgpLT5zZXRTY3JvbGxC
YXJQb2xpY3koUXQ6OlZlcnRpY2FsLCBRdDo6U2Nyb2xsQmFyQXNOZWVkZWQpOwogICAgIG1fcGFn
ZS0+bWFpbkZyYW1lKCktPnNldFNjcm9sbEJhclBvbGljeShRdDo6SG9yaXpvbnRhbCwgUXQ6OlNj
cm9sbEJhckFzTmVlZGVkKTsKIAorICAgIGlmIChpc0h0dHBUZXN0KHVybCkpIHsKKyAgICAgICAg
Ly8gY3JlZGVudGlhbHMgbWF5IGV4aXN0IGZyb20gcHJldmlvdXMgdGVzdHMuCisgICAgICAgIG1f
cGFnZS0+c2V0TmV0d29ya0FjY2Vzc01hbmFnZXIoMCk7CisgICAgICAgIGRlbGV0ZSBtX25ldHdv
cmtBY2Nlc3NNYW5hZ2VyOworICAgICAgICBtX25ldHdvcmtBY2Nlc3NNYW5hZ2VyID0gbmV3IE5l
dHdvcmtBY2Nlc3NNYW5hZ2VyKHRoaXMpOworICAgICAgICBtX3BhZ2UtPnNldE5ldHdvcmtBY2Nl
c3NNYW5hZ2VyKG1fbmV0d29ya0FjY2Vzc01hbmFnZXIpOworICAgIH0KKwogICAgIFdvcmtRdWV1
ZTo6c2hhcmVkKCktPmNsZWFyKCk7CiAgICAgV29ya1F1ZXVlOjpzaGFyZWQoKS0+c2V0RnJvemVu
KGZhbHNlKTsKIApAQCAtNTgzLDcgKzU5OCw3IEBAIHN0YXRpYyBib29sIGlzV2ViSW5zcGVjdG9y
VGVzdChjb25zdCBRVXIKIHZvaWQgRHVtcFJlbmRlclRyZWU6Om9wZW4oY29uc3QgUVVybCYgdXJs
KQogewogICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpkdW1wUmVzb3VyY2VMb2FkQ2FsbGJh
Y2tzUGF0aChRRmlsZUluZm8odXJsLnRvU3RyaW5nKCkpLnBhdGgoKSk7Ci0gICAgcmVzZXRUb0Nv
bnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3RpbmcoKTsKKyAgICByZXNldFRvQ29uc2lzdGVudFN0YXRl
QmVmb3JlVGVzdGluZyh1cmwpOwogCiAgICAgaWYgKGlzV2ViSW5zcGVjdG9yVGVzdChtX3BhZ2Ut
Pm1haW5GcmFtZSgpLT51cmwoKSkpCiAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyKCktPmNs
b3NlV2ViSW5zcGVjdG9yKCk7CkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVu
ZGVyVHJlZVF0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJl
bmRlclRyZWVRdC5oCShyZXZpc2lvbiA3Njc1NSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0
L0R1bXBSZW5kZXJUcmVlUXQuaAkod29ya2luZyBjb3B5KQpAQCAtODYsNyArODYsNyBAQCBwdWJs
aWM6CiAgICAgdm9pZCBzZXREdW1wUGl4ZWxzKGJvb2wpOwogCiAgICAgdm9pZCBjbG9zZVJlbWFp
bmluZ1dpbmRvd3MoKTsKLSAgICB2b2lkIHJlc2V0VG9Db25zaXN0ZW50U3RhdGVCZWZvcmVUZXN0
aW5nKCk7CisgICAgdm9pZCByZXNldFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZyhjb25z
dCBRVXJsJik7CiAKICAgICBMYXlvdXRUZXN0Q29udHJvbGxlciAqbGF5b3V0VGVzdENvbnRyb2xs
ZXIoKSBjb25zdCB7IHJldHVybiBtX2NvbnRyb2xsZXI7IH0KICAgICBFdmVudFNlbmRlciAqZXZl
bnRTZW5kZXIoKSBjb25zdCB7IHJldHVybiBtX2V2ZW50U2VuZGVyOyB9CkluZGV4OiBMYXlvdXRU
ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp
c2lvbiA3Njk0MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt
MSwzICsxLDEyIEBACisyMDExLTAxLTI4ICBDaGFuZyBTaHUgIDxjaGFuZy5zaHVAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tp
cHAgYXV0aC5odG1sIGFmdGVyIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTM2Njg4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgor
CiAyMDExLTAxLTI4ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgog
CiAgICAgICAgIFVucmV2aWV3ZWQuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lw
cGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlz
aW9uIDc2NzU1KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBj
b3B5KQpAQCAtNDk2OCwxMCArNDk2OCw2IEBAIGh0dHAvdGVzdHMvbG9jYWwvbGluay1zdHlsZXNo
ZWV0LWxvYWQtb3IKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUx
MzI0CiBmYXN0L3RleHQvZW1waGFzaXMtb3ZlcmxhcC5odG1sCiAKLSNbUXRdIExheW91dFRlc3Rz
L2h0dHAvdGVzdHMvYXBwY2FjaGUvYXV0aC5odG1sIGZhaWxlZCBhbmQgc2tpcHBlZAotIyBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2ODgKLWh0dHAvdGVzdHMvYXBw
Y2FjaGUvYXV0aC5odG1sCi0KICMgUkVHUkVTU0lPTihyNzQ5NzEpOiBbUXRdIC9lZGl0aW5nL3Nl
bGVjdGlvbi9jYXJldC1iaWRpLWZpcnN0LWFuZC1sYXN0LWxldHRlcnMuaHRtbCBmYWlscwogIyBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE4ODQKIGVkaXRpbmcvc2Vs
ZWN0aW9uL2NhcmV0LWJpZGktZmlyc3QtYW5kLWxhc3QtbGV0dGVycy5odG1sCg==
</data>
<flag name="review"
          id="71933"
          type_id="1"
          status="+"
          setter="kling"
    />
    <flag name="commit-queue"
          id="71934"
          type_id="3"
          status="-"
          setter="kling"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80457</attachid>
            <date>2011-01-28 09:08:24 -0800</date>
            <delta_ts>2011-01-28 11:16:35 -0800</delta_ts>
            <desc>fix patch 2</desc>
            <filename>36688_2.patch</filename>
            <type>text/plain</type>
            <size>4218</size>
            <attacher name="Chang Shu">cshu</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc2OTQ2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTYgQEAKKzIwMTEtMDEtMjggIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5jb20+CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzZXQgTmV0
d29ya0FjY2Vzc01hbmFnZXIgdG8gY2xlYW4gdXAgY3JlZGVudGlhbHMgZnJvbSBwcmV2aW91cyB0
ZXN0cy4KKyAgICAgICAgVGhpcyBjaGFuZ2UgY2F1c2VzIG5vIHBlcmZvcm1hbmNlIG92ZXJoZWFk
IGVpdGhlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTM2Njg4CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OkR1bXBSZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0
YXRlQmVmb3JlVGVzdGluZyk6CisgICAgICAgIChXZWJDb3JlOjpEdW1wUmVuZGVyVHJlZTo6b3Bl
bik6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5oOgorCiAy
MDExLTAxLTI4ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9x
dC9EdW1wUmVuZGVyVHJlZVF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl
ZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcAkocmV2aXNpb24gNzY3NTUpCisrKyBUb29scy9EdW1w
UmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIw
LDcgKzUyMCw3IEBAIHZvaWQgRHVtcFJlbmRlclRyZWU6OmRyeVJ1blByaW50KFFXZWJGcmEKICNl
bmRpZgogfQogCi12b2lkIER1bXBSZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVm
b3JlVGVzdGluZygpCit2b2lkIER1bXBSZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRl
QmVmb3JlVGVzdGluZyhjb25zdCBRVXJsJiB1cmwpCiB7CiAgICAgLy8gcmVzZXQgc28gdGhhdCBh
bnkgY3VycmVudCBsb2FkcyBhcmUgc3RvcHBlZAogICAgIC8vIE5PVEU6IHRoYXQgdGhpcyBoYXMg
dG8gYmUgZG9uZSBiZWZvcmUgdGhlIGxheW91dFRlc3RDb250cm9sbGVyIGlzCkBAIC01NTAsNiAr
NTUwLDE0IEBAIHZvaWQgRHVtcFJlbmRlclRyZWU6OnJlc2V0VG9Db25zaXN0ZW50U3QKICAgICBt
X3BhZ2UtPm1haW5GcmFtZSgpLT5zZXRTY3JvbGxCYXJQb2xpY3koUXQ6OlZlcnRpY2FsLCBRdDo6
U2Nyb2xsQmFyQXNOZWVkZWQpOwogICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPnNldFNjcm9sbEJh
clBvbGljeShRdDo6SG9yaXpvbnRhbCwgUXQ6OlNjcm9sbEJhckFzTmVlZGVkKTsKIAorICAgIGlm
ICh1cmwuc2NoZW1lKCkgPT0gImh0dHAiIHx8IHVybC5zY2hlbWUoKSA9PSAiaHR0cHMiKSB7Cisg
ICAgICAgIC8vIGNyZWRlbnRpYWxzIG1heSBleGlzdCBmcm9tIHByZXZpb3VzIHRlc3RzLgorICAg
ICAgICBtX3BhZ2UtPnNldE5ldHdvcmtBY2Nlc3NNYW5hZ2VyKDApOworICAgICAgICBkZWxldGUg
bV9uZXR3b3JrQWNjZXNzTWFuYWdlcjsKKyAgICAgICAgbV9uZXR3b3JrQWNjZXNzTWFuYWdlciA9
IG5ldyBOZXR3b3JrQWNjZXNzTWFuYWdlcih0aGlzKTsKKyAgICAgICAgbV9wYWdlLT5zZXROZXR3
b3JrQWNjZXNzTWFuYWdlcihtX25ldHdvcmtBY2Nlc3NNYW5hZ2VyKTsKKyAgICB9CisKICAgICBX
b3JrUXVldWU6OnNoYXJlZCgpLT5jbGVhcigpOwogICAgIFdvcmtRdWV1ZTo6c2hhcmVkKCktPnNl
dEZyb3plbihmYWxzZSk7CiAKQEAgLTU4Myw3ICs1OTEsNyBAQCBzdGF0aWMgYm9vbCBpc1dlYklu
c3BlY3RvclRlc3QoY29uc3QgUVVyCiB2b2lkIER1bXBSZW5kZXJUcmVlOjpvcGVuKGNvbnN0IFFV
cmwmIHVybCkKIHsKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6ZHVtcFJlc291cmNlTG9h
ZENhbGxiYWNrc1BhdGgoUUZpbGVJbmZvKHVybC50b1N0cmluZygpKS5wYXRoKCkpOwotICAgIHJl
c2V0VG9Db25zaXN0ZW50U3RhdGVCZWZvcmVUZXN0aW5nKCk7CisgICAgcmVzZXRUb0NvbnNpc3Rl
bnRTdGF0ZUJlZm9yZVRlc3RpbmcodXJsKTsKIAogICAgIGlmIChpc1dlYkluc3BlY3RvclRlc3Qo
bV9wYWdlLT5tYWluRnJhbWUoKS0+dXJsKCkpKQogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl
cigpLT5jbG9zZVdlYkluc3BlY3RvcigpOwpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv
RHVtcFJlbmRlclRyZWVRdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0
L0R1bXBSZW5kZXJUcmVlUXQuaAkocmV2aXNpb24gNzY3NTUpCisrKyBUb29scy9EdW1wUmVuZGVy
VHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmgJKHdvcmtpbmcgY29weSkKQEAgLTg2LDcgKzg2LDcg
QEAgcHVibGljOgogICAgIHZvaWQgc2V0RHVtcFBpeGVscyhib29sKTsKIAogICAgIHZvaWQgY2xv
c2VSZW1haW5pbmdXaW5kb3dzKCk7Ci0gICAgdm9pZCByZXNldFRvQ29uc2lzdGVudFN0YXRlQmVm
b3JlVGVzdGluZygpOworICAgIHZvaWQgcmVzZXRUb0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3Rp
bmcoY29uc3QgUVVybCYpOwogCiAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIgKmxheW91dFRlc3RD
b250cm9sbGVyKCkgY29uc3QgeyByZXR1cm4gbV9jb250cm9sbGVyOyB9CiAgICAgRXZlbnRTZW5k
ZXIgKmV2ZW50U2VuZGVyKCkgY29uc3QgeyByZXR1cm4gbV9ldmVudFNlbmRlcjsgfQpJbmRleDog
TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv
ZwkocmV2aXNpb24gNzY5NDYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w
eSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wMS0yOCAgQ2hhbmcgU2h1ICA8Y2hhbmcuc2h1QG5v
a2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBVbnNraXBwIGF1dGguaHRtbCBhZnRlciBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjY4OAorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tp
cHBlZDoKKwogMjAxMS0wMS0yNyAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAg
ICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRm
b3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tp
cHBlZAkocmV2aXNpb24gNzY3NTUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk
CSh3b3JraW5nIGNvcHkpCkBAIC00OTY4LDEwICs0OTY4LDYgQEAgaHR0cC90ZXN0cy9sb2NhbC9s
aW5rLXN0eWxlc2hlZXQtbG9hZC1vcgogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTEzMjQKIGZhc3QvdGV4dC9lbXBoYXNpcy1vdmVybGFwLmh0bWwKIAotI1tRdF0g
TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9hdXRoLmh0bWwgZmFpbGVkIGFuZCBza2lw
cGVkCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjY4OAotaHR0
cC90ZXN0cy9hcHBjYWNoZS9hdXRoLmh0bWwKLQogIyBSRUdSRVNTSU9OKHI3NDk3MSk6IFtRdF0g
L2VkaXRpbmcvc2VsZWN0aW9uL2NhcmV0LWJpZGktZmlyc3QtYW5kLWxhc3QtbGV0dGVycy5odG1s
IGZhaWxzCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTg4NAog
ZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtYmlkaS1maXJzdC1hbmQtbGFzdC1sZXR0ZXJzLmh0bWwK
</data>

          </attachment>
      

    </bug>

</bugzilla>