36687 2010-03-26 18:25:58 -0700 change new-run-webkit-tests to not use more than 4 threads by default on the Mac port 2010-03-29 15:35:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke cjerdonek eric mmoss oldest_to_newest 204895 0 dpranke 2010-03-26 18:25:58 -0700 new-run-webkit-tests seems to be unstable w/ more than 4 threads running in parallel (see bug 36622). Change the default until that bug is fixed. 204897 1 51803 dpranke 2010-03-26 18:27:38 -0700 Created attachment 51803 Patch 205030 2 cjerdonek 2010-03-27 12:44:08 -0700 How does this issue relate to this code? http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121 205265 3 dpranke 2010-03-28 17:21:41 -0700 (In reply to comment #2) > How does this issue relate to this code? > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121 new-run-webkit-tests doesn't use that code, and I have no idea where that code is used. I'm not sure if that answers your questin? 205268 4 cjerdonek 2010-03-28 17:32:29 -0700 (In reply to comment #3) > (In reply to comment #2) > > How does this issue relate to this code? > > > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121 > > new-run-webkit-tests doesn't use that code, and I have no idea where that code > is used. I'm not sure if that answers your questin? Superficially, it looks like we have two ways of getting the CPU (core?) count in our code base. If they are doing the same thing, we might want to combine those code paths. 205530 5 dpranke 2010-03-29 10:47:09 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > How does this issue relate to this code? > > > > > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py#L121 > > > > new-run-webkit-tests doesn't use that code, and I have no idea where that code > > is used. I'm not sure if that answers your questin? > > Superficially, it looks like we have two ways of getting the CPU (core?) count > in our code base. If they are doing the same thing, we might want to combine > those code paths. Yes, you are correct. There's a lot of duplication between the port/* interface and code written outside of the layout_tests directory, and we haven't really tried to reduce that yet. Nobody has yet proposed what the right structure is, and I've been mostly focused on simply getting the new-run-webkit-tests to be bug-free and feature-equivalent to the Perl code. 205626 6 51803 dglazkov 2010-03-29 13:15:07 -0700 Comment on attachment 51803 Patch ok. 205707 7 51803 dpranke 2010-03-29 15:35:43 -0700 Comment on attachment 51803 Patch Clearing flags on attachment: 51803 Committed r56746: <http://trac.webkit.org/changeset/56746> 205708 8 dpranke 2010-03-29 15:35:48 -0700 All reviewed patches have been landed. Closing bug. 51803 2010-03-26 18:27:38 -0700 2010-03-29 15:35:43 -0700 Patch bug-36687-20100326182736.patch text/plain 1553 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2YjRlM2RhLi4wYmM0YjBlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTAtMDMt MjYgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIG5ldy1ydW4td2Via2l0LXRl c3RzIHRvIG5vdCB1c2UgbW9yZSB0aGFuIGZvdXIgdGhyZWFkcyBieQorICAgICAgICBkZWZhdWx0 IG9uIHRoZSBtYWMgcG9ydCB1bnRpbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzY2MjIgaXMgZml4ZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2Njg3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weToKKworMjAxMC0wMy0yNiAgRGlyayBQcmFua2Ug IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRl bC4KIAogICAgICAgICBDaGFuZ2UgdGhlIE1hYyBwb3J0IG9mIG5ldy1ydW4td2Via2l0LXRlc3Rz IHRvIGxvb2sgZm9yIGEKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKaW5kZXggYzVkMjE5MC4uMGMzOTI4ZSAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMu cHkKQEAgLTE1NSw3ICsxNTUsMTMgQEAgY2xhc3MgTWFjUG9ydChiYXNlLlBvcnQpOgogICAgICAg ICByZXR1cm4gcmVzdWx0CiAKICAgICBkZWYgbnVtX2NvcmVzKHNlbGYpOgotICAgICAgICByZXR1 cm4gaW50KG9zLnBvcGVuMigic3lzY3RsIC1uIGh3Lm5jcHUiKVsxXS5yZWFkKCkpCisgICAgICAg IG5jb3JlcyA9IGludChvcy5wb3BlbjIoInN5c2N0bCAtbiBody5uY3B1IilbMV0ucmVhZCgpKQor ICAgICAgICAjIEZJWE1FOiBuZXctcnVuLXdlYmtpdC10ZXN0cyBpcyB1bnN0YWJsZSBydW5uaW5n IG1vcmUgdGhhbiBmb3VyCisgICAgICAgICMgdGhyZWFkcyBpbiBwYXJhbGxlbC4KKyAgICAgICAg IyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjIyCisgICAg ICAgIGlmIG5jb3JlcyA+IDQ6CisgICAgICAgICAgICBuY29yZXMgPSA0CisgICAgICAgIHJldHVy biBuY29yZXMKIAogICAgIGRlZiBwYXRoX3RvX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUoc2VsZik6 CiAgICAgICAgIHJldHVybiBzZWxmLnBhdGhfZnJvbV93ZWJraXRfYmFzZSgnTGF5b3V0VGVzdHMn LCAncGxhdGZvcm0nLAo=