36672 2010-03-26 12:41:34 -0700 Assertion failure: !repaintContainer || repaintContainer == this 2010-04-01 11:19:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://www.floreysoft.net/#main2product0sharedcontacts1 P2 Normal --- 1 ap simon.fraser mitz simon.fraser oldest_to_newest 204719 0 ap 2010-03-26 12:41:34 -0700 Opening http://www.floreysoft.net/#main2product0sharedcontacts1 ASSERTION FAILED: !repaintContainer || repaintContainer == this (/Volumes/Data/Safari/OpenSource/WebCore/rendering/RenderView.cpp:266 virtual void WebCore::RenderView::computeRectForRepaint(WebCore::RenderBoxModelObject*, WebCore::IntRect&, bool)) 204721 1 ap 2010-03-26 12:42:13 -0700 With r56633. 204871 2 simon.fraser 2010-03-26 17:16:08 -0700 I can't reproduce this. I don't see any compositing stuff on this page at all. 204873 3 ap 2010-03-26 17:35:17 -0700 I can still reproduce with ToT, r56648. 205046 4 ap 2010-03-27 13:33:13 -0700 FWIW, this didn't happen for me under Fast Malloc. 205696 5 simon.fraser 2010-03-29 15:25:53 -0700 Alexey: are you reproducing in a normal debug build? 205709 6 ap 2010-03-29 15:36:48 -0700 Oops, comment 4 was meant to say "cannot reproduce under Guard Malloc". I can reproduce with normal debug build. 206174 7 simon.fraser 2010-03-30 14:10:49 -0700 I can reproduce now. 206202 8 52087 simon.fraser 2010-03-30 15:14:37 -0700 Created attachment 52087 Testcase 206817 9 simon.fraser 2010-03-31 16:42:56 -0700 The problem here is that RenderText::clippedOverflowRectForRepaint() is calling containingBlock(), which skips the repaint container. 207255 10 52313 simon.fraser 2010-04-01 11:11:40 -0700 Created attachment 52313 Patch 207259 11 52313 mitz 2010-04-01 11:15:12 -0700 Comment on attachment 52313 Patch > + Test for repainting where the repaintContainer is a descendent of the containing block. Google says: Did you mean: descendant > + So in this case, check to see whether repaintContainer is actually a descendent of the Ditto. 207265 12 simon.fraser 2010-04-01 11:19:40 -0700 http://trac.webkit.org/changeset/56924 52087 2010-03-30 15:14:37 -0700 2010-03-30 15:14:37 -0700 Testcase inline-repaint.html text/html 785 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBt ZWRpYT0ic2NyZWVuIj4KICAgICN0ZXN0IHsKICAgICAgICBwb3NpdGlvbjogcmVsYXRpdmU7CiAg ICB9CiAgICAKICAgIC5jb21wb3NpdGVkIHsKICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAg ICAgICAgd2lkdGg6IDIwMHB4OwogICAgICAgIGhlaWdodDogMTAwcHg7CiAgICAgICAgYm9yZGVy OiAxcHggc29saWQgYmxhY2s7CiAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZVoo MCk7CiAgICB9CiAgPC9zdHlsZT4KICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hh cnNldD0idXRmLTgiPgogICAgCiAgICBmdW5jdGlvbiBkb1Rlc3QoKQogICAgewogICAgICAgIHdp bmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewogICAgICAgICAgICB2YXIgdGVzdE5vZGUgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpOwogICAgICAgICAgICB0ZXN0Tm9kZS5yZW1v dmVDaGlsZCh0ZXN0Tm9kZS5maXJzdENoaWxkKTsKICAgICAgICB9LCAwKTsKICAgIH0KICAgIAog ICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBkb1Rlc3QsIGZhbHNlKTsKICA8L3Nj cmlwdD4KPC9oZWFkPgo8Ym9keT4KICAKICAgIDxwPlRoaXMgc2hvdWxkIG5vdCBhc3NlcnQgaW4g ZGVidWcgYnVpbGRzLjwvcD4KICAgIDxkaXYgY2xhc3M9ImNvbXBvc2l0ZWQiPjwvZGl2PgogICAg PHNwYW4gaWQ9InRlc3QiPnRlc3Q8L3NwYW4+CjwvYm9keT4KPC9odG1sPgo= 52313 2010-04-01 11:11:40 -0700 2010-04-01 11:15:11 -0700 Patch bug-36672-20100401111138.patch text/plain 4267 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2YjU2NDM3Li5hNmU3OGMwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MDEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmU6ICFy ZXBhaW50Q29udGFpbmVyIHx8IHJlcGFpbnRDb250YWluZXIgPT0gdGhpcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2NzIKKyAgICAgICAgCisgICAg ICAgIFRlc3QgZm9yIHJlcGFpbnRpbmcgd2hlcmUgdGhlIHJlcGFpbnRDb250YWluZXIgaXMgYSBk ZXNjZW5kZW50IG9mIHRoZSBjb250YWluaW5nIGJsb2NrLgorCisgICAgICAgICogY29tcG9zaXRp bmcvcmVwYWludC9pbmxpbmUtcmVwYWludC1jb250YWluZXItZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBjb21wb3NpdGluZy9yZXBhaW50L2lubGluZS1yZXBhaW50LWNvbnRhaW5lci5o dG1sOiBBZGRlZC4KKwogMjAxMC0wMy0zMCAgQWRhbSBMYW5nbGV5ICA8YWdsQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2NvbXBvc2l0aW5nL3JlcGFpbnQvaW5saW5lLXJlcGFpbnQtY29udGFpbmVyLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3JlcGFpbnQvaW5saW5lLXJlcGFpbnQt Y29udGFpbmVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li5jZTU4ZWRmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvcmVw YWludC9pbmxpbmUtcmVwYWludC1jb250YWluZXItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBA QAorVGhpcyBzaG91bGQgbm90IGFzc2VydCBpbiBkZWJ1ZyBidWlsZHMuCisKK3Rlc3QKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3JlcGFpbnQvaW5saW5lLXJlcGFpbnQtY29u dGFpbmVyLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9yZXBhaW50L2lubGluZS1yZXBh aW50LWNvbnRhaW5lci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmMw MjZmMzUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9yZXBhaW50 L2lubGluZS1yZXBhaW50LWNvbnRhaW5lci5odG1sCkBAIC0wLDAgKzEsNDAgQEAKKzwhRE9DVFlQ RSBodG1sPgorCis8aHRtbD4KKzxoZWFkPgorICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlh PSJzY3JlZW4iPgorICAgIHNwYW4geworICAgICAgICBwb3NpdGlvbjogcmVsYXRpdmU7CisgICAg ICAgIHBhZGRpbmc6IDEwcHg7CisgICAgfQorICAgIAorICAgIC5jb21wb3NpdGVkIHsKKyAgICAg ICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICB3aWR0aDogMjAwcHg7CisgICAgICAgIGhl aWdodDogMTAwcHg7CisgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOworICAgICAgICAt d2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWigwKTsKKyAgICB9CisgIDwvc3R5bGU+CisgIDxz Y3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+CisgICAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEFzVGV4dCgpOworCisgICAgZnVuY3Rpb24gZG9UZXN0KCkKKyAgICB7CisgICAgICAgIHdp bmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgdmFyIHRlc3ROb2RlID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKKyAgICAgICAgICAgIHRlc3ROb2RlLnJl bW92ZUNoaWxkKHRlc3ROb2RlLmZpcnN0Q2hpbGQpOworICAgICAgICB9LCAwKTsKKyAgICB9Cisg ICAgCisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBkb1Rlc3QsIGZhbHNlKTsK KyAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgCisgICAgPHA+VGhpcyBzaG91bGQgbm90 IGFzc2VydCBpbiBkZWJ1ZyBidWlsZHMuPC9wPgorICAgIDxkaXYgY2xhc3M9ImNvbXBvc2l0ZWQi PjwvZGl2PgorICAgIDxzcGFuIGlkPSJ0ZXN0Ij50ZXN0PC9zcGFuPgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAxZjEwZDM4Li41MGExMzliIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEwLTA0LTAxICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlOiAhcmVwYWludENvbnRhaW5l ciB8fCByZXBhaW50Q29udGFpbmVyID09IHRoaXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjcyCisgICAgICAgIAorICAgICAgICBSZW5kZXJUZXh0 J3MgaW1wbGVtZW50YXRpb24gb2YgY2xpcHBlZE92ZXJmbG93UmVjdEZvclJlcGFpbnQoKSB1c2Vz IGNvbnRhaW5pbmdCbG9jaygpCisgICAgICAgIHRvIGdldCB0aGUgcmVuZGVyZXIgdG8gdXNlIGZv ciBjb21wdXRpbmcgdGhlIHJlcGFpbnQgcmVjdC4gSG93ZXZlciwgdGhlIHJlbmRlcmVyIHJldHVy bmVkCisgICAgICAgIGJ5IGNvbnRhaW5pbmdCbG9jaygpIG1heSBiZSBhbiBhbmNlc3RvciBvZiB0 aGUgcmVwYWludENvbnRhaW5lciwgYW5kIGNvbnRhaW5pbmdCbG9jaygpCisgICAgICAgIGRvZXNu J3QgaGF2ZSB0aGUgJ3JlcGFpbnRDb250YWluZXJTa2lwcGVkJyBsb2dpYyB0aGF0IGNvbnRhaW5l cigpIGhhcy4KKyAgICAgICAgCisgICAgICAgIFNvIGluIHRoaXMgY2FzZSwgY2hlY2sgdG8gc2Vl IHdoZXRoZXIgcmVwYWludENvbnRhaW5lciBpcyBhY3R1YWxseSBhIGRlc2NlbmRlbnQgb2YgdGhl CisgICAgICAgIGNvbnRhaW5pbmcgYmxvY2ssIGFuZCBpbiB0aGF0IGNhc2UganVzdCByZXBhaW50 IHRoZSBlbnRpcmUgcmVwYWludENvbnRhaW5lci4KKworICAgICAgICBUZXN0OiBjb21wb3NpdGlu Zy9yZXBhaW50L2lubGluZS1yZXBhaW50LWNvbnRhaW5lci5odG1sCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0OjpjbGlw cGVkT3ZlcmZsb3dSZWN0Rm9yUmVwYWludCk6CisKIDIwMTAtMDMtMzAgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCmluZGV4IGFhOTE5ZTAuLjZlMjY5OTMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwCkBAIC0xMTQ5LDYgKzExNDksMTEgQEAgSW50UmVjdCBSZW5kZXJU ZXh0OjpsaW5lc0JvdW5kaW5nQm94KCkgY29uc3QKIEludFJlY3QgUmVuZGVyVGV4dDo6Y2xpcHBl ZE92ZXJmbG93UmVjdEZvclJlcGFpbnQoUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250 YWluZXIpCiB7CiAgICAgUmVuZGVyT2JqZWN0KiBjYiA9IGNvbnRhaW5pbmdCbG9jaygpOworICAg IC8vIFRoZSBjb250YWluaW5nIGJsb2NrIG1heSBiZSBhbiBhbmNlc3RvciBvZiByZXBhaW50Q29u dGFpbmVyLCBidXQgd2UgbmVlZCB0byBkbyBhIHJlcGFpbnRDb250YWluZXItcmVsYXRpdmUgcmVw YWludC4KKyAgICBpZiAocmVwYWludENvbnRhaW5lciAmJiByZXBhaW50Q29udGFpbmVyICE9IGNi KSB7CisgICAgICAgIGlmICghY2ItPmlzRGVzY2VuZGFudE9mKHJlcGFpbnRDb250YWluZXIpKQor ICAgICAgICAgICAgcmV0dXJuIHJlcGFpbnRDb250YWluZXItPmNsaXBwZWRPdmVyZmxvd1JlY3RG b3JSZXBhaW50KHJlcGFpbnRDb250YWluZXIpOworICAgIH0KICAgICByZXR1cm4gY2ItPmNsaXBw ZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50KHJlcGFpbnRDb250YWluZXIpOwogfQogCg==