36669 2010-03-26 11:12:57 -0700 Use WebKitClient to instantiate WebGraphicsContext3D 2010-03-27 21:17:20 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr darin dglazkov fishd zmo oldest_to_newest 204686 0 kbr 2010-03-26 11:12:57 -0700 In order to create a browser-specific WebGraphicsContext3D instance, WebKitClient::createGraphicsContext3D() needs to be used to instantiate it rather than WebGraphicsContext3D::createDefault(). 204689 1 51764 kbr 2010-03-26 11:16:50 -0700 Created attachment 51764 Patch Note to reviewers: please don't cq+ this; Chromium changes need to land first. Want to get this ready to land, though. 204692 2 darin 2010-03-26 11:21:54 -0700 (In reply to comment #1) > Note to reviewers: please don't cq+ this; Chromium changes need to land first. > Want to get this ready to land, though. Setting cq- on a patch is another way to indicate that. 204696 3 51764 fishd 2010-03-26 11:39:07 -0700 Comment on attachment 51764 Patch > Index: WebKit/chromium/src/GraphicsContext3D.cpp ... > + WebKit::WebGraphicsContext3D* webContext = WebKit::webKitClient()->createGraphicsContext3D(); R=me, but please note (and sorry for not noting this before) that we typically add a 'using namespace WebKit' at the top of .cpp files like this so that we don't need the WebKit:: prefix everywhere. 205098 4 51764 kbr 2010-03-27 21:17:16 -0700 Comment on attachment 51764 Patch Clearing flags on attachment: 51764 Committed r56678: <http://trac.webkit.org/changeset/56678> 205099 5 kbr 2010-03-27 21:17:20 -0700 All reviewed patches have been landed. Closing bug. 51764 2010-03-26 11:16:50 -0700 2010-03-27 21:17:16 -0700 Patch webkitclient.patch text/plain 1515 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTY2MzQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMjYgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBXZWJLaXRDbGllbnQgdG8gaW5zdGFudGlhdGUgV2Vi R3JhcGhpY3NDb250ZXh0M0QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM2NjY5CisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6aW5pdGlhbGl6ZSk6 CisKIDIwMTAtMDMtMjYgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0L2Nocm9taXVt L3NyYy9HcmFwaGljc0NvbnRleHQzRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVt L3NyYy9HcmFwaGljc0NvbnRleHQzRC5jcHAJKHJldmlzaW9uIDU2NjMxKQorKysgV2ViS2l0L2No cm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzNSw5 ICszMzUsNyBAQCBib29sIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OmluaXRpYWxpCiAgICAg d2ViQXR0cmlidXRlcy5zdGVuY2lsID0gYXR0cnMuc3RlbmNpbDsKICAgICB3ZWJBdHRyaWJ1dGVz LmFudGlhbGlhcyA9IGF0dHJzLmFudGlhbGlhczsKICAgICB3ZWJBdHRyaWJ1dGVzLnByZW11bHRp cGxpZWRBbHBoYSA9IGF0dHJzLnByZW11bHRpcGxpZWRBbHBoYTsKLSAgICAvLyBGSVhNRTogb25j ZSB0aGUgQ2hyb21pdW0gcG9ydGlvbiBvZiB0aGUgV2ViS2l0Q2xpZW50IGNoYW5nZXMgaGFzIGxh bmRlZCwKLSAgICAvLyBjaGFuZ2UgdGhpcyB0byBjYWxsIFdlYktpdDo6d2ViS2l0Q2xpZW50KCkt PmNyZWF0ZUdyYXBoaWNzQ29udGV4dDNEKCkuCi0gICAgV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRl eHQzRCogd2ViQ29udGV4dCA9IFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0Q6OmNyZWF0ZURl ZmF1bHQoKTsKKyAgICBXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEKiB3ZWJDb250ZXh0ID0g V2ViS2l0Ojp3ZWJLaXRDbGllbnQoKS0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0M0QoKTsKICAgICBp ZiAoIXdlYkNvbnRleHQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIXdlYkNvbnRl eHQtPmluaXRpYWxpemUod2ViQXR0cmlidXRlcykpIHsK