36656 2010-03-26 04:51:53 -0700 [GStreamer] player header cleanups 2010-03-29 00:37:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 204503 0 pnormand 2010-03-26 04:51:53 -0700 The destructor should be private and the mediaPlayerPrivateMuteChangedCallback is not declared. 204506 1 51728 pnormand 2010-03-26 05:06:17 -0700 Created attachment 51728 player header cleanups 205315 2 pnormand 2010-03-29 00:37:51 -0700 Landed in r56709. Thanks! 51728 2010-03-26 05:06:17 -0700 2010-03-26 13:41:43 -0700 player header cleanups player-header-cleanups.patch text/plain 2441 pnormand RnJvbSBlMzliYjIyOTRiZTZmNDhiZGM0MjZkM2NmZGE3ZWI2MGI5NjJmM2FlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDI2IE1hciAyMDEwIDEzOjA1OjUwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGxheWVyIGhlYWRlciBjbGVhbnVwcwoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oICAgICAgICB8ICAgIDMgKystCiAyIGZpbGVz IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5N2JhNDUxLi5iYmJj ZWJhIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTAzLTI2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1h bmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbR1N0cmVhbWVyXSBwbGF5ZXIgaGVhZGVyIGNsZWFudXBzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjY1NgorCisgICAgICAgIERlc3Ry dWN0b3IgbWFkZSBwcml2YXRlIGFuZCBhZGRlZCBtaXNzaW5nCisgICAgICAgIG1lZGlhUGxheWVy UHJpdmF0ZU11dGVDaGFuZ2VkQ2FsbGJhY2sgZGVjbGFyYXRpb24uCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmg6CisK IDIwMTAtMDMtMDggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5o IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmgKaW5kZXggYWI4ZWUwMS4uYzhkMjM0NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmgKQEAgLTQ2LDYgKzQ2LDcgQEAgY2xhc3MgU3RyaW5nOwogCiBnYm9vbGVh biBtZWRpYVBsYXllclByaXZhdGVNZXNzYWdlQ2FsbGJhY2soR3N0QnVzKiBidXMsIEdzdE1lc3Nh Z2UqIG1lc3NhZ2UsIGdwb2ludGVyIGRhdGEpOwogdm9pZCBtZWRpYVBsYXllclByaXZhdGVWb2x1 bWVDaGFuZ2VkQ2FsbGJhY2soR09iamVjdCogZWxlbWVudCwgR1BhcmFtU3BlYyogcHNwZWMsIGdw b2ludGVyIGRhdGEpOwordm9pZCBtZWRpYVBsYXllclByaXZhdGVNdXRlQ2hhbmdlZENhbGxiYWNr KEdPYmplY3QqIGVsZW1lbnQsIEdQYXJhbVNwZWMqIHBzcGVjLCBncG9pbnRlciBkYXRhKTsKIHZv aWQgbWVkaWFQbGF5ZXJQcml2YXRlU291cmNlQ2hhbmdlZENhbGxiYWNrKEdPYmplY3QqIGVsZW1l bnQsIEdQYXJhbVNwZWMqIHBzcGVjLCBncG9pbnRlciBkYXRhKTsKIAogY2xhc3MgTWVkaWFQbGF5 ZXJQcml2YXRlIDogcHVibGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CkBAIC01NSw3 ICs1Niw2IEBAIGNsYXNzIE1lZGlhUGxheWVyUHJpdmF0ZSA6IHB1YmxpYyBNZWRpYVBsYXllclBy aXZhdGVJbnRlcmZhY2UgewogCiAgICAgICAgIHB1YmxpYzoKICAgICAgICAgICAgIHN0YXRpYyB2 b2lkIHJlZ2lzdGVyTWVkaWFFbmdpbmUoTWVkaWFFbmdpbmVSZWdpc3RyYXIpOwotICAgICAgICAg ICAgfk1lZGlhUGxheWVyUHJpdmF0ZSgpOwogCiAgICAgICAgICAgICBJbnRTaXplIG5hdHVyYWxT aXplKCkgY29uc3Q7CiAgICAgICAgICAgICBib29sIGhhc1ZpZGVvKCkgY29uc3Q7CkBAIC0xMjIs NiArMTIyLDcgQEAgY2xhc3MgTWVkaWFQbGF5ZXJQcml2YXRlIDogcHVibGljIE1lZGlhUGxheWVy UHJpdmF0ZUludGVyZmFjZSB7CiAKICAgICAgICAgcHJpdmF0ZToKICAgICAgICAgICAgIE1lZGlh UGxheWVyUHJpdmF0ZShNZWRpYVBsYXllciopOworICAgICAgICAgICAgfk1lZGlhUGxheWVyUHJp dmF0ZSgpOwogICAgICAgICAgICAgc3RhdGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSog Y3JlYXRlKE1lZGlhUGxheWVyKiBwbGF5ZXIpOwogCiAgICAgICAgICAgICBzdGF0aWMgdm9pZCBn ZXRTdXBwb3J0ZWRUeXBlcyhIYXNoU2V0PFN0cmluZz4mKTsKLS0gCjEuNi4zLjM=