36653 2010-03-26 04:06:01 -0700 [GStreamer] define static variables with DEFINE_STATIC_LOCAL macro 2010-03-29 00:41:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned webkit.review.bot oldest_to_newest 204493 0 pnormand 2010-03-26 04:06:01 -0700 In mimeTypeCache() the 2 static vars should be defined with DEFINE_STATIC_LOCAL otherwise this code won't compile on Mac OS. See also JavaScriptCore/wtf/StdLibExtras.h 204496 1 51726 pnormand 2010-03-26 04:17:59 -0700 Created attachment 51726 proposed patch 204497 2 webkit.review.bot 2010-03-26 04:20:27 -0700 Attachment 51726 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 205316 3 pnormand 2010-03-29 00:41:20 -0700 Landed in r56710. Thanks! 51726 2010-03-26 04:17:59 -0700 2010-03-26 13:41:23 -0700 proposed patch proposed-patch.patch text/plain 1739 pnormand RnJvbSA4MDk2OTE0OTdkNTIxZDhhYjE5NTZhNWYyZDJhYjg5MzE5NmJlZDZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDI2IE1hciAyMDEwIDEyOjE3OjM2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdl ZCwgMTQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDk3YmE0NTEuLjQ3YzM2OTkgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTAtMDMtMjYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtHU3RyZWFtZXJdIGRlZmluZSBzdGF0aWMgdmFyaWFibGVzIHdpdGggREVGSU5FX1NUQVRJQ19M T0NBTCBtYWNybworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzY2NTMKKworCURlZmluZWQgdGhlIHN0YXRpYyB2YXJpYWJsZXMgdXNpbmcgREVGSU5FX1NU QVRJQ19HTE9CQUwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1pbWVUeXBl Q2FjaGUpOgorCiAyMDEwLTAzLTA4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBmZjRhOTkyLi42MmI5OGQwIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTEyMjMsOCArMTIyMyw4IEBAIHN0 YXRpYyBIYXNoU2V0PFN0cmluZz4gbWltZVR5cGVDYWNoZSgpCiAKICAgICBkb0dzdEluaXQoKTsK IAotICAgIHN0YXRpYyBIYXNoU2V0PFN0cmluZz4gY2FjaGU7Ci0gICAgc3RhdGljIGJvb2wgdHlw ZUxpc3RJbml0aWFsaXplZCA9IGZhbHNlOworICAgIERFRklORV9TVEFUSUNfTE9DQUwoSGFzaFNl dDxTdHJpbmc+LCBjYWNoZSwgKCkpOworICAgIERFRklORV9TVEFUSUNfTE9DQUwoYm9vbCwgdHlw ZUxpc3RJbml0aWFsaXplZCwgKGZhbHNlKSk7CiAKICAgICBpZiAoIXR5cGVMaXN0SW5pdGlhbGl6 ZWQpIHsKICAgICAgICAgLy8gQnVpbGQgYSB3aGl0ZWxpc3Qgb2YgbWltZS10eXBlcyBrbm93biB0 byBiZSBzdXBwb3J0ZWQgYnkKLS0gCjEuNi4zLjM=