36648 2010-03-26 02:07:14 -0700 [WML] WML enabled build failure. 2010-04-05 23:20:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 nayankk webkit-unassigned commit-queue gyuyoung.kim webkit.review.bot oldest_to_newest 204473 0 nayankk 2010-03-26 02:07:14 -0700 WML enabled builds are failing with following errors, DerivedSources/WMLElementFactory.cpp: In function ‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::optionConstructor(const WebCore::QualifiedName&, WebCore::Document*, bool)’: DerivedSources/WMLElementFactory.cpp:154: error: cannot allocate an object of abstract type ‘WebCore::WMLOptionElement’ ./WebCore/wml/WMLOptionElement.h:31: note: because the following virtual functions are pure within ‘WebCore::WMLOptionElement’: ./WebCore/dom/OptionElement.h:37: note: virtual bool WebCore::OptionElement::disabled() const DerivedSources/WMLElementFactory.cpp: In function ‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::selectConstructor(const WebCore::QualifiedName&, WebCore::Document*, bool)’: DerivedSources/WMLElementFactory.cpp:179: error: cannot allocate an object of abstract type ‘WebCore::WMLSelectElement’ ./WebCore/wml/WMLSelectElement.h:30: note: because the following virtual functions are pure within ‘WebCore::WMLSelectElement’: ./WebCore/dom/SelectElement.h:64: note: virtual void WebCore::SelectElement::listBoxSelectItem(int, bool, bool, bool) make[1]: *** [DerivedSources/libwebkit_1_0_la-WMLElementFactory.lo] Error 1 204474 1 nayankk 2010-03-26 02:10:03 -0700 This build failures are due to the following changesets, http://trac.webkit.org/changeset/56041 http://trac.webkit.org/changeset/56180 These changesets make OptionElement::disabled() and SelectElement::listBoxSelectItem pure virtual. But, WMLOptionElement and WMLSelectElement derived from these classes doesn't contain the implementation for these pure virtual function, hence resulting in build failure. 204476 2 51720 nayankk 2010-03-26 02:18:42 -0700 Created attachment 51720 Build failure fix 204762 3 51720 eric 2010-03-26 13:39:45 -0700 Comment on attachment 51720 Build failure fix Our preferred style is to always mark virtual methods as virtual. Thus listBoxSelectItem should have virtual in its declaration. 204967 4 51821 nayankk 2010-03-27 01:57:34 -0700 Created attachment 51821 Patch with review comments incorporated. 207715 5 51821 eric 2010-04-01 23:37:20 -0700 Comment on attachment 51821 Patch with review comments incorporated. OK. It seems these could have just as well been in the header, but OK. 207813 6 51821 commit-queue 2010-04-02 01:50:17 -0700 Comment on attachment 51821 Patch with review comments incorporated. Rejecting patch 51821 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12613 test cases. fast/canvas/webgl/index-validation.html -> failed Exiting early after 1 failures. 5081 tests run. 88.21s total testing time 5080 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1607151 208170 7 51821 eric 2010-04-02 17:18:05 -0700 Comment on attachment 51821 Patch with review comments incorporated. Flaky test. 208192 8 51821 commit-queue 2010-04-02 18:03:31 -0700 Comment on attachment 51821 Patch with review comments incorporated. Clearing flags on attachment: 51821 Committed r57038: <http://trac.webkit.org/changeset/57038> 208193 9 commit-queue 2010-04-02 18:03:35 -0700 All reviewed patches have been landed. Closing bug. 208197 10 webkit.review.bot 2010-04-02 19:18:31 -0700 http://trac.webkit.org/changeset/57039 might have broken Leopard Intel Debug (Tests) 208913 11 gyuyoung.kim 2010-04-05 23:20:14 -0700 There are build breaks as below because of duplicate patches. Even though the patch of bug below already was puahed to trunk, this patch was landed again. There are build breaks when wml is enabled. (https://bugs.webkit.org/show_bug.cgi?id=36698). ----------------------------------------------------------------------------- In file included from WebCore/dom/OptionElement.cpp:34: ./WebCore/wml/WMLOptionElement.h:59: error: ‘virtual bool WebCore::WMLOptionElement::disabled() const’ cannot be overloaded ./WebCore/wml/WMLOptionElement.h:44: error: with ‘virtual bool WebCore::WMLOptionElement::disabled() const’ In file included from WebCore/dom/SelectElement.cpp:48: ./WebCore/wml/WMLSelectElement.h:92: error: ‘virtual void WebCore::WMLSelectElement::listBoxSelectItem(int, bool, bool, bool)’ cannot be overloaded ./WebCore/wml/WMLSelectElement.h:90: error: with ‘virtual void WebCore::WMLSelectElement::listBoxSelectItem(int, bool, bool, bool)’ CXX WebCore/dom/libwebkit_1_0_la-SelectorNodeList.lo make[1]: *** [WebCore/dom/libwebkit_1_0_la-SelectElement.lo] -------------------------------------------------------------------------------- It seems to me that one of patches should be removed. 51720 2010-03-26 02:18:42 -0700 2010-03-27 01:57:34 -0700 Build failure fix BuildFailureFix.patch text/plain 2810 nayankk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjYxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDMtMjYgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIFdNTCBlbmFibGVkIGJ1aWxkIGZhaWx1cmUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjQ4CisKKyAgICAgICAgKiB3bWwvV01MT3B0 aW9uRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxPcHRpb25FbGVtZW50OjpkaXNh YmxlZCk6CisgICAgICAgICogd21sL1dNTE9wdGlvbkVsZW1lbnQuaDoKKyAgICAgICAgKiB3bWwv V01MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxTZWxlY3RFbGVtZW50 OjpsaXN0Qm94U2VsZWN0SXRlbSk6CisgICAgICAgICogd21sL1dNTFNlbGVjdEVsZW1lbnQuaDoK KwogMjAxMC0wMy0wOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpJbmRleDogV2ViQ29yZS93bWwv V01MT3B0aW9uRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS93bWwvV01MT3B0aW9u RWxlbWVudC5jcHAJKHJldmlzaW9uIDU2NjE1KQorKysgV2ViQ29yZS93bWwvV01MT3B0aW9uRWxl bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MCw2ICsxNzAsMTIgQEAgdm9pZCBXTUxPcHRp b25FbGVtZW50OjpoYW5kbGVJbnRyaW5zaWNFdgogICAgICAgICBldmVudEhhbmRsZXItPnRyaWdn ZXJJbnRyaW5zaWNFdmVudChXTUxJbnRyaW5zaWNFdmVudE9uUGljayk7CiB9CiAKK2Jvb2wgV01M T3B0aW9uRWxlbWVudDo6ZGlzYWJsZWQoKSBjb25zdAoreworICAgIC8qIER1bW15IGltcGxlbWVu dGF0aW9uLCBhcyBkaXNhYmxlZCgpIGlzIHB1cmUgdmlydHVhbCBpbiBPcHRpb25FbGVtZW50IGNs YXNzICovCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB9CiAKICNlbmRpZgpJbmRleDogV2ViQ29y ZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTE9w dGlvbkVsZW1lbnQuaAkocmV2aXNpb24gNTY2MTUpCisrKyBXZWJDb3JlL3dtbC9XTUxPcHRpb25F bGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTU0LDYgKzU0LDggQEAgcHVibGljOgogICAgIHZp cnR1YWwgU3RyaW5nIHRleHRJbmRlbnRlZFRvUmVzcGVjdEdyb3VwTGFiZWwoKSBjb25zdDsKICAg ICB2aXJ0dWFsIFN0cmluZyB2YWx1ZSgpIGNvbnN0OwogCisgICAgdmlydHVhbCBib29sIGRpc2Fi bGVkKCkgY29uc3Q7CisKIHByaXZhdGU6CiAgICAgdmlydHVhbCBSZW5kZXJTdHlsZSogbm9uUmVu ZGVyZXJSZW5kZXJTdHlsZSgpIGNvbnN0OwogICAgIHZvaWQgaGFuZGxlSW50cmluc2ljRXZlbnRJ Zk5lZWRlZCgpOwpJbmRleDogV2ViQ29yZS93bWwvV01MU2VsZWN0RWxlbWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS93bWwvV01MU2VsZWN0RWxlbWVudC5jcHAJKHJldmlzaW9uIDU2NjE1 KQorKysgV2ViQ29yZS93bWwvV01MU2VsZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTU0NSw2ICs1NDUsMTEgQEAgU3RyaW5nIFdNTFNlbGVjdEVsZW1lbnQ6Oml2YWx1ZSgpIGNvbnN0 CiAgICAgcmV0dXJuIHBhcnNlVmFsdWVTdWJzdGl0dXRpbmdWYXJpYWJsZVJlZmVyZW5jZXMoZ2V0 QXR0cmlidXRlKGl2YWx1ZUF0dHIpKTsKIH0KIAordm9pZCBXTUxTZWxlY3RFbGVtZW50OjpsaXN0 Qm94U2VsZWN0SXRlbShpbnQgbGlzdEluZGV4LCBib29sIGFsbG93TXVsdGlwbHlTZWxlY3Rpb25z LCBib29sIHNoaWZ0LCBib29sIGZpcmVPbkNoYW5nZU5vdykKK3sKKyAgICAvKiBEdW1teSBpbXBs ZW1lbnRhdGlvbiBhcyBsaXN0Qm94U2VsZWN0SXRlbSBpcyBwdXJlIHZpcnR1YWwgaW4gU2VsZWN0 RWxlbWVudCBjbGFzcyAqLworfQorCiB9CiAKICNlbmRpZgpJbmRleDogV2ViQ29yZS93bWwvV01M U2VsZWN0RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTFNlbGVjdEVsZW1l bnQuaAkocmV2aXNpb24gNTY2MTUpCisrKyBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmgJ KHdvcmtpbmcgY29weSkKQEAgLTg2LDYgKzg2LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2VsZWN0 SW5pdGlhbE9wdGlvbnMoKTsKIAogICAgIGJvb2wgaW5pdGlhbGl6ZWQoKSBjb25zdCB7IHJldHVy biBtX2luaXRpYWxpemVkOyB9CisgICAgdm9pZCBsaXN0Qm94U2VsZWN0SXRlbShpbnQgbGlzdElu ZGV4LCBib29sIGFsbG93TXVsdGlwbHlTZWxlY3Rpb25zLCBib29sIHNoaWZ0LCBib29sIGZpcmVP bkNoYW5nZU5vdyA9IHRydWUpOwogCiBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRl ZEludG9UcmVlKGJvb2wpOwo= 51821 2010-03-27 01:57:34 -0700 2010-04-02 18:03:30 -0700 Patch with review comments incorporated. BuildFailureFix.diff text/plain 2810 nayankk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjY1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDMtMjcgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIFdNTCBlbmFibGVkIGJ1aWxkIGZhaWx1cmUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjQ4CisKKyAgICAgICAgKiB3bWwvV01MT3B0 aW9uRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxPcHRpb25FbGVtZW50OjpkaXNh YmxlZCk6CisgICAgICAgICogd21sL1dNTE9wdGlvbkVsZW1lbnQuaDoKKyAgICAgICAgKiB3bWwv V01MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxTZWxlY3RFbGVtZW50 OjpsaXN0Qm94U2VsZWN0SXRlbSk6CisgICAgICAgICogd21sL1dNTFNlbGVjdEVsZW1lbnQuaDoK KwogMjAxMC0wMy0yNiAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4KSW5kZXg6IFdlYkNvcmUvd21sL1dNTE9wdGlvbkVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuY3BwCShy ZXZpc2lvbiA1NjY1OCkKKysrIFdlYkNvcmUvd21sL1dNTE9wdGlvbkVsZW1lbnQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNzAsNiArMTcwLDEyIEBAIHZvaWQgV01MT3B0aW9uRWxlbWVudDo6aGFu ZGxlSW50cmluc2ljRXYKICAgICAgICAgZXZlbnRIYW5kbGVyLT50cmlnZ2VySW50cmluc2ljRXZl bnQoV01MSW50cmluc2ljRXZlbnRPblBpY2spOwogfQogCitib29sIFdNTE9wdGlvbkVsZW1lbnQ6 OmRpc2FibGVkKCkgY29uc3QKK3sKKyAgICAvKiBEdW1teSBpbXBsZW1lbnRhdGlvbiwgYXMgZGlz YWJsZWQoKSBpcyBwdXJlIHZpcnR1YWwgaW4gT3B0aW9uRWxlbWVudCBjbGFzcyAqLworICAgIHJl dHVybiBmYWxzZTsKK30KKwogfQogCiAjZW5kaWYKSW5kZXg6IFdlYkNvcmUvd21sL1dNTE9wdGlv bkVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxPcHRpb25FbGVtZW50LmgJ KHJldmlzaW9uIDU2NjU4KQorKysgV2ViQ29yZS93bWwvV01MT3B0aW9uRWxlbWVudC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC01NCw2ICs1NCw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFN0cmluZyB0 ZXh0SW5kZW50ZWRUb1Jlc3BlY3RHcm91cExhYmVsKCkgY29uc3Q7CiAgICAgdmlydHVhbCBTdHJp bmcgdmFsdWUoKSBjb25zdDsKIAorICAgIHZpcnR1YWwgYm9vbCBkaXNhYmxlZCgpIGNvbnN0Owor CiBwcml2YXRlOgogICAgIHZpcnR1YWwgUmVuZGVyU3R5bGUqIG5vblJlbmRlcmVyUmVuZGVyU3R5 bGUoKSBjb25zdDsKICAgICB2b2lkIGhhbmRsZUludHJpbnNpY0V2ZW50SWZOZWVkZWQoKTsKSW5k ZXg6IFdlYkNvcmUvd21sL1dNTFNlbGVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvd21sL1dNTFNlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiA1NjY1OCkKKysrIFdlYkNvcmUv d21sL1dNTFNlbGVjdEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NDUsNiArNTQ1LDEx IEBAIFN0cmluZyBXTUxTZWxlY3RFbGVtZW50OjppdmFsdWUoKSBjb25zdAogICAgIHJldHVybiBw YXJzZVZhbHVlU3Vic3RpdHV0aW5nVmFyaWFibGVSZWZlcmVuY2VzKGdldEF0dHJpYnV0ZShpdmFs dWVBdHRyKSk7CiB9CiAKK3ZvaWQgV01MU2VsZWN0RWxlbWVudDo6bGlzdEJveFNlbGVjdEl0ZW0o aW50IGxpc3RJbmRleCwgYm9vbCBhbGxvd011bHRpcGx5U2VsZWN0aW9ucywgYm9vbCBzaGlmdCwg Ym9vbCBmaXJlT25DaGFuZ2VOb3cpCit7CisgICAgLyogRHVtbXkgaW1wbGVtZW50YXRpb24gYXMg bGlzdEJveFNlbGVjdEl0ZW0gaXMgcHVyZSB2aXJ0dWFsIGluIFNlbGVjdEVsZW1lbnQgY2xhc3Mg Ki8KK30KKwogfQogCiAjZW5kaWYKSW5kZXg6IFdlYkNvcmUvd21sL1dNTFNlbGVjdEVsZW1lbnQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmgJKHJldmlzaW9u IDU2NjU4KQorKysgV2ViQ29yZS93bWwvV01MU2VsZWN0RWxlbWVudC5oCSh3b3JraW5nIGNvcHkp CkBAIC04Niw2ICs4Niw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHNlbGVjdEluaXRpYWxPcHRpb25z KCk7CiAKICAgICBib29sIGluaXRpYWxpemVkKCkgY29uc3QgeyByZXR1cm4gbV9pbml0aWFsaXpl ZDsgfQorICAgIAorICAgIHZpcnR1YWwgdm9pZCBsaXN0Qm94U2VsZWN0SXRlbShpbnQgbGlzdElu ZGV4LCBib29sIGFsbG93TXVsdGlwbHlTZWxlY3Rpb25zLCBib29sIHNoaWZ0LCBib29sIGZpcmVP bkNoYW5nZU5vdyA9IHRydWUpOwogCiBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRl ZEludG9UcmVlKGJvb2wpOwo=