36607 2010-03-25 09:44:43 -0700 [Qt] Package build on Maemo 5 is broken 2010-03-31 11:10:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other Linux CLOSED FIXED Qt P1 Blocker --- 35784 1 hausmann hausmann casper.vandonderen commit-queue luiz oldest_to_newest 204100 0 hausmann 2010-03-25 09:44:43 -0700 RenderThemeQt.cpp depends on themeQtNoListboxesUserAgentStyleSheet when compiling for maemo5. The corresponding stylesheet is only embedded in WebCore.pri when the corresponding listbox feature is enabled: contains(DEFINES, ENABLE_NO_LISTBOX_RENDERING=1) { STYLESHEETS_EMBED += $$PWD/css/themeQtNoListboxes.css } For the packaging we need to generate all files. Therefore it's the easiest to always embed the stylesheet, but enable the #define for the feature only when compiling for Maemo5. The error message when compiling the package on Maemo5 is: platform/qt/RenderThemeQt.cpp:187: error: 'themeQtNoListboxesUserAgentStyleSheet' was not declared in this scope 204101 1 51649 hausmann 2010-03-25 09:46:17 -0700 Created attachment 51649 Patch 204281 2 51649 commit-queue 2010-03-25 16:12:14 -0700 Comment on attachment 51649 Patch Clearing flags on attachment: 51649 Committed r56576: <http://trac.webkit.org/changeset/56576> 204282 3 commit-queue 2010-03-25 16:12:19 -0700 All reviewed patches have been landed. Closing bug. 204490 4 hausmann 2010-03-26 03:47:45 -0700 Revision r56576 cherry-picked into qtwebkit-2.0 with commit d362c2e1c4559bf5ab4b4efaf3b8b09613f7c3fd 206596 5 luiz 2010-03-31 11:10:21 -0700 *** Bug 36880 has been marked as a duplicate of this bug. *** 51649 2010-03-25 09:46:17 -0700 2010-03-25 16:12:14 -0700 Patch bug-36607-20100325174615.patch text/plain 1051 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTM4MzliYS4uYzkzNmU0MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0yNSAgU2ltb24gSGF1c21h bm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggdGhlIHBhY2thZ2UgYnVpbGQgb24gTWFl bW8gNQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NjYwNworCisgICAgICAgIEFsd2F5cyBlbWJlZCB0aGUgc3R5bGVzaGVldCBmb3IgdGhlIG5vLWxp c3Rib3ggcmVuZGVyaW5nLiBUaGlzIHdheSBpdCdsbCBiZQorICAgICAgICBpbmNsdWRlZCBpbiB0 aGUgZ2VuZXJhdGVkIGZpbGVzIGZvciB0aGUgcGFja2FnZSBnZW5lcmF0aW9uLgorCisgICAgICAg ICogV2ViQ29yZS5wcmk6CisKIDIwMTAtMDMtMjUgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5wcmkgYi9XZWJDb3JlL1dlYkNvcmUucHJpCmluZGV4IDJh OTA5N2YuLjY0MjI0OWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5wcmkKKysrIGIvV2Vi Q29yZS9XZWJDb3JlLnByaQpAQCAtMjE1LDkgKzIxNSw3IEBAIG1hZW1vNSB7CiAgICAgREVGSU5F UyArPSBFTkFCTEVfTk9fTElTVEJPWF9SRU5ERVJJTkc9MQogfQogCi1jb250YWlucyhERUZJTkVT LCBFTkFCTEVfTk9fTElTVEJPWF9SRU5ERVJJTkc9MSkgewotICAgIFNUWUxFU0hFRVRTX0VNQkVE ICs9ICQkUFdEL2Nzcy90aGVtZVF0Tm9MaXN0Ym94ZXMuY3NzCi19CitTVFlMRVNIRUVUU19FTUJF RCArPSAkJFBXRC9jc3MvdGhlbWVRdE5vTGlzdGJveGVzLmNzcwogCiBJRExfQklORElOR1MgKz0g XAogICAgIGNzcy9Db3VudGVyLmlkbCBcCg==