36602 2010-03-25 07:56:26 -0700 [chromium] linux: prefer the "hinting" fontconfig preference. 2010-05-17 00:49:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 agl agl eric evan tony oldest_to_newest 204064 0 agl 2010-03-25 07:56:26 -0700 fontconfig can give contradictory hinting information, setting "hinting" to zero and "hintstyle" to non-zero. In this case we should take the "hinting" preference. 204068 1 51641 agl 2010-03-25 08:04:14 -0700 Created attachment 51641 patch 204074 2 evan 2010-03-25 08:18:59 -0700 LGTM 204104 3 51641 levin 2010-03-25 09:50:35 -0700 Comment on attachment 51641 patch > diff --git a/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp b/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp > + default: > + paint->setHinting((SkPaint::Hinting) m_style.hintStyle); Please use C++ style casting like this: paint->setHinting(static_cast<SkPaint::Hinting>(m_style.hintStyle)); 205580 4 eric 2010-03-29 11:40:06 -0700 Attachment 51641 was posted by a committer and has review+, assigning to Adam Langley for commit. 226654 5 eric 2010-05-17 00:45:26 -0700 Unsure of the status of this patch. It's been in pending-commit for over a month. Updates? 226661 6 tony 2010-05-17 00:49:06 -0700 (In reply to comment #5) > Unsure of the status of this patch. It's been in pending-commit for over a month. Updates? This was landed in http://trac.webkit.org/changeset/56800. 51641 2010-03-25 08:04:14 -0700 2010-03-25 09:50:35 -0700 patch patch text/plain 7496 agl Y29tbWl0IDExYjE2YmQ1ZTFhMTA5ZDRjMWY3ZTYzYWRjNDE1ZWQwNmNlMjA4MGYKQXV0aG9yOiBB ZGFtIExhbmdsZXkgPGFnbEBjaHJvbWl1bS5vcmc+CkRhdGU6ICAgVGh1IE1hciAyNSAxMTowMToy OSAyMDEwIC0wNDAwCgogICAgMjAxMC0wMy0yNSAgQWRhbSBMYW5nbGV5ICA8YWdsQGNocm9taXVt Lm9yZz4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBbY2hyb21pdW1dIGxpbnV4OiBwcmVmZXIgdGhlICJoaW50aW5nIiBmb250Y29u ZmlnIHByZWZlcmVuY2UuCiAgICAKICAgICAgICAgICAgZm9udGNvbmZpZyBjYW4gZ2l2ZSBjb250 cmFkaWN0b3J5IGhpbnRpbmcgaW5mb3JtYXRpb24sIHNldHRpbmcKICAgICAgICAgICAgImhpbnRp bmciIHRvIHplcm8gYW5kICJoaW50c3R5bGUiIHRvIG5vbi16ZXJvLiBJbiB0aGlzIGNhc2Ugd2UK ICAgICAgICAgICAgc2hvdWxkIHRha2UgdGhlICJoaW50aW5nIiBwcmVmZXJlbmNlLgogICAgCiAg ICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjYwMgog ICAgCiAgICAgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udFBsYXRmb3Jt RGF0YUxpbnV4LmNwcDoKICAgICAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OnNl dHVwUGFpbnQpOgoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA4MzQ3MDI2Li45ODllNjY4IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMDMtMjUgIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW2Nocm9taXVtXSBsaW51eDogcHJlZmVyIHRoZSAiaGludGluZyIgZm9udGNvbmZpZyBwcmVm ZXJlbmNlLgorCisgICAgICAgIGZvbnRjb25maWcgY2FuIGdpdmUgY29udHJhZGljdG9yeSBoaW50 aW5nIGluZm9ybWF0aW9uLCBzZXR0aW5nCisgICAgICAgICJoaW50aW5nIiB0byB6ZXJvIGFuZCAi aGludHN0eWxlIiB0byBub24temVyby4gSW4gdGhpcyBjYXNlIHdlCisgICAgICAgIHNob3VsZCB0 YWtlIHRoZSAiaGludGluZyIgcHJlZmVyZW5jZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2MDIKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLmh0bWw6 CisKIDIwMTAtMDMtMjQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQWRlbGUgUGV0ZXJzb24uCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3RleHQv Y2hyb21pdW0tbGludXgtZm9udGNvbmZpZy1yZW5kZXJzdHlsZS1leHBlY3RlZC5jaGVja3N1bSBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsYXRmb3JtL2Nocm9taXVtL2Zh c3QvdGV4dC9jaHJvbWl1bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLWV4cGVjdGVkLmNo ZWNrc3VtCmluZGV4IGU5YTE0YjIuLmUxZWRhM2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvdGV4dC9jaHJvbWl1 bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLWV4cGVjdGVkLmNoZWNrc3VtCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsYXRmb3JtL2Nocm9taXVtL2Zhc3Qv dGV4dC9jaHJvbWl1bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLWV4cGVjdGVkLmNoZWNr c3VtCkBAIC0xICsxIEBACi0zMDA2ZjViZTExZGY2YmQ4OWJhNjY4Mjg2NzU3ZWEyZQpcIE5vIG5l d2xpbmUgYXQgZW5kIG9mIGZpbGUKKzA3MjRhMGQwNDhiMTY4NzE2NzM3ZWRkOTc4MjYyNjZmClwg Tm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0tbGludXgvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC90ZXh0L2Nocm9taXVtLWxp bnV4LWZvbnRjb25maWctcmVuZGVyc3R5bGUtZXhwZWN0ZWQucG5nIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0tbGludXgvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC90ZXh0L2Nocm9taXVt LWxpbnV4LWZvbnRjb25maWctcmVuZGVyc3R5bGUtZXhwZWN0ZWQucG5nCmluZGV4IGZlYzBmYWQu LjNhZTJmNDkgMTAwNjQ0CkJpbmFyeSBmaWxlcyBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtLWxpbnV4L3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51eC1mb250 Y29uZmlnLXJlbmRlcnN0eWxlLWV4cGVjdGVkLnBuZyBhbmQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS1saW51eC9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3RleHQvY2hyb21pdW0tbGlu dXgtZm9udGNvbmZpZy1yZW5kZXJzdHlsZS1leHBlY3RlZC5wbmcgZGlmZmVyCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbGF0Zm9ybS9jaHJvbWl1bS9m YXN0L3RleHQvY2hyb21pdW0tbGludXgtZm9udGNvbmZpZy1yZW5kZXJzdHlsZS1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbGF0Zm9ybS9jaHJvbWl1 bS9mYXN0L3RleHQvY2hyb21pdW0tbGludXgtZm9udGNvbmZpZy1yZW5kZXJzdHlsZS1leHBlY3Rl ZC50eHQKaW5kZXggZGIxYTVjZC4uYWY0YjEyNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0tbGludXgvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC90ZXh0L2Nocm9taXVt LWxpbnV4LWZvbnRjb25maWctcmVuZGVyc3R5bGUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvdGV4dC9j aHJvbWl1bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLWV4cGVjdGVkLnR4dApAQCAtMTgs NyArMTgsNyBAQCBsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKICAgICAgICAgICB0ZXh0IHJ1 biBhdCAoNDEyLDApIHdpZHRoIDMwNjogIiBtb2RlLCBhcyB0aGF0IGZvcmNlcyBzb21lIHJlbmRl cmluZyBzZXR0aW5ncyB1c2VkICIKICAgICAgICAgICB0ZXh0IHJ1biBhdCAoNzE4LDApIHdpZHRo IDMyOiAiaW4gdGhlIgogICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDIwKSB3aWR0aCA4OTogImZv bGxvd2luZyB0ZXN0cy4iCi0gICAgICBSZW5kZXJCbG9jayB7T0x9IGF0ICgwLDU2KSBzaXplIDc4 NHgxNDUKKyAgICAgIFJlbmRlckJsb2NrIHtPTH0gYXQgKDAsNTYpIHNpemUgNzg0eDIzNQogICAg ICAgICBSZW5kZXJMaXN0SXRlbSB7TEl9IGF0ICg0MCwwKSBzaXplIDc0NHg1NQogICAgICAgICAg IFJlbmRlckJsb2NrIHtQfSBhdCAoMCwwKSBzaXplIDc0NHgyMAogICAgICAgICAgICAgUmVuZGVy TGlzdE1hcmtlciBhdCAoLTIxLDApIHNpemUgMTZ4MTk6ICIxIgpAQCAtMzksMyArMzksMTQgQEAg bGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCiAgICAgICAgICAgUmVuZGVyQmxvY2sge1B9IGF0 ICgwLDU2KSBzaXplIDc0NHgxOAogICAgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgw LDApIHNpemUgMjE4eDE4CiAgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDIx ODogImdvdmVybm1lbnQgLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4iCisgICAgICAg IFJlbmRlckxpc3RJdGVtIHtMSX0gYXQgKDQwLDE2MSkgc2l6ZSA3NDR4NzQKKyAgICAgICAgICBS ZW5kZXJCbG9jayB7UH0gYXQgKDAsMCkgc2l6ZSA3NDR4NDAKKyAgICAgICAgICAgIFJlbmRlckxp c3RNYXJrZXIgYXQgKC0yMSwwKSBzaXplIDE2eDE5OiAiMyIKKyAgICAgICAgICAgIFJlbmRlclRl eHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDczOHgzOQorICAgICAgICAgICAgICB0ZXh0IHJ1biBh dCAoMCwwKSB3aWR0aCAzNzc6ICJUaGUgZm9sbG93aW5nIHRleHQgc2hvdWxkIGJlIHVuaGludGVk IFZlcmRhbmEuIFRoZSBmb250Y29uZmlnICIKKyAgICAgICAgICAgICAgdGV4dCBydW4gYXQgKDM3 NywwKSB3aWR0aCAzNjE6ICJjb25maWd1cmF0aW9uIGZvciB0aGlzIGlzIGNvbnRyYWRpY3Rvcnks IHNldHRpbmcgYm90aCBmdWxsLWhpbnRpbmciCisgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgw LDIwKSB3aWR0aCAyNDU6ICJhbmQgbm8taGludGluZy4gVGhlIGxhdHRlciBzaG91bGQgd2luIG91 dC4iCisgICAgICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDU2KSBzaXplIDc0NHgxOAorICAg ICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgNjMyeDE4CisgICAgICAg ICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDQ0NDogIkhlcmUgaXMgVGlnZ2VyIGRvaW5n IHdoYXQgdGlnZ2VycyBkbyBiZXN0IFx4ezIwMjZ9IG9wZXJhdGluZyAiCisgICAgICAgICAgICAg IHRleHQgcnVuIGF0ICg0NDQsMCkgd2lkdGggMTg4OiAiaHlkcmF1bGljIGV4b3NrZWxldG9ucy4i CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3RleHQvY2hy b21pdW0tbGludXgtZm9udGNvbmZpZy1yZW5kZXJzdHlsZS5odG1sIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vZmFzdC90ZXh0L2Nocm9taXVtLWxpbnV4LWZvbnRjb25maWctcmVuZGVy c3R5bGUuaHRtbAppbmRleCA3OThmZWEzLi4yMzhkOTBkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3RleHQvY2hyb21pdW0tbGludXgtZm9udGNvbmZpZy1y ZW5kZXJzdHlsZS5odG1sCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3Qv dGV4dC9jaHJvbWl1bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLmh0bWwKQEAgLTE4LDYg KzE4LDE3IEBACiAgICAgICAgICAgZ292ZXJubWVudCAuLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLgogICAgICAgICA8L3A+CiAgICAgICA8L2xpPgorCisgICAgICA8bGk+CisgICAgICAg IDxwPlRoZSBmb2xsb3dpbmcgdGV4dCBzaG91bGQgYmUgdW5oaW50ZWQgVmVyZGFuYS4gVGhlIGZv bnRjb25maWcKKyAgICAgICAgICBjb25maWd1cmF0aW9uIGZvciB0aGlzIGlzIGNvbnRyYWRpY3Rv cnksIHNldHRpbmcgYm90aCBmdWxsLWhpbnRpbmcKKyAgICAgICAgICBhbmQgbm8taGludGluZy4g VGhlIGxhdHRlciBzaG91bGQgd2luIG91dC48L3A+CisKKyAgICAgICAgPHAgc3R5bGU9ImZvbnQt ZmFtaWx5Ok5vbkhpbnRlZFNhbnMiPgorICAgICAgICAgIEhlcmUgaXMgVGlnZ2VyIGRvaW5nIHdo YXQgdGlnZ2VycyBkbyBiZXN0ICZoZWxsaXA7IG9wZXJhdGluZworICAgICAgICAgIGh5ZHJhdWxp YyBleG9za2VsZXRvbnMuCisgICAgICAgIDwvcD4KKyAgICAgIDwvbGk+CiAgICAgPC9vbD4KICAg PC9ib2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA4YjI5OWI4Li5kN2M3ODY4IDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTAz LTI1ICBBZGFtIExhbmdsZXkgIDxhZ2xAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gbGludXg6IHByZWZlciB0 aGUgImhpbnRpbmciIGZvbnRjb25maWcgcHJlZmVyZW5jZS4KKworICAgICAgICBmb250Y29uZmln IGNhbiBnaXZlIGNvbnRyYWRpY3RvcnkgaGludGluZyBpbmZvcm1hdGlvbiwgc2V0dGluZworICAg ICAgICAiaGludGluZyIgdG8gemVybyBhbmQgImhpbnRzdHlsZSIgdG8gbm9uLXplcm8uIEluIHRo aXMgY2FzZSB3ZQorICAgICAgICBzaG91bGQgdGFrZSB0aGUgImhpbnRpbmciIHByZWZlcmVuY2Uu CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjAy CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1EYXRh TGludXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6c2V0dXBQYWlu dCk6CisKIDIwMTAtMDMtMjUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRlbGUgUGV0ZXJzb24uCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51eC5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51 eC5jcHAKaW5kZXggMjUwN2FjNy4uNWZiNGI4MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1EYXRhTGludXguY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udFBsYXRmb3JtRGF0YUxpbnV4LmNwcApA QCAtMTMxLDcgKzEzMSwxOCBAQCB2b2lkIEZvbnRQbGF0Zm9ybURhdGE6OnNldHVwUGFpbnQoU2tQ YWludCogcGFpbnQpIGNvbnN0CiAgICAgY29uc3QgZmxvYXQgdHMgPSBtX3RleHRTaXplID4gMCA/ IG1fdGV4dFNpemUgOiAxMjsKIAogICAgIHBhaW50LT5zZXRBbnRpQWxpYXMobV9zdHlsZS51c2VB bnRpQWxpYXMgPT0gRm9udFJlbmRlclN0eWxlOjpOb1ByZWZlcmVuY2UgPyBpc1NraWFBbnRpQWxp YXMgOiBtX3N0eWxlLnVzZUFudGlBbGlhcyk7Ci0gICAgcGFpbnQtPnNldEhpbnRpbmcobV9zdHls ZS51c2VIaW50aW5nID09IEZvbnRSZW5kZXJTdHlsZTo6Tm9QcmVmZXJlbmNlID8gc2tpYUhpbnRp bmcgOiAoU2tQYWludDo6SGludGluZykgbV9zdHlsZS5oaW50U3R5bGUpOworICAgIHN3aXRjaCAo bV9zdHlsZS51c2VIaW50aW5nKSB7CisgICAgY2FzZSBGb250UmVuZGVyU3R5bGU6Ok5vUHJlZmVy ZW5jZToKKyAgICAgICAgcGFpbnQtPnNldEhpbnRpbmcoc2tpYUhpbnRpbmcpOworICAgICAgICBi cmVhazsKKyAgICBjYXNlIDA6CisgICAgICAgIHBhaW50LT5zZXRIaW50aW5nKFNrUGFpbnQ6OmtO b19IaW50aW5nKTsKKyAgICAgICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgcGFpbnQt PnNldEhpbnRpbmcoKFNrUGFpbnQ6OkhpbnRpbmcpIG1fc3R5bGUuaGludFN0eWxlKTsKKyAgICAg ICAgYnJlYWs7CisgICAgfQorCiAgICAgcGFpbnQtPnNldFRleHRTaXplKFNrRmxvYXRUb1NjYWxh cih0cykpOwogICAgIHBhaW50LT5zZXRUeXBlZmFjZShtX3R5cGVmYWNlKTsKICAgICBwYWludC0+ c2V0RmFrZUJvbGRUZXh0KG1fZmFrZUJvbGQpOwo=