36597 2010-03-25 07:17:06 -0700 [v8] Add if ENABLE guard for Worker specific code. 2010-03-30 05:44:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 kristianm benm android-webkit-unforking benm levin oldest_to_newest 204037 0 kristianm 2010-03-25 07:17:06 -0700 Guarding the funtion in the head as well as the implementation so it will cause a compile error instead of linker error. 204047 1 51639 kristianm 2010-03-25 07:27:08 -0700 Created attachment 51639 Patch number 1 204111 2 51639 levin 2010-03-25 09:59:48 -0700 Comment on attachment 51639 Patch number 1 > Index: WebCore/ChangeLog > +2010-03-25 Kristian Monsen <kristianm@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Guarding the function in the header as well. I'll r+ *but* before committing the patch this line should be changed to the (new) title of the bug (a WK committer can do this for you right before they commit the change and I think you have a few nearby). The problem is that right now this line doesn't tell you anything. Ideally one should be able to read this and get a sense of what was addressed (so folks can decide to look at the details or not -- think of it like a good email subject). 204112 3 kristianm 2010-03-25 10:02:15 -0700 OK, thanks for the comment. I will update this bug and improve for next patch. 205960 4 benm 2010-03-30 05:41:49 -0700 Will update Changelog as per review comments and land. 205961 5 benm 2010-03-30 05:44:47 -0700 Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMWrapper.h Transmitting file data .. Committed revision 56778. 51639 2010-03-25 07:27:08 -0700 2010-03-25 09:59:48 -0700 Patch number 1 patch36597.txt text/plain 1416 kristianm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjU0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMjUgIEtyaXN0aWFuIE1vbnNlbiAgPGtyaXN0aWFubUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEd1YXJkaW5nIHRoZSBmdW5jdGlvbiBpbiB0aGUgaGVhZGVyIGFzIHdlbGwuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjU5NworCisgICAgICAg IEJ1aWxkIGZpeCBvbmx5LCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9W OERPTVdyYXBwZXIuaDoKKwogMjAxMC0wMy0yNSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDog V2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCShyZXZpc2lvbiA1NjUzNCkKKysrIFdlYkNvcmUv YmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwOSw3ICsxMDks OSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHN0YXRpYyB2ODo6TG9jYWw8djg6OkZ1 bmN0aW9uPiBnZXRDb25zdHJ1Y3RvckZvckNvbnRleHQoV3JhcHBlclR5cGVJbmZvKiwgdjg6Okhh bmRsZTx2ODo6Q29udGV4dD4pOwogICAgICAgICBzdGF0aWMgdjg6OkxvY2FsPHY4OjpGdW5jdGlv bj4gZ2V0Q29uc3RydWN0b3IoV3JhcHBlclR5cGVJbmZvKiwgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IG9iamVjdFByb3RvdHlwZSk7CiAgICAgICAgIHN0YXRpYyB2ODo6TG9jYWw8djg6OkZ1bmN0aW9u PiBnZXRDb25zdHJ1Y3RvcihXcmFwcGVyVHlwZUluZm8qLCBET01XaW5kb3cqKTsKKyNpZiBFTkFC TEUoV09SS0VSUykKICAgICAgICAgc3RhdGljIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IGdldENv bnN0cnVjdG9yKFdyYXBwZXJUeXBlSW5mbyosIFdvcmtlckNvbnRleHQqKTsKKyNlbmRpZgogCiAg ICAgICAgIC8vIFNldCBKUyB3cmFwcGVyIG9mIGEgRE9NIG9iamVjdCwgdGhlIGNhbGxlciBpbiBj aGFyZ2Ugb2YgaW5jcmVhc2UgcmVmLgogICAgICAgICBzdGF0aWMgdm9pZCBzZXRKU1dyYXBwZXJG b3JET01PYmplY3Qodm9pZCosIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+KTsK