36589 2010-03-25 03:42:40 -0700 [Qt] GraphicsLayer: Timing functions don't work with transitions 2010-03-28 14:47:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux CLOSED FIXED P2 Normal --- 35784 0 kim.1.gronholm webkit-unassigned commit-queue hausmann noam oldest_to_newest 203975 0 51619 kim.1.gronholm 2010-03-25 03:42:40 -0700 Created attachment 51619 Test case for transform transition timing functions. When AC is enabled, setting the -webkit-transition-timing-function for transform transition has no effect. The default timing function is always used. See the test case. 203979 1 51621 kim.1.gronholm 2010-03-25 03:57:19 -0700 Created attachment 51621 Fixes the timing functions in transform transitions with AC If the animation value doesn't have timing function set, we need to use the animation's timing function. Fixed also a bug in passing the duration to solveCubicBezierFunction. The duration was divided two times by 1000 and meanwhile casted to int. It needs to be kept as double and divided by 1000 only once. 203989 2 noam 2010-03-25 04:13:40 -0700 LGTM :) 204454 3 51621 eric 2010-03-26 00:54:16 -0700 Comment on attachment 51621 Fixes the timing functions in transform transitions with AC Can't we make an automated test for this? Otherwise this change looks fine. 204456 4 noam 2010-03-26 00:57:13 -0700 We actually can't automate the testing until QGraphicsWebView is part of our automated test process. For now we have to work on that alongside fixing AC bugs the "un-automated" way. 205120 5 hausmann 2010-03-28 02:22:22 -0700 (In reply to comment #4) > We actually can't automate the testing until QGraphicsWebView is part of our > automated test process. For now we have to work on that alongside fixing AC > bugs the "un-automated" way. ... or changing DRT before continuing with this. 205124 6 51621 commit-queue 2010-03-28 02:46:12 -0700 Comment on attachment 51621 Fixes the timing functions in transform transitions with AC Clearing flags on attachment: 51621 Committed r56685: <http://trac.webkit.org/changeset/56685> 205125 7 commit-queue 2010-03-28 02:46:17 -0700 All reviewed patches have been landed. Closing bug. 205252 8 hausmann 2010-03-28 14:47:07 -0700 Revision r56685 cherry-picked into qtwebkit-2.0 with commit b3d7ff975d5e5e858e969b524c501fcd03fb40c9 51619 2010-03-25 03:42:40 -0700 2010-03-25 03:42:40 -0700 Test case for transform transition timing functions. transition-timing-functions.html text/html 1300 kim.1.gronholm PGh0bWw+CjxoZWFkPgogIDx0aXRsZT5UcmFuc2l0aW9uIHRpbWluZy1mdW5jdGlvbnM8L3RpdGxl PgogIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CiAgICAuYm94IHsKICAg ICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgICBsZWZ0OiAwOwogICAgICBoZWlnaHQ6IDUwcHg7 CiAgICAgIHdpZHRoOiA1MHB4OwogICAgICBtYXJnaW46IDEwcHg7CiAgICAgIGJhY2tncm91bmQt Y29sb3I6IGJsdWU7CiAgICAgIC13ZWJraXQtdHJhbnNpdGlvbi1kdXJhdGlvbjogNXM7CiAgICAg IC13ZWJraXQtdHJhbnNpdGlvbi10aW1pbmctZnVuY3Rpb246IGxpbmVhcjsKICAgICAgLXdlYmtp dC10cmFuc2Zvcm06IHRyYW5zbGF0ZSgwcHgsIDBweCk7CiAgICB9CiAgPC9zdHlsZT4KICA8c2Ny aXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgogICAgZnVuY3Rpb24g c3RhcnRUcmFuc2l0aW9uKCkKICAgIHsKICAgICAgdmFyIGJveGVzID0gZG9jdW1lbnQuYm9keS5n ZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCdib3gnKTsKICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBi b3hlcy5sZW5ndGg7ICsraSkKICAgICAgICBib3hlc1tpXS5zdHlsZS53ZWJraXRUcmFuc2Zvcm0g PSAndHJhbnNsYXRlKDQwMHB4LCAwcHgpJzsKICAgIH0KICAgIHdpbmRvdy5hZGRFdmVudExpc3Rl bmVyKCdsb2FkJywgc3RhcnRUcmFuc2l0aW9uLCBmYWxzZSk7CiAgPC9zY3JpcHQ+CjwvaGVhZD4K PGJvZHk+CkFsbCBvZiB0aGUgZml2ZSBzcXVhcmVzIHNob3VsZCBzbGlkZSBmcm9tIGxlZnQgdG8g cmlnaHQgd2l0aCBub3RpY2VhYmx5IGRpZmZlcmVudCBzcGVlZHM6CiAgPGRpdiBpZD0iYm94MSIg Y2xhc3M9ImJveCIgc3R5bGU9Ii13ZWJraXQtdHJhbnNpdGlvbi10aW1pbmctZnVuY3Rpb246IGxp bmVhcjsiPjwvZGl2PgogIDxkaXYgaWQ9ImJveDIiIGNsYXNzPSJib3giIHN0eWxlPSItd2Via2l0 LXRyYW5zaXRpb24tdGltaW5nLWZ1bmN0aW9uOiBlYXNlOyI+PC9kaXY+CiAgPGRpdiBpZD0iYm94 MyIgY2xhc3M9ImJveCIgc3R5bGU9Ii13ZWJraXQtdHJhbnNpdGlvbi10aW1pbmctZnVuY3Rpb246 IGVhc2UtaW47Ij48L2Rpdj4KICA8ZGl2IGlkPSJib3g0IiBjbGFzcz0iYm94IiBzdHlsZT0iLXdl YmtpdC10cmFuc2l0aW9uLXRpbWluZy1mdW5jdGlvbjogZWFzZS1vdXQ7Ij48L2Rpdj4KICA8ZGl2 IGlkPSJib3g1IiBjbGFzcz0iYm94IiBzdHlsZT0iLXdlYmtpdC10cmFuc2l0aW9uLXRpbWluZy1m dW5jdGlvbjogZWFzZS1pbi1vdXQ7Ij48L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+Cg== 51621 2010-03-25 03:57:19 -0700 2010-03-28 02:46:12 -0700 Fixes the timing functions in transform transitions with AC patch-36589.diff text/plain 4171 kim.1.gronholm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGUyODYxMi4uMzBiZTRhYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wMy0yNSAgS2ltIEdyw7ZuaG9s bSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzTGF5ZXI6IFRpbWluZyBmdW5jdGlv bnMgZG9uJ3Qgd29yayB3aXRoIHRyYW5zaXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjU4OQorCisgICAgICAgIElmIHRoZSBhbmltYXRpb24g dmFsdWUgZG9lc24ndCBoYXZlIHRpbWluZyBmdW5jdGlvbiBzZXQsIHdlIG5lZWQgdG8KKyAgICAg ICAgdXNlIHRoZSBhbmltYXRpb24ncyB0aW1pbmcgZnVuY3Rpb24uCisgICAgICAgIAorICAgICAg ICBGaXhlZCBhbHNvIGEgYnVnIGluIHBhc3NpbmcgdGhlIGR1cmF0aW9uIHRvIHNvbHZlQ3ViaWNC ZXppZXJGdW5jdGlvbi4KKyAgICAgICAgVGhlIGR1cmF0aW9uIHdhcyBkaXZpZGVkIHR3byB0aW1l cyBieSAxMDAwIGFuZCBtZWFud2hpbGUgY2FzdGVkIHRvIGludC4KKyAgICAgICAgSXQgbmVlZHMg dG8gYmUga2VwdCBhcyBkb3VibGUgYW5kIGRpdmlkZWQgYnkgMTAwMCBvbmx5IG9uY2UuCisKKyAg ICAgICAgVGVzdCBjYXNlOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9hdHRhY2htZW50LmNnaT9p ZD01MTYxOQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFwcGx5VGltaW5nRnVuY3Rpb24pOgorICAgICAgICAo V2ViQ29yZTo6QW5pbWF0aW9uUXQ6OjpBbmltYXRpb25RdEJhc2UpOgorICAgICAgICAoV2ViQ29y ZTo6QW5pbWF0aW9uUXQ6OnVwZGF0ZUN1cnJlbnRUaW1lKToKKwogMjAxMC0wMy0yNSAgVGFzdWt1 IFN1enVraSAgPHRhc3VrdS5zdXp1a2lAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9H cmFwaGljc0xheWVyUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0xheWVyUXQuY3BwCmluZGV4IGE1Nzk3YTEuLjI5MTNlZWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAorKysgYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKQEAgLTk3MSwxOCArOTcxLDE4 IEBAIHN0YXRpYyBpbmxpbmUgZG91YmxlIHNvbHZlQ3ViaWNCZXppZXJGdW5jdGlvbihxcmVhbCBw MXgsIHFyZWFsIHAxeSwgcXJlYWwgcDJ4LCBxCiAKIC8vIHdlIHdhbnQgdGhlIHRpbWluZyBmdW5j dGlvbiB0byBiZSBhcyBjbG9zZSBhcyBwb3NzaWJsZSB0byB3aGF0IHRoZSB3ZWItZGV2ZWxvcGVy IGludGVuZGVkLCBzbyB3ZSdyZSB1c2luZyB0aGUgc2FtZSBmdW5jdGlvbiB1c2VkIGJ5IFdlYkNv cmUgd2hlbiBjb21wb3NpdGluZyBpcyBkaXNhYmxlZAogLy8gVXNpbmcgZWFzaW5nLWN1cnZlcyB3 b3VsZCBwcm9iYWJseSB3b3JrIGZvciBzb21lIG9mIHRoZSBjYXNlcywgYnV0IHdvdWxkbid0IHJl YWxseSBidXkgdXMgYW55dGhpbmcgYXMgd2UnZCBoYXZlIHRvIGNvbnZlcnQgdGhlIGJlemllciBm dW5jdGlvbiBiYWNrIHRvIGFuIGVhc2luZyBjdXJ2ZQotc3RhdGljIGlubGluZSBxcmVhbCBhcHBs eVRpbWluZ0Z1bmN0aW9uKGNvbnN0IFRpbWluZ0Z1bmN0aW9uJiB0aW1pbmdGdW5jdGlvbiwgcXJl YWwgcHJvZ3Jlc3MsIGludCBkdXJhdGlvbikKLXsKLSAgICAgICAgaWYgKHRpbWluZ0Z1bmN0aW9u LnR5cGUoKSA9PSBMaW5lYXJUaW1pbmdGdW5jdGlvbikKLSAgICAgICAgICAgIHJldHVybiBwcm9n cmVzczsKLSAgICAgICAgaWYgKHRpbWluZ0Z1bmN0aW9uLnR5cGUoKSA9PSBDdWJpY0JlemllclRp bWluZ0Z1bmN0aW9uKSB7Ci0gICAgICAgICAgICByZXR1cm4gc29sdmVDdWJpY0JlemllckZ1bmN0 aW9uKHRpbWluZ0Z1bmN0aW9uLngxKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHRpbWluZ0Z1bmN0aW9uLnkxKCksCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHRpbWluZ0Z1bmN0aW9uLngyKCksCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRpbWluZ0Z1bmN0aW9uLnkyKCksCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvdWJsZShwcm9ncmVzcyks IGRvdWJsZShkdXJhdGlvbikgLyAxMDAwKTsKLSAgICAgICAgfQorc3RhdGljIGlubGluZSBxcmVh bCBhcHBseVRpbWluZ0Z1bmN0aW9uKGNvbnN0IFRpbWluZ0Z1bmN0aW9uJiB0aW1pbmdGdW5jdGlv biwgcXJlYWwgcHJvZ3Jlc3MsIGRvdWJsZSBkdXJhdGlvbikKK3sKKyAgICBpZiAodGltaW5nRnVu Y3Rpb24udHlwZSgpID09IExpbmVhclRpbWluZ0Z1bmN0aW9uKQogICAgICAgICByZXR1cm4gcHJv Z3Jlc3M7CisgICAgaWYgKHRpbWluZ0Z1bmN0aW9uLnR5cGUoKSA9PSBDdWJpY0JlemllclRpbWlu Z0Z1bmN0aW9uKSB7CisgICAgICAgIHJldHVybiBzb2x2ZUN1YmljQmV6aWVyRnVuY3Rpb24odGlt aW5nRnVuY3Rpb24ueDEoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB0aW1pbmdGdW5jdGlvbi55MSgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHRpbWluZ0Z1bmN0aW9uLngyKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdGltaW5nRnVuY3Rpb24ueTIoKSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBkb3VibGUocHJvZ3Jlc3MpLCBkb3VibGUoZHVyYXRpb24pIC8gMTAw MCk7CisgICAgfQorICAgIHJldHVybiBwcm9ncmVzczsKIH0KIAogLy8gaGVscGVyIGZ1bmN0aW9u cyB0byBzYWZlbHkgZ2V0IGEgdmFsdWUgb3V0IG9mIFdlYkNvcmUncyBBbmltYXRpb25WYWx1ZSoK QEAgLTEwNTUsNiArMTA1NSw4IEBAIHB1YmxpYzoKICAgICAgICAgICAgIEtleWZyYW1lVmFsdWVR dDxUPiBrZXlmcmFtZVZhbHVlOwogICAgICAgICAgICAgaWYgKGFuaW1hdGlvblZhbHVlLT50aW1p bmdGdW5jdGlvbigpKQogICAgICAgICAgICAgICAgIGtleWZyYW1lVmFsdWUudGltaW5nRnVuY3Rp b24gPSAqYW5pbWF0aW9uVmFsdWUtPnRpbWluZ0Z1bmN0aW9uKCk7CisgICAgICAgICAgICBlbHNl CisgICAgICAgICAgICAgICAga2V5ZnJhbWVWYWx1ZS50aW1pbmdGdW5jdGlvbiA9IGFuaW0tPnRp bWluZ0Z1bmN0aW9uKCk7CiAgICAgICAgICAgICB3ZWJraXRBbmltYXRpb25Ub1F0QW5pbWF0aW9u VmFsdWUoYW5pbWF0aW9uVmFsdWUsIGtleWZyYW1lVmFsdWUudmFsdWUpOwogICAgICAgICAgICAg bV9rZXlmcmFtZVZhbHVlc1thbmltYXRpb25WYWx1ZS0+a2V5VGltZSgpXSA9IGtleWZyYW1lVmFs dWU7CiAgICAgICAgIH0KQEAgLTExMDMsNyArMTEwNSw3IEBAIHByb3RlY3RlZDoKICAgICAgICAg Ly8gd2UgY2FuIG5vdyBwcm9jZXNzIHRoZSBwcm9ncmVzcyBhbmQgYXBwbHkgdGhlIGZyYW1lCiAg ICAgICAgIHByb2dyZXNzID0gKCFwcm9ncmVzcyB8fCBwcm9ncmVzcyA9PSAxIHx8IGl0LmtleSgp ID09IGl0Mi5rZXkoKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg PyBwcm9ncmVzcwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IGFw cGx5VGltaW5nRnVuY3Rpb24odGltaW5nRnVuYywgKHByb2dyZXNzIC0gaXQua2V5KCkpIC8gKGl0 Mi5rZXkoKSAtIGl0LmtleSgpKSwgZHVyYXRpb24oKSAvIDEwMDApOworICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICA6IGFwcGx5VGltaW5nRnVuY3Rpb24odGltaW5nRnVu YywgKHByb2dyZXNzIC0gaXQua2V5KCkpIC8gKGl0Mi5rZXkoKSAtIGl0LmtleSgpKSwgZHVyYXRp b24oKSk7CiAgICAgICAgIGFwcGx5RnJhbWUoZnJvbVZhbHVlLCB0b1ZhbHVlLCBwcm9ncmVzcyk7 CiAgICAgfQogCg==