36586 2010-03-25 02:16:40 -0700 [Chromium-Win] websocket_server.py failed to start 2010-03-26 01:45:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 1 ukai ukai oldest_to_newest 203944 0 ukai 2010-03-25 02:16:40 -0700 On Chromium-Win, websocket_server.py failed to start the server. http://build.chromium.org/buildbot/try-server/builders/win/builds/24808/steps/ui_tests/logs/stdio [ RUN ] WorkerTest.WorkerWebSocketLayoutTests No handlers could be found for logger "webkitpy.layout_tests.port.websocket_server" Traceback (most recent call last): File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 308, in ? pywebsocket.start() File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 205, in start env=env) File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 534, in __init__ (p2cread, p2cwrite, File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 594, in _get_handles p2cread = self._make_inheritable(p2cread) File "c:\b\slave\win\build\src\third_party\python_24\lib\subprocess.py", line 635, in _make_inheritable DUPLICATE_SAME_ACCESS) TypeError: an integer is required 203967 1 51617 ukai 2010-03-25 03:29:07 -0700 Created attachment 51617 Patch 203968 2 ukai 2010-03-25 03:30:28 -0700 (In reply to comment #1) > Created an attachment (id=51617) [details] > Patch With this patch, chromium tests passes on Win. http://build.chromium.org/buildbot/try-server/builders/win/builds/24835 http://build.chromium.org/buildbot/try-server/builders/win/builds/24835/steps/gclient/logs/patch http://build.chromium.org/buildbot/try-server/builders/win/builds/24835/steps/ui_tests/logs/stdio 204452 3 51617 hamaji 2010-03-26 00:51:31 -0700 Comment on attachment 51617 Patch Looks good! But please add a few more information into ChangeLog before you submit. > + * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin It would be better to describe why this change fixes the issue. 204471 4 ukai 2010-03-26 01:45:42 -0700 Committed r56614: <http://trac.webkit.org/changeset/56614> 51617 2010-03-25 03:29:07 -0700 2010-03-26 00:51:31 -0700 Patch bug-36586-20100325192906.patch text/plain 1470 ukai ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlODhhNDEwLi41ZGMzZjJjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMt MjUgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtLVdpbl0gd2Vic29ja2V0 X3NlcnZlci5weSBmYWlsZWQgdG8gc3RhcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM2NTg2CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L3dlYnNvY2tldF9zZXJ2ZXIucHk6IG9wZW4gb3MuZGV2bnVsbCBmb3Ig c3RkaW4KKwogMjAxMC0wMy0yNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vic29ja2V0X3NlcnZlci5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vic29ja2V0X3Nl cnZlci5weQppbmRleCAxYjFhZjcxLi5iMjgzNWY3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYnNvY2tldF9zZXJ2ZXIucHkKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2Nr ZXRfc2VydmVyLnB5CkBAIC0yMDAsNyArMjAwLDkgQEAgY2xhc3MgUHlXZWJTb2NrZXQoaHR0cF9z ZXJ2ZXIuTGlnaHR0cGQpOgogICAgICAgICBfbG9nLmRlYnVnKCdTdGFydGluZyAlcyBzZXJ2ZXIg b24gJWQuJyAlICgKICAgICAgICAgICAgICAgICAgICBzZWxmLl9zZXJ2ZXJfbmFtZSwgc2VsZi5f cG9ydCkpCiAgICAgICAgIF9sb2cuZGVidWcoJ2NtZGxpbmU6ICVzJyAlICcgJy5qb2luKHN0YXJ0 X2NtZCkpCi0gICAgICAgIHNlbGYuX3Byb2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKHN0YXJ0X2Nt ZCwgc3Rkb3V0PXNlbGYuX3dzb3V0LAorICAgICAgICBzZWxmLl9wcm9jZXNzID0gc3VicHJvY2Vz cy5Qb3BlbihzdGFydF9jbWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0ZGluPW9wZW4ob3MuZGV2bnVsbCwgJ3InKSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgc3Rkb3V0PXNlbGYuX3dzb3V0LAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzdGRlcnI9c3VicHJvY2Vzcy5TVERPVVQsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVudj1lbnYpCiAK