36582 2010-03-25 00:07:29 -0700 REGRESSION: webkit-patch land can't land "rubber-stamped" patches 2010-03-25 19:21:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 203852 0 eric 2010-03-25 00:07:29 -0700 REGRESSION: webkit-patch land can't land "rubber-stamped" patches I don't think land should be nearly so strict in the manual use case. It should probably just warn. 204264 1 abarth 2010-03-25 15:46:40 -0700 Fixed in http://trac.webkit.org/changeset/56554 204271 2 eric 2010-03-25 15:54:46 -0700 Sigh. I don't think that we should be prescribing "rubber stamp". It's common for folks to use "rubber-stamped". 204298 3 abarth 2010-03-25 16:33:23 -0700 ok 204300 4 51690 abarth 2010-03-25 16:34:24 -0700 Created attachment 51690 Patch 204301 5 51690 eric 2010-03-25 16:37:34 -0700 Comment on attachment 51690 Patch I still think this is error prone. I'm also saddened by lack of testing on this step. 204303 6 51690 abarth 2010-03-25 16:42:30 -0700 Comment on attachment 51690 Patch Yeah. It's a bit of an experiment. We might need to try a different approach at some point. 204379 7 51690 commit-queue 2010-03-25 19:21:15 -0700 Comment on attachment 51690 Patch Clearing flags on attachment: 51690 Committed r56589: <http://trac.webkit.org/changeset/56589> 204380 8 commit-queue 2010-03-25 19:21:20 -0700 All reviewed patches have been landed. Closing bug. 51690 2010-03-25 16:34:24 -0700 2010-03-25 19:21:15 -0700 Patch bug-36582-20100325163423.patch text/plain 1356 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwNmE1MjU3Li4yYjEzODg1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMt MjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OOiB3ZWJraXQtcGF0Y2ggbGFu ZCBjYW4ndCBsYW5kICJydWJiZXItc3RhbXBlZCIgcGF0Y2hlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY1ODIKKworICAgICAgICBBbGxvdyBhICIt IiBpbiBydWJiZXIgc3RhbXBlZC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9z dGVwcy92YWxpZGF0ZXJldmlld2VyLnB5OgorCiAyMDEwLTAzLTI1ICBMYXN6bG8gR29tYm9zICA8 bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBm aXguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMv dmFsaWRhdGVyZXZpZXdlci5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9z dGVwcy92YWxpZGF0ZXJldmlld2VyLnB5CmluZGV4IDg3MWEyZGEuLjQwYjNkM2IgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy92YWxpZGF0ZXJldmll d2VyLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy92YWxp ZGF0ZXJldmlld2VyLnB5CkBAIC00NSw3ICs0NSw3IEBAIGNsYXNzIFZhbGlkYXRlUmV2aWV3ZXIo QWJzdHJhY3RTdGVwKToKICAgICAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAgaWYg cmUuc2VhcmNoKCJ1bnJldmlld2VkIiwgY2hhbmdlbG9nX2VudHJ5LmNvbnRlbnRzKCksIHJlLklH Tk9SRUNBU0UpOgogICAgICAgICAgICAgICAgIGNvbnRpbnVlCi0gICAgICAgICAgICBpZiByZS5z ZWFyY2goInJ1YmJlciBzdGFtcCIsIGNoYW5nZWxvZ19lbnRyeS5jb250ZW50cygpLCByZS5JR05P UkVDQVNFKToKKyAgICAgICAgICAgIGlmIHJlLnNlYXJjaCgicnViYmVyWyAtXXN0YW1wIiwgY2hh bmdlbG9nX2VudHJ5LmNvbnRlbnRzKCksIHJlLklHTk9SRUNBU0UpOgogICAgICAgICAgICAgICAg IGNvbnRpbnVlCiAgICAgICAgICAgICByZXZpZXdlcl90ZXh0ID0gY2hhbmdlbG9nX2VudHJ5LnJl dmlld2VyX3RleHQoKQogICAgICAgICAgICAgaWYgcmV2aWV3ZXJfdGV4dDoK