<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36579</bug_id>
          
          <creation_ts>2010-03-24 22:21:21 -0700</creation_ts>
          <short_desc>Abstract LayoutTestResults logic for easier reuse</short_desc>
          <delta_ts>2010-03-24 23:23:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>203797</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-24 22:21:21 -0700</bug_when>
    <thetext>Abstract LayoutTestResults logic for easier reuse</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>203799</commentid>
    <comment_count>1</comment_count>
      <attachid>51595</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-24 22:23:07 -0700</bug_when>
    <thetext>Created attachment 51595
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>203800</commentid>
    <comment_count>2</comment_count>
      <attachid>51595</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-03-24 22:24:13 -0700</bug_when>
    <thetext>Comment on attachment 51595
Patch

Great!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>203802</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-24 22:26:01 -0700</bug_when>
    <thetext>Committed r56488: &lt;http://trac.webkit.org/changeset/56488&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>203825</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-24 23:23:18 -0700</bug_when>
    <thetext>Committed r56496: &lt;http://trac.webkit.org/changeset/56496&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>51595</attachid>
            <date>2010-03-24 22:23:07 -0700</date>
            <delta_ts>2010-03-24 22:24:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-36579-20100324222306.patch</filename>
            <type>text/plain</type>
            <size>5662</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA3NzQ0YmEyLi41YjM2YjA2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTAtMDMt
MjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFic3RyYWN0IExheW91dFRlc3RSZXN1bHRzIGxv
Z2ljIGZvciBlYXNpZXIgcmV1c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTM2NTc5CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2J1aWxkYm90
LnB5OgorICAgICAgICAgLSBTcGxpdCBvdXQgbG9naWMgaW50byBuZXcgTGF5b3V0VGVzdFJlc3Vs
dHMgY2xhc3MuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9idWlsZGJvdF91bml0dGVzdC5w
eToKKyAgICAgICAgIC0gUmVuYW1lIHRoZSB0ZXN0aW5nIGNsYXNzIHRvIG1hdGNoLgorICAgICAg
ICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvcXVlcmllcy5weToKKyAgICAgICAgIC0gVXNl
IHRoZSBuZXcgTGF5b3V0VGVzdFJlc3VsdHMgY2xhc3MuCisKKzIwMTAtMDMtMjQgIEVyaWMgU2Vp
ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs
LgogCiAgICAgICAgIE1vdmUgQnVnemlsbGEucHJvbXB0X2Zvcl9jb21wb25lbnQgdG8gVXNlci5w
cm9tcHRfd2l0aF9saXN0IGZvciByZS11c2UKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvYnVpbGRib3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1
aWxkYm90LnB5CmluZGV4IGZmZjA2MTcuLjRjMDdhZjkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz
L1NjcmlwdHMvd2Via2l0cHkvYnVpbGRib3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93
ZWJraXRweS9idWlsZGJvdC5weQpAQCAtMTUwLDYgKzE1MCw0NCBAQCBjbGFzcyBCdWlsZGVyKG9i
amVjdCk6CiAgICAgICAgIHJldHVybiBzdXNwZWN0X3JldmlzaW9ucwogCiAKK2NsYXNzIExheW91
dFRlc3RSZXN1bHRzKG9iamVjdCk6CisgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIF9wYXJzZV9y
ZXN1bHRzX2h0bWwoY2xzLCBwYWdlKToKKyAgICAgICAgcGFyc2VkX3Jlc3VsdHMgPSB7fQorICAg
ICAgICB0YWJsZXMgPSBCZWF1dGlmdWxTb3VwKHBhZ2UpLmZpbmRBbGwoInRhYmxlIikKKyAgICAg
ICAgZm9yIHRhYmxlIGluIHRhYmxlczoKKyAgICAgICAgICAgIHRhYmxlX3RpdGxlID0gdGFibGUu
ZmluZFByZXZpb3VzU2libGluZygicCIpLnN0cmluZworICAgICAgICAgICAgIyBXZSBtaWdodCB3
YW50IHRvIHRyYW5zbGF0ZSB0YWJsZSB0aXRsZXMgaW50byBpZGVudGlmaWVycyBhdCBzb21lIHBv
aW50LgorICAgICAgICAgICAgcGFyc2VkX3Jlc3VsdHNbdGFibGVfdGl0bGVdID0gW3Jvdy5maW5k
KCJhIikuc3RyaW5nIGZvciByb3cgaW4gdGFibGUuZmluZEFsbCgidHIiKV0KKworICAgICAgICBy
ZXR1cm4gcGFyc2VkX3Jlc3VsdHMKKworICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBfZmV0Y2hf
cmVzdWx0c19odG1sKGNscywgYmFzZV91cmwpOgorICAgICAgICByZXN1bHRzX2h0bWwgPSAiJXMv
cmVzdWx0cy5odG1sIiAlIGJhc2VfdXJsCisgICAgICAgICMgRklYTUU6IFdlIG5lZWQgdG8gbW92
ZSB0aGlzIHNvcnQgb2YgNDA0IGxvZ2ljIGludG8gTmV0d29ya1RyYW5zYWN0aW9uIG9yIHNpbWls
YXIuCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHBhZ2UgPSB1cmxsaWIyLnVybG9wZW4ocmVz
dWx0c19odG1sKQorICAgICAgICAgICAgcmV0dXJuIGNscy5fcGFyc2VfcmVzdWx0c19odG1sKHBh
Z2UpCisgICAgICAgIGV4Y2VwdCB1cmxsaWIyLkhUVFBFcnJvciwgZXJyb3I6CisgICAgICAgICAg
ICBpZiBlcnJvci5jb2RlICE9IDQwNDoKKyAgICAgICAgICAgICAgICByYWlzZQorCisgICAgQGNs
YXNzbWV0aG9kCisgICAgZGVmIHJlc3VsdHNfZnJvbV91cmwoY2xzLCBiYXNlX3VybCk6CisgICAg
ICAgIHBhcnNlZF9yZXN1bHRzID0gY2xzLl9mZXRjaF9yZXN1bHRzX2h0bWwoYmFzZV91cmwpCisg
ICAgICAgIGlmIG5vdCBwYXJzZWRfcmVzdWx0czoKKyAgICAgICAgICAgIHJldHVybiBOb25lCisg
ICAgICAgIHJldHVybiBjbHMoYmFzZV91cmwsIHBhcnNlZF9yZXN1bHRzKQorCisgICAgZGVmIF9f
aW5pdF9fKHNlbGYsIGJhc2VfdXJsLCBwYXJzZWRfcmVzdWx0cyk6CisgICAgICAgIHNlbGYuX2Jh
c2VfdXJsID0gYmFzZV91cmwKKyAgICAgICAgc2VsZi5fcGFyc2VkX3Jlc3VsdHMgPSBwYXJzZWRf
cmVzdWx0cworCisgICAgZGVmIHBhcnNlZF9yZXN1bHRzKHNlbGYpOgorICAgICAgICByZXR1cm4g
c2VsZi5fcGFyc2VkX3Jlc3VsdHMKKworCiBjbGFzcyBCdWlsZChvYmplY3QpOgogICAgIGRlZiBf
X2luaXRfXyhzZWxmLCBidWlsZGVyLCBidWlsZF9udW1iZXIsIHJldmlzaW9uLCBpc19ncmVlbik6
CiAgICAgICAgIHNlbGYuX2J1aWxkZXIgPSBidWlsZGVyCkBAIC0xNjksMjcgKzIwNyw5IEBAIGNs
YXNzIEJ1aWxkKG9iamVjdCk6CiAgICAgICAgIHJlc3VsdHNfZGlyZWN0b3J5ID0gInIlcyAoJXMp
IiAlIChzZWxmLnJldmlzaW9uKCksIHNlbGYuX251bWJlcikKICAgICAgICAgcmV0dXJuICIlcy8l
cyIgJSAoc2VsZi5fYnVpbGRlci5yZXN1bHRzX3VybCgpLCB1cmxsaWIucXVvdGUocmVzdWx0c19k
aXJlY3RvcnkpKQogCi0gICAgZGVmIF9wYXJzZV9sYXlvdXRfdGVzdF9yZXN1bHRzKHNlbGYsIHBh
Z2UpOgotICAgICAgICBsYXlvdXRfdGVzdF9yZXN1bHRzID0ge30KLSAgICAgICAgdGFibGVzID0g
QmVhdXRpZnVsU291cChwYWdlKS5maW5kQWxsKCJ0YWJsZSIpCi0gICAgICAgIGZvciB0YWJsZSBp
biB0YWJsZXM6Ci0gICAgICAgICAgICB0YWJsZV90aXRsZSA9IHRhYmxlLmZpbmRQcmV2aW91c1Np
YmxpbmcoInAiKS5zdHJpbmcKLSAgICAgICAgICAgIGxheW91dF90ZXN0X3Jlc3VsdHNbdGFibGVf
dGl0bGVdID0gW3Jvdy5maW5kKCJhIikuc3RyaW5nIGZvciByb3cgaW4gdGFibGUuZmluZEFsbCgi
dHIiKV0KLQotICAgICAgICByZXR1cm4gbGF5b3V0X3Rlc3RfcmVzdWx0cwotCi0gICAgZGVmIF9m
ZXRjaF9sYXlvdXRfdGVzdF9yZXN1bHRzKHNlbGYpOgotICAgICAgICByZXN1bHRzX2h0bWwgPSAi
JXMvcmVzdWx0cy5odG1sIiAlIHNlbGYucmVzdWx0c191cmwoKQotICAgICAgICB0cnk6Ci0gICAg
ICAgICAgICBwYWdlID0gdXJsbGliMi51cmxvcGVuKHJlc3VsdHNfaHRtbCkKLSAgICAgICAgICAg
IHJldHVybiBzZWxmLl9wYXJzZV9sYXlvdXRfdGVzdF9yZXN1bHRzKHBhZ2UpCi0gICAgICAgIGV4
Y2VwdCB1cmxsaWIyLkhUVFBFcnJvciwgZXJyb3I6Ci0gICAgICAgICAgICBpZiBlcnJvci5jb2Rl
ICE9IDQwNDoKLSAgICAgICAgICAgICAgICByYWlzZQotCiAgICAgZGVmIGxheW91dF90ZXN0X3Jl
c3VsdHMoc2VsZik6CiAgICAgICAgIGlmIG5vdCBzZWxmLl9sYXlvdXRfdGVzdF9yZXN1bHRzOgot
ICAgICAgICAgICAgc2VsZi5fbGF5b3V0X3Rlc3RfcmVzdWx0cyA9IHNlbGYuX2ZldGNoX2xheW91
dF90ZXN0X3Jlc3VsdHMoKQorICAgICAgICAgICAgc2VsZi5fbGF5b3V0X3Rlc3RfcmVzdWx0cyA9
IExheW91dFRlc3RSZXN1bHRzLnJlc3VsdHNfZnJvbV91cmwoc2VsZi5yZXN1bHRzX3VybCgpKQog
ICAgICAgICByZXR1cm4gc2VsZi5fbGF5b3V0X3Rlc3RfcmVzdWx0cwogCiAgICAgZGVmIGJ1aWxk
ZXIoc2VsZik6CkBAIC0yMDgsNyArMjI4LDcgQEAgY2xhc3MgQnVpbGQob2JqZWN0KToKIAogCiBj
bGFzcyBCdWlsZEJvdChvYmplY3QpOgotCisgICAgIyBGSVhNRTogVGhpcyBzaG91bGQgbW92ZSBp
bnRvIHNvbWUgc29ydCBvZiB3ZWJraXRfY29uZmlnLnB5CiAgICAgZGVmYXVsdF9ob3N0ID0gImJ1
aWxkLndlYmtpdC5vcmciCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgaG9zdD1kZWZhdWx0X2hv
c3QpOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWlsZGJvdF91
bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYnVpbGRib3RfdW5pdHRl
c3QucHkKaW5kZXggZTQxN2QxNC4uYTJlNjgyOCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9idWlsZGJvdF91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp
cHRzL3dlYmtpdHB5L2J1aWxkYm90X3VuaXR0ZXN0LnB5CkBAIC04Myw3ICs4Myw3IEBAIGNsYXNz
IEJ1aWxkZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0
RXF1YWwoc2VsZi5idWlsZGVyLl9yZXZpc2lvbl9hbmRfYnVpbGRfZm9yX2ZpbGVuYW1lKGZpbGVu
YW1lKSwgcmV2aXNpb25fYW5kX2J1aWxkKQogCiAKLWNsYXNzIEJ1aWxkVGVzdCh1bml0dGVzdC5U
ZXN0Q2FzZSk6CitjbGFzcyBMYXlvdXRUZXN0UmVzdWx0c1Rlc3QodW5pdHRlc3QuVGVzdENhc2Up
OgogICAgIF9leGFtcGxlX3Jlc3VsdHNfaHRtbCA9ICIiIgogPGh0bWw+CiA8aGVhZD4KQEAgLTEx
OCw4ICsxMTgsNyBAQCBjbGFzcyBCdWlsZFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAg
ICBdCiAgICAgfQogICAgIGRlZiB0ZXN0X3BhcnNlX2xheW91dF90ZXN0X3Jlc3VsdHMoc2VsZik6
Ci0gICAgICAgIGJ1aWxkID0gQnVpbGQoTm9uZSwgcmV2aXNpb249MSwgYnVpbGRfbnVtYmVyPTEs
IGlzX2dyZWVuPUZhbHNlKQotICAgICAgICByZXN1bHRzID0gYnVpbGQuX3BhcnNlX2xheW91dF90
ZXN0X3Jlc3VsdHMoc2VsZi5fZXhhbXBsZV9yZXN1bHRzX2h0bWwpCisgICAgICAgIHJlc3VsdHMg
PSBMYXlvdXRUZXN0UmVzdWx0cy5fcGFyc2VfcmVzdWx0c19odG1sKHNlbGYuX2V4YW1wbGVfcmVz
dWx0c19odG1sKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuX2V4cGVjdGVkX2xheW91
dF90ZXN0X3Jlc3VsdHMsIHJlc3VsdHMpCiAKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93
ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5CmluZGV4IDc0ZDY4MjAuLjUxODdmMTggMTAwNjQ0
Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvcXVlcmllcy5weQor
KysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXJpZXMucHkKQEAg
LTE3Niw3ICsxNzYsNyBAQCBjbGFzcyBSZXN1bHRzRm9yKEFic3RyYWN0RGVjbGFyYXRpdmVDb21t
YW5kKToKICAgICAgICAgaWYgbm90IHJlc3VsdHM6CiAgICAgICAgICAgICBwcmludCAiIE5vIHJl
c3VsdHMuIgogICAgICAgICAgICAgcmV0dXJuCi0gICAgICAgIGZvciB0aXRsZSwgZmlsZXMgaW4g
cmVzdWx0cy5pdGVtcygpOgorICAgICAgICBmb3IgdGl0bGUsIGZpbGVzIGluIHJlc3VsdHMucGFy
c2VkX3Jlc3VsdHMoKS5pdGVtcygpOgogICAgICAgICAgICAgcHJpbnQgIiAlcyIgJSB0aXRsZQog
ICAgICAgICAgICAgZm9yIGZpbGVuYW1lIGluIGZpbGVzOgogICAgICAgICAgICAgICAgIHByaW50
ICIgICVzIiAlIGZpbGVuYW1lCg==
</data>
<flag name="review"
          id="34875"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>