36576 2010-03-24 20:55:15 -0700 The function "roundf" included in math.h on solaris 2023-02-01 17:56:15 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Other RESOLVED INVALID PlatformOnly P3 Normal --- 0 yuntong.jin webkit-unassigned ahmad.saleem792 ap roche+webkit oldest_to_newest 203768 0 51590 yuntong.jin 2010-03-24 20:55:15 -0700 Created attachment 51590 The function "roundf" included in math.h on solaris "./WebCore/platform/graphics/FloatSize.h", line 134: Error: The function "roundf" must have a prototype. "./WebCore/platform/graphics/FloatSize.h", line 134: Error: The function "roundf" must have a prototype. "./WebCore/platform/graphics/FloatPoint.h", line 155: Error: The function "roundf" must have a prototype. "./WebCore/platform/graphics/FloatPoint.h", line 155: Error: The function "roundf" must have a prototype. 4 Error(s) detected. 203839 1 51590 eric 2010-03-24 23:50:05 -0700 Comment on attachment 51590 The function "roundf" included in math.h on solaris Every change requires a ChangeLog. See http://webkit.org/coding/contributing.html. I'm not sure if MathExtras.h is supposed to include math.h or not. 467849 2 roche+webkit 2011-09-15 09:25:56 -0700 Also required for GCC. Hence I would suggest: --- src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h.orig Wed Sep 14 13:22:06 2011 +++ src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h Wed Sep 14 11:58:35 2011 @@ -190,7 +190,7 @@ inline float rad2grad(float r) { return r * 200.0f / piFloat; } inline float grad2rad(float g) { return g * piFloat / 200.0f; } -#if !COMPILER(MSVC) && !OS(ANDROID) && !OS(SYMBIAN) +#if !COMPILER(MSVC) && !OS(ANDROID) && !OS(SYMBIAN) && !OS(SOLARIS) using std::isfinite; using std::isinf; using std::isnan; 1930263 3 ahmad.saleem792 2023-02-01 14:07:03 -0800 Do we have Solaris port? Or we can close this unless if this is extended to any other linux port? 1930333 4 ap 2023-02-01 17:56:15 -0800 OS(SOLARIS) is gone, and in any case, I'd expect this to have been fixed since 2010 if it was still needed. 51590 2010-03-24 20:55:15 -0700 2010-06-11 10:31:05 -0700 The function "roundf" included in math.h on solaris 2-MathExtras.diff text/plain 872 yuntong.jin ZGlmZiAtciBiNjVkMDA1N2EyZjMgSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAotLS0g YS9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCVR1ZSBNYXIgMjMgMTg6NDk6MjkgMjAx MCArMDgwMAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCVR1ZSBNYXIgMjMg MTk6MDA6NTMgMjAxMCArMDgwMApAQCAtMTg2LDcgKzE4Niw3IEBACiBpbmxpbmUgZmxvYXQgcmFk MmdyYWQoZmxvYXQgcikgeyByZXR1cm4gciAqIDIwMC4wZiAvIHBpRmxvYXQ7IH0KIGlubGluZSBm bG9hdCBncmFkMnJhZChmbG9hdCBnKSB7IHJldHVybiBnICogcGlGbG9hdCAvIDIwMC4wZjsgfQog Ci0jaWYgIUNPTVBJTEVSKE1TVkMpICYmICFDT01QSUxFUihSVkNUKSAmJiAhT1MoQU5EUk9JRCkg JiYgIUNPTVBJTEVSKFdJTlNDVykKKyNpZiAhQ09NUElMRVIoTVNWQykgJiYgIUNPTVBJTEVSKFJW Q1QpICYmICFPUyhBTkRST0lEKSAmJiAhQ09NUElMRVIoV0lOU0NXKSAmJiAhQ09NUElMRVIoU1VO Q0MpCiB1c2luZyBzdGQ6OmlzZmluaXRlOwogdXNpbmcgc3RkOjppc2luZjsKIHVzaW5nIHN0ZDo6 aXNuYW47CmRpZmYgLXIgZDc0M2VmYWI0Y2I1IEphdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFz LmgKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAlXZWQgTWFyIDI0IDE4OjE2 OjM5IDIwMTAgKzA4MDAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAlUaHUg TWFyIDI1IDEwOjU1OjQzIDIwMTAgKzA4MDAKQEAgLTMyLDYgKzMyLDcgQEAKIAogI2lmIE9TKFNP TEFSSVMpCiAjaW5jbHVkZSA8aWVlZWZwLmg+CisjaW5jbHVkZSA8bWF0aC5oPgogI2VuZGlmCiAK ICNpZiBPUyhPUEVOQlNEKQo=