36553 2010-03-24 13:50:21 -0700 [Qt] Missing QWebSettings for Frame Flattening 2010-03-26 07:05:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All CLOSED FIXED Qt P2 Normal --- 35784 36558 1 jesus jesus commit-queue eric hausmann kenneth ossy tonikitoo oldest_to_newest 203560 0 jesus 2010-03-24 13:50:21 -0700 [Qt] Missing QWebSettings for Frame Flattening 203564 1 51539 jesus 2010-03-24 13:54:58 -0700 Created attachment 51539 Patch 203622 2 jesus 2010-03-24 15:03:16 -0700 This same setting will also set iFrame Flattening when available. 203639 3 kenneth 2010-03-24 15:12:19 -0700 Looks good, but it would be nice if one from the doc team could review the documentation. Simon, could you get one to do that? 203644 4 jesus 2010-03-24 15:15:50 -0700 (In reply to comment #3) > Looks good, but it would be nice if one from the doc team could review the > documentation. > > Simon, could you get one to do that? Yes, this would be nice. Also I noticed that documentation for QWebSettings:WebGL is missing. Should I open a bug report for that or the doc team is working on this?! thanks for the review! 203690 5 51539 commit-queue 2010-03-24 17:02:45 -0700 Comment on attachment 51539 Patch Clearing flags on attachment: 51539 Committed r56473: <http://trac.webkit.org/changeset/56473> 203691 6 commit-queue 2010-03-24 17:02:49 -0700 All reviewed patches have been landed. Closing bug. 203873 7 ossy 2010-03-25 00:42:53 -0700 Guys, you broke ( but most of all fix :) ) fast/frames/flattening/frameset-flattening-grid.html with this patch http://build.webkit.org/results/Qt%20Linux%20Release/r56474%20%289010%29/results.html Could you update the platform specific expected file if the new result is correct? 204075 8 tonikitoo 2010-03-25 08:25:01 -0700 (In reply to comment #7) > Guys, you broke ( but most of all fix :) ) > fast/frames/flattening/frameset-flattening-grid.html with this patch > http://build.webkit.org/results/Qt%20Linux%20Release/r56474%20%289010%29/results.html > > Could you update the platform specific expected file if the new result is > correct? diego found the problem, got a patch, kenneth reviewed and i landed. r56547 204182 9 eric 2010-03-25 11:59:56 -0700 (In reply to comment #8) > (In reply to comment #7) > > Guys, you broke ( but most of all fix :) ) > > fast/frames/flattening/frameset-flattening-grid.html with this patch > > http://build.webkit.org/results/Qt%20Linux%20Release/r56474%20%289010%29/results.html > > > > Could you update the platform specific expected file if the new result is > > correct? > > diego found the problem, got a patch, kenneth reviewed and i landed. > > r56547 Leopard is still broken. The patch you committed did not reference this bug. :( 204194 10 ossy 2010-03-25 12:43:47 -0700 (In reply to comment #9) > Leopard is still broken. > > The patch you committed did not reference this bug. :( Needless newline removed by http://trac.webkit.org/changeset/56561 and Leopard is green again. 204520 11 hausmann 2010-03-26 05:41:00 -0700 cherry-pick-for-backport: <r56547> cherry-pick-for-backport: <r56561> 204522 12 hausmann 2010-03-26 05:42:13 -0700 cherry-pick-for-backport: <r56561> 204537 13 hausmann 2010-03-26 06:29:56 -0700 cherry-pick-for-backport: <r56557> 204545 14 hausmann 2010-03-26 07:04:59 -0700 Revision r56473 cherry-picked into qtwebkit-2.0 with commit 289b7bf993b1cb6c896142c868c674925182a197 204546 15 hausmann 2010-03-26 07:05:09 -0700 Revision r56547 cherry-picked into qtwebkit-2.0 with commit c4fe1ca4a566b93a2f35a0d112fc1b2da12ba2dc 204547 16 hausmann 2010-03-26 07:05:18 -0700 Revision r56557 cherry-picked into qtwebkit-2.0 with commit 9b559418e4e199551fb30218390d03e596f80f9b 204548 17 hausmann 2010-03-26 07:05:29 -0700 Revision r56561 cherry-picked into qtwebkit-2.0 with commit 1989edbb25a211a0638ff8369999e02d254c8630 51539 2010-03-24 13:54:58 -0700 2010-03-24 17:02:44 -0700 Patch bug-36553-20100324175657.patch text/plain 3317 jesus ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCBjYTdkYWYwLi5kZWY0MjJkIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC0xOTUsNiArMTk1LDEwIEBAIHZvaWQgUVdlYlNldHRpbmdzUHJpdmF0ZTo6 YXBwbHkoKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbG9iYWwtPmF0 dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpEZXZlbG9wZXJFeHRyYXNFbmFibGVkKSk7CiAg ICAgICAgIHNldHRpbmdzLT5zZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKHZhbHVlKTsKIAorICAg ICAgICB2YWx1ZSA9IGF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpGcmFtZUZsYXR0ZW5p bmdFbmFibGVkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbG9iYWwt PmF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpGcmFtZUZsYXR0ZW5pbmdFbmFibGVkKSk7 CisgICAgICAgIHNldHRpbmdzLT5zZXRGcmFtZVNldEZsYXR0ZW5pbmdFbmFibGVkKHZhbHVlKTsK KwogICAgICAgICBRVXJsIGxvY2F0aW9uID0gIXVzZXJTdHlsZVNoZWV0TG9jYXRpb24uaXNFbXB0 eSgpID8gdXNlclN0eWxlU2hlZXRMb2NhdGlvbiA6IGdsb2JhbC0+dXNlclN0eWxlU2hlZXRMb2Nh dGlvbjsKICAgICAgICAgc2V0dGluZ3MtPnNldFVzZXJTdHlsZVNoZWV0TG9jYXRpb24oV2ViQ29y ZTo6S1VSTChsb2NhdGlvbikpOwogCkBAIC00MDEsNiArNDA1LDEyIEBAIFFXZWJTZXR0aW5ncyog UVdlYlNldHRpbmdzOjpnbG9iYWxTZXR0aW5ncygpCiAgICAgICAgIFFHcmFwaGljc1dlYlZpZXcs IGFjY2VsZXJhdGVzIGFuaW1hdGlvbnMgb2Ygd2ViIGNvbnRlbnQuIENTUyBhbmltYXRpb25zIG9m IHRoZSB0cmFuc2Zvcm0gYW5kCiAgICAgICAgIG9wYWNpdHkgcHJvcGVydGllcyB3aWxsIGJlIHJl bmRlcmVkIGJ5IGNvbXBvc2luZyB0aGUgY2FjaGVkIGNvbnRlbnQgb2YgdGhlIGFuaW1hdGVkIGVs ZW1lbnRzLgogICAgICAgICBUaGlzIGZlYXR1cmUgaXMgZW5hYmxlZCBieSBkZWZhdWx0CisgICAg XHZhbHVlIEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQgV2l0aCB0aGlzIHNldHRpbmcgZWFjaCBzdWJm cmFtZSBpcyBleHBhbmRlZCB0byBpdHMgY29udGVudHMuCisgICAgICAgIE9uIHRvdWNoIGRldmlj ZXMsIGl0IGlzIGRlc2lyZWQgdG8gbm90IGhhdmUgYW55IHNjcm9sbGFibGUgc3ViIHBhcnRzIG9m IHRoZSBwYWdlCisgICAgICAgIGFzIGl0IHJlc3VsdHMgaW4gYSBjb25mdXNpbmcgdXNlciBleHBl cmllbmNlLCB3aXRoIHNjcm9sbGluZyBzb21ldGltZXMgc2Nyb2xsaW5nIHN1YiBwYXJ0cworICAg ICAgICBhbmQgYXQgb3RoZXIgdGltZXMgc2Nyb2xsaW5nIHRoZSBwYWdlIGl0c2VsZi4gRm9yIHRo aXMgcmVhc29uIGlmcmFtZXMgYW5kIGZyYW1lc2V0cyBhcmUKKyAgICAgICAgYmFyZWx5IHVzYWJs ZSBvbiB0b3VjaCBkZXZpY2VzLiBUaGlzIHdpbGwgZmxhdHRlbiBhbGwgdGhlIGZyYW1lcyB0byBi ZWNvbWUgb25lIHNjcm9sbGFibGUgcGFnZS4KKyAgICAgICAgRGlzYWJsZWQgYnkgZGVmYXVsdC4K ICovCiAKIC8qIQpAQCAtNDM1LDYgKzQ0NSw3IEBAIFFXZWJTZXR0aW5nczo6UVdlYlNldHRpbmdz KCkKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OkxvY2FsQ29udGVudENh bkFjY2Vzc0ZpbGVVcmxzLCB0cnVlKTsKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0 dGluZ3M6OkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkLCB0cnVlKTsKICAgICBkLT5hdHRy aWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OldlYkdMRW5hYmxlZCwgZmFsc2UpOworICAgIGQt PmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6RnJhbWVGbGF0dGVuaW5nRW5hYmxlZCwg ZmFsc2UpOwogICAgIGQtPm9mZmxpbmVTdG9yYWdlRGVmYXVsdFF1b3RhID0gNSAqIDEwMjQgKiAx MDI0OwogICAgIGQtPmRlZmF1bHRUZXh0RW5jb2RpbmcgPSBRTGF0aW4xU3RyaW5nKCJpc28tODg1 OS0xIik7CiB9CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oIGIvV2Vi S2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAppbmRleCBkYzJiY2UwLi5jYWJhMGQ1IDEwMDY0NAot LS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdl YnNldHRpbmdzLmgKQEAgLTczLDcgKzczLDggQEAgcHVibGljOgogICAgICAgICBXZWJHTEVuYWJs ZWQsCiAgICAgICAgIFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCwKICAgICAgICAgTG9jYWxDb250 ZW50Q2FuQWNjZXNzRmlsZVVybHMsCi0gICAgICAgIFRpbGVkQmFja2luZ1N0b3JlRW5hYmxlZAor ICAgICAgICBUaWxlZEJhY2tpbmdTdG9yZUVuYWJsZWQsCisgICAgICAgIEZyYW1lRmxhdHRlbmlu Z0VuYWJsZWQKICAgICB9OwogICAgIGVudW0gV2ViR3JhcGhpYyB7CiAgICAgICAgIE1pc3NpbmdJ bWFnZUdyYXBoaWMsCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0 L0NoYW5nZUxvZwppbmRleCA2MGI2NWE3Li5mZjlmNWU5IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQv Q2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx MC0wMy0yNCAgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGplc3VzLnBhbGVuY2lhQG9wZW5ib3Nz YS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHRoZSBGcmFtZUZsYXR0ZW5pbmdFbmFibGVkIFdlYkF0dHJpYnV0ZSB0byBRV2ViU2V0dGlu Z3MuCisKKyAgICAgICAgW1F0XSBNaXNzaW5nIFFXZWJTZXR0aW5ncyBmb3IgRnJhbWUgRmxhdHRl bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY1 NTMKKworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdlYlNldHRp bmdzUHJpdmF0ZTo6YXBwbHkpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3Mp OgorICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuaDoKKwogMjAxMC0wMy0yMyAgQW5kZXJzIEJh a2tlbiA8YW5kZXJzLmJha2tlbkBub2tpYS5jb20+LCBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhIDxq ZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgo=