36545 2010-03-24 10:39:36 -0700 [Chromium] Add an ASSERT macro to the Chromium WebKit API 2010-03-25 16:48:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow commit-queue fishd oldest_to_newest 203482 0 jorlow 2010-03-24 10:39:36 -0700 [Chromium] Add an ASSERT macro to the Chromium WebKit API 203485 1 51522 jorlow 2010-03-24 10:45:34 -0700 Created attachment 51522 Patch 203770 2 51522 fishd 2010-03-24 21:07:58 -0700 Comment on attachment 51522 Patch > +++ b/WebKit/chromium/public/WebCommon.h ... > } // namespace WebKit > > +// ----------------------------------------------------------------------------- > +// Assertions > + > +namespace WebKit { > + > +void failedAssertion(const char* file, int line, const char* function, const char* assertion); > + > +} // namespace WebKit Why close and then re-open the WebKit namespace? Please annotate WebKit API entry points with WEBKIT_API. > +// Only use inside the public directory but outside of WEBKIT_IMPLEMENTATION blocks. Otherwise use WTF's ASSERT. There is actually no problem using this outside of WEBKIT_IMPLEMENTATION blocks. > +#if defined(NDEBUG) > +#define WEBKIT_ASSERT(assertion) ((void)0) > +#else > +#define WEBKIT_ASSERT(assertion) do \ > + if (!(assertion)) { \ > + WebKit::failedAssertion(__FILE__, __LINE__, __FUNCTION__, #assertion); \ > + } \ ^^^ nit: webkit style says no brackets around single line statements. 203971 3 jorlow 2010-03-25 03:35:53 -0700 > > +// Only use inside the public directory but outside of WEBKIT_IMPLEMENTATION blocks. Otherwise use WTF's ASSERT. > > There is actually no problem using this outside of WEBKIT_IMPLEMENTATION > blocks. I know, but the WebCore asserts are more robust and have extra logic for turning them on/off. Just seemed like a good idea to point people in that direction primarily. > > +#if defined(NDEBUG) > > +#define WEBKIT_ASSERT(assertion) ((void)0) > > +#else > > +#define WEBKIT_ASSERT(assertion) do \ > > + if (!(assertion)) { \ > > + WebKit::failedAssertion(__FILE__, __LINE__, __FUNCTION__, #assertion); \ > > + } \ > > ^^^ nit: webkit style says no brackets around single line statements. Just copied what was in Assertions (and then removed a line). I suppose brackets should be around the do/while tho. 203974 4 51618 jorlow 2010-03-25 03:42:36 -0700 Created attachment 51618 fix issues 204307 5 51618 commit-queue 2010-03-25 16:48:40 -0700 Comment on attachment 51618 fix issues Clearing flags on attachment: 51618 Committed r56579: <http://trac.webkit.org/changeset/56579> 204308 6 commit-queue 2010-03-25 16:48:46 -0700 All reviewed patches have been landed. Closing bug. 51522 2010-03-24 10:45:34 -0700 2010-03-25 03:42:36 -0700 Patch bug-36545-20100324174532.patch text/plain 4974 jorlow ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDExYzNlZTUuLjYwYjhjNGUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDEwLTAzLTI0ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1 bV0gQWRkIGFuIEFTU0VSVCBtYWNybyB0byB0aGUgQ2hyb21pdW0gV2ViS2l0IEFQSQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY1NDUKKworICAgICAg ICAqIFdlYktpdC5neXA6ICBBZGQgV2ViQ29tbW9uLmNwcAorICAgICAgICAqIHB1YmxpYy9XZWJD b21tb24uaDogIEFkZCB0aGUgTWFjcm8uCisgICAgICAgICogcHVibGljL1dlYlByaXZhdGVQdHIu aDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJpdmF0ZVB0cjo6fldlYlByaXZhdGVQdHIpOiAgVmVy aWZ5IHRoZSBwb2ludGVyIGlzIG5vdyAwLgorICAgICAgICAqIHNyYy9XZWJDb21tb24uY3BwOiBB ZGRlZC4KKyAgICAgICAgKFdlYktpdDo6ZmFpbGVkQXNzZXJ0aW9uKTogQ2FsbHMgdGhlIFdURiBh c3NlcnQgZnVuY3Rpb24gYW5kIHRoZW4gY3Jhc2hlcy4KKwogMjAxMC0wMy0yMiAgRGFyaW4gRmlz aGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hh cGluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9XZWJLaXQvY2hy b21pdW0vV2ViS2l0Lmd5cAppbmRleCBkMjNkMjA1Li5jMjkwZGViIDEwMDY0NAotLS0gYS9XZWJL aXQvY2hyb21pdW0vV2ViS2l0Lmd5cAorKysgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cApA QCAtMjg1LDYgKzI4NSw3IEBACiAgICAgICAgICAgICAgICAgJ3NyYy9XZWJCaW5kaW5ncy5jcHAn LAogICAgICAgICAgICAgICAgICdzcmMvV2ViQ2FjaGUuY3BwJywKICAgICAgICAgICAgICAgICAn c3JjL1dlYkNvbG9yLmNwcCcsCisgICAgICAgICAgICAgICAgJ3NyYy9XZWJDb21tb24uY3BwJywK ICAgICAgICAgICAgICAgICAnc3JjL1dlYkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUu Y3BwJywKICAgICAgICAgICAgICAgICAnc3JjL1dlYkNTdHJpbmcuY3BwJywKICAgICAgICAgICAg ICAgICAnc3JjL1dlYkN1cnNvckluZm8uY3BwJywKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViQ29tbW9uLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbW1vbi5o CmluZGV4IGQzNDdlYTYuLjRjMmY5OTAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ29tbW9uLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb21tb24uaApA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDkgR29vZ2xlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNl IGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUg cGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAt OTEsNCArOTEsMjQgQEAgdHlwZWRlZiB1bnNpZ25lZCBzaG9ydCBXZWJVQ2hhcjsKIAogfSAvLyBu YW1lc3BhY2UgV2ViS2l0CiAKKy8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisvLyBBc3NlcnRpb25z CisKK25hbWVzcGFjZSBXZWJLaXQgeworCit2b2lkIGZhaWxlZEFzc2VydGlvbihjb25zdCBjaGFy KiBmaWxlLCBpbnQgbGluZSwgY29uc3QgY2hhciogZnVuY3Rpb24sIGNvbnN0IGNoYXIqIGFzc2Vy dGlvbik7CisKK30gLy8gbmFtZXNwYWNlIFdlYktpdAorCisvLyBPbmx5IHVzZSBpbnNpZGUgdGhl IHB1YmxpYyBkaXJlY3RvcnkgYnV0IG91dHNpZGUgb2YgV0VCS0lUX0lNUExFTUVOVEFUSU9OIGJs b2Nrcy4gIE90aGVyd2lzZSB1c2UgV1RGJ3MgQVNTRVJULgorI2lmIGRlZmluZWQoTkRFQlVHKQor I2RlZmluZSBXRUJLSVRfQVNTRVJUKGFzc2VydGlvbikgKCh2b2lkKTApCisjZWxzZQorI2RlZmlu ZSBXRUJLSVRfQVNTRVJUKGFzc2VydGlvbikgZG8gXAorICAgIGlmICghKGFzc2VydGlvbikpIHsg XAorICAgICAgICBXZWJLaXQ6OmZhaWxlZEFzc2VydGlvbihfX0ZJTEVfXywgX19MSU5FX18sIF9f RlVOQ1RJT05fXywgI2Fzc2VydGlvbik7IFwKKyAgICB9IFwKK3doaWxlICgwKQorI2VuZGlmCisK ICNlbmRpZgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQcml2YXRlUHRy LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlByaXZhdGVQdHIuaAppbmRleCA1ZGRmNWJh Li40OGFkN2YyIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlByaXZhdGVQ dHIuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlByaXZhdGVQdHIuaApAQCAtNDQs NiArNDQsNyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KIGNsYXNzIFdlYlByaXZhdGVQdHIgewog cHVibGljOgogICAgIFdlYlByaXZhdGVQdHIoKSA6IG1fcHRyKDApIHsgfQorICAgIH5XZWJQcml2 YXRlUHRyKCkgeyBXRUJLSVRfQVNTRVJUKCFtX3B0cik7IH0KIAogICAgIGJvb2wgaXNOdWxsKCkg Y29uc3QgeyByZXR1cm4gIW1fcHRyOyB9CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViQ29tbW9uLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQ29tbW9uLmNwcApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mOTQ1N2ZiCi0tLSAvZGV2L251bGwKKysr IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDb21tb24uY3BwCkBAIC0wLDAgKzEsNDQgQEAKKy8q CisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAg KiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNv cHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv d2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3Jt IG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRv Y3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorICog ZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBu b3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9y c2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0 aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZU V0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9S UworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNM VURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0Yg TUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0Ug QVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVS IE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJ REVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMg KElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRT OyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAq IFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ VFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5j bHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiV2ViQ29tbW9uLmgiCisKKyNpbmNsdWRlIDx3dGYv QXNzZXJ0aW9ucy5oPgorCituYW1lc3BhY2UgV2ViS2l0IHsKKwordm9pZCBmYWlsZWRBc3NlcnRp b24oY29uc3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0IGNoYXIqIGZ1bmN0aW9uLCBjb25z dCBjaGFyKiBhc3NlcnRpb24pCit7CisgICAgV1RGUmVwb3J0QXNzZXJ0aW9uRmFpbHVyZShmaWxl LCBsaW5lLCBmdW5jdGlvbiwgYXNzZXJ0aW9uKTsKKyAgICBDUkFTSCgpOworfQorCit9IC8vIG5h bWVzcGFjZSBXZWJLaXQK 51618 2010-03-25 03:42:36 -0700 2010-03-25 16:48:40 -0700 fix issues patch text/plain 4969 jorlow ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDExYzNlZTUuLjYwYjhjNGUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDEwLTAzLTI0ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1 bV0gQWRkIGFuIEFTU0VSVCBtYWNybyB0byB0aGUgQ2hyb21pdW0gV2ViS2l0IEFQSQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY1NDUKKworICAgICAg ICAqIFdlYktpdC5neXA6ICBBZGQgV2ViQ29tbW9uLmNwcAorICAgICAgICAqIHB1YmxpYy9XZWJD b21tb24uaDogIEFkZCB0aGUgTWFjcm8uCisgICAgICAgICogcHVibGljL1dlYlByaXZhdGVQdHIu aDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJpdmF0ZVB0cjo6fldlYlByaXZhdGVQdHIpOiAgVmVy aWZ5IHRoZSBwb2ludGVyIGlzIG5vdyAwLgorICAgICAgICAqIHNyYy9XZWJDb21tb24uY3BwOiBB ZGRlZC4KKyAgICAgICAgKFdlYktpdDo6ZmFpbGVkQXNzZXJ0aW9uKTogQ2FsbHMgdGhlIFdURiBh c3NlcnQgZnVuY3Rpb24gYW5kIHRoZW4gY3Jhc2hlcy4KKwogMjAxMC0wMy0yMiAgRGFyaW4gRmlz aGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hh cGluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9XZWJLaXQvY2hy b21pdW0vV2ViS2l0Lmd5cAppbmRleCBkMjNkMjA1Li5jMjkwZGViIDEwMDY0NAotLS0gYS9XZWJL aXQvY2hyb21pdW0vV2ViS2l0Lmd5cAorKysgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cApA QCAtMjg1LDYgKzI4NSw3IEBACiAgICAgICAgICAgICAgICAgJ3NyYy9XZWJCaW5kaW5ncy5jcHAn LAogICAgICAgICAgICAgICAgICdzcmMvV2ViQ2FjaGUuY3BwJywKICAgICAgICAgICAgICAgICAn c3JjL1dlYkNvbG9yLmNwcCcsCisgICAgICAgICAgICAgICAgJ3NyYy9XZWJDb21tb24uY3BwJywK ICAgICAgICAgICAgICAgICAnc3JjL1dlYkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUu Y3BwJywKICAgICAgICAgICAgICAgICAnc3JjL1dlYkNTdHJpbmcuY3BwJywKICAgICAgICAgICAg ICAgICAnc3JjL1dlYkN1cnNvckluZm8uY3BwJywKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViQ29tbW9uLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbW1vbi5o CmluZGV4IGQzNDdlYTYuLmU3ZTM4ZDMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ29tbW9uLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb21tb24uaApA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDkgR29vZ2xlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNl IGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUg cGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAt ODksNiArODksMjEgQEAgdHlwZWRlZiB3Y2hhcl90IFdlYlVDaGFyOwogdHlwZWRlZiB1bnNpZ25l ZCBzaG9ydCBXZWJVQ2hhcjsKICNlbmRpZgogCisvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorLy8g QXNzZXJ0aW9ucworCitXRUJLSVRfQVBJIHZvaWQgZmFpbGVkQXNzZXJ0aW9uKGNvbnN0IGNoYXIq IGZpbGUsIGludCBsaW5lLCBjb25zdCBjaGFyKiBmdW5jdGlvbiwgY29uc3QgY2hhciogYXNzZXJ0 aW9uKTsKKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKKy8vIElkZWFsbHksIG9ubHkgdXNlIGlu c2lkZSB0aGUgcHVibGljIGRpcmVjdG9yeSBidXQgb3V0c2lkZSBvZiBXRUJLSVRfSU1QTEVNRU5U QVRJT04gYmxvY2tzLiAgKE90aGVyd2lzZSB1c2UgV1RGJ3MgQVNTRVJULikKKyNpZiBkZWZpbmVk KE5ERUJVRykKKyNkZWZpbmUgV0VCS0lUX0FTU0VSVChhc3NlcnRpb24pICgodm9pZCkwKQorI2Vs c2UKKyNkZWZpbmUgV0VCS0lUX0FTU0VSVChhc3NlcnRpb24pIGRvIHsgXAorICAgIGlmICghKGFz c2VydGlvbikpIFwKKyAgICAgICAgZmFpbGVkQXNzZXJ0aW9uKF9fRklMRV9fLCBfX0xJTkVfXywg X19GVU5DVElPTl9fLCAjYXNzZXJ0aW9uKTsgXAorfSB3aGlsZSAoMCkKKyNlbmRpZgorCiAjZW5k aWYKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUHJpdmF0ZVB0ci5oIGIv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQcml2YXRlUHRyLmgKaW5kZXggNWRkZjViYS4uNDhh ZDdmMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQcml2YXRlUHRyLmgK KysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQcml2YXRlUHRyLmgKQEAgLTQ0LDYgKzQ0 LDcgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+CiBjbGFzcyBXZWJQcml2YXRlUHRyIHsKIHB1Ymxp YzoKICAgICBXZWJQcml2YXRlUHRyKCkgOiBtX3B0cigwKSB7IH0KKyAgICB+V2ViUHJpdmF0ZVB0 cigpIHsgV0VCS0lUX0FTU0VSVCghbV9wdHIpOyB9CiAKICAgICBib29sIGlzTnVsbCgpIGNvbnN0 IHsgcmV0dXJuICFtX3B0cjsgfQogCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YkNvbW1vbi5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkNvbW1vbi5jcHAKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZjk0NTdmYgotLS0gL2Rldi9udWxsCisrKyBiL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViQ29tbW9uLmNwcApAQCAtMCwwICsxLDQ0IEBACisvKgorICog Q29weXJpZ2h0IChDKSAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgor ICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisgKiBtZXQ6CisgKgorICogICAgICogUmVk aXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmln aHQKKyAqIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lci4KKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0 IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBj b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyAqIGluIHRoZSBkb2N1bWVu dGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyAqIGRpc3Ry aWJ1dGlvbi4KKyAqICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRo ZSBuYW1lcyBvZiBpdHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9y IHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQg c3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUg SVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyAq ICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5H LCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNI QU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyAqIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBE SVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisgKiBPV05FUiBPUiBD T05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRB TCwKKyAqIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNM VURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUg R09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorICogREFUQSwgT1IgUFJPRklUUzsgT1Ig QlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisgKiBUSEVP UlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBP UiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElO IEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURW SVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUg ImNvbmZpZy5oIgorI2luY2x1ZGUgIldlYkNvbW1vbi5oIgorCisjaW5jbHVkZSA8d3RmL0Fzc2Vy dGlvbnMuaD4KKworbmFtZXNwYWNlIFdlYktpdCB7CisKK3ZvaWQgZmFpbGVkQXNzZXJ0aW9uKGNv bnN0IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25zdCBjaGFyKiBmdW5jdGlvbiwgY29uc3QgY2hh ciogYXNzZXJ0aW9uKQoreworICAgIFdURlJlcG9ydEFzc2VydGlvbkZhaWx1cmUoZmlsZSwgbGlu ZSwgZnVuY3Rpb24sIGFzc2VydGlvbik7CisgICAgQ1JBU0goKTsKK30KKworfSAvLyBuYW1lc3Bh Y2UgV2ViS2l0Cg==