36532 2010-03-24 06:55:47 -0700 [Qt] Use integer pixel metric QFont API to fix rounding errors in text rendering on the Mac 2013-03-12 06:21:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other OS X 10.5 CLOSED FIXED Qt P3 Normal --- 93263 35784 1 hausmann hausmann allan.jensen commit-queue jesus vestbo oldest_to_newest 203401 0 hausmann 2010-03-24 06:55:47 -0700 On Qt/Mac font metrics do have fractions. WebKit's text layouting is integer based, therefore visual rounding issues appear when using QtWebKit with Qt/Mac. Eskil is adding new API to Qt 4.7 to disable fractions in pixel metrics. We should use this API. Patch is coming soon. 203955 1 51612 eblomfel 2010-03-25 02:42:24 -0700 Created attachment 51612 Turns off fractional metrics for fonts used in WebKit, since WebKit expects font engine to be integer-based Compiles against Qt 4.7 as soon as the Oslo2 staging branch integrates. 205485 2 vestbo 2010-03-29 09:27:49 -0700 I'll land this when the required changes in Qt have been integrated from oslo-staging-2 209596 3 jesus 2010-04-07 06:07:05 -0700 I think that oslo-staging-2 was integrated recently. Has this been landed yet? 211951 4 53250 jesus 2010-04-13 07:54:40 -0700 Created attachment 53250 Patch 211953 5 53251 jesus 2010-04-13 08:00:16 -0700 Created attachment 53251 Patch 211958 6 53251 commit-queue 2010-04-13 08:21:45 -0700 Comment on attachment 53251 Patch Clearing flags on attachment: 53251 Committed r57516: <http://trac.webkit.org/changeset/57516> 211959 7 commit-queue 2010-04-13 08:21:51 -0700 All reviewed patches have been landed. Closing bug. 214899 8 hausmann 2010-04-20 13:03:42 -0700 Revision r57516 cherry-picked into qtwebkit-2.0 with commit 692f59b5496489f88a49b4af6749b9b45df090ab 853406 9 allan.jensen 2013-03-12 06:21:07 -0700 I am not sure this hack is necesary. While WebKit still uses integer coordinates for layout (until we enable SUBPIXEL_LAYOUT). Text is not layed out using integers, but using floats. Or maybe the bug is that advances are being rounded when they shouldn't be? 51612 2010-03-25 02:42:24 -0700 2010-04-13 07:54:31 -0700 Turns off fractional metrics for fonts used in WebKit, since WebKit expects font engine to be integer-based bug36532.patch text/plain 1169 eblomfel ZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9Gb250UXQuY3BwIGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0ZvbnRRdC5jcHAKaW5kZXggYzU5NjBhYy4uM2ZjNzdjMyAxMDA2NDQKLS0tIGEv c3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5j cHAKKysrIGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0 L0ZvbnRRdC5jcHAKQEAgLTE4OSw3ICsxODksMTEgQEAgZmxvYXQgRm9udDo6ZmxvYXRXaWR0aEZv ckNvbXBsZXhUZXh0KGNvbnN0IFRleHRSdW4mIHJ1biwgSGFzaFNldDxjb25zdCBTaW1wbGVGb24K ICAgICBjb25zdCBRU3RyaW5nIHN0cmluZyA9IGZpeFNwYWNpbmcocXN0cmluZyhydW4pKTsKICAg ICBRVGV4dExheW91dCBsYXlvdXQoc3RyaW5nLCBmb250KCkpOwogICAgIFFUZXh0TGluZSBsaW5l ID0gc2V0dXBMYXlvdXQoJmxheW91dCwgcnVuKTsKKyNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJ T05fQ0hFQ0soNCwgNywgMCkKKyAgICBpbnQgdyA9IGludChsaW5lLmhvcml6b250YWxBZHZhbmNl KCkpOworI2Vsc2UKICAgICBpbnQgdyA9IGludChsaW5lLm5hdHVyYWxUZXh0V2lkdGgoKSk7Cisj ZW5kaWYKICAgICAvLyBXZWJLaXQgZXhwZWN0cyB1cyB0byBpZ25vcmUgd29yZCBzcGFjaW5nIG9u IHRoZSBmaXJzdCBjaGFyYWN0ZXIgKGFzIG9wcG9zZWQgdG8gd2hhdCBRdCBkb2VzKQogICAgIGlm ICh0cmVhdEFzU3BhY2UocnVuWzBdKSkKICAgICAgICAgdyAtPSBtX3dvcmRTcGFjaW5nOwpAQCAt MjI0LDYgKzIyOCw5IEBAIFFGb250IEZvbnQ6OmZvbnQoKSBjb25zdAogICAgIFFGb250IGYgPSBw cmltYXJ5Rm9udCgpLT5nZXRRdEZvbnQoKTsKICAgICBmLnNldExldHRlclNwYWNpbmcoUUZvbnQ6 OkFic29sdXRlU3BhY2luZywgbV9sZXR0ZXJTcGFjaW5nKTsKICAgICBmLnNldFdvcmRTcGFjaW5n KG1fd29yZFNwYWNpbmcpOworI2lmIFFUX1ZFUlNJT04gPj0gUVRfVkVSU0lPTl9DSEVDSyg0LCA3 LCAwKQorICAgIGYuc2V0U3R5bGVTdHJhdGVneShRRm9udDo6Rm9yY2VJbnRlZ2VyTWV0cmljcyk7 CisjZW5kaWYKICAgICByZXR1cm4gZjsKIH0KIAo= 53250 2010-04-13 07:54:40 -0700 2010-04-13 08:00:07 -0700 Patch bug-36532-20100413115715.patch text/plain 1742 jesus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2RiMzgwYy4uMDRiYjY4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0xMyAgRXNraWwgQmxvbWZl bGR0IDxlYmxvbWZlbEB0cm9sbHRlY2guY29tPiwgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGpl c3VzLnBhbGVuY2lhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1F0XSBVc2UgaW50ZWdlciBwaXhlbCBtZXRyaWMgUUZvbnQg QVBJIHRvIGZpeCByb3VuZGluZyBlcnJvcnMgaW4gdGV4dCByZW5kZXJpbmcgb24gdGhlIE1hYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY1MzIKKwor ICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3F0L0ZvbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250OjpmbG9hdFdpZHRoRm9y Q29tcGxleFRleHQpOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6Zm9udCk6CisKIDIwMTAtMDQt MTMgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBOaWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L0ZvbnRRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5j cHAKaW5kZXggM2M1MWM2Ny4uOGMxN2NjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9Gb250UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv Rm9udFF0LmNwcApAQCAtMTgyLDcgKzE4MiwxMSBAQCBmbG9hdCBGb250OjpmbG9hdFdpZHRoRm9y Q29tcGxleFRleHQoY29uc3QgVGV4dFJ1biYgcnVuLCBIYXNoU2V0PGNvbnN0IFNpbXBsZUZvbgog CiAgICAgUVRleHRMYXlvdXQgbGF5b3V0KHN0cmluZywgZm9udCgpKTsKICAgICBRVGV4dExpbmUg bGluZSA9IHNldHVwTGF5b3V0KCZsYXlvdXQsIHJ1bik7CisjaWYgUVRfVkVSU0lPTiA+PSBRVF9W RVJTSU9OX0NIRUNLKDQsIDcsIDApCisgICAgaW50IHcgPSBpbnQobGluZS5ob3Jpem9udGFsQWR2 YW5jZSgpKTsKKyNlbHNlCiAgICAgaW50IHcgPSBpbnQobGluZS5uYXR1cmFsVGV4dFdpZHRoKCkp OworI2VuZGlmCiAgICAgLy8gV2ViS2l0IGV4cGVjdHMgdXMgdG8gaWdub3JlIHdvcmQgc3BhY2lu ZyBvbiB0aGUgZmlyc3QgY2hhcmFjdGVyIChhcyBvcHBvc2VkIHRvIHdoYXQgUXQgZG9lcykKICAg ICBpZiAodHJlYXRBc1NwYWNlKHJ1blswXSkpCiAgICAgICAgIHcgLT0gbV93b3JkU3BhY2luZzsK QEAgLTIyMyw2ICsyMjcsMTEgQEAgUUZvbnQgRm9udDo6Zm9udCgpIGNvbnN0CiAgICAgICAgIGYu c2V0TGV0dGVyU3BhY2luZyhRRm9udDo6QWJzb2x1dGVTcGFjaW5nLCBtX2xldHRlclNwYWNpbmcp OwogICAgIGlmIChtX3dvcmRTcGFjaW5nICE9IDApCiAgICAgICAgIGYuc2V0V29yZFNwYWNpbmco bV93b3JkU3BhY2luZyk7CisKKyNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwg NywgMCkKKyAgICBmLnNldFN0eWxlU3RyYXRlZ3koUUZvbnQ6OkZvcmNlSW50ZWdlck1ldHJpY3Mp OworI2VuZGlmCisKICAgICByZXR1cm4gZjsKIH0KIAo= 53251 2010-04-13 08:00:16 -0700 2010-04-13 08:21:44 -0700 Patch bug-36532-20100413120252.patch text/plain 1709 jesus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2RiMzgwYy4uMTA1NGQxYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0xMyAgRXNraWwgQmxvbWZl bGR0IDxlYmxvbWZlbEB0cm9sbHRlY2guY29tPiwgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGpl c3VzLnBhbGVuY2lhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1F0XSBVc2UgaW50ZWdlciBwaXhlbCBtZXRyaWMgUUZvbnQg QVBJIHRvIGZpeCByb3VuZGluZyBlcnJvcnMgaW4gdGV4dCByZW5kZXJpbmcgb24gdGhlIE1hYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY1MzIKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGb250OjpmbG9hdFdpZHRoRm9yQ29tcGxleFRleHQpOgorICAgICAgICAoV2ViQ29yZTo6 Rm9udDo6Zm9udCk6CisKIDIwMTAtMDQtMTMgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAKaW5kZXggM2M1MWM2Ny4uOGMxN2NjZCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQuY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcApAQCAtMTgyLDcgKzE4MiwxMSBAQCBm bG9hdCBGb250OjpmbG9hdFdpZHRoRm9yQ29tcGxleFRleHQoY29uc3QgVGV4dFJ1biYgcnVuLCBI YXNoU2V0PGNvbnN0IFNpbXBsZUZvbgogCiAgICAgUVRleHRMYXlvdXQgbGF5b3V0KHN0cmluZywg Zm9udCgpKTsKICAgICBRVGV4dExpbmUgbGluZSA9IHNldHVwTGF5b3V0KCZsYXlvdXQsIHJ1bik7 CisjaWYgUVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NIRUNLKDQsIDcsIDApCisgICAgaW50IHcg PSBpbnQobGluZS5ob3Jpem9udGFsQWR2YW5jZSgpKTsKKyNlbHNlCiAgICAgaW50IHcgPSBpbnQo bGluZS5uYXR1cmFsVGV4dFdpZHRoKCkpOworI2VuZGlmCiAgICAgLy8gV2ViS2l0IGV4cGVjdHMg dXMgdG8gaWdub3JlIHdvcmQgc3BhY2luZyBvbiB0aGUgZmlyc3QgY2hhcmFjdGVyIChhcyBvcHBv c2VkIHRvIHdoYXQgUXQgZG9lcykKICAgICBpZiAodHJlYXRBc1NwYWNlKHJ1blswXSkpCiAgICAg ICAgIHcgLT0gbV93b3JkU3BhY2luZzsKQEAgLTIyMyw2ICsyMjcsMTEgQEAgUUZvbnQgRm9udDo6 Zm9udCgpIGNvbnN0CiAgICAgICAgIGYuc2V0TGV0dGVyU3BhY2luZyhRRm9udDo6QWJzb2x1dGVT cGFjaW5nLCBtX2xldHRlclNwYWNpbmcpOwogICAgIGlmIChtX3dvcmRTcGFjaW5nICE9IDApCiAg ICAgICAgIGYuc2V0V29yZFNwYWNpbmcobV93b3JkU3BhY2luZyk7CisKKyNpZiBRVF9WRVJTSU9O ID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwgNywgMCkKKyAgICBmLnNldFN0eWxlU3RyYXRlZ3koUUZv bnQ6OkZvcmNlSW50ZWdlck1ldHJpY3MpOworI2VuZGlmCisKICAgICByZXR1cm4gZjsKIH0KIAo=