36515 2010-03-23 19:23:35 -0700 CSS style definitions are ignored if they just follow a "@charset" which appears in lines other than the first line in stylesheet. 2011-04-04 07:01:14 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED http://bbs.club.sina.com.cn/group.php?gid=26&tree=1 P2 Normal --- 1 hanrui.gao ap abarth ap commit-queue guido_jansen jnd jshin mathias phnixwxz oldest_to_newest 203312 0 51474 hanrui.gao 2010-03-23 19:23:35 -0700 Created attachment 51474 testcase 1 Browsers tested: Safari 4.0.5(531.22.7): Fail Chrome 5.0.342.3: Fail Firefox 3.6: OK IE 7: OK IE 8: OK (In IE 8, it runs in IE7 Standards mode by page default) What steps will reproduce the problem? 1. Launch the url in each browser 2. Pay attention to the top area of the page What is the expected result? Chrome and Safari should better show the same UI as that in IE and Firefox. What happens instead? In Chrome and Safari, the page loses the '新浪论坛' icon at the top-left side and shows the top login area is in a different color from that in IE and Firefox. Please provide any additional information below. Attach a screenshot if possible. Thy this page: http://bbs.club.sina.com.cn/group.php?gid=26&tree=1 In its css file(http://sjs.sinajs.cn/tiezi/css/bbs2/dev.css?38.css), there are more than one "charset" lines. All style definition right following the charset lines will be missed expect the first charset line. Yes, this issue is caused by mis-using of "charset", but why could not we handle it correctly while IE and Firefox both can? Attached please kindly find my recuded test-case. In my first test-case, the 2nd and 3rd selectors are both ignored in Safari and Chrome. But they are having effect in Firefox and IE. And in the second test-case, you will see that the first selector which just follows the '@charset' right in the first line take effect while the second selector doesn't. Thanks! 203313 1 51475 hanrui.gao 2010-03-23 19:23:56 -0700 Created attachment 51475 testcase 2 203319 2 jshin 2010-03-23 21:10:25 -0700 It's reported in Chromiub bug tracker (http://crbug.com/38877 ) 203775 3 ap 2010-03-24 21:16:53 -0700 See also: bug 18265. Seems that Firefox behavior is not what we thought it was. 204280 4 abarth 2010-03-25 16:10:51 -0700 I'm not 100% clear on the expected behavior here. Should we be ignoring these @charset directives or should we be switching charsets as we go? 204317 5 ap 2010-03-25 17:10:19 -0700 The spec just says that such stylesheets are invalid, so all we can do is check other browsers' behavior. My guess is that no browser switches the encoding. They may ignore misplaced charset declarations, or they may honor the first, or the last. The first option (ignoring) seems best and most likely to me in the absence of hard facts. 261262 6 guido_jansen 2010-08-06 08:07:24 -0700 (In reply to comment #5) > The spec just says that such stylesheets are invalid, so all we can do is check other browsers' behavior. > > My guess is that no browser switches the encoding. They may ignore misplaced charset declarations, or they may honor the first, or the last. The first option (ignoring) seems best and most likely to me in the absence of hard facts. in http://www.w3.org/TR/CSS21/syndata.html#charset it says "User agents must ignore any @charset rule not at the beginning of the style sheet." 271488 7 ap 2010-08-30 10:18:34 -0700 *** Bug 44857 has been marked as a duplicate of this bug. *** 271490 8 ap 2010-08-30 10:19:18 -0700 See also: bug 21628. 271622 9 65952 ap 2010-08-30 14:14:30 -0700 Created attachment 65952 proposed fix 271960 10 65952 commit-queue 2010-08-31 00:22:44 -0700 Comment on attachment 65952 proposed fix Rejecting patch 65952 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20871 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14296 tests run. 254.34s total testing time 14295 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3881178 271962 11 65952 abarth 2010-08-31 00:26:03 -0700 Comment on attachment 65952 proposed fix Sorry, that's a top flaky test. 271990 12 65952 commit-queue 2010-08-31 02:33:50 -0700 Comment on attachment 65952 proposed fix Rejecting patch 65952 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: ced-charset.html M WebCore/ChangeLog M WebCore/css/CSSGrammar.y A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/LayoutTests/fast/css/misplaced-charset.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 572 Full output: http://queues.webkit.org/results/3856188 272114 13 ap 2010-08-31 08:50:12 -0700 Committed <http://trac.webkit.org/changeset/66486>. 51474 2010-03-23 19:23:35 -0700 2010-03-23 19:23:35 -0700 testcase 1 testcase_of_charset_and_selector_standard.html text/html 383 hanrui.gao PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPgo8aHRtbD4KPGhlYWQ+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CmRpdntiYWNrZ3Jv dW5kLWNvbG9yOiBibGFjazt9CkBjaGFyc2V0ICJYWFgiOwpkaXZ7YmFja2dyb3VuZC1jb2xvcjog Ymx1ZTt9CkBjaGFyc2V0ICJYWFgiOwpwe2JhY2tncm91bmQtY29sb3I6IHJlZDt9Cjwvc3R5bGU+ CjwvaGVhZD4KPGJvZHk+Cgk8ZGl2IHN0eWxlPSJoZWlnaHQ6MTAwcHg7Ij48L2Rpdj4KCTxwIHN0 eWxlPSJoZWlnaHQ6MTAwcHg7Ij48L3A+CjwvYm9keT4KPC9odG1sPgo= 51475 2010-03-23 19:23:56 -0700 2010-03-23 19:23:56 -0700 testcase 2 testcase_of_charset_and_selector_standard_2.html text/html 256 hanrui.gao PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KQGNo YXJzZXQgIlVTLUFTQ0lJIjsKZGl2e2JhY2tncm91bmQtY29sb3I6IGJsdWV9CkBjaGFyc2V0ICJV Uy1BU0NJSSI7CnB7YmFja2dyb3VuZC1jb2xvcjogcmVkO30KPC9zdHlsZT4KPC9oZWFkPgo8Ym9k eT4KCTxkaXYgc3R5bGU9ImhlaWdodDoxMDBweDsiPjwvZGl2PgoJPHAgc3R5bGU9ImhlaWdodDox MDBweDsiPjwvcD4KPC9ib2R5Pgo8L2h0bWw+Cg== 65952 2010-08-30 14:14:30 -0700 2010-08-31 02:33:50 -0700 proposed fix MisplacedCSS.txt text/plain 4577 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjQwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMzAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NTE1CisgICAgICAgIENT UyBzdHlsZSBkZWZpbml0aW9ucyBhcmUgaWdub3JlZCBpZiB0aGV5IGp1c3QgZm9sbG93IGEgIkBj aGFyc2V0IiB3aGljaCBhcHBlYXJzIGluIGxpbmVzCisgICAgICAgIG90aGVyIHRoYW4gdGhlIGZp cnN0IGxpbmUgaW4gc3R5bGVzaGVldC4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9taXNwbGFj ZWQtY2hhcnNldC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTR3JhbW1hci55OiBJZ25vcmUgYSBt aXNwbGFjZWQgY2hhcnNldCBydWxlIHdpdGhvdXQgY29uc3VtaW5nIGV4dHJhIGNoYXJhY3RlcnMg YW5kCisgICAgICAgIHRodXMgYnJlYWtpbmcgc3Vic2VxdWVudCBydWxlcy4KKwogMjAxMC0wOC0z MCAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQkocmV2aXNpb24gNjYzOTIpCisrKyBX ZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkJKHdvcmtpbmcgY29weSkKQEAgLTk5LDcgKzk5LDcgQEAg c3RhdGljIGludCBjc3N5eWxleChZWVNUWVBFKiB5eWx2YWwsIHZvaQogCiAlfQogCi0lZXhwZWN0 IDU1CislZXhwZWN0IDU2CiAKICVub25hc3NvYyBMT1dFU1RfUFJFQwogCkBAIC0yMDIsNiArMjAy LDcgQEAgc3RhdGljIGludCBjc3N5eWxleChZWVNUWVBFKiB5eWx2YWwsIHZvaQogJXR5cGUgPHJl bGF0aW9uPiBjb21iaW5hdG9yCiAKICV0eXBlIDxydWxlPiBjaGFyc2V0CisldHlwZSA8cnVsZT4g aWdub3JlZF9jaGFyc2V0CiAldHlwZSA8cnVsZT4gcnVsZXNldAogJXR5cGUgPHJ1bGU+IG1lZGlh CiAldHlwZSA8cnVsZT4gaW1wb3J0CkBAIC0zOTAsNiArMzkxLDEzIEBAIGNoYXJzZXQ6CiAgIH0K IDsKIAoraWdub3JlZF9jaGFyc2V0OgorICAgIENIQVJTRVRfU1lNIG1heWJlX3NwYWNlIFNUUklO RyBtYXliZV9zcGFjZSAnOycgeworICAgICAgICAvLyBJZ25vcmUgYW55IEBjaGFyc2V0IHJ1bGUg bm90IGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIHN0eWxlIHNoZWV0LgorICAgICAgICAkJCA9IDA7 CisgICAgfQorOworCiBydWxlX2xpc3Q6CiAgICAvKiBlbXB0eSAqLwogIHwgcnVsZV9saXN0IHJ1 bGUgbWF5YmVfc2dtbCB7CkBAIC00MTQsNiArNDIyLDcgQEAgcnVsZToKICAgICB2YWxpZF9ydWxl IHsKICAgICAgICAgc3RhdGljX2Nhc3Q8Q1NTUGFyc2VyKj4ocGFyc2VyKS0+bV9oYWRTeW50YWN0 aWNhbGx5VmFsaWRDU1NSdWxlID0gdHJ1ZTsKICAgICB9CisgIHwgaWdub3JlZF9jaGFyc2V0CiAg IHwgaW52YWxpZF9ydWxlCiAgIHwgaW52YWxpZF9hdAogICA7CkluZGV4OiBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2 NjQwNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA4LTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjUxNQorICAgICAgICBDU1Mgc3R5bGUg ZGVmaW5pdGlvbnMgYXJlIGlnbm9yZWQgaWYgdGhleSBqdXN0IGZvbGxvdyBhICJAY2hhcnNldCIg d2hpY2ggYXBwZWFycyBpbiBsaW5lcworICAgICAgICBvdGhlciB0aGFuIHRoZSBmaXJzdCBsaW5l IGluIHN0eWxlc2hlZXQuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9taXNwbGFjZWQtY2hhcnNldC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL21pc3BsYWNlZC1jaGFyc2V0 Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTA4LTMwICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0aW5nIENocm9taXVtIGV4cGVjdGF0aW9u cy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzL21pc3BsYWNlZC1jaGFyc2V0LWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9taXNwbGFjZWQtY2hhcnNl dC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9taXNw bGFjZWQtY2hhcnNldC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAor VGVzdCBmb3IgYnVnIDM2NTE1OiBDU1Mgc3R5bGUgZGVmaW5pdGlvbnMgYXJlIGlnbm9yZWQgaWYg dGhleSBqdXN0IGZvbGxvdyBhICJAY2hhcnNldCIgd2hpY2ggYXBwZWFycyBpbiBsaW5lcyBvdGhl ciB0aGFuIHRoZSBmaXJzdCBsaW5lIGluIHN0eWxlc2hlZXQuCisKK1RoZXJlIHNob3VsZCBiZSB0 d28gZ3JlZW4gc3F1YXJlcyBiZWxvdzoKKworCitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2Nzcy9taXNwbGFjZWQtY2hhcnNldC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvY3NzL21pc3BsYWNlZC1jaGFyc2V0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2Nzcy9taXNwbGFjZWQtY2hhcnNldC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDI5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGUgdHlwZT0idGV4 dC9jc3MiPgorZGl2LmEge2JhY2tncm91bmQtY29sb3I6IHJlZDt9CitAY2hhcnNldCAiWFhYIjsK K2Rpdi5hIHtiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbiAhaW1wb3J0YW50O30KK0BjaGFyc2V0ICJY WFgiOworZGl2LmIge2JhY2tncm91bmQtY29sb3I6IGdyZWVuICFpbXBvcnRhbnQ7fQorPC9zdHls ZT4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjUxNSI+YnVnIDM2NTE1PC9hPjoKKyAgICBD U1Mgc3R5bGUgZGVmaW5pdGlvbnMgYXJlIGlnbm9yZWQgaWYgdGhleSBqdXN0IGZvbGxvdyBhICJA Y2hhcnNldCIgd2hpY2ggYXBwZWFycyBpbiBsaW5lcyBvdGhlciB0aGFuIHRoZSBmaXJzdCBsaW5l IGluIHN0eWxlc2hlZXQuPC9wPgorICAgIDxwPlRoZXJlIHNob3VsZCBiZSB0d28gZ3JlZW4gc3F1 YXJlcyBiZWxvdzo8L3A+CisJPGRpdiBjbGFzcz0iYSIgc3R5bGU9ImhlaWdodDoxMDBweDsgd2lk dGg6MTAwcHg7Ij48L2Rpdj48YnI+CisJPGRpdiBjbGFzcz0iYiIgc3R5bGU9ImhlaWdodDoxMDBw eDsgd2lkdGg6MTAwcHg7IGJhY2tncm91bmQtY29sb3I6cmVkOyI+PC9kaXY+CisJPGRpdiBzdHls ZT0iaGVpZ2h0OjVweDsgd2lkdGg6NXB4OyBiYWNrZ3JvdW5kLWNvbG9yOmdyZWVuOyB2aXNpYmls aXR5OiBoaWRkZW4iPjwvZGl2PgorCTxkaXYgaWQ9InJlc3VsdCI+VGVzdGluZy4uLjwvZGl2Pgor CTxzY3JpcHQ+CisJICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisJICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisJICAgIHZhciBleHBlY3RlZCA9 IGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVu dHNCeVRhZ05hbWUoImRpdiIpWzJdLCBudWxsKS5iYWNrZ3JvdW5kQ29sb3I7CisJICAgIHZhciBy ZXN1bHQgPSBkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50Lmdl dEVsZW1lbnRzQnlUYWdOYW1lKCJkaXYiKVswXSwgbnVsbCkuYmFja2dyb3VuZENvbG9yID09IGV4 cGVjdGVkCisJICAgICAgICAmJiBkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxl KGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJkaXYiKVsxXSwgbnVsbCkuYmFja2dyb3Vu ZENvbG9yID09IGV4cGVjdGVkOworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVz dWx0IikuaW5uZXJIVE1MID0gcmVzdWx0ID8gIlBBU1MiIDogIkZBSUwiOworCTwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgo=