36514 2010-03-23 18:43:00 -0700 [v8] Failed assertion in V8Proxy::setDOMException() if worker is shutting down 2010-03-24 15:05:14 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue dimich webkit.review.bot oldest_to_newest 203302 0 atwilson 2010-03-23 18:43:00 -0700 The SharedWorkerHttpAuth test results in the worker being shutdown in the middle of an importScript() call, which results in an exception being generated and passed to V8Proxy::setDOMException(). There's a race condition that occurs - if WorkerScriptController::forbidExecution() is invoked before the importScript() call returns and calls setDOMException(), then a failed assertion happens. It seems that this line in setDOMException() yields an empty exception object: exception = toV8(EventException::create(description)); Which causes this to fail further on in the function. ASSERT(!exception.IsEmpty()); I suspect the issue is that toV8() can't create an object if the worker context is shutting down. I think the right thing to do is to get rid of that assertion, and instead have a failed assertion in the default: case statement (failing if setDOMException() is passed an unknown exception type), and then quietly return without throwing the exception. 203461 1 51516 atwilson 2010-03-24 10:17:24 -0700 Created attachment 51516 Patch 203465 2 webkit.review.bot 2010-03-24 10:19:12 -0700 Attachment 51516 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 203493 3 51516 dimich 2010-03-24 10:57:01 -0700 Comment on attachment 51516 Patch r=me Please change tabs to spaces, per style bot note. It is a good rule to have [v8] in front of title of the bug if the change only affects v8-specific files. Some people use it to immediately see if the change is relevant or not relevant for them (having filters etc). I've changed the bug title. 203499 4 51527 atwilson 2010-03-24 11:05:19 -0700 Created attachment 51527 Patch 203502 5 51528 atwilson 2010-03-24 11:07:10 -0700 Created attachment 51528 Patch 203520 6 51528 dimich 2010-03-24 11:44:30 -0700 Comment on attachment 51528 Patch r=me 203626 7 51528 commit-queue 2010-03-24 15:05:09 -0700 Comment on attachment 51528 Patch Clearing flags on attachment: 51528 Committed r56461: <http://trac.webkit.org/changeset/56461> 203627 8 commit-queue 2010-03-24 15:05:14 -0700 All reviewed patches have been landed. Closing bug. 51516 2010-03-24 10:17:24 -0700 2010-03-24 11:05:16 -0700 Patch bug-36514-20100324101722.patch text/plain 1350 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTQxZDQ4MS4uNjBiZjE4YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0yNCAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRmFpbGVkIGFzc2VydGlvbiBpbiBWOFByb3h5OjpzZXRET01FeGNl cHRpb24oKSBpZiB3b3JrZXIgaXMgc2h1dHRpbmcgZG93bi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NTE0CisKKwlUZXN0OiBub25lIChleGlzdGlu ZyB3b3JrZXIgdGVzdHMgc3VmZmljZSkKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHku Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6c2V0RE9NRXhjZXB0aW9uKToKKwlVcGRh dGVkIHNldERPTUV4Y2VwdGlvbigpIHRvIGNoZWNrIGZvciBhbiBlbXB0eSBleGNlcHRpb24gKGR1 ZSB0byBubyBhY3RpdmUgY29udGV4dCkgYW5kIGF2b2lkIHRocm93aW5nIGluIHRoYXQgY2FzZS4K KwogMjAxMC0wMy0yMCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94 eS5jcHAKaW5kZXggMWEwZDYwNi4uYTdlYjVlNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFByb3h5LmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCkBA IC02NjYsMTAgKzY2NiwxMiBAQCB2b2lkIFY4UHJveHk6OnNldERPTUV4Y2VwdGlvbihpbnQgZXhj ZXB0aW9uQ29kZSkKICAgICAgICAgZXhjZXB0aW9uID0gdG9WOChYUGF0aEV4Y2VwdGlvbjo6Y3Jl YXRlKGRlc2NyaXB0aW9uKSk7CiAgICAgICAgIGJyZWFrOwogI2VuZGlmCisgICAgZGVmYXVsdDoK KyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogCi0gICAgQVNTRVJUKCFleGNl cHRpb24uSXNFbXB0eSgpKTsKLSAgICB2ODo6VGhyb3dFeGNlcHRpb24oZXhjZXB0aW9uKTsKKyAg ICBpZiAoIWV4Y2VwdGlvbi5Jc0VtcHR5KCkpCisgICAgICAgIHY4OjpUaHJvd0V4Y2VwdGlvbihl eGNlcHRpb24pOwogfQogCiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhQcm94eTo6dGhyb3dFcnJv cihFcnJvclR5cGUgdHlwZSwgY29uc3QgY2hhciogbWVzc2FnZSkK 51527 2010-03-24 11:05:19 -0700 2010-03-24 11:07:07 -0700 Patch bug-36514-20100324110518.patch text/plain 767 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjczMTc1Yy4uMWM4M2Y5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTUsMTEgKzUsMTEgQEAKICAgICAgICAgRmFpbGVkIGFzc2VydGlv biBpbiBWOFByb3h5OjpzZXRET01FeGNlcHRpb24oKSBpZiB3b3JrZXIgaXMgc2h1dHRpbmcgZG93 bi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NTE0 CiAKLQlUZXN0OiBub25lIChleGlzdGluZyB3b3JrZXIgdGVzdHMgc3VmZmljZSkKKyAgICAgICAg VGVzdDogbm9uZSAoZXhpc3Rpbmcgd29ya2VyIHRlc3RzIHN1ZmZpY2UpCiAKICAgICAgICAgKiBi aW5kaW5ncy92OC9WOFByb3h5LmNwcDoKICAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OnNldERP TUV4Y2VwdGlvbik6Ci0JVXBkYXRlZCBzZXRET01FeGNlcHRpb24oKSB0byBjaGVjayBmb3IgYW4g ZW1wdHkgZXhjZXB0aW9uIChkdWUgdG8gbm8gYWN0aXZlIGNvbnRleHQpIGFuZCBhdm9pZCB0aHJv d2luZyBpbiB0aGF0IGNhc2UuCisgICAgICAgIFVwZGF0ZWQgc2V0RE9NRXhjZXB0aW9uKCkgdG8g Y2hlY2sgZm9yIGFuIGVtcHR5IGV4Y2VwdGlvbiAoZHVlIHRvIG5vIGFjdGl2ZSBjb250ZXh0KSBh bmQgYXZvaWQgdGhyb3dpbmcgaW4gdGhhdCBjYXNlLgogCiAyMDEwLTAzLTIzICBEYXZpZCBMZXZp biAgPGxldmluQGNocm9taXVtLm9yZz4KIAo= 51528 2010-03-24 11:07:10 -0700 2010-03-24 15:05:09 -0700 Patch bug-36514-20100324110709.patch text/plain 1351 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGUyZDBiZC4uMWM4M2Y5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0yNCAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRmFpbGVkIGFzc2VydGlvbiBpbiBWOFByb3h5OjpzZXRET01FeGNl cHRpb24oKSBpZiB3b3JrZXIgaXMgc2h1dHRpbmcgZG93bi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NTE0CisKKyAgICAgICAgVGVzdDogbm9uZSAo ZXhpc3Rpbmcgd29ya2VyIHRlc3RzIHN1ZmZpY2UpCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9W OFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OnNldERPTUV4Y2VwdGlvbik6 CisgICAgICAgIFVwZGF0ZWQgc2V0RE9NRXhjZXB0aW9uKCkgdG8gY2hlY2sgZm9yIGFuIGVtcHR5 IGV4Y2VwdGlvbiAoZHVlIHRvIG5vIGFjdGl2ZSBjb250ZXh0KSBhbmQgYXZvaWQgdGhyb3dpbmcg aW4gdGhhdCBjYXNlLgorCiAyMDEwLTAzLTIzICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOYXRlIENoYXBpbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJv eHkuY3BwCmluZGV4IDFhMGQ2MDYuLmE3ZWI1ZTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhQcm94eS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcApA QCAtNjY2LDEwICs2NjYsMTIgQEAgdm9pZCBWOFByb3h5OjpzZXRET01FeGNlcHRpb24oaW50IGV4 Y2VwdGlvbkNvZGUpCiAgICAgICAgIGV4Y2VwdGlvbiA9IHRvVjgoWFBhdGhFeGNlcHRpb246OmNy ZWF0ZShkZXNjcmlwdGlvbikpOwogICAgICAgICBicmVhazsKICNlbmRpZgorICAgIGRlZmF1bHQ6 CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KIAotICAgIEFTU0VSVCghZXhj ZXB0aW9uLklzRW1wdHkoKSk7Ci0gICAgdjg6OlRocm93RXhjZXB0aW9uKGV4Y2VwdGlvbik7Cisg ICAgaWYgKCFleGNlcHRpb24uSXNFbXB0eSgpKQorICAgICAgICB2ODo6VGhyb3dFeGNlcHRpb24o ZXhjZXB0aW9uKTsKIH0KIAogdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4UHJveHk6OnRocm93RXJy b3IoRXJyb3JUeXBlIHR5cGUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UpCg==