36506 2010-03-23 14:24:21 -0700 [chromium] XMLHttpRequest.send sends 'undefined' string when passed undefined value. 2010-03-23 15:28:39 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin japhet oldest_to_newest 203209 0 levin 2010-03-23 14:24:21 -0700 From http://crbug.com/33062: Given the following JavaScript: var x = new XMLHttpRequest(); x.open('POST', '/'); x.send(undefined); Expected result is: POST request with empty request body. Instead chromium sends "undefined" as the request body. 203224 1 51454 levin 2010-03-23 14:46:31 -0700 Created attachment 51454 Proposed fix. 203227 2 51454 japhet 2010-03-23 14:51:53 -0700 Comment on attachment 51454 Proposed fix. r=me 203257 3 levin 2010-03-23 15:28:39 -0700 Committed as http://trac.webkit.org/changeset/56422 51454 2010-03-23 14:46:31 -0700 2010-03-23 14:51:53 -0700 Proposed fix. bug36506.txt text/plain 4998 levin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMjhhYjQ3Li43MWFiZjFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MjMgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gWE1MSHR0cFJlcXVlc3Qu c2VuZCBzZW5kcyAndW5kZWZpbmVkJyBzdHJpbmcgd2hlbiBwYXNzZWQgdW5kZWZpbmVkIHZhbHVl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY1MDYK KworICAgICAgICBBZGRlZCBhIHRlc3QgdG8gdmVyaWZ5IHRoYXQgc2VuZGluZyBlaXRoZXIgdW5k ZWZpbmVkIGFuZCBudWxsIGJvdGggcmVzdWx0IGluIGFuIGVtcHR5IHJlcXVlc3QgYm9keS4KKwor ICAgICAgICAqIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvc2VuZC11bmRlZmluZWQtYW5kLW51 bGwtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L3NlbmQtdW5kZWZpbmVkLWFuZC1udWxsLmh0bWw6IEFkZGVkLgorCiAyMDEwLTAzLTE5ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRw cmVxdWVzdC9zZW5kLXVuZGVmaW5lZC1hbmQtbnVsbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3NlbmQtdW5kZWZpbmVkLWFuZC1udWxsLWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi41ZTMzYTkwCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9zZW5k LXVuZGVmaW5lZC1hbmQtbnVsbC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitUZXN0cyB0 aGF0IHNlbmRpbmcgdW5kZWZpbmVkIG9yIG51bGwgcmVzdWx0cyBpbiBhbiBlbXB0eSByZXF1ZXN0 IGJvZHkuCitQQVNTIGZvciB1bmRlZmluZWQKK1BBU1MgZm9yIG51bGwKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvc2VuZC11bmRlZmluZWQtYW5kLW51 bGwuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvc2VuZC11bmRl ZmluZWQtYW5kLW51bGwuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4x NzVkYzY5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRw cmVxdWVzdC9zZW5kLXVuZGVmaW5lZC1hbmQtbnVsbC5odG1sCkBAIC0wLDAgKzEsMzUgQEAKKzxo dG1sPgorPGJvZHk+CitUZXN0cyB0aGF0IHNlbmRpbmcgdW5kZWZpbmVkIG9yIG51bGwgcmVzdWx0 cyBpbiBhbiBlbXB0eSByZXF1ZXN0IGJvZHkuCis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisK K3ZhciBjb25zb2xlX21lc3NhZ2VzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidWwiKTsKK2Rv Y3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoY29uc29sZV9tZXNzYWdlcyk7CisKK2Z1bmN0aW9uIGxv ZyhtZXNzYWdlKQoreworICAgIHZhciBpdGVtID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGki KTsKKyAgICBpdGVtLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2Up KTsKKyAgICBjb25zb2xlX21lc3NhZ2VzLmFwcGVuZENoaWxkKGl0ZW0pOworfQorCit4aHIgPSBu ZXcgWE1MSHR0cFJlcXVlc3Q7Cit4aHIub3BlbigiUE9TVCIsICJyZXNvdXJjZXMvcG9zdC1lY2hv LmNnaSIsIGZhbHNlKTsKK3hoci5zZW5kKHVuZGVmaW5lZCk7CitpZiAoIXhoci5yZXNwb25zZVRl eHQubGVuZ3RoKQorICAgIGxvZygiUEFTUyBmb3IgdW5kZWZpbmVkIik7CitlbHNlCisgICAgbG9n KCJGQUlMRUQ6IFRoZSBwb3N0ZWQgY29udGVudCB3aGVuIHNlbmRpbmcgJ3VuZGVmaW5lZCcgaXMg JyIgKyB4aHIucmVzcG9uc2VUZXh0ICsiJy4gSXQgc2hvdWxkIGhhdmUgYmVlbiAnJy4iKTsKKwor eGhyID0gbmV3IFhNTEh0dHBSZXF1ZXN0OworeGhyLm9wZW4oIlBPU1QiLCAicmVzb3VyY2VzL3Bv c3QtZWNoby5jZ2kiLCBmYWxzZSk7Cit4aHIuc2VuZChudWxsKTsKK2lmICgheGhyLnJlc3BvbnNl VGV4dC5sZW5ndGgpCisgICAgbG9nKCJQQVNTIGZvciBudWxsIik7CitlbHNlCisgICAgbG9nKCJG QUlMRUQ6IFRoZSBwb3N0ZWQgY29udGVudCB3aGVuIHNlbmRpbmcgJ251bGwnIGlzICciICsgeGhy LnJlc3BvbnNlVGV4dCArIicuIEl0IHNob3VsZCBoYXZlIGJlZW4gJycuIik7Cis8L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggN2ExZDEyMy4uMDE5MWM2NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0w My0yMyAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBYTUxIdHRwUmVxdWVz dC5zZW5kIHNlbmRzICd1bmRlZmluZWQnIHN0cmluZyB3aGVuIHBhc3NlZCB1bmRlZmluZWQgdmFs dWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjUw NgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvc2VuZC11bmRlZmlu ZWQtYW5kLW51bGwuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4WE1MSHR0 cFJlcXVlc3RDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNEb2N1bWVudFR5cGUpOiBV bnJlbGF0ZWQgc3R5bGUgZml4OiBmaXhlZCB0aGUgY2FzaW5nIG9mIHRoZSBtZXRob2QuCisgICAg ICAgIChXZWJDb3JlOjpWOFhNTEh0dHBSZXF1ZXN0OjpzZW5kQ2FsbGJhY2spOiBBZGRlZCBjaGVj ayBmb3IgbnVsbC91bmRlZmluZWQgdG8gZG8gdGhlIHNlbmQuCisgICAgICAgIFRoaXMgbWlycm9y cyB3aGF0IGlzIGRvbmUgaW4gdGhlIEpTQyBiaW5kaW5ncy4gUHJldmlvdXNseSwgc2VuZGluZyAn bnVsbCcgd29ya2VkIGJlY2F1c2UKKyAgICAgICAgdGhlIGxhc3QgY2FzZSwgd2hpY2ggZGlkICJ0 b1dlYkNvcmVTdHJpbmdXaXRoTnVsbENoZWNrIiwgcmVzdWx0ZWQgaW4gc2VuZGluZyBhbiBlbXB0 eQorICAgICAgICByZXF1ZXN0IGJvZHkuCisKIDIwMTAtMDMtMjIgIEtldmluIERlY2tlciAgPGtk ZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q3Vz dG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0 b20uY3BwCmluZGV4IGU0N2QzZTIuLjRlOWM3MTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCkBAIC0xLDUgKzEsNSBA QAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwOCwgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5LCAyMDEwIEdvb2dsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24s IGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJl CkBAIC05OCw3ICs5OCw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFhNTEh0dHBSZXF1ZXN0 OjpvcGVuQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKICAgICByZXR1cm4gdjg6 OlVuZGVmaW5lZCgpOwogfQogCi1zdGF0aWMgYm9vbCBJc0RvY3VtZW50VHlwZSh2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gdmFsdWUpCitzdGF0aWMgYm9vbCBpc0RvY3VtZW50VHlwZSh2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gdmFsdWUpCiB7CiAgICAgLy8gRklYTUU6IGFkZCBvdGhlciBkb2N1bWVudCB0 eXBlcy4KICAgICByZXR1cm4gVjhEb2N1bWVudDo6SGFzSW5zdGFuY2UodmFsdWUpIHx8IFY4SFRN TERvY3VtZW50OjpIYXNJbnN0YW5jZSh2YWx1ZSk7CkBAIC0xMTQsNyArMTE0LDkgQEAgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IFY4WE1MSHR0cFJlcXVlc3Q6OnNlbmRDYWxsYmFjayhjb25zdCB2ODo6 QXJndW1lbnRzJiBhcmdzKQogICAgICAgICB4bWxIdHRwUmVxdWVzdC0+c2VuZChlYyk7CiAgICAg ZWxzZSB7CiAgICAgICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBhcmcgPSBhcmdzWzBdOwotICAg ICAgICBpZiAoSXNEb2N1bWVudFR5cGUoYXJnKSkgeworICAgICAgICBpZiAoaXNVbmRlZmluZWRP ck51bGwoYXJnKSkKKyAgICAgICAgICAgIHhtbEh0dHBSZXF1ZXN0LT5zZW5kKGVjKTsKKyAgICAg ICAgZWxzZSBpZiAoaXNEb2N1bWVudFR5cGUoYXJnKSkgewogICAgICAgICAgICAgdjg6OkhhbmRs ZTx2ODo6T2JqZWN0PiBvYmplY3QgPSB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KGFyZyk7 CiAgICAgICAgICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBWOERvY3VtZW50Ojp0b05hdGl2ZShv YmplY3QpOwogICAgICAgICAgICAgQVNTRVJUKGRvY3VtZW50KTsK