36497 2010-03-23 09:44:20 -0700 [v8] Use newly introduced SetPrototype method to deal with global objects. 2010-03-24 13:03:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned commit-queue oldest_to_newest 203080 0 antonm 2010-03-23 09:44:20 -0700 Use newly introduced SetPrototype method to deal with global objects. 203084 1 51432 antonm 2010-03-23 09:50:31 -0700 Created attachment 51432 Patch 203176 2 51432 japhet 2010-03-23 13:41:05 -0700 Comment on attachment 51432 Patch I like it! 203364 3 antonm 2010-03-24 02:27:31 -0700 Thanks a lot, Nate. 203546 4 51432 commit-queue 2010-03-24 13:03:01 -0700 Comment on attachment 51432 Patch Clearing flags on attachment: 51432 Committed r56452: <http://trac.webkit.org/changeset/56452> 203547 5 commit-queue 2010-03-24 13:03:06 -0700 All reviewed patches have been landed. Closing bug. 51432 2010-03-23 09:50:31 -0700 2010-03-24 13:03:01 -0700 Patch bug-36497-20100323195029.patch text/plain 4258 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjAyNzZiZC4uMDdiMDAwYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMy0yMyAgQW50b24gTXVoaW4g IDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzZSBuZXdseSBpbnRyb2R1Y2VkIFNldFByb3RvdHlwZSBtZXRob2Qg dG8gZGVhbCB3aXRoIGdsb2JhbCBvYmplY3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0OTcKKworICAgICAgICBObyBuZXcgdGVzdHMsIHNob3Vs ZCBiZSBjb3ZlcmVkIGJ5IHRoZSBjdXJyZW50IHRlc3QgaW5mcmFzdHJ1Y3R1cmUuCisKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlY4RE9NV2luZG93U2hlbGw6Omluc3RhbGxET01XaW5kb3cpOgorICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6Omdl dENvbnN0cnVjdG9yKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0 aW9uUHJveHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyQ29udGV4dEV4ZWN1dGlvblBy b3h5Ojppbml0Q29udGV4dElmTmVlZGVkKToKKwogMjAxMC0wMy0yMyAgUGF2ZWwgRmVsZG1hbiAg PHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhh dGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwu Y3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAppbmRleCA1NWNh ZDYzLi5hYmY3NjJkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93 U2hlbGwuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAK QEAgLTM0NCwxMCArMzQ0LDYgQEAgdjg6OlBlcnNpc3RlbnQ8djg6OkNvbnRleHQ+IFY4RE9NV2lu ZG93U2hlbGw6OmNyZWF0ZU5ld0NvbnRleHQodjg6OkhhbmRsZTx2ODo6T2IKIAogYm9vbCBWOERP TVdpbmRvd1NoZWxsOjppbnN0YWxsRE9NV2luZG93KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNv bnRleHQsIERPTVdpbmRvdyogd2luZG93KQogewotICAgIHY4OjpIYW5kbGU8djg6OlN0cmluZz4g aW1wbGljaXRQcm90b1N0cmluZyA9IHY4OjpTdHJpbmc6Ok5ldygiX19wcm90b19fIik7Ci0gICAg aWYgKGltcGxpY2l0UHJvdG9TdHJpbmcuSXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gZmFsc2U7 Ci0KICAgICAvLyBDcmVhdGUgYSBuZXcgSlMgd2luZG93IG9iamVjdCBhbmQgdXNlIGl0IGFzIHRo ZSBwcm90b3R5cGUgZm9yIHRoZSAgc2hhZG93IGdsb2JhbCBvYmplY3QuCiAgICAgdjg6OkhhbmRs ZTx2ODo6RnVuY3Rpb24+IHdpbmRvd0NvbnN0cnVjdG9yID0gVjhET01XcmFwcGVyOjpnZXRDb25z dHJ1Y3RvcigmVjhET01XaW5kb3c6OmluZm8sIGdldEhpZGRlbk9iamVjdFByb3RvdHlwZShjb250 ZXh0KSk7CiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGpzV2luZG93ID0gU2FmZUFsbG9jYXRp b246Om5ld0luc3RhbmNlKHdpbmRvd0NvbnN0cnVjdG9yKTsKQEAgLTM2Myw5ICszNTksOSBAQCBi b29sIFY4RE9NV2luZG93U2hlbGw6Omluc3RhbGxET01XaW5kb3codjg6OkhhbmRsZTx2ODo6Q29u dGV4dD4gY29udGV4dCwgRE9NV2luZAogICAgIFY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9y RE9NT2JqZWN0KHdpbmRvdywgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD46Ok5ldyhqc1dpbmRv dykpOwogCiAgICAgLy8gSW5zZXJ0IHRoZSB3aW5kb3cgaW5zdGFuY2UgYXMgdGhlIHByb3RvdHlw ZSBvZiB0aGUgc2hhZG93IG9iamVjdC4KLSAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHY4R2xv YmFsID0gY29udGV4dC0+R2xvYmFsKCk7Ci0gICAgVjhET01XcmFwcGVyOjpzZXRET01XcmFwcGVy KHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QodjhHbG9iYWwtPkdldFByb3RvdHlwZSgpKSwg JlY4RE9NV2luZG93OjppbmZvLCB3aW5kb3cpOwotICAgIHY4R2xvYmFsLT5TZXQoaW1wbGljaXRQ cm90b1N0cmluZywganNXaW5kb3cpOworICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gdjhSZWFs R2xvYmFsID0gdjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChjb250ZXh0LT5HbG9iYWwoKS0+ R2V0UHJvdG90eXBlKCkpOworICAgIFY4RE9NV3JhcHBlcjo6c2V0RE9NV3JhcHBlcih2OFJlYWxH bG9iYWwsICZWOERPTVdpbmRvdzo6aW5mbywgd2luZG93KTsKKyAgICB2OFJlYWxHbG9iYWwtPlNl dFByb3RvdHlwZShqc1dpbmRvdyk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKZGlmZiAtLWdpdCBh L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcCBiL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhET01XcmFwcGVyLmNwcAppbmRleCAyMzFkMDcwLi40YTMyZjkwIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5n cy92OC9WOERPTVdyYXBwZXIuY3BwCkBAIC0xMzQsNyArMTM0LDcgQEAgdjg6OkxvY2FsPHY4OjpG dW5jdGlvbj4gVjhET01XcmFwcGVyOjpnZXRDb25zdHJ1Y3RvcihXcmFwcGVyVHlwZUluZm8qIHR5 cGUsIHY4OjoKICAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+KCk7CiAgICAg Ly8gSG90bWFpbCBmaXgsIHNlZSBjb21tZW50cyBhYm92ZS4KICAgICBpZiAoIW9iamVjdFByb3Rv dHlwZS5Jc0VtcHR5KCkpCi0gICAgICAgIHZhbHVlLT5TZXQodjg6OlN0cmluZzo6TmV3KCJfX3By b3RvX18iKSwgb2JqZWN0UHJvdG90eXBlKTsKKyAgICAgICAgdmFsdWUtPlNldFByb3RvdHlwZShv YmplY3RQcm90b3R5cGUpOwogICAgIHJldHVybiB2YWx1ZTsKIH0KIApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuY3BwIGIvV2ViQ29y ZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuY3BwCmluZGV4IGQ4ZWEz MzQuLjU2ZjA2NzggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4 dEV4ZWN1dGlvblByb3h5LmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRl eHRFeGVjdXRpb25Qcm94eS5jcHAKQEAgLTE2NSw5ICsxNjUsNiBAQCBib29sIFdvcmtlckNvbnRl eHRFeGVjdXRpb25Qcm94eTo6aW5pdENvbnRleHRJZk5lZWRlZCgpCiAKICAgICB2ODo6Q29udGV4 dDo6U2NvcGUgc2NvcGUoY29udGV4dCk7CiAKLSAgICAvLyBBbGxvY2F0ZSBzdHJpbmdzIHVzZWQg ZHVyaW5nIGluaXRpYWxpemF0aW9uLgotICAgIHY4OjpIYW5kbGU8djg6OlN0cmluZz4gaW1wbGlj aXRQcm90b1N0cmluZyA9IHY4OjpTdHJpbmc6Ok5ldygiX19wcm90b19fIik7Ci0KICAgICAvLyBD cmVhdGUgYSBuZXcgSlMgb2JqZWN0IGFuZCB1c2UgaXQgYXMgdGhlIHByb3RvdHlwZSBmb3IgdGhl IHNoYWRvdyBnbG9iYWwgb2JqZWN0LgogICAgIFdyYXBwZXJUeXBlSW5mbyogY29udGV4dFR5cGUg PSAmVjhEZWRpY2F0ZWRXb3JrZXJDb250ZXh0OjppbmZvOwogI2lmIEVOQUJMRShTSEFSRURfV09S S0VSUykKQEAgLTE4OSw4ICsxODYsOCBAQCBib29sIFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94 eTo6aW5pdENvbnRleHRJZk5lZWRlZCgpCiAgICAgbV93b3JrZXJDb250ZXh0LT5yZWYoKTsKIAog ICAgIC8vIEluc2VydCB0aGUgb2JqZWN0IGluc3RhbmNlIGFzIHRoZSBwcm90b3R5cGUgb2YgdGhl IHNoYWRvdyBvYmplY3QuCi0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBnbG9iYWxPYmplY3Qg PSBtX2NvbnRleHQtPkdsb2JhbCgpOwotICAgIGdsb2JhbE9iamVjdC0+U2V0KGltcGxpY2l0UHJv dG9TdHJpbmcsIGpzV29ya2VyQ29udGV4dCk7CisgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBn bG9iYWxPYmplY3QgPSB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KG1fY29udGV4dC0+R2xv YmFsKCktPkdldFByb3RvdHlwZSgpKTsKKyAgICBnbG9iYWxPYmplY3QtPlNldFByb3RvdHlwZShq c1dvcmtlckNvbnRleHQpOwogICAgIHJldHVybiB0cnVlOwogfQogCg==