36495 2010-03-23 09:33:30 -0700 Fix compilation on Solaris: mmap and munmap take char* 2012-08-02 07:44:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 36493 1 kent.hansen webkit-unassigned hausmann webkit.review.bot oldest_to_newest 203072 0 kent.hansen 2010-03-23 09:33:30 -0700 "Formal argument 1 of type char* in call to mmap(char*, unsigned, int, int, int, long) is being passed void*" "Formal argument 1 of type char* in call to munmap(char*, unsigned) is being passed JSC::Register*." "Invalid static_cast from type char* to type Register*". 203078 1 kent.hansen 2010-03-23 09:43:08 -0700 This is a redux of the issues fixed by r34597. 203079 2 51431 kent.hansen 2010-03-23 09:43:52 -0700 Created attachment 51431 Proposed patch 203083 3 webkit.review.bot 2010-03-23 09:49:11 -0700 Attachment 51431 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/TCSystemAlloc.cpp:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/interpreter/RegisterFile.h:177: Missing spaces around | [whitespace/operators] [3] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 203087 4 kent.hansen 2010-03-23 09:54:08 -0700 (In reply to comment #3) > Attachment 51431 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > JavaScriptCore/wtf/TCSystemAlloc.cpp:446: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > JavaScriptCore/interpreter/RegisterFile.h:177: Missing spaces around | > [whitespace/operators] [3] > Total errors found: 2 in 5 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Just keeping the existing 2-character spacing of that function. 203100 5 51431 darin 2010-03-23 10:35:36 -0700 Comment on attachment 51431 Proposed patch Can we instead take care of this by setting up a header to overload these functions for void* on Solaris systems? I'd prefer a fix that doesn't require sprinkling the non-standard code around. Something like this: #if OS(SOLARIS) static inline void* mmap(void* addr, size_t length, int protections, int flags, int fileDescriptor, off_t offset) { return mmap(static_cast<char*>(addr), length, protections, flags, fileDescriptor, offset); } #endif If we put that in file called <wtf/MManExtras.h> and included that instead of <sys/mman.h> that would fit our normal portability approach. review- because I'd like you to consider that option 203352 6 kent.hansen 2010-03-24 00:44:34 -0700 (In reply to comment #5) > (From update of attachment 51431 [details]) > Can we instead take care of this by setting up a header to overload these > functions for void* on Solaris systems? I'd prefer a fix that doesn't require > sprinkling the non-standard code around. Hi Darin, Yep, makes total sense; that should also remove the chance of this issue being brought back to life again by newly introduced calls to mmap/munmap, which is _really_ the problem to solve. > If we put that in file called <wtf/MManExtras.h> and included that instead of > <sys/mman.h> that would fit our normal portability approach. Thanks for the suggestion, I'll try that one. 685377 7 hausmann 2012-08-02 07:44:52 -0700 Taking the liberty of closing this as WONTFIX. Neither Kent nor I are working on Solaris support anymore. If anyone would like to tackle this one, feel free to re-open. 51431 2010-03-23 09:43:52 -0700 2010-06-11 10:27:48 -0700 Proposed patch mmapMunmapChar.diff text/plain 4176 kent.hansen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAwN2VmNTcyLi42MDdhYzMxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTAtMDMtMjMgIEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxh dGlvbiBvbiBTb2xhcmlzOiBtbWFwIGFuZCBtdW5tYXAgdGFrZSBjaGFyKgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0OTUKKworICAgICAgICBPbiBz b21lIHN5c3RlbXMsIG11bm1hcCB0YWtlcyBhIGNoYXIqIGluc3RlYWQgb2YgYSB2b2lkKgorICAg ICAgICAoY29udHJhcnkgdG8gUE9TSVggYW5kIFNpbmdsZSBVbml4IFNwZWNpZmljYXRpb24pLiBT aW5jZSB5b3UKKyAgICAgICAgY2FuIGFsd2F5cyBjb252ZXJ0IGZyb20gY2hhciogdG8gdm9pZCog YnV0IG5vdCB2aWNlLXZlcnNhLCBkbworICAgICAgICB0aGUgY2FzdGluZyB0byBjaGFyKi4KKwor ICAgICAgICAqIGludGVycHJldGVyL1JlZ2lzdGVyRmlsZS5jcHA6CisgICAgICAgIChKU0M6OlJl Z2lzdGVyRmlsZTo6flJlZ2lzdGVyRmlsZSk6CisgICAgICAgICogaW50ZXJwcmV0ZXIvUmVnaXN0 ZXJGaWxlLmg6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyRmlsZTo6UmVnaXN0ZXJGaWxlKToKKyAg ICAgICAgKiBydW50aW1lL01hcmtTdGFja1Bvc2l4LmNwcDoKKyAgICAgICAgKEpTQzo6TWFya1N0 YWNrOjpyZWxlYXNlU3RhY2spOgorICAgICAgICAqIHd0Zi9UQ1N5c3RlbUFsbG9jLmNwcDoKKyAg ICAgICAgKFRyeU1tYXApOgorICAgICAgICAoVENNYWxsb2NfU3lzdGVtUmVsZWFzZSk6CisKIDIw MTAtMDMtMjIgIFNpZGRoYXJ0aCBNYXRodXIgIDxzaWRkaGFydGgubWF0aHVyQG5va2lhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpkaWZmIC0tZ2l0IGEvSmF2YVNj cmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcCBiL0phdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL1JlZ2lzdGVyRmlsZS5jcHAKaW5kZXggNTEwZWZmZS4uOTM5NTczYiAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcAorKysgYi9K YXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9SZWdpc3RlckZpbGUuY3BwCkBAIC0zNCw3ICszNCw3 IEBAIG5hbWVzcGFjZSBKU0MgewogUmVnaXN0ZXJGaWxlOjp+UmVnaXN0ZXJGaWxlKCkKIHsKICNp ZiBIQVZFKE1NQVApCi0gICAgbXVubWFwKG1fYnVmZmVyLCAoKG1fbWF4IC0gbV9zdGFydCkgKyBt X21heEdsb2JhbHMpICogc2l6ZW9mKFJlZ2lzdGVyKSk7CisgICAgbXVubWFwKHJlaW50ZXJwcmV0 X2Nhc3Q8Y2hhcio+KG1fYnVmZmVyKSwgKChtX21heCAtIG1fc3RhcnQpICsgbV9tYXhHbG9iYWxz KSAqIHNpemVvZihSZWdpc3RlcikpOwogI2VsaWYgSEFWRShWSVJUVUFMQUxMT0MpCiAjaWYgT1Mo V0lOQ0UpCiAgICAgVmlydHVhbEZyZWUobV9idWZmZXIsIERXT1JEKG1fY29tbWl0RW5kKSAtIERX T1JEKG1fYnVmZmVyKSwgTUVNX0RFQ09NTUlUKTsKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3Jl L2ludGVycHJldGVyL1JlZ2lzdGVyRmlsZS5oIGIvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIv UmVnaXN0ZXJGaWxlLmgKaW5kZXggMWZjNGY4Mi4uZTJjNTkyMiAxMDA2NDQKLS0tIGEvSmF2YVNj cmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmgKKysrIGIvSmF2YVNjcmlwdENvcmUv aW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmgKQEAgLTE3NCw3ICsxNzQsNyBAQCBuYW1lc3BhY2Ug SlNDIHsKIAogICAgICAgICBzaXplX3QgYnVmZmVyTGVuZ3RoID0gKGNhcGFjaXR5ICsgbWF4R2xv YmFscykgKiBzaXplb2YoUmVnaXN0ZXIpOwogICAgICNpZiBIQVZFKE1NQVApCi0gICAgICAgIG1f YnVmZmVyID0gc3RhdGljX2Nhc3Q8UmVnaXN0ZXIqPihtbWFwKDAsIGJ1ZmZlckxlbmd0aCwgUFJP VF9SRUFEfFBST1RfV1JJVEUsIE1BUF9QUklWQVRFfE1BUF9BTk9OLCBWTV9UQUdfRk9SX1JFR0lT VEVSRklMRV9NRU1PUlksIDApKTsKKyAgICAgICAgbV9idWZmZXIgPSByZWludGVycHJldF9jYXN0 PFJlZ2lzdGVyKj4obW1hcCgwLCBidWZmZXJMZW5ndGgsIFBST1RfUkVBRHxQUk9UX1dSSVRFLCBN QVBfUFJJVkFURXxNQVBfQU5PTiwgVk1fVEFHX0ZPUl9SRUdJU1RFUkZJTEVfTUVNT1JZLCAwKSk7 CiAgICAgICAgIGlmIChtX2J1ZmZlciA9PSBNQVBfRkFJTEVEKSB7CiAjaWYgT1MoV0lOQ0UpCiAg ICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkNvdWxkIG5vdCBhbGxvY2F0ZSByZWdpc3RlciBm aWxlOiAlZFxuIiwgR2V0TGFzdEVycm9yKCkpOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUv cnVudGltZS9NYXJrU3RhY2tQb3NpeC5jcHAgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtT dGFja1Bvc2l4LmNwcAppbmRleCBjMjhiYzBkLi5kZTVlOGJhIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL01hcmtTdGFja1Bvc2l4LmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL01hcmtTdGFja1Bvc2l4LmNwcApAQCAtNDQsNyArNDQsNyBAQCB2b2lkKiBNYXJrU3Rh Y2s6OmFsbG9jYXRlU3RhY2soc2l6ZV90IHNpemUpCiB9CiB2b2lkIE1hcmtTdGFjazo6cmVsZWFz ZVN0YWNrKHZvaWQqIGFkZHIsIHNpemVfdCBzaXplKQogewotICAgIG11bm1hcChhZGRyLCBzaXpl KTsKKyAgICBtdW5tYXAocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4oYWRkciksIHNpemUpOwogfQog CiB9CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvVENTeXN0ZW1BbGxvYy5jcHAgYi9K YXZhU2NyaXB0Q29yZS93dGYvVENTeXN0ZW1BbGxvYy5jcHAKaW5kZXggYzQ2ZmYzMS4uZmYyYWMy YiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1RDU3lzdGVtQWxsb2MuY3BwCisrKyBi L0phdmFTY3JpcHRDb3JlL3d0Zi9UQ1N5c3RlbUFsbG9jLmNwcApAQCAtMTk0LDEwICsxOTQsMTAg QEAgc3RhdGljIHZvaWQqIFRyeU1tYXAoc2l6ZV90IHNpemUsIHNpemVfdCAqYWN0dWFsX3NpemUs IHNpemVfdCBhbGlnbm1lbnQpIHsKIAogICAvLyBSZXR1cm4gdGhlIHVudXNlZCBtZW1vcnkgdG8g dGhlIHN5c3RlbQogICBpZiAoYWRqdXN0ID4gMCkgewotICAgIG11bm1hcChyZWludGVycHJldF9j YXN0PHZvaWQqPihwdHIpLCBhZGp1c3QpOworICAgIG11bm1hcChyZWludGVycHJldF9jYXN0PGNo YXIqPihwdHIpLCBhZGp1c3QpOwogICB9CiAgIGlmIChhZGp1c3QgPCBleHRyYSkgewotICAgIG11 bm1hcChyZWludGVycHJldF9jYXN0PHZvaWQqPihwdHIgKyBhZGp1c3QgKyBzaXplKSwgZXh0cmEg LSBhZGp1c3QpOworICAgIG11bm1hcChyZWludGVycHJldF9jYXN0PGNoYXIqPihwdHIgKyBhZGp1 c3QgKyBzaXplKSwgZXh0cmEgLSBhZGp1c3QpOwogICB9CiAKICAgcHRyICs9IGFkanVzdDsKQEAg LTQ0Myw3ICs0NDMsNyBAQCB2b2lkIFRDTWFsbG9jX1N5c3RlbVJlbGVhc2Uodm9pZCogc3RhcnQs IHNpemVfdCBsZW5ndGgpCiAKIHZvaWQgVENNYWxsb2NfU3lzdGVtUmVsZWFzZSh2b2lkKiBzdGFy dCwgc2l6ZV90IGxlbmd0aCkKIHsKLSAgdm9pZCogbmV3QWRkcmVzcyA9IG1tYXAoc3RhcnQsIGxl bmd0aCwgUFJPVF9SRUFEIHwgUFJPVF9XUklURSwgTUFQX1BSSVZBVEUgfCBNQVBfQU5PTllNT1VT IHwgTUFQX0ZJWEVELCAtMSwgMCk7CisgIHZvaWQqIG5ld0FkZHJlc3MgPSBtbWFwKHJlaW50ZXJw cmV0X2Nhc3Q8Y2hhcio+KHN0YXJ0KSwgbGVuZ3RoLCBQUk9UX1JFQUQgfCBQUk9UX1dSSVRFLCBN QVBfUFJJVkFURSB8IE1BUF9BTk9OWU1PVVMgfCBNQVBfRklYRUQsIC0xLCAwKTsKICAgLy8gSWYg dGhlIG1tYXAgZmFpbGVkIHRoZW4gdGhhdCdzIG9rLCB3ZSBqdXN0IHdvbid0IHJldHVybiB0aGUg bWVtb3J5IHRvIHRoZSBzeXN0ZW0uCiAgIEFTU0VSVF9VTlVTRUQobmV3QWRkcmVzcywgbmV3QWRk cmVzcyA9PSBzdGFydCB8fCBuZXdBZGRyZXNzID09IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KE1B UF9GQUlMRUQpKTsKIH0K