36486 2010-03-23 04:09:36 -0700 Web Inspector: render nodes in inherited style bars as links. 2010-03-23 08:40:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 202990 0 pfeldman 2010-03-23 04:09:36 -0700 Also fixes few nits: - We no longer populate search field with the class name upon click on the selector. Rationale: selector text can't be usually found using plain text matching (comma separated values, ids, containment and such spoil it all and bring in confusion) - Sections are no longer collapsed upon href click - Breakpoints navigation is fixed 202991 1 51411 pfeldman 2010-03-23 04:11:40 -0700 Created attachment 51411 [PATCH] Proposed change. 203037 2 51411 timothy 2010-03-23 07:24:37 -0700 Comment on attachment 51411 [PATCH] Proposed change. > + var nodeClass = styleRule.node.getAttribute("class"); > + if (nodeClass) > + title += "." + nodeClass; > + var nodeId = styleRule.node.getAttribute("id"); > + if (nodeId) > + title += "#" + nodeId; We should make this a helper function, I think we do this in another place when making a new style rule and breadcrumbs. 203055 3 pfeldman 2010-03-23 08:39:54 -0700 Landed with comments addressed (new utility function in elements panel). Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/BreakpointsSidebarPane.js M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.js Committed r56395 51411 2010-03-23 04:11:40 -0700 2010-03-23 07:24:36 -0700 [PATCH] Proposed change. styles_brush_up text/plain 6219 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2Q3MzY2NS4uNGFiNDI1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wMy0yMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW5kZXIgbm9kZXMgaW4gaW5oZXJp dGVkIHN0eWxlIGJhcnMgYXMgbGlua3MuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM2NDg2CisKKyAgICAgICAgKiBFbmdsaXNoLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanM6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50 c1NpZGViYXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRzU2lkZWJh clBhbmUucHJvdG90eXBlLl9hcHBlbmRCcmVha3BvaW50RWxlbWVudC5icmVha3BvaW50Q2xpY2tl ZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludHNTaWRlYmFyUGFuZS5wcm90b3R5 cGUuX2FwcGVuZEJyZWFrcG9pbnRFbGVtZW50KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlc1Np ZGViYXJQYW5lLnByb3RvdHlwZS5fdXBkYXRlLmVsc2UuaW5zZXJ0SW5oZXJpdGVkTm9kZVNlcGFy YXRvcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBl Ll91cGRhdGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLnByb3Rv dHlwZS5fc2VsZWN0Tm9kZSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanM6CisKIDIwMTAtMDMtMjIgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvV2ViQ29yZS9FbmdsaXNoLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggMGE1NTI1MC4uOWM4ZmU2ZCAxMDA2NDQKQmlu YXJ5IGZpbGVzIGEvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYW5k IGIvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgZGlmZmVyCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludHNTaWRlYmFyUGFu ZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50c1NpZGViYXJQYW5l LmpzCmluZGV4IDY5MGQwOTEuLmZjZmQyYWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9CcmVha3BvaW50c1NpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9CcmVha3BvaW50c1NpZGViYXJQYW5lLmpzCkBAIC04Myw5ICs4Myw3IEBA IFdlYkluc3BlY3Rvci5CcmVha3BvaW50c1NpZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKIAogICAg ICAgICBmdW5jdGlvbiBicmVha3BvaW50Q2xpY2tlZCgpCiAgICAgICAgIHsKLSAgICAgICAgICAg IHZhciBzY3JpcHQgPSBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMuc2NyaXB0T3JSZXNvdXJj ZUZvcklEKGJyZWFrcG9pbnQuc291cmNlSUQpOwotICAgICAgICAgICAgaWYgKHNjcmlwdCkKLSAg ICAgICAgICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMuc2hvd1NjcmlwdChzY3Jp cHQsIGJyZWFrcG9pbnQubGluZSk7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLnNj cmlwdHMuc2hvd1NvdXJjZUxpbmUoYnJlYWtwb2ludC51cmwsIGJyZWFrcG9pbnQubGluZSk7CiAg ICAgICAgIH0KIAogICAgICAgICB2YXIgYnJlYWtwb2ludEVsZW1lbnQgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCJsaSIpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1N0eWxlc1NpZGViYXJQYW5lLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxl c1NpZGViYXJQYW5lLmpzCmluZGV4IDUyZGE1MmMuLmI5N2NiMDQgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKQEAgLTE5MCw5ICsxOTAs NyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAg ICAgICAgewogICAgICAgICAgICAgICAgIHZhciBlbnRyeSA9IHt9OwogICAgICAgICAgICAgICAg IGVudHJ5LmlzSW5oZXJpdGVkTm9kZVNlcGFyYXRvciA9IHRydWU7Ci0gICAgICAgICAgICAgICAg ZW50cnkubm9kZU5hbWUgPSBub2RlLm5vZGVOYW1lOwotICAgICAgICAgICAgICAgIGVudHJ5Lm5v ZGVDbGFzcyA9IG5vZGUuZ2V0QXR0cmlidXRlKCJjbGFzcyIpOwotICAgICAgICAgICAgICAgIGVu dHJ5Lm5vZGVJZCA9IG5vZGUuZ2V0QXR0cmlidXRlKCJpZCIpOworICAgICAgICAgICAgICAgIGVu dHJ5Lm5vZGUgPSBub2RlOwogICAgICAgICAgICAgICAgIHN0eWxlUnVsZXMucHVzaChlbnRyeSk7 CiAgICAgICAgICAgICB9CiAKQEAgLTMzNCwxMiArMzMyLDIwIEBAIFdlYkluc3BlY3Rvci5TdHls ZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgaWYgKHN0eWxlUnVs ZS5pc0luaGVyaXRlZE5vZGVTZXBhcmF0b3IpIHsKICAgICAgICAgICAgICAgICAgICAgdmFyIHNl cGFyYXRvckVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAg ICAgICAgICAgICAgc2VwYXJhdG9yRWxlbWVudC5jbGFzc05hbWUgPSAic3R5bGVzLXNpZGViYXIt c2VwYXJhdG9yIjsKLSAgICAgICAgICAgICAgICAgICAgdmFyIHRpdGxlID0gc3R5bGVSdWxlLm5v ZGVOYW1lLnRvTG93ZXJDYXNlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChzdHlsZVJ1bGUu bm9kZUNsYXNzKQotICAgICAgICAgICAgICAgICAgICAgICAgdGl0bGUgKz0gIi4iICsgc3R5bGVS dWxlLm5vZGVDbGFzczsKLSAgICAgICAgICAgICAgICAgICAgaWYgKHN0eWxlUnVsZS5ub2RlSWQp Ci0gICAgICAgICAgICAgICAgICAgICAgICB0aXRsZSArPSAiIyIgKyBzdHlsZVJ1bGUubm9kZUlk OwotICAgICAgICAgICAgICAgICAgICBzZXBhcmF0b3JFbGVtZW50LmlubmVyVGV4dCA9IFdlYklu c3BlY3Rvci5VSVN0cmluZygiSW5oZXJpdGVkIGZyb20gJXMiLCB0aXRsZSk7CisgICAgICAgICAg ICAgICAgICAgIHZhciB0aXRsZSA9IHN0eWxlUnVsZS5ub2RlLm5vZGVOYW1lLnRvTG93ZXJDYXNl KCk7CisgICAgICAgICAgICAgICAgICAgIHZhciBub2RlQ2xhc3MgPSBzdHlsZVJ1bGUubm9kZS5n ZXRBdHRyaWJ1dGUoImNsYXNzIik7CisgICAgICAgICAgICAgICAgICAgIGlmIChub2RlQ2xhc3Mp CisgICAgICAgICAgICAgICAgICAgICAgICB0aXRsZSArPSAiLiIgKyBub2RlQ2xhc3M7CisgICAg ICAgICAgICAgICAgICAgIHZhciBub2RlSWQgPSBzdHlsZVJ1bGUubm9kZS5nZXRBdHRyaWJ1dGUo ImlkIik7CisgICAgICAgICAgICAgICAgICAgIGlmIChub2RlSWQpCisgICAgICAgICAgICAgICAg ICAgICAgICB0aXRsZSArPSAiIyIgKyBub2RlSWQ7CisgICAgICAgICAgICAgICAgICAgIHZhciBs aW5rID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOworICAgICAgICAgICAgICAgICAgICBs aW5rLmhyZWYgPSAiIjsKKyAgICAgICAgICAgICAgICAgICAgbGluay5hZGRFdmVudExpc3RlbmVy KCJjbGljayIsIHRoaXMuX3NlbGVjdE5vZGUuYmluZCh0aGlzLCBzdHlsZVJ1bGUubm9kZS5pZCks IGZhbHNlKTsKKyAgICAgICAgICAgICAgICAgICAgbGluay50ZXh0Q29udGVudCA9IHRpdGxlOwor CisgICAgICAgICAgICAgICAgICAgIHNlcGFyYXRvckVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuY3JlYXRlVGV4dE5vZGUoV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJJbmhlcml0ZWQgZnJvbSIp ICsgIiAiKSk7CisgICAgICAgICAgICAgICAgICAgIHNlcGFyYXRvckVsZW1lbnQuYXBwZW5kQ2hp bGQobGluayk7CiAgICAgICAgICAgICAgICAgICAgIHRoaXMuYm9keUVsZW1lbnQuYXBwZW5kQ2hp bGQoc2VwYXJhdG9yRWxlbWVudCk7CiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAg ICAgICAgICAgICAgIH0KQEAgLTM3Miw2ICszNzgsMTIgQEAgV2ViSW5zcGVjdG9yLlN0eWxlc1Np ZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKKyAgICBfc2VsZWN0 Tm9kZTogZnVuY3Rpb24obm9kZUlkLCBlKQorICAgIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLnVw ZGF0ZUZvY3VzZWROb2RlKG5vZGVJZCk7CisgICAgICAgIGUucHJldmVudERlZmF1bHQoKTsKKyAg ICB9LAorCiAgICAgX2NvbnRhaW5zSW5oZXJpdGVkOiBmdW5jdGlvbihwYXlsb2FkKQogICAgIHsK ICAgICAgICAgdmFyIHByb3BlcnRpZXMgPSBbXTsKQEAgLTQ0Niw3ICs0NTgsNiBAQCBXZWJJbnNw ZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbiA9IGZ1bmN0aW9uKHN0eWxlUnVsZSwgc3VidGl0 bGUsIGNvbXB1dGVkU3R5bAogewogICAgIFdlYkluc3BlY3Rvci5Qcm9wZXJ0aWVzU2VjdGlvbi5j YWxsKHRoaXMsIHN0eWxlUnVsZS5zZWxlY3RvclRleHQpOwogCi0gICAgdGhpcy50aXRsZUVsZW1l bnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9jbGlja1NlbGVjdG9yLmJpbmQodGhp cyksIGZhbHNlKTsKICAgICB0aGlzLnRpdGxlRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJkYmxj bGljayIsIHRoaXMuX2RibGNsaWNrU2VsZWN0b3IuYmluZCh0aGlzKSwgZmFsc2UpOwogICAgIHRo aXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJkYmxjbGljayIsIHRoaXMuX2RibGNsaWNrRW1w dHlTcGFjZS5iaW5kKHRoaXMpLCBmYWxzZSk7CiAKQEAgLTY3MSwxOSArNjgyLDYgQEAgV2ViSW5z cGVjdG9yLlN0eWxlUHJvcGVydGllc1NlY3Rpb24ucHJvdG90eXBlID0gewogICAgICAgICByZXR1 cm4gaXRlbTsKICAgICB9LAogCi0gICAgX2NsaWNrU2VsZWN0b3I6IGZ1bmN0aW9uKGV2ZW50KQot ICAgIHsKLSAgICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0aW9uKCk7Ci0KLSAgICAgICAgLy8gRG9u J3Qgc2VhcmNoICJDb21wdXRlZCBTdHlsZXMiLCAiU3R5bGUgQXR0cmlidXRlIiwgb3IgTWFwcGVk IEF0dHJpYnV0ZXMuCi0gICAgICAgIGlmICh0aGlzLmNvbXB1dGVkU3R5bGUgfHwgIXRoaXMucnVs ZSB8fCB0aGlzLnJ1bGUuaXNVc2VyKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIHZh ciBzZWFyY2hFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlYXJjaCIpOwotICAg ICAgICBzZWFyY2hFbGVtZW50LnZhbHVlID0gdGhpcy5zdHlsZVJ1bGUuc2VsZWN0b3JUZXh0Owot ICAgICAgICBXZWJJbnNwZWN0b3IucGVyZm9ybVNlYXJjaCh7IHRhcmdldDogc2VhcmNoRWxlbWVu dCB9KTsKLSAgICB9LAotCiAgICAgX2RibGNsaWNrRW1wdHlTcGFjZTogZnVuY3Rpb24oZXZlbnQp CiAgICAgewogICAgICAgICB0aGlzLmV4cGFuZCgpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanMKaW5kZXggMWQyYzQ2ZC4uZGU2ZjQ0MiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC02MzgsNiArNjM4LDcgQEAgV2ViSW5zcGVjdG9y LmRvY3VtZW50Q2xpY2sgPSBmdW5jdGlvbihldmVudCkKIAogICAgIC8vIFByZXZlbnQgdGhlIGxp bmsgZnJvbSBuYXZpZ2F0aW5nLCBzaW5jZSB3ZSBkb24ndCBkbyBhbnkgbmF2aWdhdGlvbiBieSBm b2xsb3dpbmcgbGlua3Mgbm9ybWFsbHkuCiAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAg ICBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsKIAogICAgIGZ1bmN0aW9uIGZvbGxvd0xpbmsoKQog ICAgIHsK