36473 2010-03-22 18:20:39 -0700 Missing lock in call to doneCreatingDatabase 2010-03-25 23:06:28 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ericu ericu commit-queue dumi oldest_to_newest 202865 0 ericu 2010-03-22 18:20:39 -0700 The last call to doneCreatingDatabase in DatabaseTracker::canEstablishDatabase is called without locking m_databaseGuard. This will assert in debug builds and use a supposedly-protected data structure without locking in release builds. This is a bug in my last checkin [56293]. This wasn't caught by layout tests because we don't have one that tries to create a database with a large quota. 202882 1 51382 ericu 2010-03-22 18:51:53 -0700 Created attachment 51382 Patch 202885 2 dumi 2010-03-22 19:01:40 -0700 LGTM, fwiw. 203863 3 51382 eric 2010-03-25 00:28:14 -0700 Comment on attachment 51382 Patch The test seems missing from this patch. 204137 4 51656 ericu 2010-03-25 10:47:31 -0700 Created attachment 51656 Patch 204138 5 ericu 2010-03-25 10:48:03 -0700 Thanks Eric; forgot the svn add. 204234 6 51656 levin 2010-03-25 14:51:45 -0700 Comment on attachment 51656 Patch > Index: WebCore/ChangeLog > + * storage/DatabaseTracker.cpp: Added missing lock call. Ideally your comment would be at the function level (which is where you did this change). > + (WebCore::DatabaseTracker::canEstablishDatabase): > + > Index: WebCore/storage/DatabaseTracker.cpp > + MutexLocker lockDatabase(m_databaseGuard); > doneCreatingDatabase(origin, name); It seems nicer to do this: MutexLocker lockDatabase(m_databaseGuard); if (requirement <= quotaForOriginNoLock(origin)) return true; doneCreatingDatabase(origin, name); Opinion? 204250 7 ericu 2010-03-25 15:13:15 -0700 (In reply to comment #6) > (From update of attachment 51656 [details]) > > Index: WebCore/ChangeLog > > + * storage/DatabaseTracker.cpp: Added missing lock call. > > Ideally your comment would be at the function level (which is where you did > this change). > > > + (WebCore::DatabaseTracker::canEstablishDatabase): > > + Fixed. > > Index: WebCore/storage/DatabaseTracker.cpp > > + MutexLocker lockDatabase(m_databaseGuard); > > doneCreatingDatabase(origin, name); > > It seems nicer to do this: > > MutexLocker lockDatabase(m_databaseGuard); > if (requirement <= quotaForOriginNoLock(origin)) > return true; > > doneCreatingDatabase(origin, name); > > Opinion? Sure, and I'll do you one better; I can let the previous lock call out of its braces. 204251 8 51682 ericu 2010-03-25 15:13:57 -0700 Created attachment 51682 Patch 204391 9 51682 commit-queue 2010-03-25 20:22:20 -0700 Comment on attachment 51682 Patch Rejecting patch 51682 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--build-style=both', '--quiet', '51682', '--no-update']" exit_code: 1 Last 500 characters of output: ne 60, in _run step(tool, options).run(state) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/commit.py", line 34, in run commit_message = self._tool.checkout().commit_message_for_this_commit() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 65, in commit_message_for_this_commit return CommitMessage("".join(changelog_messages).splitlines()) NameError: global name 'CommitMessage' is not defined 204396 10 51682 eric 2010-03-25 21:18:36 -0700 Comment on attachment 51682 Patch I've restarted the commit-bot. Sorry for the noise. 204421 11 51682 commit-queue 2010-03-25 23:06:24 -0700 Comment on attachment 51682 Patch Clearing flags on attachment: 51682 Committed r56604: <http://trac.webkit.org/changeset/56604> 204422 12 commit-queue 2010-03-25 23:06:28 -0700 All reviewed patches have been landed. Closing bug. 51382 2010-03-22 18:51:53 -0700 2010-03-25 10:47:28 -0700 Patch bug-36473-20100322185152.patch text/plain 1802 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjM3MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMjIgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN aXNzaW5nIGxvY2sgaW4gY2FsbCB0byBkb25lQ3JlYXRpbmdEYXRhYmFzZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NzMKKworICAgICAgICBBZGRl ZCBuZXcgdGVzdCBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sLgorCisgICAg ICAgICogc3RvcmFnZS9EYXRhYmFzZVRyYWNrZXIuY3BwOiAgQWRkZWQgbWlzc2luZyBsb2NrIGNh bGwuCisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZVRyYWNrZXI6OmNhbkVzdGFibGlzaERhdGFi YXNlKToKKwogMjAxMC0wMy0yMiAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEJyYWR5IEVpZHNvbi4KSW5kZXg6IFdlYkNvcmUvc3RvcmFn ZS9EYXRhYmFzZVRyYWNrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZVRyYWNrZXIuY3BwCShyZXZpc2lvbiA1NjM2MykKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZVRyYWNrZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzcsNiArMTc3LDcgQEAgYm9vbCBE YXRhYmFzZVRyYWNrZXI6OmNhbkVzdGFibGlzaERhdGFiYQogICAgIGlmIChyZXF1aXJlbWVudCA8 PSBxdW90YUZvck9yaWdpbihvcmlnaW4pKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIE11 dGV4TG9ja2VyIGxvY2tEYXRhYmFzZShtX2RhdGFiYXNlR3VhcmQpOwogICAgIGRvbmVDcmVhdGlu Z0RhdGFiYXNlKG9yaWdpbiwgbmFtZSk7CiAgICAgcmV0dXJuIGZhbHNlOwogfQpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gNTYzNjMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0yMiAgRXJpYyBVaHJoYW5lICA8ZXJpY3VAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1pc3NpbmcgbG9jayBpbiBjYWxsIHRvIGRvbmVDcmVhdGluZ0RhdGFiYXNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjQ3MworCisgICAgICAgIEFk ZGVkIG5ldyB0ZXN0IHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVyLXF1b3RhLmh0bWwuCisKKyAg ICAgICAgKiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorCiAyMDEwLTAzLTIyICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLgo= 51656 2010-03-25 10:47:31 -0700 2010-03-25 15:13:54 -0700 Patch bug-36473-20100325104730.patch text/plain 3140 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjM3MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMjIgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN aXNzaW5nIGxvY2sgaW4gY2FsbCB0byBkb25lQ3JlYXRpbmdEYXRhYmFzZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NzMKKworICAgICAgICBBZGRl ZCBuZXcgdGVzdCBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sLgorCisgICAg ICAgICogc3RvcmFnZS9EYXRhYmFzZVRyYWNrZXIuY3BwOiAgQWRkZWQgbWlzc2luZyBsb2NrIGNh bGwuCisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZVRyYWNrZXI6OmNhbkVzdGFibGlzaERhdGFi YXNlKToKKwogMjAxMC0wMy0yMiAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEJyYWR5IEVpZHNvbi4KSW5kZXg6IFdlYkNvcmUvc3RvcmFn ZS9EYXRhYmFzZVRyYWNrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZVRyYWNrZXIuY3BwCShyZXZpc2lvbiA1NjM2MykKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZVRyYWNrZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzcsNiArMTc3LDcgQEAgYm9vbCBE YXRhYmFzZVRyYWNrZXI6OmNhbkVzdGFibGlzaERhdGFiYQogICAgIGlmIChyZXF1aXJlbWVudCA8 PSBxdW90YUZvck9yaWdpbihvcmlnaW4pKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIE11 dGV4TG9ja2VyIGxvY2tEYXRhYmFzZShtX2RhdGFiYXNlR3VhcmQpOwogICAgIGRvbmVDcmVhdGlu Z0RhdGFiYXNlKG9yaWdpbiwgbmFtZSk7CiAgICAgcmV0dXJuIGZhbHNlOwogfQpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gNTYzNjMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0yMiAgRXJpYyBVaHJoYW5lICA8ZXJpY3VAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1pc3NpbmcgbG9jayBpbiBjYWxsIHRvIGRvbmVDcmVhdGluZ0RhdGFiYXNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjQ3MworCisgICAgICAgIEFk ZGVkIG5ldyB0ZXN0IHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVyLXF1b3RhLmh0bWwuCisKKyAg ICAgICAgKiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorCiAyMDEwLTAzLTIyICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLgpJbmRleDogTGF5b3V0VGVzdHMvc3Rv cmFnZS9vcGVuLWRhdGFiYXNlLW92ZXItcXVvdGEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3N0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVyLXF1b3RhLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVy LXF1b3RhLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyIEBACitUaGlzIHRl c3RzIHRoYXQgY2FsbGluZyBvcGVuRGF0YWJhc2Ugd2l0aCBhIHNpemUgb3ZlciA1TUIgZG9lc24n dCBhc3NlcnQgb24gZGVidWcgYnVpbGRzLgorUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFn ZS9vcGVuLWRhdGFiYXNlLW92ZXItcXVvdGEuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9zdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sCShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRhdGFiYXNlLW92ZXItcXVvdGEuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwyNCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitmdW5jdGlv biBydW5UZXN0KCkgeworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5jbGVhckFsbERhdGFiYXNlcygpOworICAgIH0KKyAgICAgICAgCisgICAg CisgICAgdmFyIGRiID0gb3BlbkRhdGFiYXNlKCdPdmVyUXVvdGFPcGVuJywgJycsICdUZXN0IGZv ciBidWcgMzY0NzM6IG1pc3NpbmcgbG9jayBpbiBjYWxsIHRvIGRvbmVDcmVhdGluZ0RhdGFiYXNl JywgMTAwMDAwMDApOworICAgIGlmICghZGIpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3Jlc3VsdCcpLmlubmVySFRNTCA9ICdQQVNTJworICAgIH0KK30KKzwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPGRpdj5UaGlzIHRlc3RzIHRoYXQg Y2FsbGluZyBvcGVuRGF0YWJhc2Ugd2l0aCBhIHNpemUgb3ZlciA1TUIgZG9lc24ndCBhc3NlcnQg b24gZGVidWcgYnVpbGRzLgorPGRpdiBpZD0icmVzdWx0Ij4KK0ZBSUw6IFdlIHNob3VsZG4ndCBo YXZlIGJlZW4gYWJsZSB0byBvcGVuIHRoZSBkYXRhYmFzZS4KKzwvZGl2PgorPC9ib2R5PgorPC9o dG1sPgo= 51682 2010-03-25 15:13:57 -0700 2010-03-25 23:06:24 -0700 Patch bug-36473-20100325151356.patch text/plain 3544 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjM3MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMjIgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN aXNzaW5nIGxvY2sgaW4gY2FsbCB0byBkb25lQ3JlYXRpbmdEYXRhYmFzZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NzMKKworICAgICAgICBBZGRl ZCBuZXcgdGVzdCBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sLgorCisgICAg ICAgICogc3RvcmFnZS9EYXRhYmFzZVRyYWNrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGF0 YWJhc2VUcmFja2VyOjpjYW5Fc3RhYmxpc2hEYXRhYmFzZSk6ICBBZGRlZCBtaXNzaW5nIGxvY2sg Y2FsbC4KKwogMjAxMC0wMy0yMiAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEJyYWR5IEVpZHNvbi4KSW5kZXg6IFdlYkNvcmUvc3RvcmFn ZS9EYXRhYmFzZVRyYWNrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZVRyYWNrZXIuY3BwCShyZXZpc2lvbiA1NjM2MykKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZVRyYWNrZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsMTYgKzE2OCwxNyBAQCBib29s IERhdGFiYXNlVHJhY2tlcjo6Y2FuRXN0YWJsaXNoRGF0YWJhCiAgICAgfQogICAgIC8vIERyb3Ag YWxsIGxvY2tzIGJlZm9yZSBjYWxsaW5nIG91dDsgd2UgZG9uJ3Qga25vdyB3aGF0IHRoZXknbGwg ZG8uCiAgICAgY29udGV4dC0+ZGF0YWJhc2VFeGNlZWRlZFF1b3RhKG5hbWUpOwotICAgIHsKLSAg ICAgICAgTXV0ZXhMb2NrZXIgbG9ja0RhdGFiYXNlKG1fZGF0YWJhc2VHdWFyZCk7Ci0gICAgICAg IG1fcHJvcG9zZWREYXRhYmFzZXMucmVtb3ZlKCZkZXRhaWxzKTsKLSAgICB9CisKKyAgICBNdXRl eExvY2tlciBsb2NrRGF0YWJhc2UobV9kYXRhYmFzZUd1YXJkKTsKKworICAgIG1fcHJvcG9zZWRE YXRhYmFzZXMucmVtb3ZlKCZkZXRhaWxzKTsKIAogICAgIC8vIElmIHRoZSBkYXRhYmFzZSB3aWxs IGZpdCBub3csIGFsbG93IGl0cyBjcmVhdGlvbi4KLSAgICBpZiAocmVxdWlyZW1lbnQgPD0gcXVv dGFGb3JPcmlnaW4ob3JpZ2luKSkKKyAgICBpZiAocmVxdWlyZW1lbnQgPD0gcXVvdGFGb3JPcmln aW5Ob0xvY2sob3JpZ2luKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBkb25lQ3JlYXRp bmdEYXRhYmFzZShvcmlnaW4sIG5hbWUpOworCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA1NjM2MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTAzLTIyICBFcmljIFVocmhhbmUgIDxlcmljdUBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTWlzc2luZyBsb2NrIGluIGNhbGwgdG8gZG9uZUNyZWF0aW5nRGF0YWJhc2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDczCisKKyAgICAg ICAgQWRkZWQgbmV3IHRlc3Qgc3RvcmFnZS9vcGVuLWRhdGFiYXNlLW92ZXItcXVvdGEuaHRtbC4K KworICAgICAgICAqIHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVyLXF1b3RhLmh0bWw6IEFkZGVk LgorICAgICAgICAqIHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVyLXF1b3RhLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisKIDIwMTAtMDMtMjIgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2Vu bmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuCkluZGV4OiBMYXlvdXRUZXN0 cy9zdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRhdGFiYXNlLW92ZXItcXVvdGEtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRhdGFiYXNl LW92ZXItcXVvdGEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIgQEAKK1Ro aXMgdGVzdHMgdGhhdCBjYWxsaW5nIG9wZW5EYXRhYmFzZSB3aXRoIGEgc2l6ZSBvdmVyIDVNQiBk b2Vzbid0IGFzc2VydCBvbiBkZWJ1ZyBidWlsZHMuCitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9z dG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3N0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1vdmVyLXF1b3RhLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1 bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg eworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmNsZWFyQWxsRGF0YWJhc2VzKCk7CisgICAgfQorICAgICAgICAK KyAgICAKKyAgICB2YXIgZGIgPSBvcGVuRGF0YWJhc2UoJ092ZXJRdW90YU9wZW4nLCAnJywgJ1Rl c3QgZm9yIGJ1ZyAzNjQ3MzogbWlzc2luZyBsb2NrIGluIGNhbGwgdG8gZG9uZUNyZWF0aW5nRGF0 YWJhc2UnLCAxMDAwMDAwMCk7CisgICAgaWYgKCFkYikgeworICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gJ1BBU1MnCisgICAgfQorfQorPC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8ZGl2PlRoaXMgdGVzdHMg dGhhdCBjYWxsaW5nIG9wZW5EYXRhYmFzZSB3aXRoIGEgc2l6ZSBvdmVyIDVNQiBkb2Vzbid0IGFz c2VydCBvbiBkZWJ1ZyBidWlsZHMuCis8ZGl2IGlkPSJyZXN1bHQiPgorRkFJTDogV2Ugc2hvdWxk bid0IGhhdmUgYmVlbiBhYmxlIHRvIG9wZW4gdGhlIGRhdGFiYXNlLgorPC9kaXY+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==