36470 2010-03-22 17:43:22 -0700 [chromium] Eliminate unnecessary graphics layer redraws 2010-03-25 00:08:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vangelis webkit-unassigned commit-queue dglazkov levin oldest_to_newest 202846 0 vangelis 2010-03-22 17:43:22 -0700 In the current implementation of ACCELERATED_COMPOSITING, LayerSkia's are asked to redraw their contents every time the browser needs to redraw the page. This results in a lot of unnecessary drawing. Contents of these layers should only be redrawn when something changes in the layer and simply composited when its time to redraw the page. 202864 1 51375 vangelis 2010-03-22 18:16:16 -0700 Created attachment 51375 Proposed patch 203068 2 51375 dglazkov 2010-03-23 09:11:23 -0700 Comment on attachment 51375 Proposed patch r=me. 203853 3 51375 commit-queue 2010-03-25 00:08:05 -0700 Comment on attachment 51375 Proposed patch Clearing flags on attachment: 51375 Committed r56502: <http://trac.webkit.org/changeset/56502> 203854 4 commit-queue 2010-03-25 00:08:09 -0700 All reviewed patches have been landed. Closing bug. 51375 2010-03-22 18:16:16 -0700 2010-03-25 00:08:05 -0700 Proposed patch no_redraw.txt text/plain 5111 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjM3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMDMtMjIgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92aW5nIHVuZWNlc3NhcnkgcmVkcmF3cyBvZiBMYXllclNraWEgY29udGVudHM6 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjQ3MAor CisgICAgICAgIFRlc3Q6IE5vIG5ldyBmdW5jdGlvbmFsaXR5IGFkZGVkLCBubyB0ZXN0cy4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvTGF5ZXJSZW5kZXJlclNraWEuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlclNraWE6OmRyYXdMYXllckluQ2FudmFzUmVj dXJzaXZlKToKKyAgICAgICAgRGVidWcgYm9yZGVycyBub3cgcmVuZGVyZWQgYXQgY29tcG9zaXRl IHRpbWUgcmF0aGVyIHRoYW4gdXBkYXRlIHRpbWUuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9MYXllclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJTa2lhOjp1cGRh dGVDb250ZW50cyk6CisgICAgICAgIChXZWJDb3JlOjpMYXllclNraWE6OmRyYXdEZWJ1Z0JvcmRl cik6CisgICAgICAgIERlYnVnIGJvcmRlciBkcmF3aW5nIHJlbW92ZWQgZnJvbSB1cGRhdGVDb250 ZW50cyBhbmQgc3BsaXQgaW50byBhIHNlcGFyYXRlIG1ldGhvZCB0aGF0CisgICAgICAgIGNhbiBi ZSBjYWxsZWQgYXQgY29tcG9zaXRlIHRpbWUuCisgICAgICAgIChXZWJDb3JlOjpMYXllclNraWE6 OnNldEJvdW5kcyk6CisgICAgICAgIFJlc2V0dGluZyB0aGUgYm91bmRzIGNhdXNlcyB0aGUgbGF5 ZXIgdG8gcmVkcmF3IGl0cyBjb250ZW50cy4KKyAgICAgICAgKFdlYkNvcmU6OkxheWVyU2tpYTo6 c2V0TmVlZHNEaXNwbGF5KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0xheWVy U2tpYS5oOgorICAgICAgICBBZGRlZCBkZWNsYXJhdGlvbiBmb3IgZHJhd0RlYnVnQm9yZGVycyBt ZXRob2QuCisKIDIwMTAtMDMtMjIgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCkluZGV4OiBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3NraWEvTGF5ZXJSZW5kZXJlclNraWEuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9MYXllclJlbmRlcmVyU2tpYS5jcHAJKHJldmlz aW9uIDU2MzcxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0xheWVyUmVuZGVy ZXJTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5LDYgKzEwOSw4IEBAIHZvaWQgTGF5ZXJS ZW5kZXJlclNraWE6OmRyYXdMYXllckluQ2FudmEKICAgICAvLyB3ZSBuZWVkIHRvIGFkanVzdCBv dXIgdHJhbnNmb3JtLgogICAgIGNhbnZhcy0+dHJhbnNsYXRlKC0wLjVmICogYm91bmRzLndpZHRo KCksIC0wLjVmICogYm91bmRzLmhlaWdodCgpKTsKIAorICAgIGxheWVyLT5kcmF3RGVidWdCb3Jk ZXIoKTsKKwogICAgIFNrUGFpbnQgb3BhY2l0eVBhaW50OwogICAgIG9wYWNpdHkgKj0gbGF5ZXIt Pm9wYWNpdHkoKTsKICAgICBvcGFjaXR5UGFpbnQuc2V0QWxwaGEob3BhY2l0eSAqIDI1NSk7Cklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvTGF5ZXJTa2lhLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvTGF5ZXJTa2lhLmNwcAkocmV2 aXNpb24gNTYzNzEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvTGF5ZXJTa2lh LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEzLDkgKzExMywxMCBAQCB2b2lkIExheWVyU2tpYTo6 dXBkYXRlQ29udGVudHMoKQogCiAgICAgaWYgKGJhY2tpbmcgJiYgIWJhY2tpbmctPnBhaW50aW5n R29lc1RvV2luZG93KCkpCiAgICAgICAgIG1fb3duZXItPnBhaW50R3JhcGhpY3NMYXllckNvbnRl bnRzKCptX2dyYXBoaWNzQ29udGV4dCwgSW50UmVjdCgwLCAwLCBtX2JvdW5kcy53aWR0aCgpLCBt X2JvdW5kcy5oZWlnaHQoKSkpOworfQogCi0gICAgLy8gUGFpbnQgdGhlIGRlYnVnIGJvcmRlci4K LSAgICAvLyBGSVhNRTogQWRkIGEgZmxhZyB0byBjaGVjayBpZiBkZWJ1ZyBib3JkZXJzIGFyZSB1 c2VkLgordm9pZCBMYXllclNraWE6OmRyYXdEZWJ1Z0JvcmRlcigpCit7CiAgICAgbV9ncmFwaGlj c0NvbnRleHQtPnNldFN0cm9rZUNvbG9yKG1fYm9yZGVyQ29sb3IsIERldmljZUNvbG9yU3BhY2Up OwogICAgIG1fZ3JhcGhpY3NDb250ZXh0LT5zZXRTdHJva2VUaGlja25lc3MobV9ib3JkZXJXaWR0 aCk7CiAgICAgbV9ncmFwaGljc0NvbnRleHQtPmRyYXdMaW5lKEludFBvaW50KDAsIDApLCBJbnRQ b2ludChtX2JvdW5kcy53aWR0aCgpLCAwKSk7CkBAIC0xOTMsNiArMTk0LDEwIEBAIHZvaWQgTGF5 ZXJTa2lhOjpzZXRCb3VuZHMoY29uc3QgU2tJUmVjdCYKICAgICAvLyBSZS1jcmVhdGUgdGhlIGNh bnZhcyBhbmQgYXNzb2NpYXRlZCBjb250ZXh0cy4KICAgICB1cGRhdGVHcmFwaGljc0NvbnRleHQo bV9ib3VuZHMpOwogCisgICAgLy8gTGF5ZXIgY29udGVudHMgbmVlZCB0byBiZSByZWRyYXduIGFz IHRoZSBiYWNraW5nIHN1cmZhY2UKKyAgICAvLyB3YXMgcmVjcmVhdGVkIGFib3ZlLgorICAgIHVw ZGF0ZUNvbnRlbnRzKCk7CisKICAgICBzZXROZWVkc0NvbW1pdCgpOwogfQogCkBAIC0yMzUsNyAr MjQwLDkgQEAgTGF5ZXJTa2lhKiBMYXllclNraWE6OnN1cGVybGF5ZXIoKSBjb25zdAogCiB2b2lk IExheWVyU2tpYTo6c2V0TmVlZHNEaXNwbGF5KGNvbnN0IFNrUmVjdCYgZGlydHlSZWN0KQogewot ICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKKyAgICAvLyBSZWRyYXcgdGhlIGNvbnRlbnRzIG9mIHRo ZSBsYXllci4KKyAgICB1cGRhdGVDb250ZW50cygpOworCiAgICAgc2V0TmVlZHNDb21taXQoKTsK IH0KIApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0xheWVyU2tpYS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9MYXllclNraWEuaAko cmV2aXNpb24gNTYzNzEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvTGF5ZXJT a2lhLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1OSw2ICsxNTksOCBAQCBwdWJsaWM6CiAKICAgICB2 b2lkIHNldEJhY2tpbmdTdG9yZVJlY3QoY29uc3QgU2tJUmVjdCYpOwogCisgICAgdm9pZCBkcmF3 RGVidWdCb3JkZXIoKTsKKwogcHJpdmF0ZToKICAgICBMYXllclNraWEoTGF5ZXJUeXBlLCBHcmFw aGljc0xheWVyU2tpYSogb3duZXIpOwogCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2Mzcx KQorKysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDEwLTAzLTIyICBWYW5nZWxpcyBLb2trZXZpcyAgPHZhbmdlbGlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF bGltaW5hdGUgdW5lY2Vzc2FyeSByZWRyYXdzIG9mIEdyYXBoaWNzTGF5ZXIgY29udGVudHMgd2hl biBkb2luZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZzoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDcwCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0lt cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6cGFpbnQpOgorICAgICAgICBS ZW1vdmUgY2FsbCB0aGF0IGZvcmNlZCByZWRyYXdpbmcgdGhlIGNvbnRlbnRzIG9mIHRoZSBlbnRp cmUgbGF5ZXIgaGllcmFyY2h5LgorCiAyMDEwLTAzLTIyICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTmF0ZSBDaGFwaW4uCkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNTYzNzEpCisrKyBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTA4LDEwICs5 MDgsNiBAQCB2b2lkIFdlYlZpZXdJbXBsOjpwYWludChXZWJDYW52YXMqIGNhbnZhCiAgICAgICAg IC8vIERyYXcgdGhlIGNvbnRlbnRzIG9mIHRoZSByb290IGxheWVyLgogICAgICAgICB1cGRhdGVS b290TGF5ZXJDb250ZW50cyhyZWN0KTsKIAotICAgICAgICAvLyBGSVhNRTogTGF5ZXJzIHNob3Vs ZCBub3QgYmUgZm9yY2VkIHRvIHJlZHJhdyB0aGVpciBjb250ZW50cwotICAgICAgICAvLyBoZXJl IGJ1dCBzaG91bGQgdXBkYXRlIGFzIG5lZWRlZC4KLSAgICAgICAgbV9sYXllclJlbmRlcmVyLT51 cGRhdGVMYXllckNvbnRlbnRzKCk7Ci0KICAgICAgICAgLy8gQ29tcG9zaXRlIGV2ZXJ5dGhpbmcg aW50byB0aGUgY2FudmFzIHRoYXQncyBwYXNzZWQgdG8gdXMuCiAgICAgICAgIFNrSVJlY3QgY2Fu dmFzSVJlY3Q7CiAgICAgICAgIGNhbnZhc0lSZWN0LnNldChyZWN0LngsIHJlY3QueSwgcmVjdC54 ICsgcmVjdC53aWR0aCwgcmVjdC55ICsgcmVjdC5oZWlnaHQpOwo=