36460 2010-03-22 13:03:02 -0700 Implement Show/Hide Controls command for <video> in chromium 2010-03-23 14:15:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 sergeyu webkit-unassigned commit-queue oldest_to_newest 202719 0 sergeyu 2010-03-22 13:03:02 -0700 Corresponding chromium bug http://code.google.com/p/chromium/issues/detail?id=19848 . 202725 1 51339 sergeyu 2010-03-22 13:25:13 -0700 Created attachment 51339 Patch 202748 2 51350 sergeyu 2010-03-22 14:04:02 -0700 Created attachment 51350 Patch 202856 3 51350 dimich 2010-03-22 17:55:29 -0700 Comment on attachment 51350 Patch > diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog > + > + Show/Hide Controls command for <video> > + > + https://bugs.webkit.org/show_bug.cgi?id=36460 these 2 lines usually do not have empty line between them. Also, typically bugs and good ChangeLogs contain a bit more info, as to why and what was changed. It helps other folks when they 'scan' trac database or search bugzilla (or sometimes try to glean more information in an attempt to fix a bug that seems to be caused by the change). Look at existing entries that describe a change in a way that give you a good understanding of why and what has changed. Since you are not a committer yet, I think you'd want to use a commit-bot. It runs compile and tests and lands the patch once it is approved. In order to use it, you flip the commit-queue flag to ?, so the reviewer knows you want to use it and flips it to + with r+. Doing r- for now, looking forward for more info in ChangeLog, looks ok in general. 202875 4 51378 sergeyu 2010-03-22 18:31:51 -0700 Created attachment 51378 Patch 202899 5 51378 dimich 2010-03-22 19:32:40 -0700 Comment on attachment 51378 Patch Almost there. Just couple of nits: > diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog > + Changes needed to implement Show/Hide Controls command for <video> in > + chrome. WebKit does not have 80-col rule, so it's better not to wrap the line for a single word. > + (WebKit::WebContextMenuData::): Added MediaHasVideo and MediaControls. That's not exactly the type of info I was looking for. It is obvious from the code that these two are added. But, for example, why MediaHasVideo was added? Is it somehow necessary to be able to toggle controls? If it's just independent addition, it could be noted as well. Sorry for what looks like nits, but a few months later someone else will look at the code and since there is not much comments in it, will probably search in trac and wish there were more actual info, especially on 'why'. > + (WebKit::WebViewImpl::performMediaPlayerAction): Controls action > + handler. Also not a necessary wrapping. Another small iteration? 203144 6 51444 sergeyu 2010-03-23 12:12:01 -0700 Created attachment 51444 Patch 203179 7 51444 dimich 2010-03-23 13:44:59 -0700 Comment on attachment 51444 Patch r=me Thanks! 203202 8 51444 commit-queue 2010-03-23 14:15:46 -0700 Comment on attachment 51444 Patch Clearing flags on attachment: 51444 Committed r56415: <http://trac.webkit.org/changeset/56415> 203203 9 commit-queue 2010-03-23 14:15:50 -0700 All reviewed patches have been landed. Closing bug. 51339 2010-03-22 13:25:13 -0700 2010-03-22 14:04:00 -0700 Patch bug-36460-20100322132512.patch text/plain 3059 sergeyu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRlYWI2MzguLjY1NTRmZDUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIwIEBACisyMDEwLTAzLTIyICBTZXJnZXkgVWxhbm92ICA8c2VyZ2V5dUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2hvdy9I aWRlIENvbnRyb2xzIGNvbW1hbmQgZm9yIDx2aWRlbz4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NjAKKworICAgICAgICAqIHB1YmxpYy9XZWJD b250ZXh0TWVudURhdGEuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVEYXRhOjop OgorICAgICAgICAqIHB1YmxpYy9XZWJNZWRpYVBsYXllckFjdGlvbi5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJNZWRpYVBsYXllckFjdGlvbjo6KToKKyAgICAgICAgKiBzcmMvQ29udGV4dE1lbnVD bGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnRJbXBsOjpn ZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcyk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnBlcmZvcm1NZWRpYVBsYXllckFj dGlvbik6CisKIDIwMTAtMDMtMjIgIEtldmluIERlY2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCmRpZmYgLS1naXQgYS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaAppbmRleCAzODQyNDBkLi4yNTAzNmQ0IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCisrKyBiL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKQEAgLTgzLDYgKzgzLDgg QEAgc3RydWN0IFdlYkNvbnRleHRNZW51RGF0YSB7CiAgICAgICAgIE1lZGlhTG9vcCA9IDB4OCwK ICAgICAgICAgTWVkaWFDYW5TYXZlID0gMHgxMCwKICAgICAgICAgTWVkaWFIYXNBdWRpbyA9IDB4 MjAsCisgICAgICAgIE1lZGlhSGFzVmlkZW8gPSAweDQwLAorICAgICAgICBNZWRpYUNvbnRyb2xz ID0gMHg4MCwKICAgICB9OwogCiAgICAgLy8gRXh0cmEgYXR0cmlidXRlcyBkZXNjcmliaW5nIG1l ZGlhIGVsZW1lbnRzLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRp YVBsYXllckFjdGlvbi5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckFj dGlvbi5oCmluZGV4IDNhZWRlMjUuLjE5MjcwNGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24uaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYk1lZGlhUGxheWVyQWN0aW9uLmgKQEAgLTM4LDcgKzM4LDggQEAgc3RydWN0IFdlYk1l ZGlhUGxheWVyQWN0aW9uIHsKICAgICAgICAgVW5rbm93biwKICAgICAgICAgUGxheSwKICAgICAg ICAgTXV0ZSwKLSAgICAgICAgTG9vcAorICAgICAgICBMb29wLAorICAgICAgICBDb250cm9scwog ICAgIH07CiAKICAgICBUeXBlIHR5cGU7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3Jj L0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRN ZW51Q2xpZW50SW1wbC5jcHAKaW5kZXggMDZhMjlmZi4uNzA4ZDExMyAxMDA2NDQKLS0tIGEvV2Vi S2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9j aHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcApAQCAtMTgxLDYgKzE4MSwxMCBA QCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0TWVudUNsaWVudEltcGw6OmdldEN1c3Rv bU1lbnVGcm9tRGVmYXVsdEl0ZW1zKAogICAgICAgICAgICAgZGF0YS5tZWRpYUZsYWdzIHw9IFdl YkNvbnRleHRNZW51RGF0YTo6TWVkaWFDYW5TYXZlOwogICAgICAgICBpZiAobWVkaWFFbGVtZW50 LT5oYXNBdWRpbygpKQogICAgICAgICAgICAgZGF0YS5tZWRpYUZsYWdzIHw9IFdlYkNvbnRleHRN ZW51RGF0YTo6TWVkaWFIYXNBdWRpbzsKKyAgICAgICAgaWYgKG1lZGlhRWxlbWVudC0+aGFzVmlk ZW8oKSkKKyAgICAgICAgICAgIGRhdGEubWVkaWFGbGFncyB8PSBXZWJDb250ZXh0TWVudURhdGE6 Ok1lZGlhSGFzVmlkZW87CisgICAgICAgIGlmIChtZWRpYUVsZW1lbnQtPmNvbnRyb2xzKCkpCisg ICAgICAgICAgICBkYXRhLm1lZGlhRmxhZ3MgfD0gV2ViQ29udGV4dE1lbnVEYXRhOjpNZWRpYUNv bnRyb2xzOwogICAgIH0KIAogICAgIGRhdGEuaXNJbWFnZUJsb2NrZWQgPQpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAppbmRleCAyMzU5M2NlLi44MTQyOWY4IDEwMDY0NAotLS0gYS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcApAQCAtMTQxNyw2ICsxNDE3LDkgQEAgdm9pZCBXZWJWaWV3SW1wbDo6 cGVyZm9ybU1lZGlhUGxheWVyQWN0aW9uKGNvbnN0IFdlYk1lZGlhUGxheWVyQWN0aW9uJiBhY3Rp b24sCiAgICAgY2FzZSBXZWJNZWRpYVBsYXllckFjdGlvbjo6TG9vcDoKICAgICAgICAgbWVkaWFF bGVtZW50LT5zZXRMb29wKGFjdGlvbi5lbmFibGUpOwogICAgICAgICBicmVhazsKKyAgICBjYXNl IFdlYk1lZGlhUGxheWVyQWN0aW9uOjpDb250cm9sczoKKyAgICAgICAgbWVkaWFFbGVtZW50LT5z ZXRDb250cm9scyhhY3Rpb24uZW5hYmxlKTsKKyAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoK ICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQo= 51350 2010-03-22 14:04:02 -0700 2010-03-22 18:31:48 -0700 Patch bug-36460-20100322140401.patch text/plain 3059 sergeyu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRlYWI2MzguLjY1NTRmZDUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIwIEBACisyMDEwLTAzLTIyICBTZXJnZXkgVWxhbm92ICA8c2VyZ2V5dUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2hvdy9I aWRlIENvbnRyb2xzIGNvbW1hbmQgZm9yIDx2aWRlbz4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NjAKKworICAgICAgICAqIHB1YmxpYy9XZWJD b250ZXh0TWVudURhdGEuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVEYXRhOjop OgorICAgICAgICAqIHB1YmxpYy9XZWJNZWRpYVBsYXllckFjdGlvbi5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJNZWRpYVBsYXllckFjdGlvbjo6KToKKyAgICAgICAgKiBzcmMvQ29udGV4dE1lbnVD bGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnRJbXBsOjpn ZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcyk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnBlcmZvcm1NZWRpYVBsYXllckFj dGlvbik6CisKIDIwMTAtMDMtMjIgIEtldmluIERlY2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCmRpZmYgLS1naXQgYS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaAppbmRleCAzODQyNDBkLi4yNTAzNmQ0IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCisrKyBiL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKQEAgLTgzLDYgKzgzLDgg QEAgc3RydWN0IFdlYkNvbnRleHRNZW51RGF0YSB7CiAgICAgICAgIE1lZGlhTG9vcCA9IDB4OCwK ICAgICAgICAgTWVkaWFDYW5TYXZlID0gMHgxMCwKICAgICAgICAgTWVkaWFIYXNBdWRpbyA9IDB4 MjAsCisgICAgICAgIE1lZGlhSGFzVmlkZW8gPSAweDQwLAorICAgICAgICBNZWRpYUNvbnRyb2xz ID0gMHg4MCwKICAgICB9OwogCiAgICAgLy8gRXh0cmEgYXR0cmlidXRlcyBkZXNjcmliaW5nIG1l ZGlhIGVsZW1lbnRzLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRp YVBsYXllckFjdGlvbi5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckFj dGlvbi5oCmluZGV4IDNhZWRlMjUuLjE5MjcwNGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24uaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYk1lZGlhUGxheWVyQWN0aW9uLmgKQEAgLTM4LDcgKzM4LDggQEAgc3RydWN0IFdlYk1l ZGlhUGxheWVyQWN0aW9uIHsKICAgICAgICAgVW5rbm93biwKICAgICAgICAgUGxheSwKICAgICAg ICAgTXV0ZSwKLSAgICAgICAgTG9vcAorICAgICAgICBMb29wLAorICAgICAgICBDb250cm9scwog ICAgIH07CiAKICAgICBUeXBlIHR5cGU7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3Jj L0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRN ZW51Q2xpZW50SW1wbC5jcHAKaW5kZXggMDZhMjlmZi4uNzA4ZDExMyAxMDA2NDQKLS0tIGEvV2Vi S2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9j aHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcApAQCAtMTgxLDYgKzE4MSwxMCBA QCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0TWVudUNsaWVudEltcGw6OmdldEN1c3Rv bU1lbnVGcm9tRGVmYXVsdEl0ZW1zKAogICAgICAgICAgICAgZGF0YS5tZWRpYUZsYWdzIHw9IFdl YkNvbnRleHRNZW51RGF0YTo6TWVkaWFDYW5TYXZlOwogICAgICAgICBpZiAobWVkaWFFbGVtZW50 LT5oYXNBdWRpbygpKQogICAgICAgICAgICAgZGF0YS5tZWRpYUZsYWdzIHw9IFdlYkNvbnRleHRN ZW51RGF0YTo6TWVkaWFIYXNBdWRpbzsKKyAgICAgICAgaWYgKG1lZGlhRWxlbWVudC0+aGFzVmlk ZW8oKSkKKyAgICAgICAgICAgIGRhdGEubWVkaWFGbGFncyB8PSBXZWJDb250ZXh0TWVudURhdGE6 Ok1lZGlhSGFzVmlkZW87CisgICAgICAgIGlmIChtZWRpYUVsZW1lbnQtPmNvbnRyb2xzKCkpCisg ICAgICAgICAgICBkYXRhLm1lZGlhRmxhZ3MgfD0gV2ViQ29udGV4dE1lbnVEYXRhOjpNZWRpYUNv bnRyb2xzOwogICAgIH0KIAogICAgIGRhdGEuaXNJbWFnZUJsb2NrZWQgPQpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAppbmRleCAyMzU5M2NlLi44MTQyOWY4IDEwMDY0NAotLS0gYS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcApAQCAtMTQxNyw2ICsxNDE3LDkgQEAgdm9pZCBXZWJWaWV3SW1wbDo6 cGVyZm9ybU1lZGlhUGxheWVyQWN0aW9uKGNvbnN0IFdlYk1lZGlhUGxheWVyQWN0aW9uJiBhY3Rp b24sCiAgICAgY2FzZSBXZWJNZWRpYVBsYXllckFjdGlvbjo6TG9vcDoKICAgICAgICAgbWVkaWFF bGVtZW50LT5zZXRMb29wKGFjdGlvbi5lbmFibGUpOwogICAgICAgICBicmVhazsKKyAgICBjYXNl IFdlYk1lZGlhUGxheWVyQWN0aW9uOjpDb250cm9sczoKKyAgICAgICAgbWVkaWFFbGVtZW50LT5z ZXRDb250cm9scyhhY3Rpb24uZW5hYmxlKTsKKyAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoK ICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQo= 51378 2010-03-22 18:31:51 -0700 2010-03-23 12:11:58 -0700 Patch bug-36460-20100322183150.patch text/plain 3249 sergeyu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRlYWI2MzguLjRmNjA2NGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIyIEBACisyMDEwLTAzLTIyICBTZXJnZXkgVWxhbm92ICA8c2VyZ2V5dUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdl cyBuZWVkZWQgdG8gaW1wbGVtZW50IFNob3cvSGlkZSBDb250cm9scyBjb21tYW5kIGZvciA8dmlk ZW8+IGluCisgICAgICAgIGNocm9tZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM2NDYwCisKKyAgICAgICAgKiBwdWJsaWMvV2ViQ29udGV4dE1lbnVE YXRhLmg6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHRNZW51RGF0YTo6KTogQWRkZWQgTWVk aWFIYXNWaWRlbyBhbmQgTWVkaWFDb250cm9scy4KKyAgICAgICAgKiBwdWJsaWMvV2ViTWVkaWFQ bGF5ZXJBY3Rpb24uaDoKKyAgICAgICAgKFdlYktpdDo6V2ViTWVkaWFQbGF5ZXJBY3Rpb246Oik6 IEFkZGVkIENvbnRyb2xzIGFjdGlvbi4KKyAgICAgICAgKiBzcmMvQ29udGV4dE1lbnVDbGllbnRJ bXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0 b21NZW51RnJvbURlZmF1bHRJdGVtcyk6IEFkZGVkCisgICAgICAgIE1lZGlhSGFzVmlkZW8gYW5k IE1lZGlhQ29udHJvbHMuCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0ltcGw6OnBlcmZvcm1NZWRpYVBsYXllckFjdGlvbik6IENvbnRyb2xz IGFjdGlvbgorICAgICAgICBoYW5kbGVyLgorCiAyMDEwLTAzLTIyICBLZXZpbiBEZWNrZXIgIDxr ZGVja2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaCBi L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKaW5kZXggMzg0MjQw ZC4uMjUwMzZkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0 TWVudURhdGEuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0 YS5oCkBAIC04Myw2ICs4Myw4IEBAIHN0cnVjdCBXZWJDb250ZXh0TWVudURhdGEgewogICAgICAg ICBNZWRpYUxvb3AgPSAweDgsCiAgICAgICAgIE1lZGlhQ2FuU2F2ZSA9IDB4MTAsCiAgICAgICAg IE1lZGlhSGFzQXVkaW8gPSAweDIwLAorICAgICAgICBNZWRpYUhhc1ZpZGVvID0gMHg0MCwKKyAg ICAgICAgTWVkaWFDb250cm9scyA9IDB4ODAsCiAgICAgfTsKIAogICAgIC8vIEV4dHJhIGF0dHJp YnV0ZXMgZGVzY3JpYmluZyBtZWRpYSBlbGVtZW50cy4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24uaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24uaAppbmRleCAzYWVkZTI1Li4xOTI3MDRmIDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQWN0aW9uLmgKKysrIGIv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckFjdGlvbi5oCkBAIC0zOCw3ICsz OCw4IEBAIHN0cnVjdCBXZWJNZWRpYVBsYXllckFjdGlvbiB7CiAgICAgICAgIFVua25vd24sCiAg ICAgICAgIFBsYXksCiAgICAgICAgIE11dGUsCi0gICAgICAgIExvb3AKKyAgICAgICAgTG9vcCwK KyAgICAgICAgQ29udHJvbHMKICAgICB9OwogCiAgICAgVHlwZSB0eXBlOwpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvV2ViS2l0L2No cm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCmluZGV4IDA2YTI5ZmYuLjcwOGQx MTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBs LmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAK QEAgLTE4MSw2ICsxODEsMTAgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVD bGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKICAgICAgICAgICAgIGRh dGEubWVkaWFGbGFncyB8PSBXZWJDb250ZXh0TWVudURhdGE6Ok1lZGlhQ2FuU2F2ZTsKICAgICAg ICAgaWYgKG1lZGlhRWxlbWVudC0+aGFzQXVkaW8oKSkKICAgICAgICAgICAgIGRhdGEubWVkaWFG bGFncyB8PSBXZWJDb250ZXh0TWVudURhdGE6Ok1lZGlhSGFzQXVkaW87CisgICAgICAgIGlmICht ZWRpYUVsZW1lbnQtPmhhc1ZpZGVvKCkpCisgICAgICAgICAgICBkYXRhLm1lZGlhRmxhZ3MgfD0g V2ViQ29udGV4dE1lbnVEYXRhOjpNZWRpYUhhc1ZpZGVvOworICAgICAgICBpZiAobWVkaWFFbGVt ZW50LT5jb250cm9scygpKQorICAgICAgICAgICAgZGF0YS5tZWRpYUZsYWdzIHw9IFdlYkNvbnRl eHRNZW51RGF0YTo6TWVkaWFDb250cm9sczsKICAgICB9CiAKICAgICBkYXRhLmlzSW1hZ2VCbG9j a2VkID0KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggMjM1OTNjZS4uODE0Mjlm OCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE0MTcsNiArMTQxNyw5IEBA IHZvaWQgV2ViVmlld0ltcGw6OnBlcmZvcm1NZWRpYVBsYXllckFjdGlvbihjb25zdCBXZWJNZWRp YVBsYXllckFjdGlvbiYgYWN0aW9uLAogICAgIGNhc2UgV2ViTWVkaWFQbGF5ZXJBY3Rpb246Okxv b3A6CiAgICAgICAgIG1lZGlhRWxlbWVudC0+c2V0TG9vcChhY3Rpb24uZW5hYmxlKTsKICAgICAg ICAgYnJlYWs7CisgICAgY2FzZSBXZWJNZWRpYVBsYXllckFjdGlvbjo6Q29udHJvbHM6CisgICAg ICAgIG1lZGlhRWxlbWVudC0+c2V0Q29udHJvbHMoYWN0aW9uLmVuYWJsZSk7CisgICAgICAgIGJy ZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0K 51444 2010-03-23 12:12:01 -0700 2010-03-23 14:15:46 -0700 Patch bug-36460-20100323121200.patch text/plain 3349 sergeyu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRlYWI2MzguLjNmNTQyNTEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIzIEBACisyMDEwLTAzLTIyICBTZXJnZXkgVWxhbm92ICA8c2VyZ2V5dUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdl cyBuZWVkZWQgdG8gaW1wbGVtZW50IFNob3cvSGlkZSBDb250cm9scyBjb21tYW5kIGZvciA8dmlk ZW8+IGluCisgICAgICAgIGNocm9tZTogKDEpIGFkZGVkIENvbnRyb2xzIGFjdGlvbiBpbiBXZWJN ZWRpYVBsYXllckFjdGlvbiB0aGF0IHRvZ2dsZXMKKyAgICAgICAgY29udHJvbHMgZm9yIG1lZGlh IHBsYXllciwgKDIpIGFkZGVkIE1lZGlhSGFzVmlkZW8gaW4KKyAgICAgICAgV2ViQ29udGV4dE1l bnVEYXRhIHNvIHRoYXQgY29udHJvbHMgY2FuIGJlIG1hZGUgdG9nZ2xlYWJsZSBvbmx5IGZvcgor ICAgICAgICB2aWRlbyBwbGF5ZXIgYnV0IG5vdCBmb3IgYXVkaW8uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjQ2MAorCisgICAgICAgICogcHVibGlj L1dlYkNvbnRleHRNZW51RGF0YS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudURh dGE6Oik6CisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVyQWN0aW9uLmg6CisgICAgICAg IChXZWJLaXQ6OldlYk1lZGlhUGxheWVyQWN0aW9uOjopOgorICAgICAgICAqIHNyYy9Db250ZXh0 TWVudUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb250ZXh0TWVudUNsaWVudElt cGw6OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKToKKyAgICAgICAgKiBzcmMvV2ViVmll d0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6cGVyZm9ybU1lZGlhUGxh eWVyQWN0aW9uKToKKwogMjAxMC0wMy0yMiAgS2V2aW4gRGVja2VyICA8a2RlY2tlckBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4KZGlmZiAtLWdpdCBhL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmggYi9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCmluZGV4IDM4NDI0MGQuLjI1MDM2ZDQgMTAw NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKKysr IGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaApAQCAtODMsNiAr ODMsOCBAQCBzdHJ1Y3QgV2ViQ29udGV4dE1lbnVEYXRhIHsKICAgICAgICAgTWVkaWFMb29wID0g MHg4LAogICAgICAgICBNZWRpYUNhblNhdmUgPSAweDEwLAogICAgICAgICBNZWRpYUhhc0F1ZGlv ID0gMHgyMCwKKyAgICAgICAgTWVkaWFIYXNWaWRlbyA9IDB4NDAsCisgICAgICAgIE1lZGlhQ29u dHJvbHMgPSAweDgwLAogICAgIH07CiAKICAgICAvLyBFeHRyYSBhdHRyaWJ1dGVzIGRlc2NyaWJp bmcgbWVkaWEgZWxlbWVudHMuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl Yk1lZGlhUGxheWVyQWN0aW9uLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxh eWVyQWN0aW9uLmgKaW5kZXggM2FlZGUyNS4uMTkyNzA0ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckFjdGlvbi5oCisrKyBiL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24uaApAQCAtMzgsNyArMzgsOCBAQCBzdHJ1Y3Qg V2ViTWVkaWFQbGF5ZXJBY3Rpb24gewogICAgICAgICBVbmtub3duLAogICAgICAgICBQbGF5LAog ICAgICAgICBNdXRlLAotICAgICAgICBMb29wCisgICAgICAgIExvb3AsCisgICAgICAgIENvbnRy b2xzCiAgICAgfTsKIAogICAgIFR5cGUgdHlwZTsKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1 bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29u dGV4dE1lbnVDbGllbnRJbXBsLmNwcAppbmRleCAwNmEyOWZmLi43MDhkMTEzIDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKKysrIGIvV2Vi S2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCkBAIC0xODEsNiArMTgx LDEwIEBAIFBsYXRmb3JtTWVudURlc2NyaXB0aW9uIENvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0 Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRlbXMoCiAgICAgICAgICAgICBkYXRhLm1lZGlhRmxhZ3Mg fD0gV2ViQ29udGV4dE1lbnVEYXRhOjpNZWRpYUNhblNhdmU7CiAgICAgICAgIGlmIChtZWRpYUVs ZW1lbnQtPmhhc0F1ZGlvKCkpCiAgICAgICAgICAgICBkYXRhLm1lZGlhRmxhZ3MgfD0gV2ViQ29u dGV4dE1lbnVEYXRhOjpNZWRpYUhhc0F1ZGlvOworICAgICAgICBpZiAobWVkaWFFbGVtZW50LT5o YXNWaWRlbygpKQorICAgICAgICAgICAgZGF0YS5tZWRpYUZsYWdzIHw9IFdlYkNvbnRleHRNZW51 RGF0YTo6TWVkaWFIYXNWaWRlbzsKKyAgICAgICAgaWYgKG1lZGlhRWxlbWVudC0+Y29udHJvbHMo KSkKKyAgICAgICAgICAgIGRhdGEubWVkaWFGbGFncyB8PSBXZWJDb250ZXh0TWVudURhdGE6Ok1l ZGlhQ29udHJvbHM7CiAgICAgfQogCiAgICAgZGF0YS5pc0ltYWdlQmxvY2tlZCA9CmRpZmYgLS1n aXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDIzNTkzY2UuLjgxNDI5ZjggMTAwNjQ0Ci0tLSBh L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC0xNDE3LDYgKzE0MTcsOSBAQCB2b2lkIFdlYlZpZXdJ bXBsOjpwZXJmb3JtTWVkaWFQbGF5ZXJBY3Rpb24oY29uc3QgV2ViTWVkaWFQbGF5ZXJBY3Rpb24m IGFjdGlvbiwKICAgICBjYXNlIFdlYk1lZGlhUGxheWVyQWN0aW9uOjpMb29wOgogICAgICAgICBt ZWRpYUVsZW1lbnQtPnNldExvb3AoYWN0aW9uLmVuYWJsZSk7CiAgICAgICAgIGJyZWFrOworICAg IGNhc2UgV2ViTWVkaWFQbGF5ZXJBY3Rpb246OkNvbnRyb2xzOgorICAgICAgICBtZWRpYUVsZW1l bnQtPnNldENvbnRyb2xzKGFjdGlvbi5lbmFibGUpOworICAgICAgICBicmVhazsKICAgICBkZWZh dWx0OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9Cg==