36458 2010-03-22 12:34:32 -0700 DOMCoreException needs NoStaticTables modifier 2010-03-24 15:22:52 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P4 Normal --- 1 ericu ericu ap commit-queue dimich ian oldest_to_newest 202696 0 ericu 2010-03-22 12:34:32 -0700 Without it, its fields are inaccessible from all but one thread. If you've got workers and the main thread both throwing exceptions, you'll have issues--methods of the object are inaccessible, and you can at least crash a debug build by enumerating them. So far I've managed to see worker exceptions .toString returning [object DOMException] instead of the custom string; I'm not sure if anything worse can happen. It's a one-line fix; I'll have a patch up shortly. 202839 1 ap 2010-03-22 17:25:02 -0700 It's so wrong that we need to make anything with "DOM" in its name supported in workers. I guess the evil started with XMLHttpRequest and other non-DOM APIs using exceptions that didn't belong to them. 202845 2 51373 ericu 2010-03-22 17:37:03 -0700 Created attachment 51373 Patch 202853 3 ericu 2010-03-22 17:49:59 -0700 (In reply to comment #1) > It's so wrong that we need to make anything with "DOM" in its name supported in > workers. I guess the evil started with XMLHttpRequest and other non-DOM APIs > using exceptions that didn't belong to them. No argument here; I think we're stuck with the terminology now. 203177 4 dimich 2010-03-23 13:43:15 -0700 (In reply to comment #1) > It's so wrong that we need to make anything with "DOM" in its name supported in > workers. I guess the evil started with XMLHttpRequest and other non-DOM APIs > using exceptions that didn't belong to them. DOMString (as it is known in IDL files) probably was the first claw (or victim) of the evil. Alexey, do you suggest some renaming or a new class for the exception used in Workers? The patch otherwise looks ok to me. 203191 5 51373 ap 2010-03-23 13:55:25 -0700 Comment on attachment 51373 Patch Renaming may make sense - DOMCoreException is just an internal name for WebKit, and I suspect that it was chosen simply to avoid file name conflicts. On the other hand, it's still DOMException, so hiding that fact under a different name would be confusing. r=me with the understanding that this will be covered by regression tests soon. 203211 6 51373 commit-queue 2010-03-23 14:28:45 -0700 Comment on attachment 51373 Patch Rejecting patch 51373 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12532 test cases. fast/workers/worker-context-multi-port.html -> failed Exiting early after 1 failures. 8830 tests run. 153.25s total testing time 8829 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1206001 203281 7 dimich 2010-03-23 16:31:59 -0700 The test has this in its expected results: PASS posting a null port did throw: [object DOMException] Needs new expected results it seems. 203494 8 51525 ericu 2010-03-24 10:59:53 -0700 Created attachment 51525 Patch 203495 9 51525 ericu 2010-03-24 11:00:51 -0700 Comment on attachment 51525 Patch Fixed the test expectation not to rely on the old broken behavior. Sorry about that! 203648 10 51525 commit-queue 2010-03-24 15:22:47 -0700 Comment on attachment 51525 Patch Clearing flags on attachment: 51525 Committed r56462: <http://trac.webkit.org/changeset/56462> 203649 11 commit-queue 2010-03-24 15:22:52 -0700 All reviewed patches have been landed. Closing bug. 51373 2010-03-22 17:37:03 -0700 2010-03-24 10:59:50 -0700 Patch bug-36458-20100322173702.patch text/plain 1259 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjM3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMjIgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE T01Db3JlRXhjZXB0aW9uIG5lZWRzIE5vU3RhdGljVGFibGVzIG1vZGlmaWVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjQ1OAorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgYnV0IHRoaXMgc2hvd3MgdXAgaW4gdGVzdHMgb2YgRGF0YWJhc2UgYWNjZXNz ZXMgZnJvbSB0aGUKKyAgICAgICAgV29ya2VyIHRocmVhZCB0aGF0IEknbGwgYmUgY2hlY2tpbmcg aW4gc29vbi4gIFRoZSBzeW1wdG9tIGlzIHRoYXQKKyAgICAgICAgRE9NQ29yZUV4Y2VwdGlvbi50 b1N0cmluZygpIHJldHVybnMgW29iamVjdCBET01FeGNlcHRpb25dIGluc3RlYWQgb2YKKyAgICAg ICAgc29tZXRoaW5nIG1vcmUgaGVscGZ1bC4KKworICAgICAgICAqIGRvbS9ET01Db3JlRXhjZXB0 aW9uLmlkbDogIEFkZGVkIE5vU3RhdGljVGFibGVzLgorCiAyMDEwLTAzLTIyICBEYXJpbiBGaXNo ZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkgRWlk c29uLgpJbmRleDogV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5pZGwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5pZGwJKHJldmlzaW9uIDU2MzYwKQorKysg V2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI4LDcg KzI4LDkgQEAKIAogbW9kdWxlIGNvcmUgewogCi0gICAgaW50ZXJmYWNlIERPTUNvcmVFeGNlcHRp b24geworICAgIGludGVyZmFjZSBbCisgICAgICAgIE5vU3RhdGljVGFibGVzCisgICAgXSBET01D b3JlRXhjZXB0aW9uIHsKIAogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQgc2hv cnQgICBjb2RlOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nICAgICAgICBu YW1lOwo= 51525 2010-03-24 10:59:53 -0700 2010-03-24 15:22:47 -0700 Patch bug-36458-20100324105951.patch text/plain 2944 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjM3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMjQgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE T01Db3JlRXhjZXB0aW9uIG5lZWRzIE5vU3RhdGljVGFibGVzIG1vZGlmaWVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjQ1OAorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgYnV0IHRoaXMgc2hvd3MgdXAgaW4gdGVzdHMgb2YgRGF0YWJhc2UgYWNjZXNz ZXMgZnJvbSB0aGUKKyAgICAgICAgV29ya2VyIHRocmVhZCB0aGF0IEknbGwgYmUgY2hlY2tpbmcg aW4gc29vbi4gIFRoZSBzeW1wdG9tIGlzIHRoYXQKKyAgICAgICAgRE9NQ29yZUV4Y2VwdGlvbi50 b1N0cmluZygpIHJldHVybnMgW29iamVjdCBET01FeGNlcHRpb25dIGluc3RlYWQgb2YKKyAgICAg ICAgc29tZXRoaW5nIG1vcmUgaGVscGZ1bC4KKworICAgICAgICAqIGRvbS9ET01Db3JlRXhjZXB0 aW9uLmlkbDogIEFkZGVkIE5vU3RhdGljVGFibGVzLgorCiAyMDEwLTAzLTIyICBEYXJpbiBGaXNo ZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkgRWlk c29uLgpJbmRleDogV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5pZGwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5pZGwJKHJldmlzaW9uIDU2MzYwKQorKysg V2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI4LDcg KzI4LDkgQEAKIAogbW9kdWxlIGNvcmUgewogCi0gICAgaW50ZXJmYWNlIERPTUNvcmVFeGNlcHRp b24geworICAgIGludGVyZmFjZSBbCisgICAgICAgIE5vU3RhdGljVGFibGVzCisgICAgXSBET01D b3JlRXhjZXB0aW9uIHsKIAogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQgc2hv cnQgICBjb2RlOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nICAgICAgICBu YW1lOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTYzNjApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0yNCAgRXJpYyBVaHJoYW5l IDxlcmljdUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRE9NQ29yZUV4Y2VwdGlvbiBuZWVkcyBO b1N0YXRpY1RhYmxlcyBtb2RpZmllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzY0NTgKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1dCB0aGlzIHNo b3dzIHVwIGluIHRlc3RzIG9mIERhdGFiYXNlIGFjY2Vzc2VzIGZyb20gdGhlCisgICAgICAgIFdv cmtlciB0aHJlYWQgdGhhdCBJJ2xsIGJlIGNoZWNraW5nIGluIHNvb24uICBUaGUgc3ltcHRvbSBp cyB0aGF0CisgICAgICAgIERPTUNvcmVFeGNlcHRpb24udG9TdHJpbmcoKSByZXR1cm5zIFtvYmpl Y3QgRE9NRXhjZXB0aW9uXSBpbnN0ZWFkIG9mCisgICAgICAgIHNvbWV0aGluZyBtb3JlIGhlbHBm dWwuCisKKyAgICAgICAgKiBmYXN0L3dvcmtlcnMvd29ya2VyLWNvbnRleHQtbXVsdGktcG9ydC1l eHBlY3RlZC50eHQ6ICBBZGp1c3RlZCBleHBlY3RhdGlvbiB0aGF0IHdhcyBkZXBlbmRpbmcgb24g dGhlIGJyb2tlbiBiZWhhdmlvci4KKwogMjAxMC0wMy0yMiAgS2VubmV0aCBSb2hkZSBDaHJpc3Rp YW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItY29udGV4dC1tdWx0aS1wb3J0LWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNv bnRleHQtbXVsdGktcG9ydC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU2MzYwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1jb250ZXh0LW11bHRpLXBvcnQtZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC02LDcgKzYsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUg YSBzZXJpZXMgb2YgIlBBCiBQQVNTIGV2ZW50LnBvcnRzIGlzIG51bGwgd2hlbiBubyBwb3J0IHNl bnQKIFBBU1MgZXZlbnQucG9ydHMgaXMgbnVsbCB3aGVuIGVtcHR5IGFycmF5IHNlbnQKIFBBU1Mg ZXZlbnQucG9ydHMgY29udGFpbnMgdHdvIHBvcnRzIHdoZW4gdHdvIHBvcnRzIHNlbnQKLVBBU1Mg cG9zdGluZyBhIG51bGwgcG9ydCBkaWQgdGhyb3c6IFtvYmplY3QgRE9NRXhjZXB0aW9uXQorUEFT UyBwb3N0aW5nIGEgbnVsbCBwb3J0IGRpZCB0aHJvdzogRXJyb3I6IElOVkFMSURfU1RBVEVfRVJS OiBET00gRXhjZXB0aW9uIDExCiBQQVNTIHBvc3RpbmcgYSBub24tcG9ydCBkaWQgdGhyb3c6IFR5 cGVFcnJvcjogVHlwZSBlcnJvcgogUEFTUyBldmVudC5wb3J0cyBjb250YWlucyB0d28gcG9ydHMg d2hlbiB0d28gcG9ydHMgcmUtc2VudCBhZnRlciBlcnJvcgogUEFTUyBwb3N0aW5nIGEgbm9uLWFy cmF5IGRpZCB0aHJvdzogVHlwZUVycm9yOiBUeXBlIGVycm9yCg==