36455 2010-03-22 11:26:19 -0700 Make WebKit more resistant against plug-in crashes 2010-03-22 11:46:18 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P1 Normal --- 1 ap ap oldest_to_newest 202634 0 ap 2010-03-22 11:26:19 -0700 WebKit isn't always prepared for NetscapePluginInstanceProxy getting destroyed as a result of plugin host crashing. 202636 1 51314 ap 2010-03-22 11:33:29 -0700 Created attachment 51314 proposed patch 202649 2 51314 sullivan 2010-03-22 11:41:46 -0700 Comment on attachment 51314 proposed patch Robustness == good. 202657 3 ap 2010-03-22 11:46:18 -0700 Committed <http://trac.webkit.org/changeset/56351>. 51314 2010-03-22 11:33:29 -0700 2010-03-22 11:41:45 -0700 proposed patch CheckForCrashes.txt text/plain 4645 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NjM0NykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDMtMjIgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDU1Cisg ICAgICAgIE1ha2UgV2ViS2l0IG1vcmUgcmVzaXN0YW50IGFnYWluc3QgcGx1Zy1pbiBjcmFzaGVz CisKKyAgICAgICAgTm8gdGVzdHMsIGJlY2F1c2UgY3Jhc2hpbmcgb24gYnVpbGQgYm90cyBpc24n dCBnb29kLCBldmVuIGlmIGl0J3Mgb25seSBoZWxwZXIgcHJvY2Vzc2VzCisgICAgICAgIHRoYXQg Y3Jhc2guCisKKyAgICAgICAgKiBQbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNl UHJveHkuaDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5Ojp3 YWl0Rm9yUmVwbHkpOiBQcm90ZWN0ICJ0aGlzIiwgYmVjYXVzZSB0aGlzIGZ1bmN0aW9uCisgICAg ICAgIG5lZWRzIGl0IGFmdGVyIHdhaXRpbmcgZm9yIHJlcGx5LiBTb21lIGNhbGxlcnMgdXNlZCB0 byBkbyB0aGlzLCBidXQgbm90IGFsbCwgYW5kIHdlIHJlYWxseQorICAgICAgICBzaG91bGRuJ3Qg ZGVwZW5kIG9uIGNhbGxlcnMgaGVyZS4KKworICAgICAgICAqIFBsdWdpbnMvSG9zdGVkL05ldHNj YXBlUGx1Z2luSW5zdGFuY2VQcm94eS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVn aW5JbnN0YW5jZVByb3h5Ojp3aGVlbEV2ZW50KTogRG9uJ3QgcHJvdGVjdCB0aGUgcGx1Zy1pbiBp bnN0YW5jZSBwcm94eSwKKyAgICAgICAgYmVjYXVzZSB0aGlzIGZ1bmN0aW9uIGRvZXNuJ3QgdXNl IGl0IGFmdGVyIHdhaXRpbmcgZm9yIHJlcGx5LgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBs dWdpbkluc3RhbmNlUHJveHk6OmNyZWF0ZUJpbmRpbmdzSW5zdGFuY2UpOiBEaXR0by4KKworICAg ICAgICAqIFBsdWdpbnMvSG9zdGVkL1Byb3h5SW5zdGFuY2UubW06IChXZWJLaXQ6OlByb3h5SW5z dGFuY2U6Omludm9rZSk6IEFkZGVkIGFuIG1faW5zdGFuY2VQcm94eQorICAgICAgICBudWxsIGNo ZWNrIGZvciBhbm90aGVyIGNvZGUgcGF0aC4KKwogMjAxMC0wMy0yMiAgS2V2aW4gRGVja2VyICA8 a2RlY2tlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4K SW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVBy b3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBs dWdpbkluc3RhbmNlUHJveHkuaAkocmV2aXNpb24gNTYzMzcpCisrKyBXZWJLaXQvbWFjL1BsdWdp bnMvSG9zdGVkL05ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBA IC0yNTcsOCArMjU3LDkgQEAgcHVibGljOgogICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBUPgogICAg IHN0ZDo6YXV0b19wdHI8VD4gd2FpdEZvclJlcGx5KHVpbnQzMl90IHJlcXVlc3RJRCkKICAgICB7 CisgICAgICAgIFJlZlB0cjxOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHk+IHByb3RlY3QodGhp cyk7IC8vIFBsdWctaW4gaG9zdCBtYXkgY3Jhc2ggd2hpbGUgd2UgYXJlIHdhaXRpbmcgZm9yIHJl cGx5LCByZWxlYXNpbmcgYWxsIGluc3RhbmNlcyB0byB0aGUgaW5zdGFuY2UgcHJveHkuCisKICAg ICAgICAgd2lsbENhbGxQbHVnaW5GdW5jdGlvbigpOwotICAgICAgICAKICAgICAgICAgbV93YWl0 aW5nRm9yUmVwbHkgPSB0cnVlOwogCiAgICAgICAgIFJlcGx5KiByZXBseSA9IHByb2Nlc3NSZXF1 ZXN0c0FuZFdhaXRGb3JSZXBseShyZXF1ZXN0SUQpOwpJbmRleDogV2ViS2l0L21hYy9QbHVnaW5z L0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHkubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHkubW0JKHJl dmlzaW9uIDU2MzM3KQorKysgV2ViS2l0L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdp bkluc3RhbmNlUHJveHkubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ2Myw5ICs0NjMsNiBAQCBib29s IE5ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94eTo6d2hlZWxFCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcGx1Z2luUG9pbnQueCwgcGx1Z2luUG9pbnQueSwgW2V2ZW50IGJ1dHRv bk51bWJlcl0sIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtldmVudCBkZWx0 YVhdLCBbZXZlbnQgZGVsdGFZXSwgW2V2ZW50IGRlbHRhWl0pOwogICAgIAotICAgIC8vIFByb3Rl Y3Qgb3Vyc2VsdmVzIGluIGNhc2Ugd2FpdGluZyBmb3IgdGhlIHJlcGx5IGNhdXNlcyB1cyB0byBi ZSBkZWxldGVkLgotICAgIFJlZlB0cjxOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHk+IHByb3Rl Y3QodGhpcyk7Ci0KICAgICBhdXRvX3B0cjxOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHk6OkJv b2xlYW5SZXBseT4gcmVwbHkgPSB3YWl0Rm9yUmVwbHk8TmV0c2NhcGVQbHVnaW5JbnN0YW5jZVBy b3h5OjpCb29sZWFuUmVwbHk+KHJlcXVlc3RJRCk7CiAgICAgaWYgKCFyZXBseS5nZXQoKSB8fCAh cmVwbHktPm1fcmVzdWx0KQogICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0xMzk5LDEwICsxMzk2 LDYgQEAgUGFzc1JlZlB0cjxJbnN0YW5jZT4gTmV0c2NhcGVQbHVnaW5JbnN0YQogICAgIGlmIChf V0tQSEdldFNjcmlwdGFibGVOUE9iamVjdChtX3BsdWdpbkhvc3RQcm94eS0+cG9ydCgpLCBtX3Bs dWdpbklELCByZXF1ZXN0SUQpICE9IEtFUk5fU1VDQ0VTUykKICAgICAgICAgcmV0dXJuIDA7CiAK LSAgICAvLyBJZiB0aGUgcGx1Zy1pbiBob3N0IGNyYXNoZXMgd2hpbGUgd2UncmUgd2FpdGluZyBm b3IgYSByZXBseSwgdGhlIGxhc3QgcmVmZXJlbmNlIHRvIHRoZSBpbnN0YW5jZSBwcm94eQotICAg IC8vIHdpbGwgZ28gYXdheS4gUHJldmVudCB0aGlzIGJ5IHByb3RlY3RpbmcgaXQgaGVyZS4KLSAg ICBSZWZQdHI8TmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5PiBwcm90ZWN0KHRoaXMpOwotICAg IAogICAgIGF1dG9fcHRyPEdldFNjcmlwdGFibGVOUE9iamVjdFJlcGx5PiByZXBseSA9IHdhaXRG b3JSZXBseTxHZXRTY3JpcHRhYmxlTlBPYmplY3RSZXBseT4ocmVxdWVzdElEKTsKICAgICBpZiAo IXJlcGx5LmdldCgpKQogICAgICAgICByZXR1cm4gMDsKQEAgLTE0MTAsNiArMTQwMyw3IEBAIFBh c3NSZWZQdHI8SW5zdGFuY2U+IE5ldHNjYXBlUGx1Z2luSW5zdGEKICAgICBpZiAoIXJlcGx5LT5t X29iamVjdElEKQogICAgICAgICByZXR1cm4gMDsKIAorICAgIC8vIFNpbmNlIHRoZSByZXBseSB3 YXMgbm9uLW51bGwsICJ0aGlzIiBpcyBzdGlsbCBhIHZhbGlkIHBvaW50ZXIuCiAgICAgcmV0dXJu IFByb3h5SW5zdGFuY2U6OmNyZWF0ZShyb290T2JqZWN0LCB0aGlzLCByZXBseS0+bV9vYmplY3RJ RCk7CiB9CiAKSW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9Ib3N0ZWQvUHJveHlJbnN0YW5jZS5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL1BsdWdpbnMvSG9zdGVkL1Byb3h5SW5zdGFuY2Uu bW0JKHJldmlzaW9uIDU2MzM3KQorKysgV2ViS2l0L21hYy9QbHVnaW5zL0hvc3RlZC9Qcm94eUlu c3RhbmNlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsOCArMTU1LDEwIEBAIEpTVmFsdWUgUHJv eHlJbnN0YW5jZTo6aW52b2tlKEpTQzo6RXhlY1MKIAogICAgIGlmIChfV0tQSE5QT2JqZWN0SW52 b2tlKG1faW5zdGFuY2VQcm94eS0+aG9zdFByb3h5KCktPnBvcnQoKSwgbV9pbnN0YW5jZVByb3h5 LT5wbHVnaW5JRCgpLCByZXF1ZXN0SUQsIG1fb2JqZWN0SUQsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdHlwZSwgaWRlbnRpZmllciwgKGNoYXIqKVthcmd1bWVudHMuZ2V0KCkgYnl0ZXNd LCBbYXJndW1lbnRzLmdldCgpIGxlbmd0aF0pICE9IEtFUk5fU1VDQ0VTUykgewotICAgICAgICBm b3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYXJncy5zaXplKCk7IGkrKykKLSAgICAgICAgICAgIG1f aW5zdGFuY2VQcm94eS0+cmVsZWFzZUxvY2FsT2JqZWN0KGFyZ3MuYXQoaSkpOworICAgICAgICBp ZiAobV9pbnN0YW5jZVByb3h5KSB7CisgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgYXJncy5zaXplKCk7IGkrKykKKyAgICAgICAgICAgICAgICBtX2luc3RhbmNlUHJveHktPnJl bGVhc2VMb2NhbE9iamVjdChhcmdzLmF0KGkpKTsKKyAgICAgICAgfQogICAgICAgICByZXR1cm4g anNVbmRlZmluZWQoKTsKICAgICB9CiAgICAgCg==