36445 2010-03-22 08:54:09 -0700 Web Inspector: fake workers fail if created before document is loaded 2010-03-22 19:11:14 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 202517 0 caseq 2010-03-22 08:54:09 -0700 Fake workers implementation that is used when Debug checkbox on Workers sidebar is ticked currently use iframes to simulate workers. The implementation attempts to append iframe to document right at the time of fake worker creation, so it fails if document is not yet loaded. Fake workers should detect that no document.body is present yet and defer iframe creation. 202543 1 51294 caseq 2010-03-22 09:28:37 -0700 Created attachment 51294 Defer attaching fake workers iframe to document until after document is loaded 202892 2 51294 commit-queue 2010-03-22 19:11:09 -0700 Comment on attachment 51294 Defer attaching fake workers iframe to document until after document is loaded Clearing flags on attachment: 51294 Committed r56374: <http://trac.webkit.org/changeset/56374> 202893 3 commit-queue 2010-03-22 19:11:14 -0700 All reviewed patches have been landed. Closing bug. 51294 2010-03-22 09:28:37 -0700 2010-03-22 19:11:09 -0700 Defer attaching fake workers iframe to document until after document is loaded workers-before-load.patch text/plain 3095 caseq SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjMzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDMtMjIgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCisgICAg ICAgIFN1cHBvcnQgY3JlYXRpb24gb2YgZmFrZSB3b3JrZXJzIGJlZm9yZSBkb2N1bWVudCBpcyBs b2FkZWQgYnkgZGVmZXJyaW5nCisgICAgICAgIGF0dGFjaGluZyBvZiBmYWtlIHdvcmtlcnMgaWZy YW1lIHVudGlsIGRvY3VtZW50IGlzIGxvYWRlZCBhbmQgYnVmZmVyaW5nIGFsbAorICAgICAgICBt ZXNzYWdlcyBhZGRyZXNzZWQgdG8gd29ya2VyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NDUKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvSW5qZWN0ZWRGYWtlV29ya2VyLmpzOgorICAgICAgICAoSW5qZWN0ZWRGYWtlV29ya2VyLkZh a2VXb3JrZXIucHJvdG90eXBlLnBvc3RNZXNzYWdlKToKKyAgICAgICAgKEluamVjdGVkRmFrZVdv cmtlci5GYWtlV29ya2VyLnByb3RvdHlwZS5fYnVpbGRXb3JrZXIpOgorICAgICAgICAoSW5qZWN0 ZWRGYWtlV29ya2VyLkZha2VXb3JrZXIucHJvdG90eXBlLl9hdHRhY2hXb3JrZXJGcmFtZVRvRG9j dW1lbnQpOgorICAgICAgICAoSW5qZWN0ZWRGYWtlV29ya2VyLkZha2VXb3JrZXIucHJvdG90eXBl Ll9vbldvcmtlckZyYW1lTG9hZGVkKToKKwogMjAxMC0wMy0yMiAgWXVyeSBTZW1pa2hhdHNreSAg PHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFu LgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkRmFrZVdvcmtlci5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRGYWtl V29ya2VyLmpzCShyZXZpc2lvbiA1NjMyNSkKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9JbmplY3RlZEZha2VXb3JrZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTU5LDYgKzU5LDEwIEBA IEZha2VXb3JrZXIucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX2ZyYW1l ICE9IG51bGwpCiAgICAgICAgICAgICB0aGlzLl9kaXNwYXRjaE1lc3NhZ2UodGhpcy5fZnJhbWUs IGJpbmQodGhpcy5fb25tZXNzYWdlV3JhcHBlciwgdGhpcyksIG1zZyk7CisgICAgICAgIGVsc2Ug aWYgKHRoaXMuX3BlbmRpbmdNZXNzYWdlcykKKyAgICAgICAgICAgIHRoaXMuX3BlbmRpbmdNZXNz YWdlcy5wdXNoKG1zZykKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgdGhpcy5fcGVuZGluZ01l c3NhZ2VzID0gWyBtc2cgXTsKICAgICB9LAogCiAgICAgdGVybWluYXRlOiBmdW5jdGlvbigpCkBA IC0xMTYsMTggKzEyMCwzNSBAQCBGYWtlV29ya2VyLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFy IGNvZGUgPSB0aGlzLl9sb2FkU2NyaXB0KHVybC51cmwpOwogICAgICAgICB2YXIgaWZyYW1lRWxl bWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlmcmFtZSIpOwogICAgICAgICBpZnJhbWVF bGVtZW50LnN0eWxlLmRpc3BsYXkgPSAibm9uZSI7Ci0gICAgICAgIGRvY3VtZW50LmJvZHkuYXBw ZW5kQ2hpbGQoaWZyYW1lRWxlbWVudCk7Ci0KLSAgICAgICAgdmFyIGZyYW1lID0gd2luZG93LmZy YW1lc1t3aW5kb3cuZnJhbWVzLmxlbmd0aCAtIDFdOwogCiAgICAgICAgIHRoaXMuX2RvY3VtZW50 ID0gZG9jdW1lbnQ7Ci0gICAgICAgIHRoaXMuX2ZyYW1lID0gZnJhbWU7CisgICAgICAgIGlmcmFt ZUVsZW1lbnQub25sb2FkID0gYmluZCh0aGlzLl9vbldvcmtlckZyYW1lTG9hZGVkLCB0aGlzLCBp ZnJhbWVFbGVtZW50LCB1cmwsIGNvZGUpOworCisgICAgICAgIGlmIChkb2N1bWVudC5ib2R5KQor ICAgICAgICAgICAgdGhpcy5fYXR0YWNoV29ya2VyRnJhbWVUb0RvY3VtZW50KGlmcmFtZUVsZW1l bnQsIHVybCwgY29kZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHdpbmRvdy5hZGRFdmVu dExpc3RlbmVyKCJsb2FkIiwgYmluZCh0aGlzLl9hdHRhY2hXb3JrZXJGcmFtZVRvRG9jdW1lbnQs IHRoaXMsIGlmcmFtZUVsZW1lbnQpLCBmYWxzZSk7CisgICAgfSwKKworICAgIF9hdHRhY2hXb3Jr ZXJGcmFtZVRvRG9jdW1lbnQ6IGZ1bmN0aW9uKGlmcmFtZUVsZW1lbnQpCisgICAgeworICAgICAg ICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcmFtZUVsZW1lbnQpOworICAgIH0sCiAKKyAg ICBfb25Xb3JrZXJGcmFtZUxvYWRlZDogZnVuY3Rpb24oaWZyYW1lRWxlbWVudCwgdXJsLCBjb2Rl KQorICAgIHsKKyAgICAgICAgdmFyIGZyYW1lID0gaWZyYW1lRWxlbWVudC5jb250ZW50V2luZG93 OworICAgICAgICB0aGlzLl9mcmFtZSA9IGZyYW1lOwogICAgICAgICB0aGlzLl9zZXR1cFdvcmtl ckNvbnRleHQoZnJhbWUsIHVybCk7CiAKICAgICAgICAgdmFyIGZyYW1lQ29udGVudHMgPSAnKGZ1 bmN0aW9uKGxvY2F0aW9uLCB3aW5kb3cpIHsgJyArIGNvZGUgKyAnfSkoX19kZXZ0b29scy5sb2Nh dGlvbiwgdW5kZWZpbmVkKTtcbicgKyAnLy9AIHNvdXJjZVVSTD0nICsgdXJsLnVybDsKIAogICAg ICAgICBmcmFtZS5ldmFsKGZyYW1lQ29udGVudHMpOworICAgICAgICBpZiAodGhpcy5fcGVuZGlu Z01lc3NhZ2VzKSB7CisgICAgICAgICAgICBmb3IgKHZhciBtc2cgaW4gdGhpcy5fcGVuZGluZ01l c3NhZ2VzKQorICAgICAgICAgICAgICAgIHRoaXMucG9zdE1lc3NhZ2UodGhpcy5fcGVuZGluZ01l c3NhZ2VzW21zZ10pOworICAgICAgICAgICAgZGVsZXRlIHRoaXMuX3BlbmRpbmdNZXNzYWdlczsK KyAgICAgICAgfQogICAgIH0sCiAKICAgICBfc2V0dXBXb3JrZXJDb250ZXh0OiBmdW5jdGlvbih3 b3JrZXJGcmFtZSwgdXJsKQo=