36443 2010-03-22 08:21:18 -0700 [chromium] Renderer crashes when navigating to a reference fragment in a frame that has no current HistoryItem. 2010-03-22 11:17:52 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Linux RESOLVED FIXED http://www.fandango.com/hottubtimemachine_126387/movietimes?date= P2 Normal --- 1 davemoore fishd fishd oldest_to_newest 202503 0 davemoore 2010-03-22 08:21:18 -0700 1) Go to this page: http://www.fandango.com/hottubtimemachine_126387/movietimes?date= in tip of tree chromium. 2) Place cursor in zip code text field. Sad tab appears I ran the linux build and got the stack trace below. It looks like the problem is in the second frame at FrameLoaderClientImpl.cpp:591, where the return of currentItem() is NULL. This appears to be recent code, introduced into webkit here: https://bugs.webkit.org/attachment.cgi?id=50758&action=prettypatch #0 0x09257db6 in WTF::RefPtr<WebCore::SerializedScriptValue>::get (this=0x74) at third_party/WebKit/JavaScriptCore/wtf/RefPtr.h:58 #1 0x09257dce in WebCore::HistoryItem::stateObject (this=0x0) at third_party/WebKit/WebCore/history/HistoryItem.h:137 #2 0x09c1c31b in WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage (this=0xe82250c) at third_party/WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp:591 #3 0x0925121b in WebCore::FrameLoader::loadInSameDocument(WebCore::KURL const&, WebCore::SerializedScriptValue*, bool) () #4 0x092514b3 in WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy(WebCore::ResourceRequest const&, bool) () #5 0x092514e6 in WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) () #6 0x09263d9a in WebCore::PolicyCallback::call(bool) () #7 0x092648aa in WebCore::PolicyChecker::continueAfterNavigationPolicy(WebCore::PolicyAction) () #8 0x09c1b875 in WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction (this=0xe82250c, function=0x92646d6 <WebCore::PolicyChecker::continueAfterNavigationPolicy(WebCore::PolicyAction)>, action=..., request=..., formState=...) at third_party/WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp:975 #9 0x09264dd4 in WebCore::PolicyChecker::checkNavigationPolicy(WebCore::Resourc---Type <return> to continue, or q <return> to quit--- eRequest const&, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, void (*)(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool), void*) () #10 0x0925556a in WebCore::FrameLoader::loadURL(WebCore::KURL const&, WebCore::String const&, WebCore::String const&, bool, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::FormState>) () #11 0x09255afd in WebCore::FrameLoader::loadFrameRequest(WebCore::FrameLoadRequest const&, bool, bool, WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::FormState>, WebCore::ReferrerPolicy) () #12 0x09255ec9 in WebCore::FrameLoader::urlSelected(WebCore::ResourceRequest const&, WebCore::String const&, WTF::PassRefPtr<WebCore::Event>, bool, bool, bool, WebCore::ReferrerPolicy) () #13 0x092560b6 in WebCore::FrameLoader::changeLocation(WebCore::KURL const&, WebCore::String const&, bool, bool, bool, bool) () #14 0x09268dbf in WebCore::RedirectScheduler::scheduleLocationChange(WebCore::String const&, WebCore::String const&, bool, bool, bool) () #15 0x094e98cf in WebCore::navigateIfAllowed(WebCore::Frame*, WebCore::KURL const&, bool, bool) () #16 0x09dd3925 in WebCore::V8Location::replaceCallback(v8::Arguments const&) () #17 0x08e8d19f in HandleApiCallHelper<false> (args=...) at v8/src/builtins.cc:904 #18 0x08e8d24a in Builtin_Impl_HandleApiCall (args=...) at v8/src/builtins.cc:921 ---Type <return> to continue, or q <return> to quit--- #19 0x08e8d26f in Builtin_HandleApiCall (args=...) at v8/src/builtins.cc:920 #20 0xebc7238e in ?? () #21 0x00000003 in ?? () 202510 1 fishd 2010-03-22 08:37:29 -0700 Yeah, we've received a lot of reports of this crash: http://code.google.com/p/chromium/issues/detail?id=38658 202535 2 51293 fishd 2010-03-22 09:21:36 -0700 Created attachment 51293 v1 patch 202548 3 51295 fishd 2010-03-22 09:31:20 -0700 Created attachment 51295 v2 patch (minus svn:eol-style on layout tests) 202622 4 51295 japhet 2010-03-22 11:10:00 -0700 Comment on attachment 51295 v2 patch (minus svn:eol-style on layout tests) LGTM Re: the FIXME: Do we have any idea how currentItem is ending up null? I'm assuming that it is a bug that script shenanigans like the ones in this layout test can cause it to become null? 202623 5 fishd 2010-03-22 11:12:28 -0700 (In reply to comment #4) > (From update of attachment 51295 [details]) > LGTM > > Re: the FIXME: Do we have any idea how currentItem is ending up null? I'm > assuming that it is a bug that script shenanigans like the ones in this layout > test can cause it to become null? Yes, I plan on fixing cases that cause this to be null, but that will be done as a separate patch. First things first: fix the crash :-) 202627 6 fishd 2010-03-22 11:17:52 -0700 Landed as http://trac.webkit.org/changeset/56346 51293 2010-03-22 09:21:36 -0700 2010-03-22 09:31:20 -0700 v1 patch nocrash_1.txt text/plain 4150 fishd SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gNTYzMzUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0yMiAgRGFyaW4gRmlzaGVyICA8 ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVuZGVyZXIgY3Jhc2hlcyB3aGVuIG5hdmlnYXRpbmcg dG8gYSByZWZlcmVuY2UgZnJhZ21lbnQgaW4KKyAgICAgICAgYSBmcmFtZSB0aGF0IGhhcyBubyBj dXJyZW50IEhpc3RvcnlJdGVtLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNjQ0MworCisgICAgICAgICogZmFzdC9sb2FkZXIvY3Jhc2gtcmVwbGFj aW5nLWxvY2F0aW9uLWJlZm9yZS1sb2FkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9sb2FkZXIvY3Jhc2gtcmVwbGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1sb2FkLmh0bWw6IEFk ZGVkLgorCiAyMDEwLTAzLTIyICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2xvYWRlci9jcmFzaC1yZXBsYWNpbmctbG9jYXRpb24tYmVmb3JlLWxvYWQtZXhwZWN0 ZWQudHh0DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09DQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvY3Jhc2gtcmVw bGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1sb2FkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2NyYXNoLXJlcGxhY2luZy1sb2NhdGlvbi1iZWZvcmUt bG9hZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1BBU1MgCg0KUHJv cGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHNcZmFzdFxsb2FkZXJcY3Jhc2gtcmVwbGFjaW5n LWxvY2F0aW9uLWJlZm9yZS1sb2FkLWV4cGVjdGVkLnR4dA0KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KQWRkZWQ6IHN2 bjplb2wtc3R5bGUNCiAgICsgbmF0aXZlDQoNCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRl ci9jcmFzaC1yZXBsYWNpbmctbG9jYXRpb24tYmVmb3JlLWxvYWQuaHRtbA0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K LS0tIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2NyYXNoLXJlcGxhY2luZy1sb2NhdGlvbi1iZWZv cmUtbG9hZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvY3Jh c2gtcmVwbGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1sb2FkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMjUgQEAKKzxzY3JpcHQ+CitpZiAocGFyZW50ID09IHdpbmRvdykgeworICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAg fQorICBmdW5jdGlvbiByZXBsYWNlSGFzaChmcmFnKSB7CisgICAgZnJhbWVzWzBdLmxvY2F0aW9u LnJlcGxhY2UoJyMnICsgZnJhZyk7CisgIH0KKyAgb25sb2FkID0gZnVuY3Rpb24oKSB7CisgICAg dmFyIGYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpZnJhbWUiKTsKKyAgICBmLnNyYyA9IGxv Y2F0aW9uOworICAgIGYub25sb2FkID0gZnVuY3Rpb24oKSB7CisgICAgICBkZWxldGUgZi5vbmxv YWQ7CisgICAgICByZXBsYWNlSGFzaCgnYmFyJyk7CisgICAgICBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7 CisgICAgfQorICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZik7CisgICAgcmVwbGFjZUhh c2goJ2ZvbycpOworICB9Cit9Cis8L3NjcmlwdD4KKzwhLS0gSWYgd2UgZG8gbm90IGNyYXNoLCB0 aGVuIHRoaXMgdGVzdCB3YXMgc3VjY2Vzc2Z1bC4gLS0+Cis8Ym9keT5QQVNTPC9ib2R5PgoNClBy b3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzXGZhc3RcbG9hZGVyXGNyYXNoLXJlcGxhY2lu Zy1sb2NhdGlvbi1iZWZvcmUtbG9hZC5odG1sDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQpBZGRlZDogc3ZuOmVvbC1z dHlsZQ0KICAgKyBMRg0KDQpJbmRleDogV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZw0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2MzM1KQorKysg V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEwLTAzLTIyICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBSZW5k ZXJlciBjcmFzaGVzIHdoZW4gbmF2aWdhdGluZyB0byBhIHJlZmVyZW5jZSBmcmFnbWVudCBpbgor ICAgICAgICBhIGZyYW1lIHRoYXQgaGFzIG5vIGN1cnJlbnQgSGlzdG9yeUl0ZW0uCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDQzCisKKyAgICAg ICAgVGVzdDogZmFzdC9sb2FkZXIvY3Jhc2gtcmVwbGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1sb2Fk Lmh0bWwKKworICAgICAgICAqIHNyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwOgorICAgICAg ICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpc3BhdGNoRGlkTmF2aWdhdGVXaXRo aW5QYWdlKToKKwogMjAxMC0wMy0yMiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA1 NjMzNSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTg3LDggKzU4Nyw5IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJ bXBsOjpkaXNwYXRjaERpZE4KICAgICAgICAgd2ViVmlldy0+Y2xpZW50KCktPmRpZFN0YXJ0TG9h ZGluZygpOwogCiAgICAgLy8gV2UgbmVlZCB0byBjbGFzc2lmeSBzb21lIGhhc2ggY2hhbmdlcyBh cyBjbGllbnQgcmVkaXJlY3RzLgotICAgIGJvb2wgaXNIYXNoQ2hhbmdlID0KLSAgICAgICAgIW1f d2ViRnJhbWUtPmZyYW1lKCktPmxvYWRlcigpLT5oaXN0b3J5KCktPmN1cnJlbnRJdGVtKCktPnN0 YXRlT2JqZWN0KCk7CisgICAgLy8gRklYTUU6IEl0IHNlZW1zIHdyb25nIHRoYXQgdGhlIGN1cnJl bnRJdGVtIGNhbiBzb21ldGltZXMgYmUgbnVsbC4KKyAgICBIaXN0b3J5SXRlbSogY3VycmVudEl0 ZW0gPSBtX3dlYkZyYW1lLT5mcmFtZSgpLT5sb2FkZXIoKS0+aGlzdG9yeSgpLT5jdXJyZW50SXRl bSgpOworICAgIGJvb2wgaXNIYXNoQ2hhbmdlID0gIWN1cnJlbnRJdGVtIHx8ICFjdXJyZW50SXRl bS0+c3RhdGVPYmplY3QoKTsKIAogICAgIFdlYkRhdGFTb3VyY2VJbXBsKiBkcyA9IG1fd2ViRnJh bWUtPmRhdGFTb3VyY2VJbXBsKCk7CiAgICAgQVNTRVJUKGRzKTsgIC8vIFNob3VsZCBub3QgYmUg bnVsbCB3aGVuIG5hdmlnYXRpbmcgdG8gYSByZWZlcmVuY2UgZnJhZ21lbnQhCg== 51295 2010-03-22 09:31:20 -0700 2010-03-22 11:10:00 -0700 v2 patch (minus svn:eol-style on layout tests) nocrash_2.txt text/plain 3754 fishd SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gNTYzMzUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0yMiAgRGFyaW4gRmlzaGVyICA8 ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVuZGVyZXIgY3Jhc2hlcyB3aGVuIG5hdmlnYXRpbmcg dG8gYSByZWZlcmVuY2UgZnJhZ21lbnQgaW4KKyAgICAgICAgYSBmcmFtZSB0aGF0IGhhcyBubyBj dXJyZW50IEhpc3RvcnlJdGVtLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNjQ0MworCisgICAgICAgICogZmFzdC9sb2FkZXIvY3Jhc2gtcmVwbGFj aW5nLWxvY2F0aW9uLWJlZm9yZS1sb2FkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9sb2FkZXIvY3Jhc2gtcmVwbGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1sb2FkLmh0bWw6IEFk ZGVkLgorCiAyMDEwLTAzLTIyICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2xvYWRlci9jcmFzaC1yZXBsYWNpbmctbG9jYXRpb24tYmVmb3JlLWxvYWQtZXhwZWN0 ZWQudHh0DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09DQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvY3Jhc2gtcmVw bGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1sb2FkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2NyYXNoLXJlcGxhY2luZy1sb2NhdGlvbi1iZWZvcmUt bG9hZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1BBU1MgCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9jcmFzaC1yZXBsYWNpbmctbG9jYXRpb24tYmVmb3Jl LWxvYWQuaHRtbA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2NyYXNo LXJlcGxhY2luZy1sb2NhdGlvbi1iZWZvcmUtbG9hZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZmFzdC9sb2FkZXIvY3Jhc2gtcmVwbGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1sb2Fk Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjUgQEAKKzxzY3JpcHQ+CitpZiAocGFyZW50 ID09IHdpbmRvdykgeworICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9s bGVyLndhaXRVbnRpbERvbmUoKTsKKyAgfQorICBmdW5jdGlvbiByZXBsYWNlSGFzaChmcmFnKSB7 CisgICAgZnJhbWVzWzBdLmxvY2F0aW9uLnJlcGxhY2UoJyMnICsgZnJhZyk7CisgIH0KKyAgb25s b2FkID0gZnVuY3Rpb24oKSB7CisgICAgdmFyIGYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJp ZnJhbWUiKTsKKyAgICBmLnNyYyA9IGxvY2F0aW9uOworICAgIGYub25sb2FkID0gZnVuY3Rpb24o KSB7CisgICAgICBkZWxldGUgZi5vbmxvYWQ7CisgICAgICByZXBsYWNlSGFzaCgnYmFyJyk7Cisg ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorICAgIGRvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQoZik7CisgICAgcmVwbGFjZUhhc2goJ2ZvbycpOworICB9Cit9Cis8L3NjcmlwdD4KKzwh LS0gSWYgd2UgZG8gbm90IGNyYXNoLCB0aGVuIHRoaXMgdGVzdCB3YXMgc3VjY2Vzc2Z1bC4gLS0+ Cis8Ym9keT5QQVNTPC9ib2R5PgpJbmRleDogV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZw0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2MzM1KQor KysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3 IEBACisyMDEwLTAzLTIyICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBS ZW5kZXJlciBjcmFzaGVzIHdoZW4gbmF2aWdhdGluZyB0byBhIHJlZmVyZW5jZSBmcmFnbWVudCBp bgorICAgICAgICBhIGZyYW1lIHRoYXQgaGFzIG5vIGN1cnJlbnQgSGlzdG9yeUl0ZW0uCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDQzCisKKyAg ICAgICAgVGVzdDogZmFzdC9sb2FkZXIvY3Jhc2gtcmVwbGFjaW5nLWxvY2F0aW9uLWJlZm9yZS1s b2FkLmh0bWwKKworICAgICAgICAqIHNyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpc3BhdGNoRGlkTmF2aWdhdGVX aXRoaW5QYWdlKToKKwogMjAxMC0wMy0yMiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2Vi S2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwDQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQot LS0gV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCShyZXZpc2lv biA1NjMzNSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNTg3LDggKzU4Nyw5IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGll bnRJbXBsOjpkaXNwYXRjaERpZE4KICAgICAgICAgd2ViVmlldy0+Y2xpZW50KCktPmRpZFN0YXJ0 TG9hZGluZygpOwogCiAgICAgLy8gV2UgbmVlZCB0byBjbGFzc2lmeSBzb21lIGhhc2ggY2hhbmdl cyBhcyBjbGllbnQgcmVkaXJlY3RzLgotICAgIGJvb2wgaXNIYXNoQ2hhbmdlID0KLSAgICAgICAg IW1fd2ViRnJhbWUtPmZyYW1lKCktPmxvYWRlcigpLT5oaXN0b3J5KCktPmN1cnJlbnRJdGVtKCkt PnN0YXRlT2JqZWN0KCk7CisgICAgLy8gRklYTUU6IEl0IHNlZW1zIHdyb25nIHRoYXQgdGhlIGN1 cnJlbnRJdGVtIGNhbiBzb21ldGltZXMgYmUgbnVsbC4KKyAgICBIaXN0b3J5SXRlbSogY3VycmVu dEl0ZW0gPSBtX3dlYkZyYW1lLT5mcmFtZSgpLT5sb2FkZXIoKS0+aGlzdG9yeSgpLT5jdXJyZW50 SXRlbSgpOworICAgIGJvb2wgaXNIYXNoQ2hhbmdlID0gIWN1cnJlbnRJdGVtIHx8ICFjdXJyZW50 SXRlbS0+c3RhdGVPYmplY3QoKTsKIAogICAgIFdlYkRhdGFTb3VyY2VJbXBsKiBkcyA9IG1fd2Vi RnJhbWUtPmRhdGFTb3VyY2VJbXBsKCk7CiAgICAgQVNTRVJUKGRzKTsgIC8vIFNob3VsZCBub3Qg YmUgbnVsbCB3aGVuIG5hdmlnYXRpbmcgdG8gYSByZWZlcmVuY2UgZnJhZ21lbnQhCg==