36437 2010-03-22 04:03:48 -0700 executive.py: Refactor the cpu_count code 2010-03-22 09:24:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cjerdonek cjerdonek abarth commit-queue eric oldest_to_newest 202430 0 cjerdonek 2010-03-22 04:03:48 -0700 I noticed the several attempted imports of the multiprocessing module when debugging autoinstall: http://trac.webkit.org/changeset/53011/trunk/WebKitTools/Scripts/webkitpy/executive.py It might be nice to move the import statement to the top, and not use a try-catch construct. 202436 1 51273 cjerdonek 2010-03-22 04:21:05 -0700 Created attachment 51273 Proposed patch 202458 2 51279 cjerdonek 2010-03-22 06:20:48 -0700 Created attachment 51279 Proposed patch 2 On second thought, try-except is probably better in this case. Did you find that it was necessary to include NotImplementedError? 202488 3 51279 abarth 2010-03-22 08:05:45 -0700 Comment on attachment 51279 Proposed patch 2 Ok 202539 4 51279 commit-queue 2010-03-22 09:24:41 -0700 Comment on attachment 51279 Proposed patch 2 Clearing flags on attachment: 51279 Committed r56336: <http://trac.webkit.org/changeset/56336> 202540 5 commit-queue 2010-03-22 09:24:46 -0700 All reviewed patches have been landed. Closing bug. 51273 2010-03-22 04:21:05 -0700 2010-03-22 06:20:48 -0700 Proposed patch _patch-36437-1.diff text/plain 2103 cjerdonek ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2OTQ5MDNjLi4xMmI0YTJjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMt MjIgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0b3JlZCB0aGUgY3B1X2Nv dW50KCkgY29kZSBpbiBleGVjdXRpdmUucHkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDM3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2V4ZWN1dGl2ZS5weToKKyAgICAgICAgICAtIE1vdmVkIHRoZSBpbXBvcnQgb2YgdGhlIG11bHRp cHJvY2Vzc2luZyBtb2R1bGUgdG8gdGhlIHRvcAorICAgICAgICAgICAgb2YgdGhlIGZpbGUgcmF0 aGVyIHRoYW4gaW1wb3J0aW5nIGZyb20gd2l0aGluIGEgZnVuY3Rpb24uCisgICAgICAgICAgLSBV c2VkIGEgY29uZGl0aW9uYWwgaW1wb3J0IGJhc2VkIG9uIGFuIGV4cGxpY2l0IHZlcnNpb24gY2hl Y2sKKyAgICAgICAgICAgIHJhdGhlciB0aGFuIHN1cnJvdW5kaW5nIHRoZSBpbXBvcnQgc3RhdGVt ZW50IHdpdGggYSB0cnktY2F0Y2guCisKIDIwMTAtMDMtMjIgIEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9u IEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9leGVj dXRpdmUucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2V4ZWN1dGl2ZS5weQppbmRl eCA1MGIxMTliLi5jMDJlODQzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2V4ZWN1dGl2ZS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2V4ZWN1 dGl2ZS5weQpAQCAtMzIsOCArMzIsMTUgQEAgaW1wb3J0IFN0cmluZ0lPCiBpbXBvcnQgc3VicHJv Y2VzcwogaW1wb3J0IHN5cwogCitmcm9tIHdlYmtpdHB5LmluaXQudmVyc2lvbmluZyBpbXBvcnQg Y29tcGFyZV92ZXJzaW9uCiBmcm9tIHdlYmtpdHB5LndlYmtpdF9sb2dnaW5nIGltcG9ydCB0ZWUK IAoraWYgY29tcGFyZV92ZXJzaW9uKHRhcmdldF92ZXJzaW9uPSIyLjUiKVswXSA+IDA6CisgICAg IyBUaGlzIEFQSSBleGlzdHMgb25seSBpbiBQeXRob24gMi42IGFuZCBoaWdoZXIuICA6KAorICAg IGltcG9ydCBtdWx0aXByb2Nlc3NpbmcKK2Vsc2U6CisgICAgbXVsdGlwcm9jZXNzaW5nID0gTm9u ZQorCiAKIGNsYXNzIFNjcmlwdEVycm9yKEV4Y2VwdGlvbik6CiAKQEAgLTExMywxNCArMTIwLDEx IEBAIGNsYXNzIEV4ZWN1dGl2ZShvYmplY3QpOgogCiAgICAgQHN0YXRpY21ldGhvZAogICAgIGRl ZiBjcHVfY291bnQoKToKLSAgICAgICAgIyBUaGlzIEFQSSBleGlzdHMgb25seSBpbiBQeXRob24g Mi42IGFuZCBoaWdoZXIuICA6KAotICAgICAgICB0cnk6Ci0gICAgICAgICAgICBpbXBvcnQgbXVs dGlwcm9jZXNzaW5nCisgICAgICAgIGlmIG11bHRpcHJvY2Vzc2luZzoKICAgICAgICAgICAgIHJl dHVybiBtdWx0aXByb2Nlc3NpbmcuY3B1X2NvdW50KCkKLSAgICAgICAgZXhjZXB0IChJbXBvcnRF cnJvciwgTm90SW1wbGVtZW50ZWRFcnJvcik6Ci0gICAgICAgICAgICAjIFRoaXMgcXVhbnRpdHkg aXMgYSBsaWUgYnV0IHByb2JhYmx5IGEgcmVhc29uYWJsZSBndWVzcyBmb3IgbW9kZXJuCi0gICAg ICAgICAgICAjIG1hY2hpbmVzLgotICAgICAgICAgICAgcmV0dXJuIDIKKyAgICAgICAgIyBUaGlz IHF1YW50aXR5IGlzIGEgbGllIGJ1dCBwcm9iYWJseSBhIHJlYXNvbmFibGUgZ3Vlc3MgZm9yIG1v ZGVybgorICAgICAgICAjIG1hY2hpbmVzLgorICAgICAgICByZXR1cm4gMgogCiAgICAgIyBFcnJv ciBoYW5kbGVycyBkbyBub3QgbmVlZCB0byBiZSBzdGF0aWMgbWV0aG9kcyBvbmNlIGFsbCBjYWxs ZXJzIGFyZQogICAgICMgdXBkYXRlZCB0byB1c2UgYW4gRXhlY3V0aXZlIG9iamVjdC4K 51279 2010-03-22 06:20:48 -0700 2010-03-22 09:24:41 -0700 Proposed patch 2 _patch-36437-2.diff text/plain 1936 cjerdonek ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2OTQ5MDNjLi4xNzY3OWI2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MjIgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0b3JlZCB0aGUgY3B1X2Nv dW50KCkgY29kZSBpbiBleGVjdXRpdmUucHkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDM3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2V4ZWN1dGl2ZS5weToKKyAgICAgICAgICAtIE1vdmVkIHRoZSBpbXBvcnQgb2YgdGhlIG11bHRp cHJvY2Vzc2luZyBtb2R1bGUgdG8gdGhlIHRvcAorICAgICAgICAgICAgb2YgdGhlIGZpbGUgcmF0 aGVyIHRoYW4gaW1wb3J0aW5nIGZyb20gd2l0aGluIGEgZnVuY3Rpb24uCisKIDIwMTAtMDMtMjIg IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9leGVjdXRpdmUucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2V4ZWN1dGl2ZS5weQppbmRleCA1MGIxMTliLi5iMWZhODY0IDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2V4ZWN1dGl2ZS5weQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2V4ZWN1dGl2ZS5weQpAQCAtMjcsNiArMjcsMTIgQEAKICMgKElOQ0xV RElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU SEUgVVNFCiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKK3RyeToKKyAgICAjIFRoaXMgQVBJIGV4aXN0cyBvbmx5 IGluIFB5dGhvbiAyLjYgYW5kIGhpZ2hlci4gIDooCisgICAgaW1wb3J0IG11bHRpcHJvY2Vzc2lu ZworZXhjZXB0IEltcG9ydEVycm9yOgorICAgIG11bHRpcHJvY2Vzc2luZyA9IE5vbmUKKwogaW1w b3J0IG9zCiBpbXBvcnQgU3RyaW5nSU8KIGltcG9ydCBzdWJwcm9jZXNzCkBAIC0xMTMsMTQgKzEx OSwxMSBAQCBjbGFzcyBFeGVjdXRpdmUob2JqZWN0KToKIAogICAgIEBzdGF0aWNtZXRob2QKICAg ICBkZWYgY3B1X2NvdW50KCk6Ci0gICAgICAgICMgVGhpcyBBUEkgZXhpc3RzIG9ubHkgaW4gUHl0 aG9uIDIuNiBhbmQgaGlnaGVyLiAgOigKLSAgICAgICAgdHJ5OgotICAgICAgICAgICAgaW1wb3J0 IG11bHRpcHJvY2Vzc2luZworICAgICAgICBpZiBtdWx0aXByb2Nlc3Npbmc6CiAgICAgICAgICAg ICByZXR1cm4gbXVsdGlwcm9jZXNzaW5nLmNwdV9jb3VudCgpCi0gICAgICAgIGV4Y2VwdCAoSW1w b3J0RXJyb3IsIE5vdEltcGxlbWVudGVkRXJyb3IpOgotICAgICAgICAgICAgIyBUaGlzIHF1YW50 aXR5IGlzIGEgbGllIGJ1dCBwcm9iYWJseSBhIHJlYXNvbmFibGUgZ3Vlc3MgZm9yIG1vZGVybgot ICAgICAgICAgICAgIyBtYWNoaW5lcy4KLSAgICAgICAgICAgIHJldHVybiAyCisgICAgICAgICMg VGhpcyBxdWFudGl0eSBpcyBhIGxpZSBidXQgcHJvYmFibHkgYSByZWFzb25hYmxlIGd1ZXNzIGZv ciBtb2Rlcm4KKyAgICAgICAgIyBtYWNoaW5lcy4KKyAgICAgICAgcmV0dXJuIDIKIAogICAgICMg RXJyb3IgaGFuZGxlcnMgZG8gbm90IG5lZWQgdG8gYmUgc3RhdGljIG1ldGhvZHMgb25jZSBhbGwg Y2FsbGVycyBhcmUKICAgICAjIHVwZGF0ZWQgdG8gdXNlIGFuIEV4ZWN1dGl2ZSBvYmplY3QuCg==