36431 2010-03-21 16:12:58 -0700 Clean up 'int' use in UString.cpp after r54789 2010-03-22 10:40:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 34952 1 ddkilzer ddkilzer barraclough oldest_to_newest 202361 0 51258 ddkilzer 2010-03-21 16:12:58 -0700 Created attachment 51258 Patch Reviewed by NOBODY (OOPS!). * runtime/UString.cpp: (JSC::UString::from): Changed argument type from 'unsigned int' to 'unsigned' to match WebKit coding style. (JSC::UString::find): Changed static_cast<int>() to static_cast<unsigned>() now that this method returns unsigned. (JSC::UString::rfind): Ditto. --- 2 files changed, 19 insertions(+), 6 deletions(-) 202363 1 51259 ddkilzer 2010-03-21 16:17:23 -0700 Created attachment 51259 Patch v2 202591 2 ddkilzer 2010-03-22 10:40:22 -0700 Committed r56342: <http://trac.webkit.org/changeset/56342> 51258 2010-03-21 16:12:58 -0700 2010-03-21 16:17:20 -0700 Patch 20100321161257.patch text/plain 3081 ddkilzer ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiZjliZmYzLi40MGI4MmZiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTAtMDMtMjEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAorICAg ICAgICBDbGVhbiB1cCAnaW50JyB1c2UgaW4gVVN0cmluZy5jcHAgYWZ0ZXIgcjU0Nzg5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL1VT dHJpbmcuY3BwOgorICAgICAgICAoSlNDOjpVU3RyaW5nOjpmcm9tKTogQ2hhbmdlZCBhcmd1bWVu dCB0eXBlIGZyb20gJ3Vuc2lnbmVkIGludCcKKyAgICAgICAgdG8gJ3Vuc2lnbmVkJyB0byBtYXRj aCBXZWJLaXQgY29kaW5nIHN0eWxlLgorICAgICAgICAoSlNDOjpVU3RyaW5nOjpmaW5kKTogQ2hh bmdlZCBzdGF0aWNfY2FzdDxpbnQ+KCkgdG8KKyAgICAgICAgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KCkgbm93IHRoYXQgdGhpcyBtZXRob2QgcmV0dXJucyB1bnNpZ25lZC4KKyAgICAgICAgKEpTQzo6 VVN0cmluZzo6cmZpbmQpOiBEaXR0by4KKworMjAxMC0wMy0yMSAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEJsaW5kIGF0dGVtcHQgIzIgdG8gZml4IHRoZSBX aW5kb3dzIGJ1aWxkIGFmdGVyIHI1NjMxNAogCiAgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGku YzogSW5jbHVkZSBKU09iamVjdFJlZlByaXZhdGUuaCBmb3IgdGhlIG5ldwpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvcnVudGltZS9VU3RyaW5nLmNwcCBiL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVVN0cmluZy5jcHAKaW5kZXggNjBiNjI3OC4uOWRhNjY5ZCAxMDA2NDQKLS0tIGEvSmF2YVNj cmlwdENvcmUvcnVudGltZS9VU3RyaW5nLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1VTdHJpbmcuY3BwCkBAIC0yMzcsNyArMjM3LDcgQEAgVVN0cmluZyBVU3RyaW5nOjpmcm9tKGxv bmcgbG9uZyBpKQogICAgIHJldHVybiBVU3RyaW5nKHAsIHN0YXRpY19jYXN0PHVuc2lnbmVkPihl bmQgLSBwKSk7CiB9CiAKLVVTdHJpbmcgVVN0cmluZzo6ZnJvbSh1bnNpZ25lZCBpbnQgdSkKK1VT dHJpbmcgVVN0cmluZzo6ZnJvbSh1bnNpZ25lZCB1KQogewogICAgIFVDaGFyIGJ1ZltzaXplb2Yo dSkgKiAzXTsKICAgICBVQ2hhciogZW5kID0gYnVmICsgc2l6ZW9mKGJ1ZikgLyBzaXplb2YoVUNo YXIpOwpAQCAtNTQzLDcgKzU0Myw3IEBAIHVuc2lnbmVkIFVTdHJpbmc6OmZpbmQoY29uc3QgVVN0 cmluZyYgZiwgdW5zaWduZWQgcG9zKSBjb25zdAogICAgICAgICBjb25zdCBVQ2hhciogZW5kID0g ZGF0YSgpICsgc2l6ZSgpOwogICAgICAgICBmb3IgKGNvbnN0IFVDaGFyKiBjID0gZGF0YSgpICsg cG9zOyBjIDwgZW5kOyBjKyspIHsKICAgICAgICAgICAgIGlmICgqYyA9PSBjaCkKLSAgICAgICAg ICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8aW50PihjIC0gZGF0YSgpKTsKKyAgICAgICAgICAg ICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGMgLSBkYXRhKCkpOwogICAgICAgICB9 CiAgICAgICAgIHJldHVybiBOb3RGb3VuZDsKICAgICB9CkBAIC01NjAsNyArNTYwLDcgQEAgdW5z aWduZWQgVVN0cmluZzo6ZmluZChjb25zdCBVU3RyaW5nJiBmLCB1bnNpZ25lZCBwb3MpIGNvbnN0 CiAgICAgKytmZGF0YTsKICAgICBmb3IgKGNvbnN0IFVDaGFyKiBjID0gZGF0YSgpICsgcG9zOyBj IDw9IGVuZDsgYysrKSB7CiAgICAgICAgIGlmIChjWzBdID09IGZjaGFyICYmICFtZW1jbXAoYyAr IDEsIGZkYXRhLCBmc2l6ZW1pbnVzb25lKSkKLSAgICAgICAgICAgIHJldHVybiBzdGF0aWNfY2Fz dDxpbnQ+KGMgLSBkYXRhKCkpOworICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2ln bmVkPihjIC0gZGF0YSgpKTsKICAgICB9CiAKICAgICByZXR1cm4gTm90Rm91bmQ7CkBAIC01NzEs NyArNTcxLDcgQEAgdW5zaWduZWQgVVN0cmluZzo6ZmluZChVQ2hhciBjaCwgdW5zaWduZWQgcG9z KSBjb25zdAogICAgIGNvbnN0IFVDaGFyKiBlbmQgPSBkYXRhKCkgKyBzaXplKCk7CiAgICAgZm9y IChjb25zdCBVQ2hhciogYyA9IGRhdGEoKSArIHBvczsgYyA8IGVuZDsgYysrKSB7CiAgICAgICAg IGlmICgqYyA9PSBjaCkKLSAgICAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxpbnQ+KGMgLSBk YXRhKCkpOworICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPihjIC0gZGF0 YSgpKTsKICAgICB9CiAKICAgICByZXR1cm4gTm90Rm91bmQ7CkBAIC01OTEsNyArNTkxLDcgQEAg dW5zaWduZWQgVVN0cmluZzo6cmZpbmQoY29uc3QgVVN0cmluZyYgZiwgdW5zaWduZWQgcG9zKSBj b25zdAogICAgIGNvbnN0IFVDaGFyKiBmZGF0YSA9IGYuZGF0YSgpOwogICAgIGZvciAoY29uc3Qg VUNoYXIqIGMgPSBkYXRhKCkgKyBwb3M7IGMgPj0gZGF0YSgpOyBjLS0pIHsKICAgICAgICAgaWYg KCpjID09ICpmZGF0YSAmJiAhbWVtY21wKGMgKyAxLCBmZGF0YSArIDEsIGZzaXplbWludXNvbmUp KQotICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PGludD4oYyAtIGRhdGEoKSk7CisgICAg ICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGMgLSBkYXRhKCkpOwogICAgIH0K IAogICAgIHJldHVybiBOb3RGb3VuZDsKQEAgLTYwNSw3ICs2MDUsNyBAQCB1bnNpZ25lZCBVU3Ry aW5nOjpyZmluZChVQ2hhciBjaCwgdW5zaWduZWQgcG9zKSBjb25zdAogICAgICAgICBwb3MgPSBz aXplKCkgLSAxOwogICAgIGZvciAoY29uc3QgVUNoYXIqIGMgPSBkYXRhKCkgKyBwb3M7IGMgPj0g ZGF0YSgpOyBjLS0pIHsKICAgICAgICAgaWYgKCpjID09IGNoKQotICAgICAgICAgICAgcmV0dXJu IHN0YXRpY19jYXN0PGludD4oYyAtIGRhdGEoKSk7CisgICAgICAgICAgICByZXR1cm4gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KGMgLSBkYXRhKCkpOwogICAgIH0KIAogICAgIHJldHVybiBOb3RGb3Vu ZDsK 51259 2010-03-21 16:17:23 -0700 2010-03-22 10:00:11 -0700 Patch v2 bug-36431-20100321161721.patch text/plain 3728 ddkilzer ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiZjliZmYzLi41NDIxZWE1IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTAtMDMtMjEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAorICAg ICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8zNjQzMT4gQ2xlYW4gdXAgJ2ludCcgdXNlIGluIFVT dHJpbmcuY3BwIGFmdGVyIHI1NDc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcnVudGltZS9VU3RyaW5nLmNwcDoKKyAgICAgICAgKEpTQzo6VVN0 cmluZzo6ZnJvbSk6IENoYW5nZWQgYXJndW1lbnQgdHlwZSBmcm9tICd1bnNpZ25lZCBpbnQnCisg ICAgICAgIHRvICd1bnNpZ25lZCcgdG8gbWF0Y2ggV2ViS2l0IGNvZGluZyBzdHlsZS4KKyAgICAg ICAgKEpTQzo6VVN0cmluZzo6ZmluZCk6IENoYW5nZWQgc3RhdGljX2Nhc3Q8aW50PigpIHRvCisg ICAgICAgIHN0YXRpY19jYXN0PHVuc2lnbmVkPigpIG5vdyB0aGF0IHRoaXMgbWV0aG9kIHJldHVy bnMgdW5zaWduZWQuCisgICAgICAgIChKU0M6OlVTdHJpbmc6OnJmaW5kKTogRGl0dG8uCisgICAg ICAgICogcnVudGltZS9VU3RyaW5nLmg6CisgICAgICAgIChKU0M6OlVTdHJpbmc6OmZyb20pOiBD aGFuZ2VkIGFyZ3VtZW50IHR5cGUgZnJvbSAndW5zaWduZWQgaW50JworICAgICAgICB0byAndW5z aWduZWQnIHRvIG1hdGNoIFdlYktpdCBjb2Rpbmcgc3R5bGUuCisKKzIwMTAtMDMtMjEgIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKwogICAgICAgICBCbGluZCBhdHRlbXB0ICMy IHRvIGZpeCB0aGUgV2luZG93cyBidWlsZCBhZnRlciByNTYzMTQKIAogICAgICAgICAqIEFQSS90 ZXN0cy90ZXN0YXBpLmM6IEluY2x1ZGUgSlNPYmplY3RSZWZQcml2YXRlLmggZm9yIHRoZSBuZXcK ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5jcHAgYi9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1VTdHJpbmcuY3BwCmluZGV4IDYwYjYyNzguLjlkYTY2OWQgMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5jcHAKKysrIGIvSmF2YVNjcmlw dENvcmUvcnVudGltZS9VU3RyaW5nLmNwcApAQCAtMjM3LDcgKzIzNyw3IEBAIFVTdHJpbmcgVVN0 cmluZzo6ZnJvbShsb25nIGxvbmcgaSkKICAgICByZXR1cm4gVVN0cmluZyhwLCBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4oZW5kIC0gcCkpOwogfQogCi1VU3RyaW5nIFVTdHJpbmc6OmZyb20odW5zaWdu ZWQgaW50IHUpCitVU3RyaW5nIFVTdHJpbmc6OmZyb20odW5zaWduZWQgdSkKIHsKICAgICBVQ2hh ciBidWZbc2l6ZW9mKHUpICogM107CiAgICAgVUNoYXIqIGVuZCA9IGJ1ZiArIHNpemVvZihidWYp IC8gc2l6ZW9mKFVDaGFyKTsKQEAgLTU0Myw3ICs1NDMsNyBAQCB1bnNpZ25lZCBVU3RyaW5nOjpm aW5kKGNvbnN0IFVTdHJpbmcmIGYsIHVuc2lnbmVkIHBvcykgY29uc3QKICAgICAgICAgY29uc3Qg VUNoYXIqIGVuZCA9IGRhdGEoKSArIHNpemUoKTsKICAgICAgICAgZm9yIChjb25zdCBVQ2hhciog YyA9IGRhdGEoKSArIHBvczsgYyA8IGVuZDsgYysrKSB7CiAgICAgICAgICAgICBpZiAoKmMgPT0g Y2gpCi0gICAgICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PGludD4oYyAtIGRhdGEoKSk7 CisgICAgICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPihjIC0gZGF0YSgp KTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gTm90Rm91bmQ7CiAgICAgfQpAQCAtNTYwLDcg KzU2MCw3IEBAIHVuc2lnbmVkIFVTdHJpbmc6OmZpbmQoY29uc3QgVVN0cmluZyYgZiwgdW5zaWdu ZWQgcG9zKSBjb25zdAogICAgICsrZmRhdGE7CiAgICAgZm9yIChjb25zdCBVQ2hhciogYyA9IGRh dGEoKSArIHBvczsgYyA8PSBlbmQ7IGMrKykgewogICAgICAgICBpZiAoY1swXSA9PSBmY2hhciAm JiAhbWVtY21wKGMgKyAxLCBmZGF0YSwgZnNpemVtaW51c29uZSkpCi0gICAgICAgICAgICByZXR1 cm4gc3RhdGljX2Nhc3Q8aW50PihjIC0gZGF0YSgpKTsKKyAgICAgICAgICAgIHJldHVybiBzdGF0 aWNfY2FzdDx1bnNpZ25lZD4oYyAtIGRhdGEoKSk7CiAgICAgfQogCiAgICAgcmV0dXJuIE5vdEZv dW5kOwpAQCAtNTcxLDcgKzU3MSw3IEBAIHVuc2lnbmVkIFVTdHJpbmc6OmZpbmQoVUNoYXIgY2gs IHVuc2lnbmVkIHBvcykgY29uc3QKICAgICBjb25zdCBVQ2hhciogZW5kID0gZGF0YSgpICsgc2l6 ZSgpOwogICAgIGZvciAoY29uc3QgVUNoYXIqIGMgPSBkYXRhKCkgKyBwb3M7IGMgPCBlbmQ7IGMr KykgewogICAgICAgICBpZiAoKmMgPT0gY2gpCi0gICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nh c3Q8aW50PihjIC0gZGF0YSgpKTsKKyAgICAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDx1bnNp Z25lZD4oYyAtIGRhdGEoKSk7CiAgICAgfQogCiAgICAgcmV0dXJuIE5vdEZvdW5kOwpAQCAtNTkx LDcgKzU5MSw3IEBAIHVuc2lnbmVkIFVTdHJpbmc6OnJmaW5kKGNvbnN0IFVTdHJpbmcmIGYsIHVu c2lnbmVkIHBvcykgY29uc3QKICAgICBjb25zdCBVQ2hhciogZmRhdGEgPSBmLmRhdGEoKTsKICAg ICBmb3IgKGNvbnN0IFVDaGFyKiBjID0gZGF0YSgpICsgcG9zOyBjID49IGRhdGEoKTsgYy0tKSB7 CiAgICAgICAgIGlmICgqYyA9PSAqZmRhdGEgJiYgIW1lbWNtcChjICsgMSwgZmRhdGEgKyAxLCBm c2l6ZW1pbnVzb25lKSkKLSAgICAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxpbnQ+KGMgLSBk YXRhKCkpOworICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPihjIC0gZGF0 YSgpKTsKICAgICB9CiAKICAgICByZXR1cm4gTm90Rm91bmQ7CkBAIC02MDUsNyArNjA1LDcgQEAg dW5zaWduZWQgVVN0cmluZzo6cmZpbmQoVUNoYXIgY2gsIHVuc2lnbmVkIHBvcykgY29uc3QKICAg ICAgICAgcG9zID0gc2l6ZSgpIC0gMTsKICAgICBmb3IgKGNvbnN0IFVDaGFyKiBjID0gZGF0YSgp ICsgcG9zOyBjID49IGRhdGEoKTsgYy0tKSB7CiAgICAgICAgIGlmICgqYyA9PSBjaCkKLSAgICAg ICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxpbnQ+KGMgLSBkYXRhKCkpOworICAgICAgICAgICAg cmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPihjIC0gZGF0YSgpKTsKICAgICB9CiAKICAgICBy ZXR1cm4gTm90Rm91bmQ7CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1VTdHJp bmcuaCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5oCmluZGV4IDY5OWJkMTAuLmU2 MTYyMDEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5oCisrKyBi L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5oCkBAIC0xMDksNyArMTA5LDcgQEAgbmFt ZXNwYWNlIEpTQyB7CiAKICAgICAgICAgc3RhdGljIFVTdHJpbmcgZnJvbShpbnQpOwogICAgICAg ICBzdGF0aWMgVVN0cmluZyBmcm9tKGxvbmcgbG9uZyk7Ci0gICAgICAgIHN0YXRpYyBVU3RyaW5n IGZyb20odW5zaWduZWQgaW50KTsKKyAgICAgICAgc3RhdGljIFVTdHJpbmcgZnJvbSh1bnNpZ25l ZCk7CiAgICAgICAgIHN0YXRpYyBVU3RyaW5nIGZyb20obG9uZyk7CiAgICAgICAgIHN0YXRpYyBV U3RyaW5nIGZyb20oZG91YmxlKTsKIAo=