36405 2010-03-19 20:56:08 -0700 [EFL] Move AccessibilityObjectEfl.cpp from page to accessibility 2010-04-08 09:10:20 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos tonikitoo barbieri cfleizach ddkilzer laszlo.gombos leandro tonikitoo oldest_to_newest 202166 0 laszlo.gombos 2010-03-19 20:56:08 -0700 Regarding ChangeSet r55343 (http://trac.webkit.org/changeset/55343) - Shouldn't AccessibilityObjectEfl.cpp be under accessibility directory like for other ports (e.g WebCore/accessibility/platform/efl) ? 202167 1 laszlo.gombos 2010-03-19 20:57:09 -0700 I meant WebCore/accessibility/efl and not WebCore/accessibility/platform/efl. 209679 2 ddkilzer 2010-04-07 09:47:59 -0700 (In reply to comment #1) > I meant WebCore/accessibility/efl and not WebCore/accessibility/platform/efl. Yes, it should be moved to WebCore/accessibility/efl/. 209843 3 barbieri 2010-04-07 14:27:39 -0700 Could someone move it then? The build system is still not integrated (#36761), then we could provide a new patch for build system with the correct path. 210214 4 ddkilzer 2010-04-08 08:29:43 -0700 (In reply to comment #3) > Could someone move it then? The build system is still not integrated (#36761), > then we could provide a new patch for build system with the correct path. Anyone can post a patch to move the file. 210218 5 tonikitoo 2010-04-08 08:41:33 -0700 (In reply to comment #4) > (In reply to comment #3) > > Could someone move it then? The build system is still not integrated (#36761), > > then we could provide a new patch for build system with the correct path. > > Anyone can post a patch to move the file. as agreed on IRC w/ k-s (gustavo barbieri) i will do that now 210226 6 52871 tonikitoo 2010-04-08 08:46:24 -0700 Created attachment 52871 (committed in r57282) patch v1 210229 7 52871 laszlo.gombos 2010-04-08 08:52:14 -0700 Comment on attachment 52871 (committed in r57282) patch v1 Looks good to me. 210235 8 52871 tonikitoo 2010-04-08 09:09:59 -0700 Comment on attachment 52871 (committed in r57282) patch v1 thank you laszlo! Committing to http://svn.webkit.org/repository/webkit/trunk ... R WebCore/page/efl/AccessibilityObjectEfl.cpp => WebCore/accessibility/efl/AccessibilityObjectEfl.cpp M WebCore/ChangeLog Committed r57282 52871 2010-04-08 08:46:24 -0700 2010-04-08 09:09:59 -0700 (committed in r57282) patch v1 0001--EFL-Move-AccessibilityObjectEfl.cpp-from-page-to-a.patch text/plain 4483 tonikitoo RnJvbSA1N2UxMmZiNWFlOTIyNzg0ZjE3MTk2ODE3MzQ4NmE1YTM3MDkxYjg1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCA4IEFwciAyMDEwIDExOjQ1OjA3IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW0VG TF0gTW92ZSBBY2Nlc3NpYmlsaXR5T2JqZWN0RWZsLmNwcCBmcm9tIHBhZ2UgdG8gYWNjZXNzaWJp bGl0eQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDA1CgpSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9v QHdlYmtpdC5vcmc+CgoqIGFjY2Vzc2liaWxpdHkvZWZsL0FjY2Vzc2liaWxpdHlPYmplY3RFZmwu Y3BwOiBSZW5hbWVkIGZyb20gV2ViQ29yZS9wYWdlL2VmbC9BY2Nlc3NpYmlsaXR5T2JqZWN0RWZs LmNwcC4KKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmFjY2Vzc2liaWxpdHlJZ25vcmVB dHRhY2htZW50KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTAgKysrKysKIC4uLi9hY2Nlc3NpYmlsaXR5L2VmbC9BY2Nlc3NpYmls aXR5T2JqZWN0RWZsLmNwcCAgIHwgICAzNiArKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9w YWdlL2VmbC9BY2Nlc3NpYmlsaXR5T2JqZWN0RWZsLmNwcCAgICAgICAgfCAgIDM2IC0tLS0tLS0t LS0tLS0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDM2IGRlbGV0 aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9lZmwvQWNj ZXNzaWJpbGl0eU9iamVjdEVmbC5jcHAKIGRlbGV0ZSBtb2RlIDEwMDY0NCBXZWJDb3JlL3BhZ2Uv ZWZsL0FjY2Vzc2liaWxpdHlPYmplY3RFZmwuY3BwCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmNjc3OWMwLi4zMzg4NjI2IDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA0LTA4ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VGTF0g TW92ZSBBY2Nlc3NpYmlsaXR5T2JqZWN0RWZsLmNwcCBmcm9tIHBhZ2UgdG8gYWNjZXNzaWJpbGl0 eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0MDUK KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZWZsL0FjY2Vzc2liaWxpdHlPYmplY3RFZmwuY3Bw OiBSZW5hbWVkIGZyb20gV2ViQ29yZS9wYWdlL2VmbC9BY2Nlc3NpYmlsaXR5T2JqZWN0RWZsLmNw cC4KKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmFjY2Vzc2liaWxpdHlJ Z25vcmVBdHRhY2htZW50KToKKwogMjAxMC0wNC0wOCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2VmbC9BY2Nlc3NpYmlsaXR5T2JqZWN0 RWZsLmNwcCBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9lZmwvQWNjZXNzaWJpbGl0eU9iamVjdEVm bC5jcHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZDU3YzNmYQotLS0gL2Rl di9udWxsCisrKyBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9lZmwvQWNjZXNzaWJpbGl0eU9iamVj dEVmbC5jcHAKQEAgLTAsMCArMSwzNiBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAwOCBBcHBs ZSBMdGQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDktMjAxMCBQcm9GVVNJT04gZW1iZWRkZWQgc3lz dGVtcworICogQ29weXJpZ2h0IChDKSAyMDA5LTIwMTAgU2Ftc3VuZyBFbGVjdHJvbmljcworICoK KyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5 IEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0 d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3Ig KGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiBUaGlzIGxpYnJhcnkg aXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1 dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5 IG9mCisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBP U0UuICBTZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBt b3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0 aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxvbmcgd2l0aCB0aGlz IGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyAq IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwg RmlmdGggRmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KKyAqLworCisjaW5j bHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiQWNjZXNzaWJpbGl0eU9iamVjdC5oIgorCisjaWYg SEFWRShBQ0NFU1NJQklMSVRZKQorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK2Jvb2wgQWNjZXNz aWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0eUlnbm9yZUF0dGFjaG1lbnQoKSBjb25zdAorewor ICAgIHJldHVybiBmYWxzZTsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYg Ly8gSEFWRShBQ0NFU1NJQklMSVRZKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2VmbC9BY2Nl c3NpYmlsaXR5T2JqZWN0RWZsLmNwcCBiL1dlYkNvcmUvcGFnZS9lZmwvQWNjZXNzaWJpbGl0eU9i amVjdEVmbC5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGQ1N2MzZmEuLjAwMDAw MDAKLS0tIGEvV2ViQ29yZS9wYWdlL2VmbC9BY2Nlc3NpYmlsaXR5T2JqZWN0RWZsLmNwcAorKysg L2Rldi9udWxsCkBAIC0xLDM2ICswLDAgQEAKLS8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDggQXBw bGUgTHRkLgotICogQ29weXJpZ2h0IChDKSAyMDA5LTIwMTAgUHJvRlVTSU9OIGVtYmVkZGVkIHN5 c3RlbXMKLSAqIENvcHlyaWdodCAoQykgMjAwOS0yMDEwIFNhbXN1bmcgRWxlY3Ryb25pY3MKLSAq Ci0gKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yCi0gKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy eSBHZW5lcmFsIFB1YmxpYwotICogTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29m dHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCi0gKiB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9y IChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCi0gKgotICogVGhpcyBsaWJyYXJ5 IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCi0gKiBi dXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50 eSBvZgotICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQ T1NFLiAgU2VlIHRoZSBHTlUKLSAqIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3Ig bW9yZSBkZXRhaWxzLgotICoKLSAqIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKLSAqIGFsb25nIHdpdGggdGhp cyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5MSUIuICBJZiBub3QsIHdyaXRlIHRvCi0g KiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQs IEZpZnRoIEZsb29yLAotICogQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCi0gKi8KLQotI2lu Y2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIkFjY2Vzc2liaWxpdHlPYmplY3QuaCIKLQotI2lm IEhBVkUoQUNDRVNTSUJJTElUWSkKLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi1ib29sIEFjY2Vz c2liaWxpdHlPYmplY3Q6OmFjY2Vzc2liaWxpdHlJZ25vcmVBdHRhY2htZW50KCkgY29uc3QKLXsK LSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKLQotI2VuZGlm IC8vIEhBVkUoQUNDRVNTSUJJTElUWSkKLS0gCjEuNi4wLjQKCg==