36390 2010-03-19 14:19:40 -0700 [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr 2010-03-29 21:04:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson oldest_to_newest 202033 0 mrobinson 2010-03-19 14:19:40 -0700 Very similar to: https://bugs.webkit.org/show_bug.cgi?id=27215 The Totem plugin, in particular can cause spurious failures when it uses the GLib logger. 202040 1 51188 mrobinson 2010-03-19 14:29:40 -0700 Created attachment 51188 Patch for this issue 203882 2 51188 eric 2010-03-25 00:51:49 -0700 Comment on attachment 51188 Patch for this issue We need a comment in the code, otherwise the next person to look at this will have no clue what this is for. 204089 3 51645 mrobinson 2010-03-25 09:12:07 -0700 Created attachment 51645 Patch for this issue (rev2) Sounds good. Update attached. 205283 4 51645 zecke 2010-03-28 19:39:15 -0700 Comment on attachment 51645 Patch for this issue (rev2) Yes, this will work for the totem plugin. Some how my memory tells me we had a patch to run-webkit-test to filter out certain output but my memory seems to play tricks... 205831 5 mrobinson 2010-03-29 21:04:52 -0700 Committed r56760: <http://trac.webkit.org/changeset/56760> 51188 2010-03-19 14:29:40 -0700 2010-03-25 09:12:07 -0700 Patch for this issue 0001-Suppress-debugging-messages-sent-to-the-GLib-logger-.patch text/plain 1972 mrobinson RnJvbSA5NjVmYjdmZTQ2ZjA1MWM1ZTkzZDFiNjc4ZmRkMjNlZGUwMTk5OGZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1hcnRpbi5qYW1lcy5yb2JpbnNv bkBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMTkgTWFyIDIwMTAgMTQ6MjA6NTAgLTA3MDAKU3ViamVj dDogW1BBVENIXSBTdXBwcmVzcyBkZWJ1Z2dpbmcgbWVzc2FnZXMgc2VudCB0byB0aGUgR0xpYiBs b2dnZXIgZHVyaW5nIERSVCBydW5zLgoKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIHwgICAgNyArKysrKysrCiAyIGZp bGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDIx MjA3M2IuLjkxMmJhZWMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9X ZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0xOSAgTWFydGlu IFJvYmluc29uICA8bXJvYmluc29uQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gc3VwcHJlc3MgKHVuKWRlc2lyZWQgbGF1 bmNoZXIgb3V0cHV0IHRoYXQgY2FuIG1ha2UgbGF5b3V0IHRlc3QgdG8gZmFpbCB3aXRoIHN0ZGVy cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYzOTAK KworICAgICAgICBTdXBwcmVzcyBkZWJ1Z2dpbmcgbWVzc2FnZXMgc2VudCB0byB0aGUgR0xpYiBs b2dnZXIgZHVyaW5nIERSVCBydW5zLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1 bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKGxvZ0hhbmRsZXIpOiBBZGRlZC4KKyAgICAgICAg KG1haW4pOiBVc2UgbG9nSGFuZGxlciBhcyB0aGUgZGVmYXVsdCBHTGliIGxvZyBtZXNzYWdlIGhh bmRsZXIuCisKIDIwMTAtMDMtMTcgIFZpY3RvciBXYW5nICA8dmljdG9yd0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggNmFhNGMzZS4u ZTMwOWMzYSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBS ZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJl bmRlclRyZWUuY3BwCkBAIC04NDMsMTEgKzg0MywxOCBAQCBzdGF0aWMgV2ViS2l0V2ViVmlldyog d2ViVmlld0NyZWF0ZShXZWJLaXRXZWJWaWV3KiB2aWV3LCBXZWJLaXRXZWJGcmFtZSogZnJhbWUp CiAgICAgcmV0dXJuIG5ld1dlYlZpZXc7CiB9CiAKK3N0YXRpYyB2b2lkIGxvZ0hhbmRsZXIoY29u c3QgZ2NoYXIqIGRvbWFpbiwgR0xvZ0xldmVsRmxhZ3MgbGV2ZWwsIGNvbnN0IGdjaGFyKiBtZXNz YWdlLCBncG9pbnRlciBkYXRhKQoreworICAgIGlmIChsZXZlbCA8IEdfTE9HX0xFVkVMX0RFQlVH KQorICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIiVzXG4iLCBtZXNzYWdlKTsKK30KKwogaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKIHsKICAgICBnX3RocmVhZF9pbml0KE5VTEwpOwog ICAgIGd0a19pbml0KCZhcmdjLCAmYXJndik7CiAKKyAgICBnX2xvZ19zZXRfZGVmYXVsdF9oYW5k bGVyKGxvZ0hhbmRsZXIsIDApOwogI2lmIFBMQVRGT1JNKFgxMSkKICAgICBGY0luaXQoKTsKICAg ICBpbml0aWFsaXplRm9udHMoKTsKLS0gCjEuNi4zLjMKCg== 51645 2010-03-25 09:12:07 -0700 2010-03-28 19:39:15 -0700 Patch for this issue (rev2) 0001-GTK-suppress-un-desired-launcher-output-that-can-mak.patch text/plain 2260 mrobinson RnJvbSA0Y2MwODIyOGVhZGJhYzJiZmExOTk5MmI4MDFkMGQ2ODQwZWJiOTlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1yb2JpbnNvbkB3ZWJraXQub3Jn PgpEYXRlOiBUaHUsIDI1IE1hciAyMDEwIDA5OjEwOjIzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g W0dUS10gc3VwcHJlc3MgKHVuKWRlc2lyZWQgbGF1bmNoZXIgb3V0cHV0IHRoYXQgY2FuIG1ha2Ug bGF5b3V0IHRlc3QgdG8gZmFpbCB3aXRoIHN0ZGVycgogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM2MzkwCgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAgfCAgIDExICsrKysrKysrKysrCiAy IGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDk2NWNhZjQuLjE1NGU1ZjYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorKzIwMTAtMDMtMjUgIE1h cnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHN1cHByZXNzICh1bilkZXNpcmVk IGxhdW5jaGVyIG91dHB1dCB0aGF0IGNhbiBtYWtlIGxheW91dCB0ZXN0IHRvIGZhaWwgd2l0aCBz dGRlcnIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2 MzkwCisKKyAgICAgICAgU3VwcHJlc3MgZGVidWdnaW5nIG1lc3NhZ2VzIHNlbnQgdG8gdGhlIEdM aWIgbG9nZ2VyIGR1cmluZyBEUlQgcnVucy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0 ay9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChsb2dIYW5kbGVyKTogQWRkZWQuCisgICAg ICAgIChtYWluKTogVXNlIGxvZ0hhbmRsZXIgYXMgdGhlIGRlZmF1bHQgR0xpYiBsb2cgbWVzc2Fn ZSBoYW5kbGVyLgorCiAyMDEwLTAzLTI1ICBEaWVnbyBHb256YWxleiAgPGRpZWdvLmdvbnphbGV6 QG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBDaHJpc3RpYW5z ZW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRl clRyZWUuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVl LmNwcAppbmRleCA5ZjcxMzg3Li44YjkzNTdiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTg2MiwxMSArODYyLDIyIEBAIHN0 YXRpYyBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3Q3JlYXRlKFdlYktpdFdlYlZpZXcqIHZpZXcsIFdl YktpdFdlYkZyYW1lKiBmcmFtZSkKICAgICByZXR1cm4gbmV3V2ViVmlldzsKIH0KIAorc3RhdGlj IHZvaWQgbG9nSGFuZGxlcihjb25zdCBnY2hhciogZG9tYWluLCBHTG9nTGV2ZWxGbGFncyBsZXZl bCwgY29uc3QgZ2NoYXIqIG1lc3NhZ2UsIGdwb2ludGVyIGRhdGEpCit7CisgICAgaWYgKGxldmVs IDwgR19MT0dfTEVWRUxfREVCVUcpCisgICAgICAgIGZwcmludGYoc3RkZXJyLCAiJXNcbiIsIG1l c3NhZ2UpOworfQorCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogewogICAgIGdf dGhyZWFkX2luaXQoTlVMTCk7CiAgICAgZ3RrX2luaXQoJmFyZ2MsICZhcmd2KTsKIAorICAgIC8v IFNvbWUgcGx1Z2lucyBtaWdodCB0cnkgdG8gdXNlIHRoZSBHTGliIGxvZ2dlciBmb3IgcHJpbnRp bmcgZGVidWcKKyAgICAvLyBtZXNzYWdlcy4gVGhpcyB3aWxsIGNhdXNlIHRlc3RzIHRvIGZhaWwg YmVjYXVzZSBvZiB1bmV4cGVjdGVkIG91dHB1dC4KKyAgICAvLyBXZSBzcXVlbGNoIGFsbCBkZWJ1 ZyBtZXNzYWdlcyBzZW50IHRvIHRoZSBsb2dnZXIuCisgICAgZ19sb2dfc2V0X2RlZmF1bHRfaGFu ZGxlcihsb2dIYW5kbGVyLCAwKTsKKwogI2lmIFBMQVRGT1JNKFgxMSkKICAgICBGY0luaXQoKTsK ICAgICBpbml0aWFsaXplRm9udHMoKTsKLS0gCjEuNi4zLjMKCg==