36380 2010-03-19 12:06:22 -0700 REGESSION: websocket/tests/frame-lengths.html times out on Tiger bot 2010-03-19 13:43:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 35041 1 eric ap ap darin dpranke ojan zimmermann oldest_to_newest 201970 0 eric 2010-03-19 12:06:22 -0700 REGESSION: websocket/tests/frame-lengths.html times out on Tiger bot This has been happening for days, if not weeks and has rendered the bot useless. We need to find resolution to this soon, even if that means skipping this test on tiger. Two recent failures: http://build.webkit.org/results/Tiger%20Intel%20Release/r56247%20(9828)/websocket/tests/frame-lengths-diffs.txt http://build.webkit.org/results/Tiger%20Intel%20Release/r56243%20(9825)/websocket/tests/frame-lengths-diffs.txt This fails every Tiger build. 201972 1 eric 2010-03-19 12:08:44 -0700 This has been failing since at least 2/22/09: https://bugs.webkit.org/show_bug.cgi?id=35041#c2 I think we should just skip this test on Tiger since it's been ignored for nearly a month already. 201976 2 eric 2010-03-19 12:17:32 -0700 This test was added by Alexey 3 months ago: http://trac.webkit.org/browser/trunk/LayoutTests/websocket/tests/frame-lengths.html 201985 3 ap 2010-03-19 12:32:33 -0700 This test has always timed out on slow machines. I think that we need to increase the timeout. 201987 4 eric 2010-03-19 12:34:57 -0700 How do we do that? 201990 5 ap 2010-03-19 12:40:58 -0700 Just change these lines in run-webkit-tests, and make matching changes to DRT, I guess. # DumpRenderTree has an internal timeout of 15 seconds, so this must be > 15. my $timeoutSeconds = 20; 201992 6 eric 2010-03-19 12:43:09 -0700 That seems wrong. Why would we want to make all tests possibly take longer when timing out, instead of modifying this single test? new-run-webkit-tests has a way of marking a single test as slow, but we don't have that ability for run-webkit-tests yet. Seems we should either cut this test down to size or skip it on slow machines instead. No? 202002 7 ap 2010-03-19 13:03:07 -0700 I'd agree if only one test was timing out, but in fact, many tests are timing out on slower machines. Didn't we discuss this on webkit-dev a few days ago? How much of a problem would increasing the timeout be in practice? Normally, no tests are timing out, so such a change wouldn't affect anything. 202003 8 eric 2010-03-19 13:04:36 -0700 I must have missed the webkit-dev discussion. I reverse my position. r=me to increase the timeout. Once we have the new-webkit-tests technology of individual "slow tests", we can push the timeout back down. 202008 9 51183 ap 2010-03-19 13:18:43 -0700 Created attachment 51183 proposed patch 202011 10 ap 2010-03-19 13:20:48 -0700 *** Bug 35041 has been marked as a duplicate of this bug. *** 202012 11 eric 2010-03-19 13:22:10 -0700 A little trivia: new-webkit-tests's timeout limit is 6 seconds for release and 12 for debug. :) You can mark individual tests as SLOW and then they get 5X the base timeout. 202013 12 ap 2010-03-19 13:22:49 -0700 Committed revision 56262. 202014 13 ap 2010-03-19 13:24:03 -0700 > A little trivia: Is there a global override? Running the tests on PPC/Debug, or on a mobile platform would be a pain without one. 202020 14 eric 2010-03-19 13:43:11 -0700 The architecture is such that one could have a per-port timeout. Although that's not currently wired up. You can also (already) pass a timeout over the command line. See: new-run-webkit-tests --help 51183 2010-03-19 13:18:43 -0700 2010-03-19 13:19:19 -0700 proposed patch Timeout30.txt text/plain 4394 ap SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU2MjYwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDMtMTkgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2Mzgw CisgICAgICAgIHdlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGhzLmh0bWwgdGltZXMgb3V0IG9u IFRpZ2VyIGJvdAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNTA0MQorICAgICAgICB3ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3Rocy5odG1sIC8g d2Vic29ja2V0L3Rlc3RzL3NpbXBsZS1zdHJlc3MuaHRtbCBmYWlsIG9uIFdpbmRvd3MgYm90CisK KyAgICAgICAgRG91YmxlIHRoZSB0aW1lb3V0IChmcm9tIDE1IHNlY29uZHMgdG8gMzAgc2Vjb25k cykuIFdlIGNhbiBpbmNyZWFzZSBpdCBtb3JlLCBpZiBuZWNlc3NhcnkgLQorICAgICAgICBzYW1w bGluZyB0aGUgRFJUIHByb2Nlc3Mgb24gTWFjIE9TIFggdGFrZXMgbXVjaCBsb25nZXIgYW55d2F5 LCBzbyBpdCdzIGJldHRlciB0byBhdm9pZAorICAgICAgICB0aW1pbmcgb3V0IHRoYW4gdG8gZGV0 ZWN0IGl0IGVhcmx5LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RD b250cm9sbGVyR3RrLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRXYWl0 VG9EdW1wKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdENvbnRyb2xs ZXJNYWMubW06CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xs ZXJRdC5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6d2FpdFVudGlsRG9uZSk6 CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVyV2luLmNw cDoKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6CisKIDIwMTAtMDMtMTkgIExh c3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuCkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENv bnRyb2xsZXJHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAJKHJldmlzaW9uIDU2MjU5KQorKysgV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzE1LDcgKzMxNSw3IEBAIHN0YXRpYyBnYm9vbGVhbiB3YWl0VG9E dW1wV2F0Y2hkb2dGaXJlZCgKIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0V2FpdFRv RHVtcChib29sIHdhaXRVbnRpbERvbmUpCiB7Ci0gICAgc3RhdGljIGNvbnN0IGludCB0aW1lb3V0 U2Vjb25kcyA9IDE1OworICAgIHN0YXRpYyBjb25zdCBpbnQgdGltZW91dFNlY29uZHMgPSAzMDsK IAogICAgIG1fd2FpdFRvRHVtcCA9IHdhaXRVbnRpbERvbmU7CiAgICAgaWYgKG1fd2FpdFRvRHVt cCAmJiAhd2FpdFRvRHVtcFdhdGNoZG9nKQpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvbWFjL0xheW91dFRlc3RDb250cm9sbGVyTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0Q29udHJvbGxlck1hYy5tbQkocmV2aXNp b24gNTYyNTkpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdENv bnRyb2xsZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQyOSw3ICs0MjksNyBAQCB2b2lkIExh eW91dFRlc3RDb250cm9sbGVyOjpzZXRTZWxlY3RUcmFpCiAgICAgW1ttYWluRnJhbWUgd2ViVmll d10gc2V0U2VsZWN0VHJhaWxpbmdXaGl0ZXNwYWNlRW5hYmxlZDpmbGFnXTsKIH0KIAotc3RhdGlj IGNvbnN0IENGVGltZUludGVydmFsIHdhaXRUb0R1bXBXYXRjaGRvZ0ludGVydmFsID0gMTUuMDsK K3N0YXRpYyBjb25zdCBDRlRpbWVJbnRlcnZhbCB3YWl0VG9EdW1wV2F0Y2hkb2dJbnRlcnZhbCA9 IDMwLjA7CiAKIHN0YXRpYyB2b2lkIHdhaXRVbnRpbERvbmVXYXRjaGRvZ0ZpcmVkKENGUnVuTG9v cFRpbWVyUmVmIHRpbWVyLCB2b2lkKiBpbmZvKQogewpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAJKHJl dmlzaW9uIDU2MjU5KQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVz dENvbnRyb2xsZXJRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOCw3ICsxMzgsNyBAQCB2b2lk IExheW91dFRlc3RDb250cm9sbGVyOjp3YWl0VW50aWxEb25lCiB7CiAgICAgLy9xRGVidWcoKSA8 PCAiPj4+PndhaXRGb3JEb25lIjsKICAgICBtX3dhaXRGb3JEb25lID0gdHJ1ZTsKLSAgICBtX3Rp bWVvdXRUaW1lci5zdGFydCgxNTAwMCwgdGhpcyk7CisgICAgbV90aW1lb3V0VGltZXIuc3RhcnQo MzAwMDAsIHRoaXMpOwogfQogCiBRU3RyaW5nIExheW91dFRlc3RDb250cm9sbGVyOjpjb3VudGVy VmFsdWVGb3JFbGVtZW50QnlJZChjb25zdCBRU3RyaW5nJiBpZCkKSW5kZXg6IFdlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3dpbi9MYXlvdXRUZXN0Q29udHJvbGxlcldpbi5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVy V2luLmNwcAkocmV2aXNpb24gNTYyNTkpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93 aW4vTGF5b3V0VGVzdENvbnRyb2xsZXJXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MjIsNyAr NzIyLDcgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0U2VsZWN0VHJhaQogICAgIHZp ZXdFZGl0aW5nLT5zZXRTZWxlY3RUcmFpbGluZ1doaXRlc3BhY2VFbmFibGVkKGZsYWcgPyBUUlVF IDogRkFMU0UpOwogfQogCi1zdGF0aWMgY29uc3QgQ0ZUaW1lSW50ZXJ2YWwgd2FpdFRvRHVtcFdh dGNoZG9nSW50ZXJ2YWwgPSAxNS4wOworc3RhdGljIGNvbnN0IENGVGltZUludGVydmFsIHdhaXRU b0R1bXBXYXRjaGRvZ0ludGVydmFsID0gMzAuMDsKIAogc3RhdGljIHZvaWQgQ0FMTEJBQ0sgd2Fp dFVudGlsRG9uZVdhdGNoZG9nRmlyZWQoSFdORCwgVUlOVCwgVUlOVF9QVFIsIERXT1JEKQogewpJ bmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwkocmV2aXNpb24gNTYyNTkpCisr KyBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAg LTE0OCw4ICsxNDgsOCBAQCBteSAkdG1wRGlyID0gIi90bXAiOwogbXkgJHRlc3RSZXN1bHRzRGly ZWN0b3J5ID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkdG1wRGlyLCAibGF5b3V0LXRlc3QtcmVzdWx0 cyIpOwogbXkgJHRlc3RzUGVyRHVtcFRvb2wgPSAxMDAwOwogbXkgJHRocmVhZGVkID0gMDsKLSMg RHVtcFJlbmRlclRyZWUgaGFzIGFuIGludGVybmFsIHRpbWVvdXQgb2YgMTUgc2Vjb25kcywgc28g dGhpcyBtdXN0IGJlID4gMTUuCi1teSAkdGltZW91dFNlY29uZHMgPSAyMDsKKyMgRHVtcFJlbmRl clRyZWUgaGFzIGFuIGludGVybmFsIHRpbWVvdXQgb2YgMzAgc2Vjb25kcywgc28gdGhpcyBtdXN0 IGJlID4gMzAuCitteSAkdGltZW91dFNlY29uZHMgPSAzNTsKIG15ICR0b2xlcmFuY2UgPSAwOwog bXkgJHRyZWF0U2tpcHBlZCA9ICJkZWZhdWx0IjsKIG15ICR1c2VSZW1vdGVMaW5rc1RvVGVzdHMg PSAwOwo=