36371 2010-03-19 08:12:40 -0700 [Gtk] Elements with a title attribute should not be ignored 2010-03-25 04:44:58 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro cfleizach commit-queue walker.willie xan.lopez oldest_to_newest 201859 0 jdiggs 2010-03-19 08:12:40 -0700 Currently we ignore any element which does not itself contain content. Thus given: <div class="note" title="Note"> <div class="inner"> <div class="contents"> <p class="p">Note contents</p> </div> </div> </div> We'd expose: -> Document Frame -> Paragraph (text: Note contents) If the content provider has specified a title attribute, we should include that element in the hierarchy. When we do so, the title attribute should automatically become exposed as the accessible description, i.e.: -> Document Frame -> Section (description: Note) -> Paragraph (text: Note contents) 201869 1 jdiggs 2010-03-19 08:54:55 -0700 Chris: What's the story on the Mac? Do VoiceOver users have a need for this as well, or should it be limited to Gtk? 201888 2 cfleizach 2010-03-19 09:25:04 -0700 thats reasonable i think. on the mac, that will be exposed as an AXGroup, which is ok 202694 3 51334 jdiggs 2010-03-22 12:32:46 -0700 Created attachment 51334 proposed fix 203922 4 51334 eric 2010-03-25 01:48:40 -0700 Comment on attachment 51334 proposed fix Looks reasonable to my eye. 203996 5 51334 commit-queue 2010-03-25 04:44:54 -0700 Comment on attachment 51334 proposed fix Clearing flags on attachment: 51334 Committed r56530: <http://trac.webkit.org/changeset/56530> 203997 6 commit-queue 2010-03-25 04:44:58 -0700 All reviewed patches have been landed. Closing bug. 51334 2010-03-22 12:32:46 -0700 2010-03-25 04:44:54 -0700 proposed fix 36371.patch text/plain 5334 jdiggs RnJvbSAyYzJhMjhhYzVhM2Q5ZWI1NGRlY2FlMTMxMGU2YjY1ZjFjNTE2ZWMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IE1vbiwgMjIgTWFyIDIwMTAgMTI6MDc6MjQgLTA3MDAKU3ViamVjdDogW1BB VENIXSAyMDEwLTAzLTIyICBKb2FubWFyaWUgRGlnZ3MgIDxqb2FubWFyaWUuZGlnZ3NAZ21haWwu Y29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MzcxCiAgICAgICAgW0d0a10gRWxl bWVudHMgd2l0aCBhIHRpdGxlIGF0dHJpYnV0ZSBzaG91bGQgbm90IGJlIGlnbm9yZWQKCiAgICAg ICAgKiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9vYmplY3Qtd2l0aC10aXRsZS5odG1sOiBB ZGRlZAogICAgICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2JqZWN0LXdpdGgtdGl0 bGUtZXhwZWN0ZWQudHh0OiBBZGRlZAoKMjAxMC0wMy0yMiAgSm9hbm1hcmllIERpZ2dzICA8am9h bm1hcmllLmRpZ2dzQGdtYWlsLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjM3 MQogICAgICAgIFtHdGtdIEVsZW1lbnRzIHdpdGggYSB0aXRsZSBhdHRyaWJ1dGUgc2hvdWxkIG5v dCBiZSBpZ25vcmVkCgogICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVy T2JqZWN0LmNwcDoKICAgICAgICAoQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWNjZXNzaWJp bGl0eUlzSWdub3JlZCk6Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEwICsrKysrCiAuLi4vYWNjZXNzaWJpbGl0eS9vYmplY3Qtd2l0 aC10aXRsZS1leHBlY3RlZC50eHQgICB8ICAgMTYgKysrKysrKysKIC4uLi9ndGsvYWNjZXNzaWJp bGl0eS9vYmplY3Qtd2l0aC10aXRsZS5odG1sICAgICAgIHwgICAzOSArKysrKysrKysrKysrKysr KysrKwogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDEwICsrKysrCiAuLi4vYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0 LmNwcCAgICB8ICAgIDMgKysKIDUgZmlsZXMgY2hhbmdlZCwgNzggaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv YWNjZXNzaWJpbGl0eS9vYmplY3Qtd2l0aC10aXRsZS1leHBlY3RlZC50eHQKIGNyZWF0ZSBtb2Rl IDEwMDY0NCBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9vYmplY3Qtd2l0 aC10aXRsZS5odG1sCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGNkYzY2YjMuLjBiYzg1NGYgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MyBAQAorMjAxMC0wMy0yMiAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dzQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYzNzEKKyAgICAgICAgW0d0 a10gRWxlbWVudHMgd2l0aCBhIHRpdGxlIGF0dHJpYnV0ZSBzaG91bGQgbm90IGJlIGlnbm9yZWQK KworICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L29iamVjdC13aXRoLXRpdGxl Lmh0bWw6IEFkZGVkCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2JqZWN0 LXdpdGgtdGl0bGUtZXhwZWN0ZWQudHh0OiBBZGRlZAorCiAyMDEwLTAzLTIxICBEbWl0cnkgR29y YmlrICA8c29ja2V0LmhAZ21haWwuY29tPgogCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9i LzE0ODU4PiA8Y29sPiB3aWR0aCBpZ25vcmVkIHdoZW4gbm90IHRpZWQgdG8gYSBzaW5nbGUgY2Vs bApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2Jq ZWN0LXdpdGgtdGl0bGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Fj Y2Vzc2liaWxpdHkvb2JqZWN0LXdpdGgtdGl0bGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLmY5ZmJlZjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9vYmplY3Qtd2l0aC10aXRsZS1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwxNiBAQAorb25lCit0d28KK29uZQordHdvCitUaGlzIHRlc3RzIHRo ZSBpbmNsdXNpb24gb2Ygb2JqZWN0cyB3aXRoIGEgdGl0bGUgYXR0cmlidXRlLgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBjaGlsZC5yb2xlIGlzICdsaXN0JworUEFTUyBj aGlsZC5yb2xlIGlzICdzZWN0aW9uJworUEFTUyBjaGlsZC5yb2xlIGlzICdsaXN0JworUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L29iamVjdC13aXRoLXRpdGxl Lmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9vYmplY3Qtd2l0 aC10aXRsZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjAxOTJkN2MK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0 eS9vYmplY3Qtd2l0aC10aXRsZS5odG1sCkBAIC0wLDAgKzEsMzkgQEAKKzwhRE9DVFlQRSBIVE1M IFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayBy ZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUu Y3NzIj4KKzxzY3JpcHQ+Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gZmFsc2U7Cis8L3Njcmlw dD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9keSI+Cis8ZGl2PgorICA8dWw+PGxp Pm9uZTwvbGk+PGxpPnR3bzwvbGk+PC91bD4KKzwvZGl2PgorPGRpdiB0aXRsZT0iSW5jbHVkZSBN ZSI+CisgIDx1bD48bGk+b25lPC9saT48bGk+dHdvPC9saT48L3VsPgorPC9kaXY+Cis8cCBpZD0i ZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KKyAg ICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGUgaW5jbHVzaW9uIG9mIG9iamVjdHMgd2l0aCBh IHRpdGxlIGF0dHJpYnV0ZS4iKTsKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9s bGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJvZHkiKS5mb2N1cygpOworICAgICAgICB2YXIg d2ViQXJlYSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OworCisgICAg ICAgIHZhciBjaGlsZCA9IHdlYkFyZWEuY2hpbGRBdEluZGV4KDApOworICAgICAgICBzaG91bGRC ZSgiY2hpbGQucm9sZSIsICInbGlzdCciKTsKKworICAgICAgICBjaGlsZCA9IHdlYkFyZWEuY2hp bGRBdEluZGV4KDEpOworICAgICAgICBzaG91bGRCZSgiY2hpbGQucm9sZSIsICInc2VjdGlvbici KTsKKworICAgICAgICBjaGlsZCA9IGNoaWxkLmNoaWxkQXRJbmRleCgwKTsKKyAgICAgICAgc2hv dWxkQmUoImNoaWxkLnJvbGUiLCAiJ2xpc3QnIik7CisgICAgfQorICAgIHN1Y2Nlc3NmdWxseVBh cnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMWMy Yjc1Li4xNGY1YzM5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTAzLTIyICBKb2FubWFyaWUgRGlnZ3Mg IDxqb2FubWFyaWUuZGlnZ3NAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNjM3MQorICAgICAgICBbR3RrXSBFbGVtZW50cyB3aXRoIGEgdGl0bGUgYXR0cmlidXRl IHNob3VsZCBub3QgYmUgaWdub3JlZAorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlSZW5kZXJPYmpl Y3Q6OmFjY2Vzc2liaWxpdHlJc0lnbm9yZWQpOgorCiAyMDEwLTAzLTIxICBLaW0gR3LDtm5ob2xt ICA8a2ltLmdyb25ob2xtQG5vbW92b2suY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9u IEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlSZW5kZXJPYmplY3QuY3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3QuY3BwCmluZGV4IDhkZThlNWIuLmMyOGE2NTIgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAorKysgYi9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTE1Mzks NiArMTUzOSw5IEBAIGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWNjZXNzaWJpbGl0 eUlzSWdub3JlZCgpIGNvbnN0CiAgICAgCiAgICAgaWYgKGFyaWFSb2xlICE9IFVua25vd25Sb2xl KQogICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoIWhlbHBUZXh0KCkuaXNFbXB0eSgp KQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCiAgICAgLy8gZG9uJ3QgaWdub3JlIGxhYmVs cywgYmVjYXVzZSB0aGV5IHNlcnZlIGFzIFRpdGxlVUlFbGVtZW50cwogICAgIE5vZGUqIG5vZGUg PSBtX3JlbmRlcmVyLT5ub2RlKCk7Ci0tIAoxLjcuMAoK