36350 2010-03-19 00:28:45 -0700 Simplify BuildBot core builder code for easier re-use 2010-03-19 00:37:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned oldest_to_newest 201757 0 eric 2010-03-19 00:28:45 -0700 Simplify BuildBot core builder code for easier re-use 201758 1 51133 eric 2010-03-19 00:29:57 -0700 Created attachment 51133 Patch 201760 2 51133 abarth 2010-03-19 00:31:08 -0700 Comment on attachment 51133 Patch I comprehend 201764 3 51133 eric 2010-03-19 00:37:54 -0700 Comment on attachment 51133 Patch Clearing flags on attachment: 51133 Committed r56225: <http://trac.webkit.org/changeset/56225> 201765 4 eric 2010-03-19 00:37:59 -0700 All reviewed patches have been landed. Closing bug. 51133 2010-03-19 00:29:57 -0700 2010-03-19 00:37:54 -0700 Patch bug-36350-20100319002956.patch text/plain 3565 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjYWQwZTNlLi45ODI5OGRkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTAtMDMt MTkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsaWZ5IEJ1aWxkQm90IGNvcmUgYnVpbGRl ciBjb2RlIGZvciBlYXNpZXIgcmUtdXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNjM1MAorCisgICAgICAgIEkgc2ltcGx5IGNvdWxkbid0IHNlZSBh bnl0aGluZyB0aHJvdWdoIGFsbCB0aGlzIFlhay1oYWlyLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9idWlsZGJvdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRz L3F1ZXJpZXMucHk6CisKKzIwMTAtMDMtMTkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3Jn PgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCiAKICAgICAgICAgTW92ZSBmaW5k X2dyZWVuX3RvX3JlZF90cmFuc2l0aW9uIG91dCBvZiAid2hhdC1icm9rZSIgb250byBCdWlsZGVy IGZvciBlYXNpZXIgcmUtdXNlCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2J1aWxkYm90LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWlsZGJvdC5w eQppbmRleCAzMjY4ZjlkLi5kNDQzZjhhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2J1aWxkYm90LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv YnVpbGRib3QucHkKQEAgLTE3MSwyNCArMTcxLDIyIEBAIGNsYXNzIEJ1aWxkQm90KG9iamVjdCk6 CiAgICAgICAgICMgV2UgY291bGQgcGFyc2Ugb3V0IHRoZSBjdXJyZW50IGFjdGl2aXR5IHRvby4K ICAgICAgICAgcmV0dXJuIGJ1aWxkZXIKIAotICAgIGRlZiBfYnVpbGRlcl9zdGF0dXNlc193aXRo X25hbWVzX21hdGNoaW5nX3JlZ2V4cHMoc2VsZiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1aWxkZXJfc3RhdHVzZXMsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuYW1lX3JlZ2V4cHMp OgotICAgICAgICBidWlsZGVycyA9IFtdCi0gICAgICAgIGZvciBidWlsZGVyIGluIGJ1aWxkZXJf c3RhdHVzZXM6Ci0gICAgICAgICAgICBmb3IgbmFtZV9yZWdleHAgaW4gbmFtZV9yZWdleHBzOgot ICAgICAgICAgICAgICAgIGlmIHJlLm1hdGNoKG5hbWVfcmVnZXhwLCBidWlsZGVyWyduYW1lJ10p OgotICAgICAgICAgICAgICAgICAgICBidWlsZGVycy5hcHBlbmQoYnVpbGRlcikKLSAgICAgICAg cmV0dXJuIGJ1aWxkZXJzCisgICAgZGVmIF9tYXRjaGVzX3JlZ2V4cHMoc2VsZiwgYnVpbGRlcl9u YW1lLCBuYW1lX3JlZ2V4cHMpOgorICAgICAgICBmb3IgbmFtZV9yZWdleHAgaW4gbmFtZV9yZWdl eHBzOgorICAgICAgICAgICAgaWYgcmUubWF0Y2gobmFtZV9yZWdleHAsIGJ1aWxkZXJfbmFtZSk6 CisgICAgICAgICAgICAgICAgcmV0dXJuIFRydWUKKyAgICAgICAgcmV0dXJuIEZhbHNlCisKKyAg ICAjIEZJWE1FOiBTaG91bGQgbW92ZSBvbnRvIEJ1aWxkZXIKKyAgICBkZWYgX2lzX2NvcmVfYnVp bGRlcihzZWxmLCBidWlsZGVyX25hbWUpOgorICAgICAgICByZXR1cm4gc2VsZi5fbWF0Y2hlc19y ZWdleHBzKGJ1aWxkZXJfbmFtZSwgc2VsZi5jb3JlX2J1aWxkZXJfbmFtZXNfcmVnZXhwcykKKwor ICAgICMgRklYTUU6IFRoaXMgbWV0aG9kIG5lZWRzIHRvIGRpZSwgYnV0IGlzIHVzZWQgYnkgYSB1 bml0IHRlc3QgYXQgdGhlIG1vbWVudC4KKyAgICBkZWYgX2J1aWxkZXJfc3RhdHVzZXNfd2l0aF9u YW1lc19tYXRjaGluZ19yZWdleHBzKHNlbGYsIGJ1aWxkZXJfc3RhdHVzZXMsIG5hbWVfcmVnZXhw cyk6CisgICAgICAgIHJldHVybiBbYnVpbGRlciBmb3IgYnVpbGRlciBpbiBidWlsZGVyX3N0YXR1 c2VzIGlmIHNlbGYuX21hdGNoZXNfcmVnZXhwcyhidWlsZGVyWyJuYW1lIl0sIG5hbWVfcmVnZXhw cyldCiAKICAgICBkZWYgcmVkX2NvcmVfYnVpbGRlcnMoc2VsZik6Ci0gICAgICAgIHJlZF9idWls ZGVycyA9IFtdCi0gICAgICAgIGZvciBidWlsZGVyIGluIHNlbGYuX2J1aWxkZXJfc3RhdHVzZXNf d2l0aF9uYW1lc19tYXRjaGluZ19yZWdleHBzKAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHNlbGYuYnVpbGRlcl9zdGF0dXNlcygpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHNlbGYuY29yZV9idWlsZGVyX25hbWVzX3JlZ2V4cHMpOgotICAgICAgICAgICAgaWYgbm90 IGJ1aWxkZXJbJ2lzX2dyZWVuJ106Ci0gICAgICAgICAgICAgICAgcmVkX2J1aWxkZXJzLmFwcGVu ZChidWlsZGVyKQotICAgICAgICByZXR1cm4gcmVkX2J1aWxkZXJzCisgICAgICAgIHJldHVybiBb YnVpbGRlciBmb3IgYnVpbGRlciBpbiBzZWxmLmJ1aWxkZXJfc3RhdHVzZXMoKSBpZiBub3QgYnVp bGRlclsiaXNfZ3JlZW4iXSBhbmQgc2VsZi5faXNfY29yZV9idWlsZGVyKGJ1aWxkZXJbIm5hbWUi XSldCiAKICAgICBkZWYgcmVkX2NvcmVfYnVpbGRlcnNfbmFtZXMoc2VsZik6CiAgICAgICAgIHJl ZF9idWlsZGVycyA9IHNlbGYucmVkX2NvcmVfYnVpbGRlcnMoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5IGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5CmluZGV4IGQyMzU2M2YuLjhkODdm ZmMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvcXVl cmllcy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXJp ZXMucHkKQEAgLTE0Miw2ICsxNDIsOSBAQCBhbmQgZGlzcGxheWVzIHRoZSBzdGF0dXMgb2YgZWFj aCBidWlsZGVyLiIiIgogICAgICAgICAgICAgY29tbWl0X2luZm8gPSBDb21taXRJbmZvLmNvbW1p dF9pbmZvX2Zvcl9yZXZpc2lvbihzZWxmLnRvb2wuc2NtKCksIHJldmlzaW9uKQogICAgICAgICAg ICAgc2VsZi5fcHJpbnRfYmxhbWVfaW5mb3JtYXRpb25fZm9yX2NvbW1pdChjb21taXRfaW5mbykK IAorICAgIGRlZiByZXZpc2lvbnNfY2F1c2luZ19mYWlsdXJlcyhzZWxmLCBvbmx5X2NvcmVfYnVp bGRlcnM9VHJ1ZSk6CisgICAgICAgIGJ1aWxkZXJfc3RhdHVzZXMgPSB0b29sLmJ1aWxkYm90LmJ1 aWxkZXJfc3RhdHVzZXMoKQorCiAgICAgZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJncywg dG9vbCk6CiAgICAgICAgIGJ1aWxkZXJfc3RhdHVzZXMgPSB0b29sLmJ1aWxkYm90LmJ1aWxkZXJf c3RhdHVzZXMoKQogICAgICAgICBsb25nZXN0X2J1aWxkZXJfbmFtZSA9IHNlbGYuX2xvbmdlc3Rf YnVpbGRlcl9uYW1lKGJ1aWxkZXJfc3RhdHVzZXMpCg==