36348 2010-03-19 00:16:59 -0700 [Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6 2010-03-19 09:42:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-qt-unassigned commit-queue hausmann koivisto tonikitoo oldest_to_newest 201749 0 laszlo.gombos 2010-03-19 00:16:59 -0700 It seems that the QtWebKit tiled backing store needs the QGraphicsItem::scale function (seeQGraphicsWebViewPrivate::updateTiledBackingStoreScale). I propose to turn off TILED_BACKING_STORE if Qt version is earlier than Qt4.6 (instead of making it work on Qt 4.5 or earlier). 201752 1 51130 laszlo.gombos 2010-03-19 00:21:11 -0700 Created attachment 51130 proposed patch 201763 2 hausmann 2010-03-19 00:35:41 -0700 QGraphicsItem::scale is present in Qt 4.5, but it's not a Q_PROPERTY in QGraphicsObject. 201867 3 tonikitoo 2010-03-19 08:49:56 -0700 i confess I do not know what is the current minimum version of Qt that QtWebKit has to support. one mentioned it is current release (4.6) and the next (4.7). If so, should we care much about 4.5? just out of curiosity. 201897 4 51130 commit-queue 2010-03-19 09:41:55 -0700 Comment on attachment 51130 proposed patch Clearing flags on attachment: 51130 Committed r56243: <http://trac.webkit.org/changeset/56243> 201898 5 commit-queue 2010-03-19 09:42:00 -0700 All reviewed patches have been landed. Closing bug. 51130 2010-03-19 00:21:11 -0700 2010-03-19 09:41:55 -0700 proposed patch 36348.patch text/plain 1333 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjIyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRGlzYWJsZSBUSUxFRF9CQUNLSU5HX1NUT1JFIGlmIFF0IHZlcnNpb24gaXMg ZWFybGllciB0aGFuIFF0NC42CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNjM0OAorCisgICAgICAgIEJhY2tpbmcgc3RvcmUgaW1wbGVtZW50YXRpb24g Zm9yIFF0V2ViS2l0IHJlcXVpcmVzIGF0IGxlYXN0IFF0CisgICAgICAgIHZlcnNpb24gNC42Lgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBpcyBubyBuZXcgZnVuY3Rpb25hbGl0eS4K KworICAgICAgICAqIFdlYkNvcmUucHJpOgorCiAyMDEwLTAzLTE4ICBDaHJpcyBFdmFucyAgPGNl dmFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJt YW5uLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dl YkNvcmUucHJpCShyZXZpc2lvbiA1NjIxMikKKysrIFdlYkNvcmUvV2ViQ29yZS5wcmkJKHdvcmtp bmcgY29weSkKQEAgLTgwLDcgKzgwLDkgQEAgZ3JlYXRlclRoYW4oUVRfTUlOT1JfVkVSU0lPTiwg NSkgewogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVRBTElTVD0uKTogREVGSU5FUyArPSBF TkFCTEVfREFUQUxJU1Q9MQogCiAjIFRpbGVkIEJhY2tpbmcgU3RvcmUgc3VwcG9ydAotIWNvbnRh aW5zKERFRklORVMsIEVOQUJMRV9USUxFRF9CQUNLSU5HX1NUT1JFPS4pOiBERUZJTkVTICs9IEVO QUJMRV9USUxFRF9CQUNLSU5HX1NUT1JFPTEKK2dyZWF0ZXJUaGFuKFFUX01JTk9SX1ZFUlNJT04s IDUpIHsKKyAgICAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1RJTEVEX0JBQ0tJTkdfU1RPUkU9 Lik6IERFRklORVMgKz0gRU5BQkxFX1RJTEVEX0JBQ0tJTkdfU1RPUkU9MQorfQogCiAjIE5lc2Nh cGUgcGx1Z2lucyBzdXBwb3J0IChOUEFQSSkKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfTkVU U0NBUEVfUExVR0lOX0FQST0uKSB7Cg==